Re: git diff-tree -r -C output inexact sometimes

2012-09-21 Thread Jeff King
On Thu, Sep 20, 2012 at 11:20:31PM -0400, Cristian Tibirna wrote: Running the script in attachment produces a git repository in which were operated a large number of file renames, in which many of the renamed files (in this particular case all) have the same content but different names.

Re: [PATCH v4 3/6] Color skipped tests blue

2012-09-21 Thread Jeff King
On Wed, Sep 19, 2012 at 09:24:23PM +0100, Adam Spiers wrote: t/test-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 5293830..78c88c2 100755 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -182,13 +182,13 @@ then

Re: [PATCH v2 14/14] Add git-check-ignore sub-command

2012-09-21 Thread Michael Haggerty
On 09/20/2012 09:46 PM, Adam Spiers wrote: This works in a similar manner to git-check-attr. Some code was reused from add.c by refactoring out into pathspec.c. Thanks to Jeff King and Junio C Hamano for the idea: http://thread.gmane.org/gmane.comp.version-control.git/108671/focus=108815

Re: [PATCH v2 12/14] Extract some useful pathspec handling code from builtin/add.c into a library

2012-09-21 Thread Michael Haggerty
On 09/20/2012 09:46 PM, Adam Spiers wrote: This is in preparation for reuse by a new git check-ignore command. Signed-off-by: Adam Spiers g...@adamspiers.org --- Makefile | 2 ++ builtin/add.c | 95 ++--- pathspec.c| 97

Re: [PATCH v2 13/14] Provide free_directory() for reclaiming dir_struct memory

2012-09-21 Thread Michael Haggerty
On 09/20/2012 09:46 PM, Adam Spiers wrote: Signed-off-by: Adam Spiers g...@adamspiers.org --- Documentation/technical/api-directory-listing.txt | 2 ++ dir.c | 23 +-- dir.h | 1 +

Re: [PATCH 2/2] pretty: support placeholders %C+ and %C-

2012-09-21 Thread Nguyen Thai Ngoc Duy
On Fri, Sep 21, 2012 at 12:47 AM, Junio C Hamano gits...@pobox.com wrote: +- '%C+': enable coloring on the following placeholders if supported +- '%C-': disable coloring on the following placeholders OK, so typically you replace some format placeholder %? in your format string with %C+%?%C-,

Re: [PATCH 3/2] pretty: support right alignment

2012-09-21 Thread Nguyen Thai Ngoc Duy
On Thu, Sep 20, 2012 at 11:40 PM, Junio C Hamano gits...@pobox.com wrote: I think this is a great feature at the conceptual level, and you know but is coming ;-). I'm still not sure if it's useful beyond my simple example. For example, will it be useful in multiline log format, not just

Re: [PATCH] Add Auto-Submitted header to post-receive-email

2012-09-21 Thread Chris Hiestand
My email in April went unanswered so I'm resending it. An Auto-Submitted header would be an improvement to the standard [git] post receive email. Thanks, Chris Begin forwarded message: From: Chris Hiestand chiest...@salk.edu Subject: [PATCH] Add Auto-Submitted header to post-receive-email

Re: The GitTogether

2012-09-21 Thread Christian Couder
Hi, On Thu, Sep 20, 2012 at 8:53 PM, Sebastian Schuberth sschube...@gmail.com wrote: On 19.09.2012 15:43, Michael Haggerty wrote: Is there any news about the proposed gatherings? I would be quite interested in attending the developer meeting. October is just around the corner...what's up?

Re: [PATCH 3/2] pretty: support right alignment

2012-09-21 Thread Nguyen Thai Ngoc Duy
On Thu, Sep 20, 2012 at 09:40:49AM -0700, Junio C Hamano wrote: - I am wondering if somebody ever want to do this with a follow-up patch: Left %h%|Center %cd%|Right %ad Is %| a sensible choice for flush right? I am wondering if it makes more sense to make %|, % and % as

Re: The GitTogether

2012-09-21 Thread Shawn Pearce
On Fri, Sep 21, 2012 at 2:20 AM, Christian Couder christian.cou...@gmail.com wrote: On Thu, Sep 20, 2012 at 8:53 PM, Sebastian Schuberth sschube...@gmail.com wrote: On 19.09.2012 15:43, Michael Haggerty wrote: Is there any news about the proposed gatherings? I would be quite interested in

Re: The GitTogether

2012-09-21 Thread Jeff King
On Fri, Sep 21, 2012 at 07:05:53AM -0700, Shawn O. Pearce wrote: I have no further information about the potential GitTogether than anyone else. IIRC there is a suggestion in this thread about hosting something in the EU sometime in early next year, with someone at GitHub acting as organizer.

Re: [PATCH] Disable dumb HTTP fallback with GIT_CURL_FALLBACK=0

2012-09-21 Thread Shawn Pearce
On Thu, Sep 20, 2012 at 10:26 PM, Jeff King p...@peff.net wrote: On Thu, Sep 20, 2012 at 04:05:03PM -0700, Shawn O. Pearce wrote: But right now I am seeing failures in libcurl's SSL connection that may also be causing the smart connection failures. For example this trace, where libcurl was

Re: The GitTogether

2012-09-21 Thread Sebastian Schuberth
On Fri, Sep 21, 2012 at 4:19 PM, Scott Chacon scha...@gmail.com wrote: I'm also very much interested in attending a gathering Berlin, though preferably not in the first week of October. As I'm a local, I could probably also help with finding a location if necessary. If you would like, I

Quickly searching for a note

2012-09-21 Thread Joshua Jensen
Background: To tie Perforce changelists to Git commits, I add a note to a commit with the form P4@123456. Later, I use the note to sync down the closest Perforce changelist matching the Git commit. I search for these notes by getting a list of revisions: git rev-list --max-count=1000

Re: Quickly searching for a note

2012-09-21 Thread Andreas Schwab
Joshua Jensen jjen...@workspacewhiz.com writes: Background: To tie Perforce changelists to Git commits, I add a note to a commit with the form P4@123456. Later, I use the note to sync down the closest Perforce changelist matching the Git commit. I search for these notes by getting a list of

Re: The GitTogether

2012-09-21 Thread Christian Couder
On Fri, Sep 21, 2012 at 4:05 PM, Shawn Pearce spea...@spearce.org wrote: On Fri, Sep 21, 2012 at 2:20 AM, Christian Couder It is sad that people who know what is or what is not happening are not taking care of letting people on this list know about it... I did not post to this mailing list

Re: [PATCH v2 13/14] Provide free_directory() for reclaiming dir_struct memory

2012-09-21 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: On 09/20/2012 09:46 PM, Adam Spiers wrote: Signed-off-by: Adam Spiers g...@adamspiers.org --- Documentation/technical/api-directory-listing.txt | 2 ++ dir.c | 23 +-- dir.h

Re: [PATCH v2 14/14] Add git-check-ignore sub-command

2012-09-21 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: +For each pathname given via the command-line or from a file via +`--stdin`, this command will list the first exclude pattern found (if +any) which explicitly excludes or includes that pathname. Note that +within any given exclude file, later

Re: The GitTogether

2012-09-21 Thread Patrick Renaud
Guys, Are we still talking of having two disconnected events for Git, one for core devs and one for users? -Patrick On 21 September 2012 11:23, Christian Couder christian.cou...@gmail.com wrote: On Fri, Sep 21, 2012 at 4:05 PM, Shawn Pearce spea...@spearce.org wrote: On Fri, Sep 21, 2012 at

Re: The GitTogether

2012-09-21 Thread Scott Chacon
Actually, responding to some of the feedback I've been getting, I'm thinking of having a single day of just core developers and then a day or two of users, or vice versa, but doing them together in a single event. Then just doing that same pattern in both the EU and the US. Scott On Fri, Sep

Re: [PATCH 2/3] receive-pack: send pack-processing stderr over sideband

2012-09-21 Thread Junio C Hamano
Jeff King p...@peff.net writes: Receive-pack invokes either unpack-objects or index-pack to handle the incoming pack. However, we do not redirect the stderr of the sub-processes at all, so it is never seen by the client. From the initial thread adding sideband support, which is here:

Re: The GitTogether

2012-09-21 Thread Patrick Renaud
THAT would be awesome :-) On 21 September 2012 12:45, Scott Chacon scha...@gmail.com wrote: Actually, responding to some of the feedback I've been getting, I'm thinking of having a single day of just core developers and then a day or two of users, or vice versa, but doing them together in a

Re: The GitTogether

2012-09-21 Thread Luca Milanesio
Agreed, that would be very nice. For the EU location, I would personally sponsor London, possibly at some well-know location such as Skills Matters Luca. On 21 Sep 2012, at 17:55, Patrick Renaud prenau...@gmail.com wrote: THAT would be awesome :-) On 21 September 2012 12:45, Scott Chacon

Re: [PATCH 2/3] receive-pack: send pack-processing stderr over sideband

2012-09-21 Thread Jeff King
On Fri, Sep 21, 2012 at 09:49:40AM -0700, Junio C Hamano wrote: 2. No matter what the cause, we are probably better off showing the errors to the client. If the client and the server admin are not the same entity, it is probably much easier for the client to cut-and-paste

Re: [RFC PATCH] add t3420-rebase-topology

2012-09-21 Thread Martin von Zweigbergk
On Tue, Sep 18, 2012 at 12:51 AM, Junio C Hamano gits...@pobox.com wrote: Martin von Zweigbergk martinv...@gmail.com writes: do you agree that 'rebase --onto does not re-apply patches in onto' is desirable? This depends on how you look at --onto. Recall the most typical and the original

Re: [PATCH] Add Auto-Submitted header to post-receive-email

2012-09-21 Thread Junio C Hamano
Chris Hiestand chiest...@salk.edu writes: My email in April went unanswered so I'm resending it. An Auto-Submitted header would be an improvement to the standard [git] post receive email. Thanks, Chris Begin forwarded message: From: Chris Hiestand chiest...@salk.edu Subject: [PATCH]

Re: Quickly searching for a note

2012-09-21 Thread Junio C Hamano
Joshua Jensen jjen...@workspacewhiz.com writes: Background: To tie Perforce changelists to Git commits, I add a note to a commit with the form P4@123456. Later, I use the note to sync down the closest Perforce changelist matching the Git commit. I search for these notes by getting a list of

Re: [PATCH 2/3] receive-pack: send pack-processing stderr over sideband

2012-09-21 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Fri, Sep 21, 2012 at 09:49:40AM -0700, Junio C Hamano wrote: 2. No matter what the cause, we are probably better off showing the errors to the client. If the client and the server admin are not the same entity, it is probably much

RE: Unable to clone GIT project

2012-09-21 Thread Ankush_Aggarwal
I have tried with iconv by adding its path in PATH and LIBRARY Path but failed to get any solution... Still getting below error c:\Ankush Data\work\Test-GIT\trial_1git clone ssh://bea@IP:/home/bea/GIT/sample_project Cloning into 'sample_project'... bea@.IP:'s password: git-upload-pack: error

Re: [PATCH 2/2] remote-curl: let users turn off smart http

2012-09-21 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Thu, Sep 20, 2012 at 02:15:20PM -0700, Junio C Hamano wrote: Jeff King p...@peff.net writes: I'm half-tempted to just drop the config entirely, leave GIT_SMART_HTTP=false as an escape hatch, and see if anybody even cares. Sounds like a very

Re: [PATCH 2/3] receive-pack: send pack-processing stderr over sideband

2012-09-21 Thread Jeff King
On Fri, Sep 21, 2012 at 10:25:24AM -0700, Junio C Hamano wrote: However, this does make things more consistent with upload-pack, which connects the stderr of pack-objects to sideband (which it must to handle progress). Furthermore, many of the messages from receive-pack are handled by

Re: [PATCH 2/2] remote-curl: let users turn off smart http

2012-09-21 Thread Jeff King
On Fri, Sep 21, 2012 at 10:34:22AM -0700, Junio C Hamano wrote: I'm half-tempted to just drop the config entirely, leave GIT_SMART_HTTP=false as an escape hatch, and see if anybody even cares. Sounds like a very attractive minimalistic way to go forward. We can always add per-remote

Re: [PATCH 3/2] pretty: support right alignment

2012-09-21 Thread Junio C Hamano
Nguyen Thai Ngoc Duy pclo...@gmail.com writes: - How does this interact with the wrapped output? Should it? We have to deal with it anyway when the left aligned text takes all the space. On one hand, I don't want to break the terminal width, leading to ugly output, so it'll interact. On

RE: Unable to clone GIT project

2012-09-21 Thread Ankush_Aggarwal
Lovely... I found the solution. So want to share with you all. Solution : add /usr/local/lib to /etc/ld.so.conf and run sudo ldconfig ld.so.conf file includes ld.so.conf.d/*.conf so I created local-lib.conf having value /usr/local/lib and place local-lib.conf under /etc/ld.so.conf.d

Re: Quickly searching for a note

2012-09-21 Thread Joshua Jensen
- Original Message - From: Junio C Hamano Date: 9/21/2012 11:21 AM Joshua Jensen jjen...@workspacewhiz.com writes: Background: To tie Perforce changelists to Git commits, I add a note to a commit with the form P4@123456. Later, I use the note to sync down the closest Perforce

Re: Quickly searching for a note

2012-09-21 Thread Joshua Jensen
- Original Message - From: Andreas Schwab Date: 9/21/2012 9:10 AM Joshua Jensen jjen...@workspacewhiz.com writes: Background: To tie Perforce changelists to Git commits, I add a note to a commit with the form P4@123456. Later, I use the note to sync down the closest Perforce

Re: Unable to clone GIT project

2012-09-21 Thread Andreas Schwab
That doesn't solve the mystery why you need libiconv in the first place. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. -- To unsubscribe from this list: send the line

Re: [PATCH v2 00/14] new git check-ignore sub-command

2012-09-21 Thread Junio C Hamano
Adam Spiers g...@adamspiers.org writes: It has been rebased on the latest master, and passed a full test run. FYI, I applied the attached on top before queuing it in 'pu'. Points to note: * We match the underline and the title of documentation header; * a few type mismatches (constness of

What are the ways CRLF files can make it into the repository?

2012-09-21 Thread Joshua Jensen
Hi. We've been running with core.autocrlf = input (some people with core.autocrlf = true). However, there are some text files in the repository that are CRLF, and I am at a loss to explain how they go here. We understand that if core.autocrlf=false, this could happen. While I admit there

Re* [PATCH] Documentation/git-blame.txt: --follow is a NO-OP

2012-09-21 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Wed, Sep 19, 2012 at 01:31:50PM -0700, Kevin Ballard wrote: I am a little lukewarm on my patch if only because of the precedent it sets. There are a trillion options that revision.c parses that are not necessarily meaningful or implemented for

Re: How do I run tests under Valgrind?

2012-09-21 Thread Ramkumar Ramachandra
Hi Peff, I was able to reproduce the problem on all my machines, and I consider this very disturbing. However, I was successfully able to corner the issue. I have an overtly long $PATH that's not getting split properly by `IFS=:` in one corner case -- in other words, this shell script fails to

Re: [PATCH v2 14/14] Add git-check-ignore sub-command

2012-09-21 Thread Junio C Hamano
Adam Spiers g...@adamspiers.org writes: +expect_in () { + dest=$HOME/expected-$1 text=$2 + if test -z $text + then + $dest # avoid newline + else + echo -e $text $dest This breaks when your shell is not bash. +test_check_ignore () { + args=$1

Re: Quickly searching for a note

2012-09-21 Thread Junio C Hamano
Joshua Jensen jjen...@workspacewhiz.com writes: Is there any particular reason you do that as two separate steps? It would feel more natural, at least to me, to do something along the lines of git log --show-notes=p4notes -1000 Thanks for the reply. I did not make clear above that

Re: How do I run tests under Valgrind?

2012-09-21 Thread Stefano Lattarini
On 09/21/2012 09:58 PM, Ramkumar Ramachandra wrote: Hi again, Ramkumar Ramachandra wrote: I was able to reproduce the problem on all my machines, and I consider this very disturbing. However, I was successfully able to corner the issue. I have an overtly long $PATH that's not getting split

Re: How do I run tests under Valgrind?

2012-09-21 Thread Ramkumar Ramachandra
Hi Stefano, Stefano Lattarini wrote: Zsh doesn't do word-splitting by default on variable expansions: $ zsh -c 'v=1 2 3; for x in $v; do echo $x; done' 1 2 3 unless you set the SH_WORD_SPLIT option, or put Zsh in Bourne-compatibility mode somehow: ... but didn't we set $IFS for

Re: Quickly searching for a note

2012-09-21 Thread Joshua Jensen
- Original Message - From: Junio C Hamano Date: 9/21/2012 2:04 PM Joshua Jensen jjen...@workspacewhiz.com writes: Is there any particular reason you do that as two separate steps? It would feel more natural, at least to me, to do something along the lines of git log

Re: How do I run tests under Valgrind?

2012-09-21 Thread Ramkumar Ramachandra
Hi again, Ramkumar Ramachandra wrote: ... but didn't we set $IFS for this purpose? The following segment of code works: I'm sorry, it doesn't. That is the problem. Ram -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More

Re: How do I run tests under Valgrind?

2012-09-21 Thread Jeff King
On Fri, Sep 21, 2012 at 10:13:09PM +0200, Stefano Lattarini wrote: On 09/21/2012 09:58 PM, Ramkumar Ramachandra wrote: Hi again, Ramkumar Ramachandra wrote: I was able to reproduce the problem on all my machines, and I consider this very disturbing. However, I was successfully able

Re: Quickly searching for a note

2012-09-21 Thread Johannes Sixt
Am 21.09.2012 22:25, schrieb Joshua Jensen: - Original Message - From: Junio C Hamano Date: 9/21/2012 2:04 PM Joshua Jensen jjen...@workspacewhiz.com writes: Is there any particular reason you do that as two separate steps? It would feel more natural, at least to me, to do something

[PATCH] t/test-lib.sh: do not trust $SHELL

2012-09-21 Thread Ramkumar Ramachandra
Replace $SHELL with an explicit `/bin/sh`, as some shells do not support all the features used in the script. For example, ZSH does not respect IFS, which is used in line 478. Signed-off-by: Ramkumar Ramachandra artag...@gmail.com --- t/test-lib.sh |2 +- 1 files changed, 1 insertions(+), 1

Re: [PATCH] t/test-lib.sh: do not trust $SHELL

2012-09-21 Thread Jeff King
On Sat, Sep 22, 2012 at 02:22:46AM +0530, Ramkumar Ramachandra wrote: Replace $SHELL with an explicit `/bin/sh`, as some shells do not support all the features used in the script. For example, ZSH does not respect IFS, which is used in line 478. I don't think that is the right thing to do.

Re: Re* [PATCH] Documentation/git-blame.txt: --follow is a NO-OP

2012-09-21 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Let's do this for now instead. That would make it clear to people who (rightly or wrongly) think the --follow option should do something that we already do so, and explain the output that they see when they do give the --follow option to the command.

Re: [PATCH] t/test-lib.sh: do not trust $SHELL

2012-09-21 Thread Ramkumar Ramachandra
Hi, Jeff King wrote: On Sat, Sep 22, 2012 at 02:22:46AM +0530, Ramkumar Ramachandra wrote: Replace $SHELL with an explicit `/bin/sh`, as some shells do not support all the features used in the script. For example, ZSH does not respect IFS, which is used in line 478. I don't think that is

Re: [PATCH] t/test-lib.sh: do not trust $SHELL

2012-09-21 Thread Andreas Schwab
Jeff King p...@peff.net writes: A bigger question is: why are you setting SHELL=zsh in the first place? SHELL is set to the login shell by default. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something

Re: Quickly searching for a note

2012-09-21 Thread Joshua Jensen
- Original Message - From: Johannes Sixt Date: 9/21/2012 2:50 PM The trick is to pipe 'git log' output into another process that reads no more than it needs and exits. Then 'git log' dies from SIGPIPE before it processed all 1000 commits because its down-stream has gone away. For

Re: [PATCH] t/test-lib.sh: do not trust $SHELL

2012-09-21 Thread Jeff King
On Sat, Sep 22, 2012 at 02:37:38AM +0530, Ramkumar Ramachandra wrote: I don't think that is the right thing to do. The point of SHELL is to point at a bourne-compatible shell. On some systems, the main reason to set it is that /bin/sh is _broken_, and we are trying to avoid it. But

Re: [PATCH] t/test-lib.sh: do not trust $SHELL

2012-09-21 Thread Jeff King
On Fri, Sep 21, 2012 at 11:08:34PM +0200, Andreas Schwab wrote: Jeff King p...@peff.net writes: A bigger question is: why are you setting SHELL=zsh in the first place? SHELL is set to the login shell by default. Yeah, sorry, I was thinking this was coming from our $SHELL_PATH Makefile

Re: [PATCH] t/test-lib.sh: do not trust $SHELL

2012-09-21 Thread Ramkumar Ramachandra
Hi Peff, Jeff King wrote: On Sat, Sep 22, 2012 at 02:37:38AM +0530, Ramkumar Ramachandra wrote: I don't think that is the right thing to do. The point of SHELL is to point at a bourne-compatible shell. On some systems, the main reason to set it is that /bin/sh is _broken_, and we are

[PATCH] Teach git-completion about git p4

2012-09-21 Thread Ryan Cumming
From: Ryan Cumming etao...@gmail.com git p4 was moved out of contrib in 1.7.11 but it git-completion didn't know about it. Add git p4 completion based on the existing SVN completion. It covers all known subcommands and options except for the -/ option for clone which doesn't use the standard --

Re: [PATCH] t/test-lib.sh: do not trust $SHELL

2012-09-21 Thread Andreas Schwab
Ramkumar Ramachandra artag...@gmail.com writes: My SHELL_PATH is not set, and I can see SHELL_PATH ?= $(SHELL) in the Makefile. Which shell is it supposed to point to? Inside a makefile the variable SHELL is special in that it is never imported from the environment. If not set it defaults to

Re: [PATCH] t/test-lib.sh: do not trust $SHELL

2012-09-21 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: Hi Peff, Jeff King wrote: On Sat, Sep 22, 2012 at 02:37:38AM +0530, Ramkumar Ramachandra wrote: I don't think that is the right thing to do. The point of SHELL is to point at a bourne-compatible shell. On some systems, the main reason to

Re: [PATCH] t/test-lib.sh: do not trust $SHELL

2012-09-21 Thread Jeff King
On Sat, Sep 22, 2012 at 03:04:50AM +0530, Ramkumar Ramachandra wrote: No, the #!-header is only information. When you run make test we actually invoke the shell ourselves using $SHELL_PATH. My SHELL_PATH is not set, and I can see SHELL_PATH ?= $(SHELL) in the Makefile. Which shell is it

Re: [PATCH] t/test-lib.sh: do not trust $SHELL

2012-09-21 Thread Junio C Hamano
Andreas Schwab sch...@linux-m68k.org writes: Ramkumar Ramachandra artag...@gmail.com writes: My SHELL_PATH is not set, and I can see SHELL_PATH ?= $(SHELL) in the Makefile. Which shell is it supposed to point to? Inside a makefile the variable SHELL is special in that it is never imported

Re: Quickly searching for a note

2012-09-21 Thread Jeff King
On Fri, Sep 21, 2012 at 03:10:40PM -0600, Joshua Jensen wrote: - Original Message - From: Johannes Sixt Date: 9/21/2012 2:50 PM The trick is to pipe 'git log' output into another process that reads no more than it needs and exits. Then 'git log' dies from SIGPIPE before it processed

Re: Quickly searching for a note

2012-09-21 Thread Junio C Hamano
Jeff King p...@peff.net writes: I think people have provided sane techniques for doing this with a pipeline. But there is really no reason not to have --grep-notes, just as we have --grep. It's simply that nobody has implemented it yet (and nobody is working on it as far as I know). It would

[PATCH 0/6] Advanced --oneline layout

2012-09-21 Thread Nguyễn Thái Ngọc Duy
Still a toy series (previous discussion [1]) but it's getting close to something useful. This introduces three placeholders %, % and % for left/right/center align the next placeholder. Any of them can be followed by '|' to make the next placeholder use up to the Nth column. It's pretty useful

[PATCH 2/6] pretty: split parsing %C into a separate function

2012-09-21 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- pretty.c | 60 +++- 1 file changed, 35 insertions(+), 25 deletions(-) diff --git a/pretty.c b/pretty.c index e910679..93c96c2 100644 --- a/pretty.c +++ b/pretty.c @@ -863,6 +863,40

[PATCH 3/6] pretty: support %C(auto[,N]) to turn on coloring on next placeholder(s)

2012-09-21 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- Documentation/pretty-formats.txt | 1 + pretty.c | 28 +++- 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/Documentation/pretty-formats.txt

[PATCH 4/6] utf8.c: move display_mode_esc_sequence_len() for use by other functions

2012-09-21 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- utf8.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/utf8.c b/utf8.c index a544f15..18a4d9c 100644 --- a/utf8.c +++ b/utf8.c @@ -9,6 +9,20 @@ struct interval { int last; };

[PATCH 5/6] utf8.c: add utf8_strnwidth() with the ability to skip ansi sequences

2012-09-21 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- utf8.c | 20 ++-- utf8.h | 1 + 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/utf8.c b/utf8.c index 18a4d9c..791499e 100644 --- a/utf8.c +++ b/utf8.c @@ -266,18 +266,26 @@ int utf8_width(const char

[PATCH 6/6] pretty: support padding placeholders, % % and %

2012-09-21 Thread Nguyễn Thái Ngọc Duy
Either %, % or % standing before a placeholder specifies how many columns (at least as the placeholder can exceed it) it takes. Each differs on how spaces are padded: % pads on the right (aka left alignment) % pads on the left (aka right alignment) % pads both ways equally (aka centered)

[PATCH 1/6] pretty: share code between format_decoration and show_decorations

2012-09-21 Thread Nguyễn Thái Ngọc Duy
This also adds color support to format_decoration() Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- log-tree.c | 59 log-tree.h | 3 ++ pretty.c | 19 +

Re: [PATCH] t/test-lib.sh: do not trust $SHELL

2012-09-21 Thread Ramkumar Ramachandra
Hi Junio, Junio C Hamano wrote: The reference to ${SHELL-/bin/sh} in the test need to be updated to SHELL_PATH as Peff suggested in the other subthread. For that, the entire block needs to be moved down to come after `. GIT_BUILD_DIR=$TEST_DIRECTORY/..`. Is this okay? diff --git

[PATCH 7/6] pretty: trim trailing spaces due to padding

2012-09-21 Thread Nguyễn Thái Ngọc Duy
TODO: should only be enabled explicitly to avoid unexpected trimming Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- And I did not remember I was in interactive rebase mode when I made the series. This patch is for discussion only. My screen seems to flash (I think) printing trailing

Re: Quickly searching for a note

2012-09-21 Thread Junio C Hamano
Joshua Jensen jjen...@workspacewhiz.com writes: Background: To tie Perforce changelists to Git commits, I add a note to a commit with the form P4@123456. Later, I use the note to sync down the closest Perforce changelist matching the Git commit. I noticed that nobody brought this up, but

Re: [PATCH] t/test-lib.sh: do not trust $SHELL

2012-09-21 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: Junio C Hamano wrote: The reference to ${SHELL-/bin/sh} in the test need to be updated to SHELL_PATH as Peff suggested in the other subthread. For that, the entire block needs to be moved down to come after `.

Re: [PATCH] t/test-lib.sh: do not trust $SHELL

2012-09-21 Thread Ramkumar Ramachandra
Hi again, On Sat, Sep 22, 2012 at 10:22 AM, Junio C Hamano gits...@pobox.com wrote: Ramkumar Ramachandra artag...@gmail.com writes: Junio C Hamano wrote: The reference to ${SHELL-/bin/sh} in the test need to be updated to SHELL_PATH as Peff suggested in the other subthread. For that, the

Re: [PATCH] t/test-lib.sh: do not trust $SHELL

2012-09-21 Thread Ramkumar Ramachandra
Here's a patch. -- 8 -- From: Ramkumar Ramachandra artag...@gmail.com Date: Sat, 22 Sep 2012 10:25:10 +0530 Subject: [PATCH] test-lib: do not trust $SHELL Do not trust $SHELL to be a bourne-compatible shell. Instead, use the Makefile variable $SHELL_PATH. This fixes a bug: when a test was run

Re: git clone over http with basic auth bug?

2012-09-21 Thread Jeff King
On Sat, Sep 22, 2012 at 09:37:38AM +1000, Paul J R wrote: Im not sure if this is a bug, or just as implemented. But when cloning from a repo sitting on a web site that uses basic auth, the git client appears to forget its authentication info and ignores the 401's the server is sending back.

Re: Git 1.7.12 installer blocked by Gatekeeper - needs signing with an Apple developer ID

2012-09-21 Thread Jeff King
On Wed, Sep 19, 2012 at 10:31:58AM -0700, Junio C Hamano wrote: Torsten Louland torsten.loul...@telenet.be writes: Installing latest stable git on Mac OS X Mountain Lion is blocked by Gatekeeper. Could you provide an installer for latest stable git that is signed with an Apple issued