Re: cvsps, parsecvs, svn2git and the CVS exporter mess

2013-01-05 Thread Max Horn
On 03.01.2013, at 21:53, Eric S. Raymond wrote: Michael Haggerty mhag...@alum.mit.edu: There are two good reasons that the output is written to two separate files: Those are good reasons to write to a pair of tempfiles, and I was able to deduce in advance most of what your explanation

[PATCH] Add getenv.so for catching invalid getenv() use via LD_PRELOAD

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- Perhaps this will help the getenv bug hunting (I assume we do the hunting on Linux platform only). So far it catches this and is stuck at getenv in git_pager(). diff --git a/exec_cmd.c b/exec_cmd.c index 125fa6f..d8be5ce 100644

Re: [PATCH] Add getenv.so for catching invalid getenv() use via LD_PRELOAD

2013-01-05 Thread Matt Kraai
On Sat, Jan 05, 2013 at 03:55:46PM +0700, Nguyễn Thái Ngọc Duy wrote: Perhaps this will help the getenv bug hunting (I assume we do the hunting on Linux platform only). So far it catches this and is stuck at getenv in git_pager(). It seems like a static analysis tool might be able to detect

t7061: comments and one failure

2013-01-05 Thread Torsten Bögershausen
Hej, TC 9 is failing (Mac OS X 10.6), == expecting success: tracked/uncommitted git status --porcelain --ignored actual test_cmp expected actual --- expected2013-01-05 11:01:00.0 + +++ actual 2013-01-05 11:01:00.0

Re: t7061: comments and one failure

2013-01-05 Thread Antoine Pelisse
Yeah, I can reproduce the problem here on my OS X test box. It seems to be related to core.ignorecase. If you put git config core.ignorecase false at the top of t7061, it passes on OS X. Likewise, if you set it to true, it will start failing on Linux. Great, so I have a chance to

Re: [PATCH] Add getenv.so for catching invalid getenv() use via LD_PRELOAD

2013-01-05 Thread Duy Nguyen
On Sat, Jan 5, 2013 at 5:39 PM, Matt Kraai kr...@ftbfs.org wrote: On Sat, Jan 05, 2013 at 03:55:46PM +0700, Nguyễn Thái Ngọc Duy wrote: Perhaps this will help the getenv bug hunting (I assume we do the hunting on Linux platform only). So far it catches this and is stuck at getenv in

Re: [BUG] git submodule update is not fail safe

2013-01-05 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 04/01/2013 22:51, Junio C Hamano ha scritto: Manlio Perillo manlio.peri...@gmail.com writes: $ git submodule update --init ... Submodule 'roms/vgabios' (git://git.qemu.org/vgabios.git/) registered for path 'roms/vgabios' fatal: unable to

Re: [BUG] git submodule update is not fail safe

2013-01-05 Thread Jens Lehmann
Am 04.01.2013 22:51, schrieb Junio C Hamano: Manlio Perillo manlio.peri...@gmail.com writes: $ git submodule update --init ... Submodule 'roms/vgabios' (git://git.qemu.org/vgabios.git/) registered for path 'roms/vgabios' fatal: unable to connect to anongit.freedesktop.org:

Re: [RFC/PATCH] avoid SIGPIPE warnings for aliases

2013-01-05 Thread Jeff King
On Fri, Jan 04, 2013 at 02:20:52PM -0800, Junio C Hamano wrote: Jeff King p...@peff.net writes: I have two reservations with this patch: 1. We are ignoring SIGPIPE all the time. For an alias that is calling log, that is fine. But if pack-objects dies on the server side,

Re: [PATCH] gitk: Display the date of a tag in a human friendly way.

2013-01-05 Thread Anand Kumria
Hi Junio, On 4 January 2013 23:50, Junio C Hamano gits...@pobox.com wrote: Anand Kumria wildf...@progsoc.org writes: By selecting a tag within gitk you can display information about it. This information is output by using the command 'git cat-file tag tagid' This outputs the *raw*

Re: [BUG] git submodule update is not fail safe

2013-01-05 Thread Jens Lehmann
Am 05.01.2013 14:52, schrieb Manlio Perillo: Il 04/01/2013 22:51, Junio C Hamano ha scritto: Manlio Perillo manlio.peri...@gmail.com writes: $ git submodule update --init ... Submodule 'roms/vgabios' (git://git.qemu.org/vgabios.git/) registered for path 'roms/vgabios' fatal: unable to

[PATCH] run-command: encode signal death as a positive integer

2013-01-05 Thread Jeff King
On Sat, Jan 05, 2013 at 09:03:16AM -0500, Jeff King wrote: In fact, I really wonder if this code from wait_or_whine is actually correct: code = WTERMSIG(status); /* * This return value is chosen so that code 0xff * mimics the exit code that a POSIX shell would report for *

Re: [BUG] git submodule update is not fail safe

2013-01-05 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 05/01/2013 15:01, Jens Lehmann ha scritto: [...] $ git submodule update --init fatal: Needed a single revision Unable to find current revision in submodule path 'pixman' The problem is easy to solve: manually remove the pixman directory;

Re: [BUG] git submodule update is not fail safe

2013-01-05 Thread Jens Lehmann
Am 05.01.2013 15:01, schrieb Jens Lehmann: Am 04.01.2013 22:51, schrieb Junio C Hamano: Manlio Perillo manlio.peri...@gmail.com writes: $ git submodule update --init ... Submodule 'roms/vgabios' (git://git.qemu.org/vgabios.git/) registered for path 'roms/vgabios' fatal: unable to connect

[PATCH] fix compilation with NO_PTHREADS

2013-01-05 Thread Jeff King
Commit 1327452 cleaned up an unused parameter from wait_or_whine, but forgot to update a caller that is inside #ifdef NO_PTHREADS. Signed-off-by: Jeff King p...@peff.net --- I happened to notice this while looking at the sigpipe topic. I guess not many people are building with NO_PTHREADS these

Re: cvsps, parsecvs, svn2git and the CVS exporter mess

2013-01-05 Thread Eric S. Raymond
Max Horn post...@quendi.de: Hm, you snipped this part of Michael's mail: However, if that is a problem, it is possible to configure cvs2git to write the blobs inline with the rest of the dumpfile (this mode is supported because hg fast-import doesn't support detached blobs). I would

Re: cvsps, parsecvs, svn2git and the CVS exporter mess

2013-01-05 Thread Eric S. Raymond
Bart Massey b...@cs.pdx.edu: I don't know what Eric Raymond officially end-of-life-ing parsecvs means? You and Keith handed me the maintainer's baton. If I were to EOL it, that would be the successor you two designated judging in public that the code is unsalvageable or has become pointless.

[PATCH] git-fast-import(1): remove duplicate --done option

2013-01-05 Thread John Keeping
The --done option to git-fast-import is documented twice in its manual page. Combine the best bits of each description, keeping the location of the instance that was added first. Signed-off-by: John Keeping j...@keeping.me.uk --- I'm guessing that the reason the option was documented again (in

[PATCH] Documentation: fix man page dependency on asciidoc.conf

2013-01-05 Thread John Keeping
When building manual pages, the source text is transformed to XML with AsciiDoc before the man pages are generated from the XML with xmlto. Fix the dependency in the Makefile so that the XML files are rebuilt when asciidoc.conf changes and not just the manual pages from unchanged XML.

Re: Lockless Refs? (Was [PATCH] refs: do not use cached refs in repack_without_ref)

2013-01-05 Thread Jeff King
On Mon, Dec 31, 2012 at 03:30:53AM -0700, Martin Fick wrote: The general approach is to setup a transaction and either commit or abort it. A transaction can be setup by renaming an appropriately setup directory to the ref.lock name. If the rename succeeds, the transaction is begun. Any

Re: [PATCH] git-fast-import(1): remove duplicate --done option

2013-01-05 Thread Eric S. Raymond
John Keeping j...@keeping.me.uk: I'm guessing that the reason the option was documented again (in commit 3266de10) is because the options are not in an obvious order. There does seem to be some grouping of the options by type, but without subheadings I wonder if it would make more sense to

[PATCH] Alphabetize the fast-import options, following a suggestion on the list.

2013-01-05 Thread Eric S. Raymond
--- Documentation/git-fast-import.txt | 94 +++ 1 file changed, 45 insertions(+), 49 deletions(-) diff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt index 68bca1a..d006bcf 100644 --- a/Documentation/git-fast-import.txt +++

Re: [LHF] making t5000 tar xf tests more lenient

2013-01-05 Thread René Scharfe
Am 24.12.2012 21:49, schrieb Junio C Hamano: I've been running testsuite on a few platforms that are unfamiliar to me, and was bitten by BSD implementation of tar that do not grok the extended pax headers. I've already fixed one in t9502 [*1*] where we produce a tarball with git archive and

Re: [PATCH] gitk: Display the date of a tag in a human friendly way.

2013-01-05 Thread Junio C Hamano
Anand Kumria wildf...@progsoc.org writes: Sorry, I didn't know that gitk had been split back out (and Documentation/gitk.txt still mentions it is part of the git suite). It is not split back at all, and it won't be. From git user's point of view it is part of the suite. Gitk however is still

Re: [PATCH 00/10] push: switch default from matching to simple

2013-01-05 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: We promised to change the behaviour of lazy git push [there] that does not say what to push on the command line from matching to simple in Git 2.0. Even though the top-level RelNotes symbolic link points at 1.8.2, we can change our mind to tag 2.0 at

Re: [LHF] making t5000 tar xf tests more lenient

2013-01-05 Thread Junio C Hamano
René Scharfe rene.scha...@lsrfire.ath.cx writes: Anyway, I don't think the pax headers are to blame here. The patch below fixes the tar failures for me, but I'm not sure why. There must be something special about some (not all!) directory entries with trailing slashes after directory names.

Re: [PATCH] run-command: encode signal death as a positive integer

2013-01-05 Thread Johannes Sixt
Am 05.01.2013 15:49, schrieb Jeff King: On Sat, Jan 05, 2013 at 09:03:16AM -0500, Jeff King wrote: In fact, I really wonder if this code from wait_or_whine is actually correct: code = WTERMSIG(status); /* * This return value is chosen so that code 0xff * mimics the exit code

Re: [LHF] making t5000 tar xf tests more lenient

2013-01-05 Thread Junio C Hamano
René Scharfe rene.scha...@lsrfire.ath.cx writes: Anyway, I don't think the pax headers are to blame here. Hmph, I am reasonably sure I saw a test that created an archive from a commit (hence with pax header), asked platform tar to either list the contents or actually extracted to the

[PATCH] clone: support atomic operation with --separate-git-dir

2013-01-05 Thread Jens Lehmann
Since b57fb80a7d (init, clone: support --separate-git-dir for .git file) git clone supports the --separate-git-dir option to create the git dir outside the work tree. But when that option is used, the git dir won't be deleted in case the clone fails like it would be without this option. This makes

RE: [PATCH v4] git-completion.bash: add support for path completion

2013-01-05 Thread Marc Khouzam
Junio C Hamano gits...@pobox.com writes: Marc Khouzam marc.khou...@ericsson.com writes: I've been playing with it but I'm not getting the expected behavior when I cd to a sub-directory. Thanks for testing. Manlio? Can you try the attached patch? Thanks for this, it improves the

[PATCH] status: report ignored yet tracked directories

2013-01-05 Thread Antoine Pelisse
Tracked directories (i.e. directories containing tracked files) that are ignored must be reported as ignored if they contain untracked files. Currently, tracked files or directories can't be reported untracked or ignored. Remove that constraint when searching ignored files. Signed-off-by:

[Feature request] make git buildable from a separate directory

2013-01-05 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi. Many C projects I have seen (based on autoconf, but not always - like Nginx) allow the project to be build in a separate directory, in order to avoid to pollute the working directory with compiled files. Unfortunately this seems to not be

Re: [PATCH] clone: support atomic operation with --separate-git-dir

2013-01-05 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 05/01/2013 21:17, Jens Lehmann ha scritto: Since b57fb80a7d (init, clone: support --separate-git-dir for .git file) git clone supports the --separate-git-dir option to create the git dir outside the work tree. But when that option is used, the

Re: Suggested improvements to the git-p4 documentation (branch-related)

2013-01-05 Thread Pete Wyckoff
sh...@keba.be wrote on Thu, 03 Jan 2013 15:58 -0500: While struggling to get git-p4 to work properly with branches, I thought the documentation on http://git-scm.com/docs/git-p4 could use some improvements: Thanks, I definitely appreciate the constructive comments here. 1. At the end of the

[PATCH 00/10] Log mailmap optimization

2013-01-05 Thread Antoine Pelisse
Hi, Here is a reroll of ap/log-mailmap. The idea is to use another preparatory step: Allow case-insensitive and length search in list_lookup We can now search for mapping name and email without any copy. Of course a copy is then necessary to store the info, but we no longer need any copy to

[PATCH 01/10] list_lookup: create case and length search

2013-01-05 Thread Antoine Pelisse
Create a new function to look-up a string in a string_list, but: - add a new parameter to ignore case differences - add a length parameter to search for a substring The idea is to avoid several copies (lowering a string before searching it when we just want to ignore case), or copying a

[PATCH 02/10] Use split_ident_line to parse author and committer

2013-01-05 Thread Antoine Pelisse
Currently blame.c::get_acline, pretty.c::pp_user_info() and shortlog.c::insert_one_record are parsing author name, email, time and tz themselves. Use ident.c::split_ident_line for better code reuse. Signed-off-by: Antoine Pelisse apeli...@gmail.com --- builtin/blame.c| 59

[PATCH 06/10] pretty: use mailmap to display username and email

2013-01-05 Thread Antoine Pelisse
Use the mailmap information to display the correct username and email address in all log commands. Signed-off-by: Antoine Pelisse apeli...@gmail.com --- pretty.c | 58 +- 1 file changed, 37 insertions(+), 21 deletions(-) diff --git

[PATCH 05/10] mailmap: add mailmap structure to rev_info and pp

2013-01-05 Thread Antoine Pelisse
the mailmap string_list structure filled with mailmap information is passed along from rev_info to pretty_print_context to provide mailmap information to pretty print each commits with the correct username and email. Signed-off-by: Antoine Pelisse apeli...@gmail.com --- commit.h | 1 +

[PATCH 08/10] test: add test for --use-mailmap option

2013-01-05 Thread Antoine Pelisse
The new option '--use-mailmap' can be used to make sure that mailmap file is used to convert name when running log commands. The test is simple and checks that the Author line is correctly replaced when running log. Signed-off-by: Antoine Pelisse apeli...@gmail.com --- t/t4203-mailmap.sh | 14

[PATCH 04/10] mailmap: simplify map_user() interface

2013-01-05 Thread Antoine Pelisse
The new string_list_lookup_extended() allows us to simplify map_user(), mostly to avoid copies of string buffers. It also simplifies caller functions. map_user() directly receive pointers and length from the commit buffer as mail and name. If mapping of the user and mail can be done, the pointer

[PATCH 10/10] log: add log.mailmap configuration option

2013-01-05 Thread Antoine Pelisse
Teach log.mailmap configuration variable to turn --use-mailmap option on to git log, git show and git whatchanged. The --no-use-mailmap option from the command line can countermand the setting. Signed-off-by: Antoine Pelisse apeli...@gmail.com --- Documentation/config.txt | 4

[PATCH 03/10] mailmap: remove email copy and length limitation

2013-01-05 Thread Antoine Pelisse
In map_user(), the new string_list_lookup_extended() allows us to remove the copy of email buffer to lower it. This also removes the limitation on the length of the copy buffer and simplifies the function. Signed-off-by: Antoine Pelisse apeli...@gmail.com --- mailmap.c | 22

[PATCH 09/10] log: grep author/committer using mailmap

2013-01-05 Thread Antoine Pelisse
Currently you can use mailmap to display log authors and committers but you can't use the mailmap to find commits with mapped values. This commit allows you to run: git log --use-mailmap --author mapped_name_or_email git log --use-mailmap --committer mapped_name_or_email Of course it

Re: [PATCH v4] git-completion.bash: add support for path completion

2013-01-05 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 05/01/2013 21:23, Marc Khouzam ha scritto: [...] I did further testing with your patch and found some less obvious issues. I didn't debug the script myself as I'm not that familiar with it either, but I think the testcases below should help

Re: [PATCH] status: report ignored yet tracked directories

2013-01-05 Thread Torsten Bögershausen
On 05.01.13 21:42, Antoine Pelisse wrote: Tracked directories (i.e. directories containing tracked files) that are ignored must be reported as ignored if they contain untracked files. Currently, tracked files or directories can't be reported untracked or ignored. Remove that constraint when

[PATCH 07/10] log: add --use-mailmap option

2013-01-05 Thread Antoine Pelisse
Add the --use-mailmap option to log commands. It allows to display names from mailmap file when displaying logs, whatever the format used. Signed-off-by: Antoine Pelisse apeli...@gmail.com --- Documentation/git-log.txt | 5 + builtin/log.c | 9 - 2 files changed, 13

Re: [PATCH 01/10] list_lookup: create case and length search

2013-01-05 Thread Junio C Hamano
Antoine Pelisse apeli...@gmail.com writes: Create a new function to look-up a string in a string_list, but: - add a new parameter to ignore case differences - add a length parameter to search for a substring The idea is to avoid several copies (lowering a string before searching it when

[PATCH] archive-tar: split long paths more carefully

2013-01-05 Thread René Scharfe
The name field of a tar header has a size of 100 characters. This limit was extended long ago in a backward compatible way by providing the additional prefix field, which can hold 155 additional characters. The actual path is constructed at extraction time by concatenating the prefix field, a

Re: [LHF] making t5000 tar xf tests more lenient

2013-01-05 Thread René Scharfe
Am 05.01.2013 21:11, schrieb Junio C Hamano: René Scharfe rene.scha...@lsrfire.ath.cx writes: Anyway, I don't think the pax headers are to blame here. Hmph, I am reasonably sure I saw a test that created an archive from a commit (hence with pax header), asked platform tar to either list the

Re: [PATCH] Add getenv.so for catching invalid getenv() use via LD_PRELOAD

2013-01-05 Thread Jonathan Nieder
Nguyễn Thái Ngọc Duy wrote: Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- Perhaps this will help the getenv bug hunting Even if no one decides to do the getenv hunting (I haven't decided yet whether it's worth the trouble, though patches like the setup_path() one that make string

Re: cvsps, parsecvs, svn2git and the CVS exporter mess

2013-01-05 Thread Jonathan Nieder
Eric S. Raymond wrote: Michael Haggerty wants me to trust that cvs2git's analysis stage has been fixed, but I must say that is a more difficult leap of faith when two of the most visible things about it are still (a) a conspicuous instance of interface misdesign, and (b) documentation that is

Re: [PATCH] status: report ignored yet tracked directories

2013-01-05 Thread Jeff King
On Sat, Jan 05, 2013 at 09:42:43PM +0100, Antoine Pelisse wrote: Tracked directories (i.e. directories containing tracked files) that are ignored must be reported as ignored if they contain untracked files. Currently, tracked files or directories can't be reported untracked or ignored.

Re: [PATCH] Alphabetize the fast-import options, following a suggestion on the list.

2013-01-05 Thread Jonathan Nieder
Eric S. Raymond wrote: --- Missing sign-off. Depending on when you prefer to add the sign-off, something like echo '[alias] c = commit --signoff' ~/.gitconfig or echo '[alias] f = format-patch --signoff' ~/.gitconfig might be useful for the future, assuming you already look

Re: [PATCH] run-command: encode signal death as a positive integer

2013-01-05 Thread Jeff King
On Sat, Jan 05, 2013 at 02:19:09PM -0800, Jonathan Nieder wrote: Documentation/technical/api-run-command.txt | 6 ++ editor.c| 2 +- run-command.c | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-)

Re: [PATCH] git-fast-import(1): remove duplicate --done option

2013-01-05 Thread Jonathan Nieder
John Keeping wrote: The --done option to git-fast-import is documented twice in its manual page. Combine the best bits of each description, keeping the location of the instance that was added first. Signed-off-by: John Keeping j...@keeping.me.uk Good catch, thanks. Reviewed-by: Jonathan

Re: [PATCH] Documentation: fix man page dependency on asciidoc.conf

2013-01-05 Thread Jonathan Nieder
John Keeping wrote: When building manual pages, the source text is transformed to XML with AsciiDoc before the man pages are generated from the XML with xmlto. Fix the dependency in the Makefile so that the XML files are rebuilt when asciidoc.conf changes and not just the manual pages from

Re: [PATCH] archive-tar: split long paths more carefully

2013-01-05 Thread Jonathan Nieder
René Scharfe wrote: --- a/archive-tar.c +++ b/archive-tar.c @@ -153,6 +153,8 @@ static unsigned int ustar_header_chksum(const struct ustar_header *header) static size_t get_path_prefix(const char *path, size_t pathlen, size_t maxlen) { size_t i = pathlen; + if (i 1 path[i

Re: [PATCH] fix compilation with NO_PTHREADS

2013-01-05 Thread Jonathan Nieder
Jeff King wrote: I happened to notice this while looking at the sigpipe topic. I guess not many people are building with NO_PTHREADS these days. Or that those people don't build next. :) Thanks for catching it. -- To unsubscribe from this list: send the line unsubscribe git in the body of a

Re: [PATCH] run-command: encode signal death as a positive integer

2013-01-05 Thread Jonathan Nieder
Jeff King wrote: I'd expecting cooking this patch for a while would flush out any I missed. Heh, probably not. ;-) But I tried to examine all the callsites (and only found the two messages I mentioned), and among the reviewers, I'm guessing we hit them all. Ciao,

Re: [Feature request] make git buildable from a separate directory

2013-01-05 Thread Jonathan Nieder
Hi Manlio, Manlio Perillo wrote: Many C projects I have seen (based on autoconf, but not always - like Nginx) allow the project to be build in a separate directory, in order to avoid to pollute the working directory with compiled files. Unfortunately this seems to not be possible with Git.

Trying to understand the web dav details

2013-01-05 Thread Jason Pyeron
When doing a clone by https (reverse proxied to http) the first request is GET /git/project/info/refs?service=git-upload-pack How does the ?service= get translated in to the action performed on the web server? I ask because I have 2 projects, one works the other does not. I am using

Version 1.8.1 does not compile on Cygwin 1.7.14

2013-01-05 Thread Stephen Linda Smith
Commit 9fca6cffc05321445b59c91e8f8d308f41588b53 message states that the macro was being renamed for clarity. The patch also changes a define. This change causes the code to not compile on cygwin 1.7.14. I narrowed the problem to this patch by bisecting commits between v1.8.0 and 1.8.1 Here

RE: Version 1.8.1 does not compile on Cygwin 1.7.14

2013-01-05 Thread Jason Pyeron
Stephen Linda Smith Sent: Saturday, January 05, 2013 21:05 Commit 9fca6cffc05321445b59c91e8f8d308f41588b53 message states that the macro was being renamed for clarity. The patch also changes a define. Was it the commit before 9fca6cffc05321445b59c91e8f8d308f41588b53 that compiles or

Re: Trying to understand the web dav details

2013-01-05 Thread Jeff King
On Sat, Jan 05, 2013 at 08:32:09PM -0500, Jason Pyeron wrote: When doing a clone by https (reverse proxied to http) the first request is GET /git/project/info/refs?service=git-upload-pack How does the ?service= get translated in to the action performed on the web server? If you are

RE: Version 1.8.1 does not compile on Cygwin 1.7.14

2013-01-05 Thread Jason Pyeron
-Original Message- From: Jason Pyeron Sent: Saturday, January 05, 2013 22:38 Stephen Linda Smith Sent: Saturday, January 05, 2013 21:05 Commit 9fca6cffc05321445b59c91e8f8d308f41588b53 message states that the macro was being renamed for clarity. The patch also

RE: Trying to understand the web dav details

2013-01-05 Thread Pyeron, Jason J CTR (US)
-Original Message- From: Jeff King Sent: Saturday, January 05, 2013 11:20 PM On Sat, Jan 05, 2013 at 08:32:09PM -0500, Jason Pyeron wrote: When doing a clone by https (reverse proxied to http) the first request is GET /git/project/info/refs?service=git-upload-pack How

[PATCH 00/21] struct pathspec conversion

2013-01-05 Thread Nguyễn Thái Ngọc Duy
This is another step towards the pathspec unification. This series introduces a get_pathspec() alternative: parse_pathspec(). The new function intializes struct pathspec directly. Many builtin commands (except mv) are converted to use this function. As a result, struct pathspec is used from the

[PATCH 01/21] pathspec: save the non-wildcard length part

2013-01-05 Thread Nguyễn Thái Ngọc Duy
We mark pathspec with wildcards with the field use_wildcard. We could do better by saving the length of the non-wildcard part, which can be used for optimizations such as f9f6e2c (exclude: do strcmp as much as possible before fnmatch - 2012-06-07). Signed-off-by: Nguyễn Thái Ngọc Duy

[PATCH 02/21] Add parse_pathspec() that converts cmdline args to struct pathspec

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Currently to fill a struct pathspec, we do: const char **paths; paths = get_pathspec(prefix, argv); ... init_pathspec(pathspec, paths); paths can only carry bare strings, which loses information from command line arguments such as pathspec magic or the prefix part's length for each

[PATCH 03/21] pathspec: make sure the prefix part is wildcard-clean

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Prefix is the result of Git moving back from current directory to worktree's top directory and it has to prepend all user provided paths so that they become relative to the new current directory. Any wildcards in the prefix should not be treated as such because it's not the user intention. Make

[PATCH 04/21] Export parse_pathspec() and convert some get_pathspec() calls

2013-01-05 Thread Nguyễn Thái Ngọc Duy
These call sites follow the pattern: paths = get_pathspec(prefix, argv); init_pathspec(pathspec, paths); which can be converted into a single parse_pathspec() call. Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- builtin/grep.c | 4 +--- builtin/ls-tree.c | 2 +-

[PATCH 05/21] clean: convert to use parse_pathspec

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- builtin/clean.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/builtin/clean.c b/builtin/clean.c index 69c1cda..788ad8c 100644 --- a/builtin/clean.c +++ b/builtin/clean.c @@ -42,7 +42,7 @@ int

[PATCH 06/21] commit: convert to use parse_pathspec

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- builtin/commit.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/builtin/commit.c b/builtin/commit.c index d6dd3df..8410617 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -277,17 +277,18 @@

[PATCH 07/21] status: convert to use parse_pathspec

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- builtin/commit.c | 6 +++--- wt-status.c | 17 +++-- wt-status.h | 2 +- 3 files changed, 11 insertions(+), 14 deletions(-) diff --git a/builtin/commit.c b/builtin/commit.c index 8410617..b706ebb 100644 ---

[PATCH 08/21] rerere: convert to use parse_pathspec

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- builtin/rerere.c | 6 +++--- rerere.c | 8 rerere.h | 4 +++- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/builtin/rerere.c b/builtin/rerere.c index dc1708e..a573c4a 100644 ---

[PATCH 09/21] checkout: convert to use parse_pathspec

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- builtin/checkout.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/builtin/checkout.c b/builtin/checkout.c index a9c1b5a..da25298 100644 --- a/builtin/checkout.c +++

[PATCH 10/21] rm: convert to use parse_pathspec

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- builtin/rm.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/builtin/rm.c b/builtin/rm.c index dabfcf6..d719d95 100644 --- a/builtin/rm.c +++ b/builtin/rm.c @@ -216,7 +216,7 @@ static struct option

[PATCH 11/21] ls-files: convert to use parse_pathspec

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- builtin/ls-files.c | 42 +++--- cache.h| 1 + dir.c | 20 3 files changed, 32 insertions(+), 31 deletions(-) diff --git a/builtin/ls-files.c

[PATCH 12/21] archive: convert to use parse_pathspec

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- archive.c | 10 -- archive.h | 2 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/archive.c b/archive.c index 4666404..530badb 100644 --- a/archive.c +++ b/archive.c @@ -150,7 +150,6 @@ int

[PATCH 13/21] add: convert to use parse_pathspec

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- builtin/add.c | 57 - 1 file changed, 28 insertions(+), 29 deletions(-) diff --git a/builtin/add.c b/builtin/add.c index e664100..af36bc4 100644 --- a/builtin/add.c +++

[PATCH 14/21] Convert read_cache_preload() to take struct pathspec

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- builtin/checkout.c | 2 +- builtin/commit.c | 4 ++-- builtin/diff-files.c | 2 +- builtin/diff-index.c | 2 +- builtin/diff.c | 4 ++-- cache.h | 4 +++- preload-index.c | 20 +++- 7

[PATCH 15/21] Convert unmerge_cache to take struct pathspec

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- builtin/checkout.c | 2 +- rerere.c | 2 +- resolve-undo.c | 4 ++-- resolve-undo.h | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/builtin/checkout.c b/builtin/checkout.c index 00910dc..aa399d6

[PATCH 16/21] checkout: convert read_tree_some to take struct pathspec

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- builtin/checkout.c | 9 +++-- tree.c | 4 ++-- tree.h | 2 +- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/builtin/checkout.c b/builtin/checkout.c index aa399d6..a7ddb35 100644 ---

[PATCH 17/21] Convert report_path_error to take struct pathspec

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- builtin/checkout.c | 2 +- builtin/commit.c | 14 ++ builtin/ls-files.c | 14 -- cache.h| 2 +- 4 files changed, 16 insertions(+), 16 deletions(-) diff --git a/builtin/checkout.c

[PATCH 18/21] Convert refresh_index to take struct pathspec

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- builtin/add.c| 14 ++ builtin/commit.c | 2 +- builtin/rm.c | 2 +- cache.h | 2 +- read-cache.c | 5 +++-- 5 files changed, 12 insertions(+), 13 deletions(-) diff --git a/builtin/add.c

[PATCH 19/21] Convert {read,fill}_directory to take struct pathspec

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- builtin/add.c | 2 +- builtin/clean.c| 2 +- builtin/grep.c | 2 +- builtin/ls-files.c | 2 +- dir.c | 10 +- dir.h | 4 ++-- wt-status.c| 4 ++-- 7 files changed, 13

[PATCH 20/21] Convert add_files_to_cache to take struct pathspec

2013-01-05 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- builtin/add.c| 8 +--- builtin/commit.c | 2 +- cache.h | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/builtin/add.c b/builtin/add.c index f5ceb5c..641037f 100644 --- a/builtin/add.c +++

[PATCH 21/21] Convert more init_pathspec() to parse_pathspec()

2013-01-05 Thread Nguyễn Thái Ngọc Duy
init_pathspec() was introduced to work with the result from get_pathspec(). init_pathspec() will be removed eventually after parse_pathspec() takes over, so that there is only place that initializes struct pathspec. Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- archive.c |

RE: Trying to understand the web dav details

2013-01-05 Thread Jason Pyeron
Ignore everything below, it was a case sensitive typo. It always worked it. -Original Message- From: Jeff King Sent: Sunday, January 06, 2013 0:38 On Sun, Jan 06, 2013 at 04:49:57AM +, Pyeron, Jason J CTR (US) wrote: How does the ?service= get translated in to the

RE: Version 1.8.1 does not compile on Cygwin 1.7.14

2013-01-05 Thread Jason Pyeron
-Original Message- From: Stephen Linda Smith Sent: Sunday, January 06, 2013 1:21 Was it the commit before 9fca6cffc05321445b59c91e8f8d308f41588b53 that compiles or was it 9fca6cffc05321445b59c91e8f8d308f41588b53 that compiled? I am doing a cygwin update presently to look

Re: [PATCH] clone: support atomic operation with --separate-git-dir

2013-01-05 Thread Junio C Hamano
Jens Lehmann jens.lehm...@web.de writes: Since b57fb80a7d (init, clone: support --separate-git-dir for .git file) git clone supports the --separate-git-dir option to create the git dir outside the work tree. But when that option is used, the git dir won't be deleted in case the clone fails

Re: [PATCH] Documentation: fix man page dependency on asciidoc.conf

2013-01-05 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: John Keeping wrote: When building manual pages, the source text is transformed to XML with AsciiDoc before the man pages are generated from the XML with xmlto. Fix the dependency in the Makefile so that the XML files are rebuilt when asciidoc.conf

Re: [PATCH] archive-tar: split long paths more carefully

2013-01-05 Thread Junio C Hamano
René Scharfe rene.scha...@lsrfire.ath.cx writes: The name field of a tar header has a size of 100 characters. This limit was extended long ago in a backward compatible way by providing the additional prefix field, which can hold 155 additional characters. The actual path is constructed at

Re: [PATCH] run-command: encode signal death as a positive integer

2013-01-05 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Sat, Jan 05, 2013 at 09:03:16AM -0500, Jeff King wrote: ... The downside is that callers of run_command can no longer differentiate between a signal received directly by the sub-process, and one propagated. However, no caller currently cares, and since we

Re: [PATCH] Alphabetize the fast-import options, following a suggestion on the list.

2013-01-05 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: My knee-jerk response was If the options are currently organized logically, wouldn't it be more appropriate to add a sub-heading for each group of options and alphabetize only within the subgroups? But in fact the current options list doesn't seem

Re: Version 1.8.1 does not compile on Cygwin 1.7.14

2013-01-05 Thread Torsten Bögershausen
On 06.01.13 07:29, Jason Pyeron wrote: -Original Message- From: Stephen Linda Smith Sent: Sunday, January 06, 2013 1:21 Was it the commit before 9fca6cffc05321445b59c91e8f8d308f41588b53 that compiles or was it 9fca6cffc05321445b59c91e8f8d308f41588b53 that compiled? I am doing a

Re: [PATCH] SubmittingPatches: Document how to request a patch review tag

2013-01-05 Thread Michael Haggerty
On 01/04/2013 09:58 PM, Jason Holden wrote: Document the preferred way a developer should request to have their Acked-by/Tested-by/Reviewed-by tag to a patch series under discussion Signed-off-by: Jason Holden jason.k.holden.sw...@gmail.com --- Junio, I was ready to add my Reviewed-by to