Re: What's cooking in git.git (Sep 2013, #03; Wed, 11)

2013-09-13 Thread Junio C Hamano
Johannes Sixt j.s...@viscovery.net writes: Am 9/12/2013 17:24, schrieb Junio C Hamano: Johannes Sixt j.s...@viscovery.net writes: Am 9/12/2013 1:32, schrieb Junio C Hamano: * jc/ref-excludes (2013-09-03) 2 commits Thanks for a dose of sanity. I didn't look at rev-parse. I vaguely recall

Re: [PATCH] send-email: don't call methods on undefined values

2013-09-13 Thread Junio C Hamano
brian m. carlson sand...@crustytoothpaste.net writes: On Mon, Sep 09, 2013 at 09:45:10AM -0700, Junio C Hamano wrote: brian m. carlson sand...@crustytoothpaste.net writes: --- a/git-send-email.perl +++ b/git-send-email.perl @@ -1234,7 +1234,7 @@ X-Mailer: git-send-email $gitversion

Removing all notes containing a specific string

2013-09-13 Thread Francis Moreau
Hello, I'd like to know if that's possible to parse all notes to detect a special string and if it's the case, remove the note like git-notes remove would do. Thanks -- Francis -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org

Re: Removing all notes containing a specific string

2013-09-13 Thread Johan Herland
On Fri, Sep 13, 2013 at 8:51 AM, Francis Moreau francis.m...@gmail.com wrote: Hello, I'd like to know if that's possible to parse all notes to detect a special string and if it's the case, remove the note like git-notes remove would do. Hi, There's no built-in command/option to do this, but

Re: [PATCH v2 2/4] pathspec: strip multiple trailing slashes from submodules

2013-09-13 Thread John Keeping
On Fri, Sep 13, 2013 at 08:28:24AM +0700, Duy Nguyen wrote: On Fri, Sep 13, 2013 at 3:21 AM, John Keeping j...@keeping.me.uk wrote: On Thu, Sep 12, 2013 at 12:48:10PM -0700, Junio C Hamano wrote: John Keeping j...@keeping.me.uk writes: This allows us to replace the submodule path

Your registration code (E3O6M6Y)

2013-09-13 Thread Ahamad Yaki
Your registration code (E3O6M6Y) This is to update you regarding your CARD ATM of US$1.8Million Contact the Atm Director with your delivery address for more information via their details below. MD. Ms. Kieffer Robert Email:(dhlcom_p...@yahoo.fr) Tel:+229 98298252 Mr. Ahamad Yaki -- To

Re: Converting repo from HG, `git filter-branch --prune-empty -- --all` is extremely slow and errors out.

2013-09-13 Thread Felipe Contreras
On Thu, Sep 12, 2013 at 7:47 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Indeed, I remember writing my own simplified version of 'git filter-branch' that was much faster. If I recall correctly, the trick was avoiding 'git write-tree' which can be done if you are not using any tree

Re: Re-Transmission of blobs?

2013-09-13 Thread Josef Wolf
On Thu, Sep 12, 2013 at 03:44:53PM -0400, Jeff King wrote: On Thu, Sep 12, 2013 at 12:35:32PM +0200, Josef Wolf wrote: I'm not sure I understand correctly. I see that bitmaps can be used to implement set operations. But how comes that walking the graph requires a lot of CPU? Isn't it

Re: Re-Transmission of blobs?

2013-09-13 Thread Josef Wolf
On Thu, Sep 12, 2013 at 08:06:35PM +, Pyeron, Jason J CTR (US) wrote: Yes, but it is those awfully slow connections (slower that the looping issue) which happen to always drop while cloning from our office. And the round trip should be mitigated by http-keep-alives. [ ... ] But, again if

[PATCH] pack-objects: no crc check when the cached version is used

2013-09-13 Thread Nguyễn Thái Ngọc Duy
Current code makes pack-objects always do check_pack_crc() in unpack_entry() even if right after that we find out there's a cached version and pack access is not needed. Swap two code blocks, search for cached version first, then check crc. Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com

Re: [PATCH v2 1/2] version-gen: cleanup

2013-09-13 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: +describe () { + VN=$(git describe --match v[0-9]* --abbrev=7 HEAD 2/dev/null) || return 1 case $VN in + *$LF*) + return 1 + ;; v[0-9]*) git update-index -q --refresh

[PATCH 0/3] stop storing trailing slash in dir-hash

2013-09-13 Thread Eric Sunshine
This series alters name-hash so that it no longer stores the (redundant) trailing slash with index_state.dir_hash entries. As an intentional side-effect, the series fixes [1] in a cleaner way (suggested by Junio [2]) than either [3] (680be044 in master) or [4]. As noted by Peff [5], this change

[PATCH 1/3] name-hash: refactor polymorphic index_name_exists()

2013-09-13 Thread Eric Sunshine
Depending upon the absence or presence of a trailing '/' on the incoming pathname, index_name_exists() checks either if a file is present in the index or if a directory is represented within the index. Each caller explicitly chooses the mode of operation by adding or removing a trailing '/'

[PATCH 2/3] name-hash: stop storing trailing '/' on paths in index_state.dir_hash

2013-09-13 Thread Eric Sunshine
When 5102c617 (Add case insensitivity support for directories when using git status, 2010-10-03) added directories to the name-hash there was only a single hash table in which both real cache entries and leading directory prefixes were registered. To distinguish between the two types of entries,

[PATCH 3/3] dir: revert work-around for retired dangerous behavior

2013-09-13 Thread Eric Sunshine
directory_exists_in_index_icase() dangerously assumed that it could access one character beyond the end of its directory argument, and that that character would unconditionally be '/'. 2eac2a4c (ls-files -k: a directory only can be killed if the index has a non-directory, 2013-08-15) added a

RE: Re-Transmission of blobs?

2013-09-13 Thread Jason Pyeron
-Original Message- From: Josef Wolf Sent: Friday, September 13, 2013 6:23 On Thu, Sep 12, 2013 at 08:06:35PM +, Pyeron, Jason J CTR (US) wrote: Yes, but it is those awfully slow connections (slower that the looping issue) which happen to always drop while cloning from

Re: [PATCH v2 1/2] version-gen: cleanup

2013-09-13 Thread Felipe Contreras
On Fri, Sep 13, 2013 at 1:10 AM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com writes: +describe () { + VN=$(git describe --match v[0-9]* --abbrev=7 HEAD 2/dev/null) || return 1 case $VN in + *$LF*) + return 1 +

Re: Re-Transmission of blobs?

2013-09-13 Thread Duy Nguyen
On Fri, Sep 13, 2013 at 3:06 AM, Pyeron, Jason J CTR (US) jason.j.pyeron@mail.mil wrote: But, again if the connection drops, we have already lost the delta advantage. I would think the scenario would go like this: git clone url://blah/blah [fail] cd blah git clone --resume #uses normal

Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

2013-09-13 Thread Sebastian Schuberth
On Thu, Sep 12, 2013 at 10:08 PM, Junio C Hamano gits...@pobox.com wrote: I'm not too happy with the wording either. As I see it, even on MinGW runtime version 4.0 it's not true that string.h has _only_ inline definition of strcasecmp; there's also #define strncasecmp _strnicmp which

Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

2013-09-13 Thread Sebastian Schuberth
On Thu, Sep 12, 2013 at 10:29 PM, Junio C Hamano gits...@pobox.com wrote: Jeff King p...@peff.net writes: I think there are basically three classes of solution: 1. Declare __NO_INLINE__ everywhere. I'd worry this might affect other environments, who would then not inline and lose

Re: [PATCH 2/4] pack v4: add v4_size to struct delta_base_cache_entry

2013-09-13 Thread Nicolas Pitre
On Thu, 12 Sep 2013, Nguyễn Thái Ngọc Duy wrote: The intention is to store flat v4 trees in delta base cache to avoid repeatedly expanding copy sequences in v4 trees. When the user needs to unpack a v4 tree and the tree is found in the cache, the tree will be converted back to canonical

Re: [PATCH 1/2] relative_path should honor dos_drive_prefix

2013-09-13 Thread Torsten Bögershausen
On 13.09.13 06:55, Jiang Xin wrote: 2013/9/13 Junio C Hamano gits...@pobox.com: For systems that need POSIX escape hatch for Apollo Domain ;-), we would need a bit more work. When both path1 and path2 begin with a double-dash, we would need to check if they match up to the next slash, so

Re: [PATCH 2/4] pack v4: add v4_size to struct delta_base_cache_entry

2013-09-13 Thread Duy Nguyen
On Fri, Sep 13, 2013 at 8:27 PM, Nicolas Pitre n...@fluxnic.net wrote: On Thu, 12 Sep 2013, Nguyễn Thái Ngọc Duy wrote: The intention is to store flat v4 trees in delta base cache to avoid repeatedly expanding copy sequences in v4 trees. When the user needs to unpack a v4 tree and the tree is

Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

2013-09-13 Thread Junio C Hamano
Sebastian Schuberth sschube...@gmail.com writes: On Thu, Sep 12, 2013 at 10:08 PM, Junio C Hamano gits...@pobox.com wrote: I'm not too happy with the wording either. As I see it, even on MinGW runtime version 4.0 it's not true that string.h has _only_ inline definition of strcasecmp; there's

Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

2013-09-13 Thread Junio C Hamano
Sebastian Schuberth sschube...@gmail.com writes: Well, if by everywhere in (1) you mean on all platforms then you're right. But my patch does not define __NO_INLINE__ globally, but only at the time string.h / strings.h is included. Afterwards __NO_INLINE__ is undefined. In that sense,

Re: Removing all notes containing a specific string

2013-09-13 Thread Francis Moreau
On Fri, Sep 13, 2013 at 10:12 AM, Johan Herland jo...@herland.net wrote: On Fri, Sep 13, 2013 at 8:51 AM, Francis Moreau francis.m...@gmail.com wrote: Hello, I'd like to know if that's possible to parse all notes to detect a special string and if it's the case, remove the note like

Re: Fwd: Fwd: git-daemon access-hook race condition

2013-09-13 Thread Eugene Sajine
For now I'm trying to do the following: access-hook.bash has: delayed-notify.bash $@ delayed-notify.bash has: sleep 10 ... curl ... I'm expecting access-hook to spawn new process and return without waiting for it to finish to let the service to do its job. But when i do push - it

Re: [PATCH v2 2/2] version-gen: avoid messing the version

2013-09-13 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: If the version is 'v1.8.4-rc1' that is the version, and there's no need to change it to anything else, like 'v1.8.4.rc1'. If RedHat, or somebody else, needs a specific version, they can use the 'version' file, like everybody else.

Re: [PATCH] pack-objects: no crc check when the cached version is used

2013-09-13 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Current code makes pack-objects always do check_pack_crc() in unpack_entry() even if right after that we find out there's a cached version and pack access is not needed. Swap two code blocks, search for cached version first, then check crc.

Re: [PATCH 1/3] name-hash: refactor polymorphic index_name_exists()

2013-09-13 Thread Junio C Hamano
Eric Sunshine sunsh...@sunshineco.com writes: Depending upon the absence or presence of a trailing '/' on the incoming pathname, index_name_exists() checks either if a file is present in the index or if a directory is represented within the index. Each caller explicitly chooses the mode of

Re: [PATCH 1/3] name-hash: refactor polymorphic index_name_exists()

2013-09-13 Thread Eric Sunshine
On Fri, Sep 13, 2013 at 2:40 PM, Junio C Hamano gits...@pobox.com wrote: Eric Sunshine sunsh...@sunshineco.com writes: Depending upon the absence or presence of a trailing '/' on the incoming pathname, index_name_exists() checks either if a file is present in the index or if a directory is

Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

2013-09-13 Thread Sebastian Schuberth
On Fri, Sep 13, 2013 at 4:26 PM, Junio C Hamano gits...@pobox.com wrote: Perhaps the real issue is that the header file does not give an equivalent those who want to take the address of strcasecmp will get the address of _stricmp instead macro, e.g. #define strcasecmp _stricmp or

Re: [PATCH v2 1/3] test: use unambigous leading path (/foo) for mingw

2013-09-13 Thread Junio C Hamano
Jiang Xin worldhello@gmail.com writes: In test cases for relative_path, path with one leading character (such as /a, /x) may be recogonized as a:/ or x:/ if there is such doc drive on MINGW platform. Use an umambigous leading path /foo instead. DOS drive, you mean? Are they really

Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

2013-09-13 Thread Sebastian Schuberth
On Fri, Sep 13, 2013 at 4:37 PM, Junio C Hamano gits...@pobox.com wrote: Which means people who do want to see that macro defined will be broken after that section of the header file which unconditionally undefs it, right? Right, but luckily you've fixed that in our proposed patch :-) That

Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

2013-09-13 Thread Linus Torvalds
On Fri, Sep 13, 2013 at 12:53 PM, Sebastian Schuberth sschube...@gmail.com wrote: +#ifdef __MINGW32__ +#ifdef __NO_INLINE__ Why do you want to push this insane workaround for a clear Mingw bug? Please have mingw just fix the nasty bug, and the git patch with the trivial wrapper looks much

Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

2013-09-13 Thread Junio C Hamano
Sebastian Schuberth sschube...@gmail.com writes: I don't like the idea of introducing a compat/mingw/string.h because of two reasons: You would have to add a conditional to include that string.h instead of the system one anyway, With -Icompat/mingw passed to the compiler, which is a

Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

2013-09-13 Thread Sebastian Schuberth
On Fri, Sep 13, 2013 at 9:56 PM, Linus Torvalds torva...@linux-foundation.org wrote: +#ifdef __MINGW32__ +#ifdef __NO_INLINE__ Why do you want to push this insane workaround for a clear Mingw bug? To be frank, because Git is picking up patches much quicker than MinGW does, and I want a

Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

2013-09-13 Thread Sebastian Schuberth
On Fri, Sep 13, 2013 at 10:01 PM, Junio C Hamano gits...@pobox.com wrote: I don't like the idea of introducing a compat/mingw/string.h because of two reasons: You would have to add a conditional to include that string.h instead of the system one anyway, With -Icompat/mingw passed to the

Re: [PATCH] pack-objects: no crc check when the cached version is used

2013-09-13 Thread Thomas Rast
Junio C Hamano gits...@pobox.com writes: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Current code makes pack-objects always do check_pack_crc() in unpack_entry() even if right after that we find out there's a cached version and pack access is not needed. Swap two code blocks, search for

[PATCH V2 2/3] config doc: update dot-repository notes

2013-09-13 Thread Philip Oakley
branch.name.remote can be set to '.' (period) as the repository path (URL) as part of the remote name dwimmery. Tell the reader. Such relative paths are not 'special'. Correct the branch.name.merge note. Signed-off-by: Philip Oakley philipoak...@iee.org --- Documentation/config.txt | 6 --

[PATCH V2 3/3] doc: command line interface (cli) dot-repository dwimmery

2013-09-13 Thread Philip Oakley
The Git cli will accept dot '.' (period) as the relative path to the current repository. Explain this action. Signed-off-by: Philip Oakley philipoak...@iee.org --- Documentation/gitcli.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/gitcli.txt b/Documentation/gitcli.txt

[PATCH V2 1/3] Doc URLs: relative paths imply the dot-respository

2013-09-13 Thread Philip Oakley
Signed-off-by: Philip Oakley philipoak...@iee.org --- Documentation/urls.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/urls.txt b/Documentation/urls.txt index 9ccb246..5350a63 100644 --- a/Documentation/urls.txt +++ b/Documentation/urls.txt @@ -55,6 +55,13 @@ These

[PATCH V2 0/3] Extend dot repository documentation

2013-09-13 Thread Philip Oakley
This is an update to my patch series on 19 May documenting the dot repository notation. The earlier threads start at: $gmane/224870/ [0/2] Extend dot repository documentation $gmane/224868/ [1/2] config doc: add dot-repository note $gmane/224869/ [2/2] doc: command line interface (cli)

Re: [PATCH 1/3] name-hash: refactor polymorphic index_name_exists()

2013-09-13 Thread Eric Sunshine
On Fri, Sep 13, 2013 at 3:41 PM, Junio C Hamano gits...@pobox.com wrote: On Fri, Sep 13, 2013 at 12:29 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Fri, Sep 13, 2013 at 2:40 PM, Junio C Hamano gits...@pobox.com wrote: Eric Sunshine sunsh...@sunshineco.com writes: Since these two

Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

2013-09-13 Thread Junio C Hamano
Sebastian Schuberth sschube...@gmail.com writes: On Fri, Sep 13, 2013 at 10:01 PM, Junio C Hamano gits...@pobox.com wrote: I don't like the idea of introducing a compat/mingw/string.h because of two reasons: You would have to add a conditional to include that string.h instead of the system

Re: [PATCH 1/3] name-hash: refactor polymorphic index_name_exists()

2013-09-13 Thread Junio C Hamano
Eric Sunshine sunsh...@sunshineco.com writes: Given the above. How should I proceed? Do you still feel that it is advisable to keep an index_name_exists() around for compatibility reasons in case any new callers are introduced? Regardless of that answer, do you want index_name_exists()

What's cooking in git.git (Sep 2013, #04; Fri, 13)

2013-09-13 Thread Junio C Hamano
Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The third batch of topics are now in 'master'. You can find the changes described here in the integration branches of the repositories listed

Re: [PATCH 1/3] name-hash: refactor polymorphic index_name_exists()

2013-09-13 Thread Eric Sunshine
On Fri, Sep 13, 2013 at 6:16 PM, Junio C Hamano gits...@pobox.com wrote: Eric Sunshine sunsh...@sunshineco.com writes: Given the above. How should I proceed? Do you still feel that it is advisable to keep an index_name_exists() around for compatibility reasons in case any new callers are

[PATCH v2] sequencer: trivial cleanup

2013-09-13 Thread Ramkumar Ramachandra
Consider that the return values of allow_empty() could either be negative, zero, or one. However, there is no reason to be overtly conservative about it: we might as well return positive values as well since the callsite has no problems with it. Signed-off-by: Ramkumar Ramachandra

Re: [PATCH V2 1/3] Doc URLs: relative paths imply the dot-respository

2013-09-13 Thread Junio C Hamano
Philip Oakley philipoak...@iee.org writes: Signed-off-by: Philip Oakley philipoak...@iee.org --- Documentation/urls.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/urls.txt b/Documentation/urls.txt index 9ccb246..5350a63 100644 --- a/Documentation/urls.txt

Re: [PATCH V2 2/3] config doc: update dot-repository notes

2013-09-13 Thread Junio C Hamano
Philip Oakley philipoak...@iee.org writes: branch.name.remote can be set to '.' (period) as the repository path (URL) as part of the remote name dwimmery. Tell the reader. Such relative paths are not 'special'. Correct the branch.name.merge note. Looks good. It naturally follows that this

Re: [PATCH V2 3/3] doc: command line interface (cli) dot-repository dwimmery

2013-09-13 Thread Junio C Hamano
Philip Oakley philipoak...@iee.org writes: The Git cli will accept dot '.' (period) as the relative path to the current repository. Explain this action. Signed-off-by: Philip Oakley philipoak...@iee.org --- Documentation/gitcli.txt | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

2013-09-13 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: You can explicitly include the system header from your compatibility layer, i.e. ... and then in config.mak.uname, do something like this: ... COMPAT_CFLAGS += -DSYSTEM_STRING_H_HEADER=$(SYSTEM_STRING_H_HEADER) You need to have one level of

Re: [PATCH] pack-objects: no crc check when the cached version is used

2013-09-13 Thread Duy Nguyen
On Sat, Sep 14, 2013 at 4:26 AM, Thomas Rast tr...@inf.ethz.ch wrote: Junio C Hamano gits...@pobox.com writes: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Current code makes pack-objects always do check_pack_crc() in unpack_entry() even if right after that we find out there's a cached

Re: [PATCH 2/4] pack v4: add v4_size to struct delta_base_cache_entry

2013-09-13 Thread Nicolas Pitre
On Fri, 13 Sep 2013, Duy Nguyen wrote: On Fri, Sep 13, 2013 at 8:27 PM, Nicolas Pitre n...@fluxnic.net wrote: On Thu, 12 Sep 2013, Nguyễn Thái Ngọc Duy wrote: The intention is to store flat v4 trees in delta base cache to avoid repeatedly expanding copy sequences in v4 trees. When the

Re: [PATCH] pack-objects: no crc check when the cached version is used

2013-09-13 Thread Nicolas Pitre
On Sat, 14 Sep 2013, Duy Nguyen wrote: On Sat, Sep 14, 2013 at 4:26 AM, Thomas Rast tr...@inf.ethz.ch wrote: I tried the perf script below, but at least for the git repo the only thing I can see is noise. --stdout does not set do_check_packed_object_crc, you need to run pack-objects

Re: [PATCH 2/4] pack v4: add v4_size to struct delta_base_cache_entry

2013-09-13 Thread Nicolas Pitre
On Fri, 13 Sep 2013, Nicolas Pitre wrote: On Fri, 13 Sep 2013, Duy Nguyen wrote: On Fri, Sep 13, 2013 at 8:27 PM, Nicolas Pitre n...@fluxnic.net wrote: However I can see that, as you say, the same base object is repeatedly referenced. This means that we need to parse it over and over

[PATCH] t7508: avoid non-portable sed expression

2013-09-13 Thread Eric Sunshine
2556b996 (status: disable display of '#' comment prefix by default; 2013-09-06) introduced tests which fail on Mac OS X due to unportable use of \t (for TAB) in a sed expression. POSIX [1][2] also disallows it. Fix this. [1]:

Re: [PATCH v2 2/2] version-gen: avoid messing the version

2013-09-13 Thread Felipe Contreras
On Fri, Sep 13, 2013 at 1:16 PM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com writes: If the version is 'v1.8.4-rc1' that is the version, and there's no need to change it to anything else, like 'v1.8.4.rc1'. If RedHat, or somebody else, needs a specific