GSoC 2014: Summary so far, discussion starter: how to improve?

2013-10-19 Thread Thomas Rast
[Unfortunately libgit2 no longer has a mailing list. I put an arbitrary group of libgit2 contributors in the Cc list.] Previous Episodes = Git participated in Google Summer of Code (GSoC) 2007-2012, but did not participate in 2013 based on discussion in February [1]. At

Joy wertvollsten Momente mit Nike

2013-10-19 Thread Terugds
Nike sind alle freiberuflich Schuster, der hatte eine beispielhafte Befehl über Turnschuhe bekommen . seine Turnschuhe mit Qualität billig Nike No-cost Runs und eine Menge wünschenswert Womens Nike kommen kostenlos betrieben drei . Zusammen mit erweiterten Begriff Verbesserung hat Nike Unternehmen

Re: [PATCH v8] diff.c: keep arrow(=) on show_stats()'s shortened filename part to make rename visible

2013-10-19 Thread Thomas Rast
Yoshioka Tsuneo yoshiokatsu...@gmail.com writes: git diff -M --stat can detect rename and show renamed file name like foofoofoo = barbarbar. Before this commit, this output is shortened always by omitting left most part like ...foo = barbarbar. So, if the destination filename is too long,

Schuhe auf der guten alten Zeit

2013-10-19 Thread Terugds
OH Mein persönlicher GAWD - Also ich bin in schätzen neben unserer neuen Sneakers! Ich geworden , wenn immer die Finger für eine Reihe von Nike Breeze Max 1 ist, als dass sie wieder erschien auf der städtischen Szene in bunten Schuhen zusätzlich verrückt Arten - Einbau , dass die fabelhafte animal

Re: What's cooking in git.git (Oct 2013, #04; Fri, 18)

2013-10-19 Thread Jeff King
On Fri, Oct 18, 2013 at 03:14:49PM -0700, Junio C Hamano wrote: * jn/add-2.0-u-A-sans-pathspec (2013-04-26) 1 commit - git add: -u/-A now affects the entire working tree Will cook in 'next' until Git 2.0. * jc/core-checkstat-2.0 (2013-05-06) 1 commit - core.statinfo: remove as

Re: What's cooking in git.git (Oct 2013, #04; Fri, 18)

2013-10-19 Thread Felipe Contreras
Jeff King wrote: On Fri, Oct 18, 2013 at 03:14:49PM -0700, Junio C Hamano wrote: * jn/add-2.0-u-A-sans-pathspec (2013-04-26) 1 commit - git add: -u/-A now affects the entire working tree Will cook in 'next' until Git 2.0. * jc/core-checkstat-2.0 (2013-05-06) 1 commit -

separate-git-dir doesn't work with mapped drive

2013-10-19 Thread Ain Valtin
Hi I want to use git in a VirtualBox guest so that the repository is on the host drive. So in the VB settings for the guest I set up a shared folder gitRepos to /home/ain with full access rights. Then in the guest OS (Windows XP) I map this shared folder as G drive. Now in the project dir I

Re: separate-git-dir doesn't work with mapped drive

2013-10-19 Thread Duy Nguyen
There seems to be some regression fixes regarding dos drives. The one that caught my eyes is 7fbd422 (relative_path should honor dos-drive-prefix - 2013-10-14) but it's not released yet. And I'm not sure if msys branch picks it up yet even if you want to rebuild and test it yourself. Copying Jiang

Re: pack corruption post-mortem

2013-10-19 Thread Duy Nguyen
On Wed, Oct 16, 2013 at 3:34 PM, Jeff King p...@peff.net wrote: I was recently presented with a repository with a corrupted packfile, and was asked if the data was recoverable. This post-mortem describes the steps I took to investigate and fix the problem. I thought others might find the

Re: GSoC 2014: Summary so far, discussion starter: how to improve?

2013-10-19 Thread Christian Couder
Hi, On Sat, Oct 19, 2013 at 8:09 AM, Thomas Rast t...@thomasrast.ch wrote: Previous Episodes = Git participated in Google Summer of Code (GSoC) 2007-2012, but did not participate in 2013 based on discussion in February [1]. At Git-Merge in Berlin there was a discussion

[PATCH] Prevent buffer overflows when path is too big

2013-10-19 Thread Antoine Pelisse
Currently, most buffers created with PATH_MAX length, are not checked when being written, and can overflow if PATH_MAX is not big enough to hold the path. Fix that by using strlcpy() where strcpy() was used, and also run some extra checks when copy is done with memcpy(). Reported-by: Wataru

Re: separate-git-dir doesn't work with mapped drive

2013-10-19 Thread Fredrik Gustafsson
On Sat, Oct 19, 2013 at 11:49:27AM +0300, Ain Valtin wrote: Hi I want to use git in a VirtualBox guest so that the repository is on the host drive. So in the VB settings for the guest I set up a shared folder gitRepos to /home/ain with full access rights. Then in the guest OS (Windows XP) I

Re: separate-git-dir doesn't work with mapped drive

2013-10-19 Thread Ain Valtin
On Sat, Oct 19, 2013 at 2:11 PM, Fredrik Gustafsson iv...@iveqy.com wrote: Git has a bad history with mapped drives in windows. It's also usually a bad idea to use git over the network (and most mapped drives are over the network and not local between virt. machines). I would advise not to

Re: separate-git-dir doesn't work with mapped drive

2013-10-19 Thread Fredrik Gustafsson
On Sat, Oct 19, 2013 at 02:45:46PM +0300, Ain Valtin wrote: On Sat, Oct 19, 2013 at 2:11 PM, Fredrik Gustafsson iv...@iveqy.com wrote: Git has a bad history with mapped drives in windows. It's also usually a bad idea to use git over the network (and most mapped drives are over the network

RE: GSoC 2014: Summary so far, discussion starter: how to improve?

2013-10-19 Thread Felipe Contreras
Thomas Rast wrote: * Diminishing returns: Git is too mature, with little low-hanging fruit left, making such projects harder Too mature? Aren't there other projects that are too mature as well? In particular I'm thinking about the Linux kernel. I think it's not about maturity, but how they

Re: [PATCH v2 00/14] Officially start moving to the term 'staging area'

2013-10-19 Thread Philip Oakley
From: Karsten Blees karsten.bl...@gmail.com Am 15.10.2013 00:29, schrieb Felipe Contreras: tl;dr: everyone except Junio C Hamano and Drew Northup agrees; we should move away from the name the index. It has been discussed many times in the past that 'index' is not an appropriate description for

Re: pack corruption post-mortem

2013-10-19 Thread Nicolas Pitre
On Sat, 19 Oct 2013, Duy Nguyen wrote: On Wed, Oct 16, 2013 at 3:34 PM, Jeff King p...@peff.net wrote: I was recently presented with a repository with a corrupted packfile, and was asked if the data was recoverable. This post-mortem describes the steps I took to investigate and fix the

Re: [PATCH] send-pack: don't send a thin pack when the server doesn't support it

2013-10-19 Thread Carlos Martín Nieto
On Tue, 2013-10-08 at 15:22 -0700, Jonathan Nieder wrote: Duy Nguyen wrote: Or maybe it's not that late. How about you go with your patch and add thin-pack capability to receive-pack too? When new git push is used against old server, thin pack is disabled. But that's not a big deal (I

Re: pack corruption post-mortem

2013-10-19 Thread Shawn Pearce
On Sat, Oct 19, 2013 at 7:41 AM, Nicolas Pitre n...@fluxnic.net wrote: On Sat, 19 Oct 2013, Duy Nguyen wrote: On Wed, Oct 16, 2013 at 3:34 PM, Jeff King p...@peff.net wrote: I was recently presented with a repository with a corrupted packfile, and was asked if the data was recoverable. This

Re: [PATCH v3 10/11] read-cache.c: fix memory leaks caused by removed cache entries

2013-10-19 Thread Thomas Rast
Karsten Blees karsten.bl...@gmail.com writes: When cache_entry structs are removed from index_state.cache, they are not properly freed. Freeing those entries wasn't possible before because we couldn't remove them from index_state.name_hash. Now that we _do_ remove the entries from name_hash,

Re: separate-git-dir doesn't work with mapped drive

2013-10-19 Thread Ain Valtin
(This could go to msysgit mailing list, so I add a CC) (and I think, it is a known issue) As a work around, could you try this: Downgrading to msysgit 1.8.3 fixes my problem. and tell us if this helps you? Yes, 1.8.3 seems to work (did initial commit successfully). ain -- To unsubscribe

[PATCH 1/2] Revert test-lib: support running tests under valgrind in parallel

2013-10-19 Thread Thomas Rast
This reverts commit ad0e6233320b004f0d686f6887c803e508607bd2. --valgrind-parallel was broken from the start: during review I made the whole valgrind setup code conditional on not being a --valgrind-parallel worker child. But even the children crucially need $GIT_VALGRIND to be set; it should

[PATCH 0/2] Revert --valgrind-parallel test option

2013-10-19 Thread Thomas Rast
These patches remove the --valgrind-parallel=N option that was broken from the outset (shame on me). Peff's judgement at the time that its usefulness would approximately be meh turns out to be correct. What's not in the commit message, but drives part of my reasoning in doing a revert instead of

[PATCH 2/2] Revert test-lib: allow prefixing a custom string before ok N etc.

2013-10-19 Thread Thomas Rast
Now that ad0e623 (test-lib: support running tests under valgrind in parallel, 2013-06-23) has been reverted, this support code has no users any more. Revert it, too. This reverts commit e939e15d241e942662b9f88f6127ab470ab0a0b9. --- t/test-lib.sh | 27 --- 1 file changed,

Re: GSoC 2014: Summary so far, discussion starter: how to improve?

2013-10-19 Thread Fredrik Gustafsson
Hi, so I was a GSoC:er, I got some (most) of my code merged but didn't fully met my (personal) goals for the project. However I do passed in the eyes of Google. GSoC is _hard_. You end up feeling completely stupid over and over again. Git has hard standards. Beeing just a single programmer and/or

Re: [PATCH v8] diff.c: keep arrow(=) on show_stats()'s shortened filename part to make rename visible

2013-10-19 Thread Yoshioka Tsuneo
Hello Thomas Can you briefly describe what you changed in v7 and v8, both compared to earlier versions and between v7 and v8? On v7, sfx's basename part is tried to kept. On v7, whole sfx part is tried to kept. For example, in case below: parent_path{sourceDirectory =

Re: pack corruption post-mortem

2013-10-19 Thread Duy Nguyen
On Sat, Oct 19, 2013 at 9:41 PM, Nicolas Pitre n...@fluxnic.net wrote: On Sat, 19 Oct 2013, Duy Nguyen wrote: The SHA1 used in the name of the pack file is actually the SHA1 checksum of the SHA1 table. The path and ident tables are already protected by the CRC32 in the zlib deflated stream.

Re: [msysGit] [PATCH] Prevent buffer overflows when path is too big

2013-10-19 Thread Torsten Bögershausen
(may be s/path is too big/path is too long/ ?) On 19.10.13 12:52, Antoine Pelisse wrote: Currently, most buffers created with PATH_MAX length, are not checked when being written, and can overflow if PATH_MAX is not big enough to hold the path. Fix that by using strlcpy() where strcpy() was