On Fri, Oct 14, 2016 at 8:40 PM, Junio C Hamano wrote:
> Jakub Narębski writes:
>
>> s/SHA1/SHA-1/g in above paragraph (for correctness and consistency).
>>>
>>> I think it's fairly dubious to link to things matching [0-9a-fA-F]
>>> here as opposed to just [0-9a-f], that dates back to the initial
The object_id functions oid_to_hex, oid_to_hex_r, oidclr, oidcmp, and
oidcpy are defined as wrappers of their legacy counterparts sha1_to_hex,
sha1_to_hex_r, hashclr, hashcmp, and hashcpy, respectively. Make sure
that the Coccinelle transformations for converting legacy function calls
are not appl
Hey Junio,
On Sat, Oct 15, 2016 at 3:13 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> +test_expect_success 'check whether bisection cleanup is not done with bad
>> merges' '
>> + git bisect start $HASH7 $SIDE_HASH7 &&
>> + test_expect_failure git bisect bad >out 2>out &&
>
> I t
Use "test-parse-options --expect" to rewrite the tests to avoid checking
the whole variable dump by just testing what is required. This commit is
based on 8ca65aeb (t0040: convert a few tests to use test-parse-options;
Junio C Hamano; May 6, 2016).
Signed-off-by: Pranit Bauva
---
t/t0040-parse-o
On Sat, Oct 15, 2016 at 10:25:34AM +0200, René Scharfe wrote:
> The object_id functions oid_to_hex, oid_to_hex_r, oidclr, oidcmp, and
> oidcpy are defined as wrappers of their legacy counterparts sha1_to_hex,
> sha1_to_hex_r, hashclr, hashcmp, and hashcpy, respectively. Make sure
> that the Coccin
@Peff: If you have time, it would be great if you could comment on
one question below prefixed with "@Peff". Thanks!
> On 12 Oct 2016, at 03:54, Jakub Narębski wrote:
>
> W dniu 12.10.2016 o 00:26, Lars Schneider pisze:
>>> On 09 Oct 2016, at 01:06, Jakub Narębski wrote:
>>
After
> On 08 Oct 2016, at 22:42, Torsten Bögershausen wrote:
>
> On 08.10.16 13:25, larsxschnei...@gmail.com wrote:
>> From: Lars Schneider
>>
>> Add a simple pass-thru filter as example implementation for the Git
>> filter protocol version 2. See Documentation/gitattributes.txt, section
>> "Filter
> On 11 Oct 2016, at 05:12, Johannes Schindelin
> wrote:
>
> Hi Lars,
>
> On Sat, 8 Oct 2016, larsxschnei...@gmail.com wrote:
>
>> @@ -31,6 +32,15 @@ static void cleanup_children(int sig, int in_signal)
>> while (children_to_clean) {
>> struct child_to_clean *p = children_to
> On 11 Oct 2016, at 16:46, Ramsay Jones wrote:
>
> If you need to re-roll your 'ls/filter-process' branch, could you
> please squash this into commit 85290197
> ("convert: add filter..process option", 08-10-2016).
>
>
> -void stop_multi_file_filter(struct child_process *process)
> +static voi
Calculating offsets involving a NULL pointer is undefined. It works in
practice (for now?), but we should not rely on it. Allocate first and
then simply refer to the flexible array member by its name instead of
performing pointer arithmetic up front. The resulting code is slightly
shorter, easie
Not sure is this has been reported before:
sequencer.c:633:14: warning: comparison of constant 2 with expression of type
'const enum todo_command' is always true
[-Wtautological-constant-out-of-range-compare]
if (command < ARRAY_SIZE(todo_command_strings))
~~~ ^ ~~~
On Sat, Oct 15, 2016 at 06:23:11PM +0200, René Scharfe wrote:
> Calculating offsets involving a NULL pointer is undefined. It works in
> practice (for now?), but we should not rely on it. Allocate first and
> then simply refer to the flexible array member by its name instead of
> performing poin
On Sat, Oct 15, 2016 at 07:03:46PM +0200, Torsten Bögershausen wrote:
> sequencer.c:633:14: warning: comparison of constant 2 with expression of type
> 'const enum todo_command' is always true
> [-Wtautological-constant-out-of-range-compare]
> if (command < ARRAY_SIZE(todo_command_string
On 15.10.16 19:19, Jeff King wrote:
> On Sat, Oct 15, 2016 at 07:03:46PM +0200, Torsten Bögershausen wrote:
>
>> sequencer.c:633:14: warning: comparison of constant 2 with expression of
>> type 'const enum todo_command' is always true
>> [-Wtautological-constant-out-of-range-compare]
>>
On Sat, Oct 15, 2016 at 07:45:48AM -0700, Lars Schneider wrote:
> >> I have to agree that "capability=" might read a
> >> little bit nicer. However, Peff suggested "=true"
> >> as his preference and this is absolutely OK with me.
> >
> > From what I remember it was Peff stating that he thinks "=
On Sat, Oct 15, 2016 at 07:40:15PM +0200, Torsten Bögershausen wrote:
> > I wonder if:
> >
> > if ((int)command < ARRAY_SIZE(todo_command_strings))
> >
> > silences the warning (I suppose size_t is probably an even better type,
> > though obviously it does not matter in practice).
> >
> Both
W dniu 15.10.2016 o 16:45, Lars Schneider pisze:
>> On 12 Oct 2016, at 03:54, Jakub Narębski wrote:
>> W dniu 12.10.2016 o 00:26, Lars Schneider pisze:
On 09 Oct 2016, at 01:06, Jakub Narębski wrote:
>
>>>
> After the filter started
> Git sends a welcome message ("git-filter-cli
Signed-off-by: Ramsay Jones
---
Hi Jonathan,
If you need to re-roll your 'jt/trailer-with-cruft' branch, could you
please squash this into the relevant patch. [commit 3fb120de ("trailer:
use list.h for doubly-linked list", 14-10-2016)]
Thanks!
ATB,
Ramsay Jones
trailer.c | 2 +-
1 file chan
On 15/10/16 16:05, Lars Schneider wrote:
>> On 11 Oct 2016, at 16:46, Ramsay Jones wrote:
[snip]
>> -void stop_multi_file_filter(struct child_process *process)
>> +static void stop_multi_file_filter(struct child_process *process)
>
> Done! Do you have some kind of script to detect these things
> On 15 Oct 2016, at 14:01, Ramsay Jones wrote:
>
>
>
> On 15/10/16 16:05, Lars Schneider wrote:
>>> On 11 Oct 2016, at 16:46, Ramsay Jones wrote:
> [snip]
>>> -void stop_multi_file_filter(struct child_process *process)
>>> +static void stop_multi_file_filter(struct child_process *process)
>>
20 matches
Mail list logo
