Re: ^D to credentials prompt results in "fatal: ... Success"

2018-06-24 Thread Jeff King
On Fri, Jun 22, 2018 at 07:42:38PM -0700, Anthony Sottile wrote: > A bit of an amusing edge case. > > I'm not exactly sure the correct approach to fix this but here's my > reproduction, triage, and a few potential options I see. > > Note that after the username prompt, I pressed ^D > >

[PATCH] Documentation: declare "core.ignorecase" as internal variable

2018-06-24 Thread Marc Strapetz
The current description of "core.ignorecase" reads like an option which is intended to be changed by the user while it's actually expected to be set by Git only [1]. [1] https://marc.info/?l=git=152972992729761=2 Signed-off-by: Marc Strapetz --- Documentation/config.txt | 4 ++-- 1 file

[BUG] url schemes should be case-insensitive

2018-06-24 Thread Jeff King
We seem to match url schemes case-sensitively: $ git clone SSH://example.com/repo.git Cloning into 'repo'... fatal: Unable to find remote helper for 'SSH' whereas rfc3986 is clear that the scheme portion is case-insensitive. We probably ought to match at least our internal ones with

Re: Unexpected ignorecase=false behavior on Windows

2018-06-24 Thread Marc Strapetz
On 22.06.2018 22:58, Bryan Turner wrote: On Fri, Jun 22, 2018 at 1:45 PM Marc Strapetz wrote: On 22.06.2018 19:36, Johannes Sixt wrote: Am 22.06.2018 um 14:04 schrieb Marc Strapetz: On Windows, when creating following repository: $ git init $ echo "1" > file.txt $ git add . $ git commit -m

Re: [PATCH] Documentation: declare "core.ignorecase" as internal variable

2018-06-24 Thread Eric Sunshine
On Sun, Jun 24, 2018 at 6:05 AM Marc Strapetz wrote: > The current description of "core.ignorecase" reads like an option which > is intended to be changed by the user while it's actually expected to > be set by Git only [1]. > > [1] https://marc.info/?l=git=152972992729761=2 Thanks for following

Incorrect unified diff when run with "--find-copies-harder"

2018-06-24 Thread Daniel Penkin
Hello, I believe I found a bug in how Git represents a diff when invoked with "--find-copies-harder" parameter. Specifically, the unified diff header of a hunk contains an extra piece of text which appears to be a line from the context (i.e. unchanged line), something like this: > git diff

[PATCH v2] Documentation: declare "core.ignorecase" as internal variable

2018-06-24 Thread Marc Strapetz
The current description of "core.ignoreCase" reads like an option which is intended to be changed by the user while it's actually expected to be set by Git on initialization only. This is especially important for Git for Windows, as noted by Bryan Turner [1]: Git on Windows is not designed

Re: Incorrect unified diff when run with "--find-copies-harder"

2018-06-24 Thread Andrei Rybak
On 2018-06-24 12:36, Daniel Penkin wrote: > Hello, > Hi, > I believe I found a bug in how Git represents a diff when invoked with > "--find-copies-harder" parameter. > Specifically, the unified diff header of a hunk contains an extra > piece of text which appears to be a line from the context

Re: [PATCH v2] Documentation: declare "core.ignorecase" as internal variable

2018-06-24 Thread Sascha Silbe
Hello Bryan, hello Marc, Marc Strapetz writes: > The current description of "core.ignoreCase" reads like an option which > is intended to be changed by the user while it's actually expected to > be set by Git on initialization only. This is especially important for > Git for Windows, as noted

Re: [PATCH v2] Documentation: declare "core.ignorecase" as internal variable

2018-06-24 Thread Torsten Bögershausen
On Sun, Jun 24, 2018 at 12:44:26PM +0200, Marc Strapetz wrote: > The current description of "core.ignoreCase" reads like an option which > is intended to be changed by the user while it's actually expected to > be set by Git on initialization only. This is especially important for > Git for

Re: Incorrect unified diff when run with "--find-copies-harder"

2018-06-24 Thread Daniel Penkin
Hi Andrei, Thanks for the prompt reply. I'm sorry for the false alarm, I should've investigated this more thoroughly before submitting a bug. Now I see I get that context hint in many diffs, I was confused by many simple file diffs I was working with recently which didn't have it. Thank you for