[PATCH 2/2] Makefile: run coccicheck on more source files

Before, when running the "coccicheck" target, only the source files which were being compiled would have been checked by Coccinelle. However, just because we aren't compiling a source file doesn't mean we have to exclude it from analysis. This will allow us to catch more mistakes, in particular one

[PATCH 1/2] Makefile: define UPSTREAM_SOURCES

After looking through the source files in compat/ and investigating the files' content and/or its Git history, I've determined the list of files that were copied from an upstream. Place the names of these files into the UPSTREAM_SOURCES variable in the Makefile. In addition, add the sha1collisiond

[PATCH 0/2] Makefile: run coccicheck on all non-upstream sources

Before, when we ran coccicheck, it would only run on files that are currently being compiled. However, this leaves us with a blindspot where Windows-only sources are not checked since Coccinelle does not run on Windows. This patchset addresses this by making the "coccicheck" target run against all

Re: [PATCH 1/2] git-gui: warn if the commit message contains lines longer than the set limit

On Fri, Sep 06, 2019 at 09:07:15PM +0100, Philip Oakley wrote: > Hi Birger, > > On 06/09/2019 15:08, Birger Skogeng Pedersen wrote: > > Hi Bert, > > > > > > We should probably distinguish between what is wrapped in git-gui > > (i.e. purely visual), and what is actually wrapped in the commit > >

Re: feature request, git-gui: add hotkey to toggle amend/new

On Wed, Sep 04, 2019 at 09:03:02PM +0200, Bert Wesarg wrote: > On Wed, Sep 4, 2019 at 8:52 PM Johannes Sixt wrote: > > > > Am 04.09.19 um 19:46 schrieb Pratyush Yadav: > > > On 04/09/19 08:24AM, Johannes Sixt wrote: > > >> That is worth a try. The check box title offers a natural hotkey then: > >

Re: [PATCH 1/1] upload-pack: fix race condition in error messages

On Wed, Sep 04, 2019 at 01:04:42AM -0400, Jeff King wrote: > On Fri, Aug 30, 2019 at 02:10:05PM +0200, SZEDER Gábor wrote: > > > On Fri, Aug 30, 2019 at 12:06:30AM +0200, SZEDER Gábor wrote: > > > On Thu, Aug 29, 2019 at 11:58:18PM +0200, SZEDER Gábor wrote: > > > > On Thu, Aug 29, 2019 at 10:38:0

RFC: Cryptographic attestation for email-based patch workflows

Hello, all: This is a very "raw" idea that stems from a handful of conversations that took place at the Kernel Summit. I wanted to pass it along to this list in hopes that it can generate some workable ideas (or shot down and allowed to die early). # Problem One of the recurring concerns raised

Re: [PATCH] ci: install P4 from package to fix build error

On Tue, Sep 10, 2019 at 12:51:01AM +0200, Johannes Schindelin wrote: > On Fri, 6 Sep 2019, SZEDER Gábor wrote: > > > On Fri, Sep 06, 2019 at 12:27:11PM +0200, SZEDER Gábor wrote: > > > To test 'git-p4' in the Linux Clang and GCC build jobs we used to > > > install the 'p4' and 'p4d' binaries by di

Re: [PATCH v2] cache-tree: do not lazy-fetch merge tree

On Mon, Sep 09, 2019 at 12:01:30PM -0700, Jonathan Tan wrote: > diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh > index 6415063980..3e434b6a81 100755 > --- a/t/t0410-partial-clone.sh > +++ b/t/t0410-partial-clone.sh > @@ -492,6 +492,20 @@ test_expect_success 'gc stops traversal whe

Re: [PATCH 2/2] Makefile: run coccicheck on more source files

On Tue, Sep 10, 2019 at 12:44:31AM -0700, Denton Liu wrote: > Before, when running the "coccicheck" target, only the source files > which were being compiled would have been checked by Coccinelle. > However, just because we aren't compiling a source file doesn't mean we > have to exclude it from an

Re: [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command

Ping :) Any thoughts on this? On 8/27/2019 12:56 PM, Garima Singh via GitGitGadget wrote: Emit trace2_cmd_mode() messages for each commit-graph sub-command. The commit graph commands were in flux when trace2 was making it's way to git. Now that we have enough sub-commands in commit-graph, we ca

Re: [PATCH v2 0/1] commit-graph: add --[no-]progress to write and verify

Ping :) Any more comments or concerns about this? On 8/26/2019 12:29 PM, Garima Singh via GitGitGadget wrote: Hey Git contributors! My name is Garima Singh and I work at Microsoft. I recently started working closely with the Microsoft team contributing to the git client ecosystem. I am very gla

Re: [PATCH 2/2] Makefile: run coccicheck on more source files

On Tue, Sep 10, 2019 at 12:44:31AM -0700, Denton Liu wrote: > Make the "coccicheck" target run on all C sources except for those that > are taken from some upstream. We don't want to patch these files since > we want them to be as close to upstream as possible so that it'll be > easier to pull in u

Patching Git to handle dates before the Unix epoch

As people use Git to create synthetic commits of code written in the past [1,2] it becomes important to handle dates before the Unix epoch (1/1/1970). I see that modern C libraries, Unix kernels, and tools can handle such dates. However Git seems to mishandle such dates in several places, suc

Re: [PATCH 2/2] Makefile: run coccicheck on more source files

On Tue, Sep 10, 2019 at 03:28:13PM +0200, SZEDER Gábor wrote: > On Tue, Sep 10, 2019 at 12:44:31AM -0700, Denton Liu wrote: > > Before, when running the "coccicheck" target, only the source files > > which were being compiled would have been checked by Coccinelle. > > However, just because we aren'

RE: Patching Git to handle dates before the Unix epoch

On September 10, 2019 10:15 AM, Diomidis Spinellis wrote: > As people use Git to create synthetic commits of code written in the past > [1,2] it becomes important to handle dates before the Unix epoch > (1/1/1970). I see that modern C libraries, Unix kernels, and tools can handle > such dates. Ho

Re: Patching Git to handle dates before the Unix epoch

On Tue, Sep 10, 2019 at 05:14:53PM +0300, Diomidis Spinellis wrote: > As people use Git to create synthetic commits of code written in the past > [1,2] it becomes important to handle dates before the Unix epoch (1/1/1970). > I see that modern C libraries, Unix kernels, and tools can handle such >

Re: Patching Git to handle dates before the Unix epoch

On Tue, Sep 10, 2019 at 12:08:34PM -0400, Randall S. Becker wrote: > My suggestion is a new feature as a patch. See other contributions. > While you're at this, especially given how extensive this may be given > the time_t references, it might be useful to examine the end of epoch > concerns as we

Re: [RFC PATCH 1/1] for-each-ref: do not output empty lines

On Mon, Sep 09, 2019 at 11:02:07PM -0700, Junio C Hamano wrote: > Eric Freese writes: > > > If the format string expands to an empty string for a given ref, do not > > print the empty line. > > > > This is helpful when wanting to print only certain kinds of refs that > > you can't already filter

Re: [PATCH 1/2] git-gui: warn if the commit message contains lines longer than the set limit

Am 04.09.19 um 22:10 schrieb Bert Wesarg: > The commit message widget does not wrap the next and has a configurable > fixed width to avoid creating too wide commit messages. Though this was > only enforced in the GUI. Now we also check the commit message at commit > time for long lines and ask the

Re: Patching Git to handle dates before the Unix epoch

On 10-Sep-19 19:26, Jeff King wrote: On Tue, Sep 10, 2019 at 05:14:53PM +0300, Diomidis Spinellis wrote: As people use Git to create synthetic commits of code written in the past [1,2] it becomes important to handle dates before the Unix epoch (1/1/1970). I see that modern C libraries, Unix kern

Re: [PATCH v2] cache-tree: do not lazy-fetch merge tree

> Junio C Hamano writes: > > > Isn't that what is going on? I thought I dug up the original that > > introduced the has_object_file() call to this codepath to make sure > > we understand why we make the check (and I expected the person who > > is proposing this change to do the same and record t

Re: [PATCH v2] cache-tree: do not lazy-fetch merge tree

> Sidenote, just curious: did you originally intend to add this test > before the test script sources 'lib-httpd.sh', or you were about to > append it at the end as usual, but then noticed the warning comment > telling you not to do so? Honestly, I don't remember. I do try to put tests near simila

Re: What's cooking in git.git (Sep 2019, #01; Sat, 7)

On 2019.09.07 10:26, Junio C Hamano wrote: > * js/trace2-json-schema (2019-07-25) 3 commits > . ci: run trace2 schema validation in the CI suite > . trace2: add a schema validator for trace2 events > . trace2: add a JSON schema for trace2 events > > The JSON output produced by "trace2" subsyst

Re: [PATCH] Documentation: fix build with Asciidoctor 2

On Sun, Sep 08, 2019 at 10:24:24PM +, brian m. carlson wrote: > Trying again, I'm able to reproduce this. I found the cause, which is > in the stylesheets. XSLT stylesheets have the ability to specify > elements from which whitespace should be stripped (using the > xsl:strip-space directive)

[PATCH] git-submodule.txt: fix AsciiDoc formatting error

In b57e8119e6 (submodule: teach set-branch subcommand, 2019-02-08), the `set-branch` subcommand was added for submodules. When the documentation was written, the syntax for a "index term" in AsciiDoc was accidentally used. This caused the documentation to be rendered as set-branch -d|--def

Re: [PATCH v5] git-gui: Add hotkeys to set widget focus

+Cc j6t This patch LGTM, but I'm not sure how to resolve the keybindings problem. Junio suggested we have configurable keybindings, and I agree with him, but until we do, something has to be agreed upon. And we also need to come up with a reasonable default. So, I don't have any preferences fo

Re: [PATCH v3 0/4] git-gui: Add ability to revert selected hunks and lines

Johannes, Bert, All, If there are no further objections with the series, I will merge it in. On 29/08/19 03:27AM, Pratyush Yadav wrote: > Hi, > > This series adds the ability to revert selected lines and hunks in > git-gui. Partially based on the patch by Bert Wesarg [0]. > > The commits can be

Re: [PATCH 1/2] git-gui: warn if the commit message contains lines longer than the set limit

On 10/09/19 01:04AM, David Aguilar wrote: > On Fri, Sep 06, 2019 at 09:07:15PM +0100, Philip Oakley wrote: > > > > Not sure if I parsed this correctly, but I'd want a WYSIWYG approach that if > > we wrap on the display it will be wrapped (newline char) in the commit. It > > sounded as if you were

Re: [PATCH v3 0/4] git-gui: Add ability to revert selected hunks and lines

Am 10.09.19 um 21:21 schrieb Pratyush Yadav: > If there are no further objections with the series, I will merge it in. No objections. I use it in production. -- Hannes

Re: [PATCH 2/2] git-gui: add horizontal scrollbar to commit buffer

On 04/09/19 10:10PM, Bert Wesarg wrote: > While the commit message widget has a configurable fixed width, it > nevertheless allows to write commit messages which exceed this limit. > Though it does not show this content because there is not scrollbar for Like we discussed before, it does show the

Re: [PATCH 1/2] git-gui: warn if the commit message contains lines longer than the set limit

On 04/09/19 10:10PM, Bert Wesarg wrote: > The commit message widget does not wrap the next and has a configurable > fixed width to avoid creating too wide commit messages. Though this was > only enforced in the GUI. Now we also check the commit message at commit > time for long lines and ask the au

Re: What's cooking in git.git (Sep 2019, #01; Sat, 7)

Hi, Junio On Sat, Sep 7, 2019 at 2:27 PM Junio C Hamano wrote: > > * mt/threaded-grep-in-object-store (2019-08-13) 4 commits > - grep: re-enable threads in some non-worktree cases > - grep: disable grep_read_mutex when possible > - grep: allow locks to be enabled individually > - object-store

Avis important

Cher utilisateur, Dans le cadre de nos messages de sécurité, nous mettons à jour régulièrement toutes les adresses électroniques de notre système de base de données. Nous ne pouvons pas mettre à jour votre compte. Nous allons donc suspendre temporairement votre accès à votre adresse électroni

git-send-email does not use conditional configuration

Hello, In my git configuration, I have an includeif section for work related repositories that configures the user and sendemail sections. I can verify that the configuration is read correctly by git: % git config --get-regex "sendemail.*" sendemail.smtpencryption tls sendemail.smtpserver smtp.o

Avis important

Cher utilisateur, Dans le cadre de nos messages de sécurité, nous mettons à jour régulièrement toutes les adresses électroniques de notre système de base de données. Nous ne pouvons pas mettre à jour votre compte. Nous allons donc suspendre temporairement votre accès à votre adresse électroni

Re: [PATCH v5] git-gui: Add hotkeys to set widget focus

Hi Pratyush, On Tue, Sep 10, 2019 at 9:12 PM Pratyush Yadav wrote: > This patch LGTM, but I'm not sure how to resolve the keybindings > problem. Junio suggested we have configurable keybindings, and I agree > with him, but until we do, something has to be agreed upon. And we also > need to come u