Re: [PATCH v2] request-pull: capitalise "Git" to make it a proper noun

y at:" Besides, this brings us in line with the documentation, see Documentation/howto/using-signed-tag-in-pull-request.txt Signed-off-by: Ann T Ropea <bedhan...@gmx.de> Acked-by: Jonathan Nieder <jrnie...@gmail.com> --- v2: rename patch, correct Signed-off-by line, add Acked-by line g

Re: [PATCH v6 4/7] checkout: describe_detached_head: remove ellipsis after committish

variable GIT_PRINT_SHA1_ELLIPSIS to "yes". Correct documentation with respect to what describe_detached_head prints when GIT_PRINT_SHA1_ELLIPSIS is not set as indicated above. Add tests for the old and new behaviour. Signed-off-by: Ann T Ropea <bedhan...@gmx.de> --- v2: rename patc

Re: [PATCH v3 3/5] Documentation: user-manual: limit usage of ellipsis

Confusing the ellipsis with the three-dot operator should be made as difficult as possible. Signed-off-by: Ann T Ropea <bedhan...@gmx.de> --- v2: rename patch series & focus on removal of ellipses v3: env var instead of config option, use one-line comments where appropriate, prese

Re: [PATCH v3 2/5] diff: diff_aligned_abbrev: remove ellipsis after abbreviated SHA-1 value

Neither Git nor the user are in need of this (visual) aid anymore, but we must offer a transition period. Also, fix a typo: "abbbreviated" ---> "abbreviated". Signed-off-by: Ann T Ropea <bedhan...@gmx.de> --- v2: rename patch series & focus on removal of ellip

Re: [PATCH v3 1/5] checkout: describe_detached_head: remove ellipsis after committish

the environment variable PRINT_SHA1_ELLIPSIS to "yes" (case does not matter). The transient nature of this fallback suggests that we should not prefix the variable by "GIT_". Signed-off-by: Ann T Ropea <bedhan...@gmx.de> --- v2: rename patch series & focus on removal o

Re: [PATCH v2 1/6] config: introduce core.printsha1ellipsis

option *and* the ellipses after abbreviated SHA-1 values after a respectable period. Signed-off-by: Ann T Ropea <bedhan...@gmx.de> --- v2: rename patch series & focus on removal of ellipses Documentation/config.txt | 10 ++ cache.h | 1 + config.c

Re: [PATCH v2 4/6] Documentation: user-manual: limit usage of ellipsis

Confusing the ellipsis with the three-dot operator should be made as difficult as possible. Signed-off-by: Ann T Ropea <bedhan...@gmx.de> --- v2: rename patch series & focus on removal of ellipses Documentation/user-manual.txt | 22 +++--- 1 file changed, 11 inserti

Re: [PATCH v2 3/6] diff: diff_aligned_abbrev: remove ellipsis after abbreviated SHA-1 value

Neither Git nor the user are in need of this (visual) aid anymore, but we must offer a transition period. Also, fix a typo: "abbbreviated" ---> "abbreviated". Signed-off-by: Ann T Ropea <bedhan...@gmx.de> --- v2: rename patch series & focus on

Re: [PATCH v2 2/6] checkout: describe_detached_head: remove ellipsis after committish

the config option core.printsha1ellipsis to true. Signed-off-by: Ann T Ropea <bedhan...@gmx.de> --- v2: rename patch series & focus on removal of ellipses builtin/checkout.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/builtin/checkout.c b/builtin/checko

Re: [PATCH v2 5/6] Documentation: revisions: fix typo: "three dot" ---> "three-dot" (in line with "two-dot").

Signed-off-by: Ann T Ropea <bedhan...@gmx.de> --- v2: rename patch series & focus on removal of ellipses Documentation/revisions.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/revisions.txt b/Documentation/revisions.txt index 61277469c874..df

Re: [PATCH v2 6/6] Testing: provide tests requiring them with ellipses after SHA-1 values

Where needed, we arrange for invocations of Git as if "-c core.printsha1ellipsis=true" had been specified on the command-line. This furnishes ellipses in the output which then matches what is expected. Signed-off-by: Ann T Ropea <bedhan...@gmx.de> --- v2: rename patc

[PATCH 1/3] checkout: describe_detached_head: remove 3dots after committish

checkout.sh (see contrib/examples/git-checkout.sh) * when git-reset causes a new HEAD line to be printed (during a hard reset), neither builtin/reset.c nor contrib/examples/git-reset.sh mention 3dots Lest we confuse the meticulous observer, we ought to retire the 3dots in the circum

[PATCH 2/3] Documentation: user-manual: limit potentially confusing usage of 3dots (and 2dots)

. Signed-off-by: Ann T Ropea <bedhan...@gmx.de> --- Documentation/user-manual.txt | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt index b4d88af133e8..bdb44b067399 100644 --- a/Documentatio

[PATCH 3/3] Documentation: revisions: add note about 3dots usages as continuation indications

Also, fix typo: "three dot" ---> "three-dot" (align with "two-dot"). Signed-off-by: Ann T Ropea <bedhan...@gmx.de> --- Documentation/revisions.txt | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/Documentation/revisions.

Re: [PATCH 1/3] checkout: describe_detached_head: remove 3dots after committish

Thanks for all the feedback provided! I'd like to summarise what consensus we have reached so far and then propose a way forward: * we'll use the term "ellipsis (pl. ellipses)" for what's been referred to as "3dots", "n-dots", "many dots" and so forth * we would like to use

Re: [PATCH v7 4/7] checkout: describe_detached_head: remove ellipsis after committish

variable GIT_PRINT_SHA1_ELLIPSIS to "yes". Correct documentation with respect to what describe_detached_head prints when GIT_PRINT_SHA1_ELLIPSIS is not set as indicated above. Add tests for the old and new behaviour. Signed-off-by: Ann T Ropea <bedhan...@gmx.de> --- v2: rename patc

Re: [PATCH v7 4/7] checkout: describe_detached_head: remove ellipsis after committish

Junio C Hamano writes: > I've however queued the following on top of the entire series. I do > not mind squashing it into this step, though. > Subject: [PATCH] t2020: test variations that matter That sounds and looks fine to me. I'm going to do this on my side (getting it

Re: [PATCH 1/2] tests: fix non-portable "${var:-"str"}" construct

-12-03) first released with Git v2.16.0. Acked-by: Ann T Ropea Thanks.