Re: [PATCH 5/5] completion: fix completion of certain aliases

2014-04-13 Thread Gábor Szeder
Hi, [I'm travelling, so I don't have the means to actually try out this patch, and it might take a while a to reply to any follow ups.] On Apr 10, 2014 12:03 AM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com writes: Some commands need the first word

Re: [SECURITY PATCH] git-prompt.sh: don't put unsanitized branch names in $PS1

2014-04-24 Thread Gábor Szeder
Hi, On Apr 22, 2014 2:53 AM, Junio C Hamano gits...@pobox.com wrote: Richard Hansen rhan...@bbn.com writes: Both bash and zsh subject the value of PS1 to parameter expansion, command substitution, and arithmetic expansion.  Rather than include the raw, unescaped branch name in PS1

Re: [PATCH 1/5] git-prompt: do not look for refs/stash in $GIT_DIR

2014-08-24 Thread Gábor Szeder
Hi, On Aug 23, 2014 12:26 PM, Jeff King p...@peff.net wrote: Since dd0b72c (bash prompt: use bash builtins to check stash state, 2011-04-01), git-prompt checks whether we have a stash by looking for $GIT_DIR/refs/stash. Generally external programs should never do this, because they would