[PATCH] gitweb: use highlight's shebang detection

2016-09-06 Thread Ian Kelling
-standalone-no-errors.sh. Signed-off-by: Ian Kelling <i...@iankelling.org> --- Notes: I wondered if adding highlight to the pipeline would make viewing a blob with no highlighting take longer but it did not on my computer. I found no noticeable impact on small files and str

Re: [PATCH v3 2/2] gitweb: use highlight's shebang detection

2016-09-24 Thread Ian Kelling
On Fri, Sep 23, 2016, at 03:15 PM, Jakub Narębski wrote: > W dniu 23.09.2016 o 11:08, Ian Kelling napisał: > > > The "highlight" binary can, in some cases, determine the language type > > by the means of file contents, for example the shebang in the first line >

Re: [PATCH v3 2/2] gitweb: use highlight's shebang detection

2016-09-24 Thread Ian Kelling
On Sat, Sep 24, 2016, at 09:21 AM, Jakub Narębski wrote: > W dniu 24.09.2016 o 00:15, Jakub Narębski pisze: > > Sidenote: this way of benchmarking of gitweb falls between two ways of > doing a benchmark. > > The first method is to simply run gitweb as a standalone script, passing > its

[PATCH v4 2/2] gitweb: use highlight's shebang detection

2016-09-24 Thread Ian Kelling
is used. Signed-off-by: Ian Kelling <i...@iankelling.org> --- Notes: The only change from v3 is the commit message as suggested by Jakub Narębski Documentation/gitweb.conf.txt | 21 ++--- gitweb/gitweb.perl | 10 +- t/t9500-gitw

[PATCH v4 1/2] gitweb: remove unused guess_file_syntax() parameter

2016-09-24 Thread Ian Kelling
Signed-off-by: Ian Kelling <i...@iankelling.org> --- Notes: The only change from v3 is a more descriptive commit message gitweb/gitweb.perl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 33d701d..6cb4280

[PATCH v3 2/2] gitweb: use highlight's shebang detection

2016-09-23 Thread Ian Kelling
e and improve syntax highlight documentation, add test to ensure gitweb doesn't crash when language detection is used. Signed-off-by: Ian Kelling <i...@iankelling.org> --- Documentation/gitweb.conf.txt | 21 ++--- gitweb/gitweb.perl | 10

Re: [PATCH v2] gitweb: use highlight's shebang detection

2016-09-23 Thread Ian Kelling
On Thu, Sep 22, 2016, at 03:50 PM, Jakub Narębski wrote: > W dniu 22.09.2016 o 00:18, Ian Kelling napisał: > > > The highlight binary can detect language by shebang when we can't tell > > the syntax type by the name of the file. In that case, pass the blob > &g

[PATCH v3 1/2] gitweb: remove unused function parameter

2016-09-23 Thread Ian Kelling
Signed-off-by: Ian Kelling <i...@iankelling.org> --- gitweb/gitweb.perl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 33d701d..6cb4280 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -3913,7 +3913,7

Re: [PATCH] gitweb: use highlight's shebang detection

2016-09-21 Thread Ian Kelling
On Tue, Sep 20, 2016, at 01:22 PM, Jakub Narębski wrote: > W dniu 06.09.2016 o 21:00, Ian Kelling pisze: > > > The highlight binary can detect language by shebang when we can't tell > > the syntax type by the name of the file. > > Was it something always present a

[PATCH] gitweb: use highlight's shebang detection

2016-09-21 Thread Ian Kelling
ove syntax highlight documentation, add test to ensure gitweb doesn't crash when language detection is used, and remove an unused parameter from gitweb_check_feature(). Signed-off-by: Ian Kelling <i...@iankelling.org> --- Documentation/gitweb.conf.txt | 21 ++--- gi

Re: [PATCH] gitweb: use highlight's shebang detection

2016-09-21 Thread Ian Kelling
fyi: I mistakenly did not include v2 in the subject of the last message.

Re: [PATCH v4 2/2] gitweb: use highlight's shebang detection

2016-09-28 Thread Ian Kelling
On Sun, Sep 25, 2016, at 11:04 AM, Jakub Narębski wrote: > > For what it is worth it: > > Acked-by: Jakub Narębski <jna...@gmail.com> > > (but unfortunately *not* tested by). Thank you for all your help. -- Ian Kelling

Re: How to watch a mailing list & repo for patches which affect a certain area of code?

2016-10-10 Thread Ian Kelling
On Mon, Oct 10, 2016, at 12:08 PM, Stefan Beller wrote: > Well it is found in 2.9 and later. Currently the base footer is > opt-in, e.g. you'd > need to convince people to run `git config format.useAutoBase true` or to > manually add the base to the patch via `format-patch --base=`. Nice. Another

How to watch a mailing list & repo for patches which affect a certain area of code?

2016-10-09 Thread Ian Kelling
I've got patches in various projects, and I don't have time to keep up with the mailing list, but I'd like to help out with maintenance of that code, or the functions/files it touches. People don't cc me. I figure I could filter the list, test patches submitted, commits made, mentions of