[PATCH] gitk: replace SHA1 entry field on keyboard paste

We already replace old SHA with the clipboard content for the mouse paste event. It seems reasonable to do the same when pasting from keyboard. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- gitk-git/gitk |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gitk-git

[PATCH] gitk: replace SHA1 entry field on keyboard paste

We already replace old SHA with the clipboard content for the mouse paste event. It seems reasonable to do the same when pasting from keyboard. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- gitk-git/gitk |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gitk-git/gitk

[PATCH 1/2] test-lib: tests skipped by GIT_SKIP_TESTS say so

We used to show (missing ) next to tests skipped because they are specified in GIT_SKIP_TESTS. Use (matched by GIT_SKIP_TESTS) instead. --- t/test-lib.sh | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 1531c24..89a405b

[PATCH 2/2] test-lib: GIT_TEST_ONLY to run only specific tests

This is a counterpart to GIT_SKIP_TESTS. Mostly useful when debugging. --- t/README | 15 +++ t/test-lib.sh |8 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/t/README b/t/README index caeeb9d..f939987 100644 --- a/t/README +++ b/t/README @@

[PATCH] rev-parse --parseopt: option argument name hints

are replaced with whitespace. It is unlikely that an underscore would be useful in the hint text. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- Documentation/git-rev-parse.txt | 11 +-- builtin/rev-parse.c | 17 - t/t1502-rev-parse-parseopt.sh | 20

Re: [PATCH 1/2] test-lib: tests skipped by GIT_SKIP_TESTS say so

On 3/3/2014 7:11 AM, Philip Oakley wrote: From: Ilya Bobyr ilya.bo...@gmail.com We used to show (missing ) next to tests skipped because they are specified in GIT_SKIP_TESTS. Use (matched by GIT_SKIP_TESTS) instead. The message below forgets the by. I'll fix the commit message. I think

Re: [PATCH 1/2] test-lib: tests skipped by GIT_SKIP_TESTS say so

On 3/3/2014 2:59 PM, Eric Sunshine wrote: On Mon, Mar 3, 2014 at 5:24 AM, Ilya Bobyr ilya.bo...@gmail.com wrote: We used to show (missing ) next to tests skipped because they are specified in GIT_SKIP_TESTS. Use (matched by GIT_SKIP_TESTS) instead. Bikeshedding: That's pretty verbose. Perhaps

Re: [PATCH 2/2] test-lib: GIT_TEST_ONLY to run only specific tests

On 3/3/2014 3:03 PM, Eric Sunshine wrote: On Mon, Mar 3, 2014 at 5:24 AM, Ilya Bobyr ilya.bo...@gmail.com wrote: This is a counterpart to GIT_SKIP_TESTS. Mostly useful when debugging. To be grammatically similar to GIT_SKIP_TESTS, perhaps name it GIT_RUN_TESTS? There is actually an upside

Re: [PATCH 2/2] test-lib: GIT_TEST_ONLY to run only specific tests

On 3/3/2014 3:26 PM, Junio C Hamano wrote: Eric Sunshine sunsh...@sunshineco.com writes: On Mon, Mar 3, 2014 at 5:24 AM, Ilya Bobyr ilya.bo...@gmail.com wrote: This is a counterpart to GIT_SKIP_TESTS. Mostly useful when debugging. To be grammatically similar to GIT_SKIP_TESTS, perhaps name

Re: [PATCH 1/2] test-lib: tests skipped by GIT_SKIP_TESTS say so

On 3/3/2014 3:18 PM, Eric Sunshine wrote: On Mon, Mar 3, 2014 at 6:12 PM, Ilya Bobyr ilya.bo...@gmail.com wrote: On 3/3/2014 2:59 PM, Eric Sunshine wrote: On Mon, Mar 3, 2014 at 5:24 AM, Ilya Bobyr ilya.bo...@gmail.com wrote: We used to show (missing ) next to tests skipped because

Re: [PATCH 2/2] test-lib: GIT_TEST_ONLY to run only specific tests

On 3/3/2014 4:08 PM, Junio C Hamano wrote: Ilya Bobyr ilya.bo...@gmail.com writes: It might be that we are looking at different use cases, as you are talking about whole test suits. I do not think so. Good :) I am trying to understand the use cases. And make sure we are talking about

Re: [PATCH 2/2] test-lib: GIT_TEST_ONLY to run only specific tests

On 3/4/2014 12:29 AM, Junio C Hamano wrote: Ilya Bobyr ilya.bo...@gmail.com writes: While it could be done, it looks less obvious than this: GIT_TEST_ONLY='1 4' ./t0001-init.sh If you are thinking about affecting only one test, Yes, that is the use case: when I am developing

Re: [PATCH] gitk: replace SHA1 entry field on keyboard paste

On 3/4/2014 10:15 AM, Junio C Hamano wrote: From: Ilya Bobyr ilya.bo...@gmail.com Date: Thu, 27 Feb 2014 22:51:37 -0800 We already replace old SHA with the clipboard content for the mouse paste event. It seems reasonable to do the same when pasting from keyboard. Signed-off-by: Ilya Bobyr

Re: howto to run git without a master branch

On 3/9/2014 12:54 PM, Carlos Pereira wrote: On 03/09/2014 07:46 AM, Torsten Bögershausen wrote: After creating a local repository with these two branches, and a server repository with git init --bare, and pushing the two branches: git remote add originfoo@bar:~/path/test.git git push

Re: [PATCH] rev-parse --parseopt: option argument name hints

On 3/4/2014 11:22 AM, Junio C Hamano wrote: Ilya Bobyr ilya.bo...@gmail.com writes: Built-in commands can specify names for option arguments, that are shown when usage text is generated for the command. sh based commands should be able to do the same. Option argument name hint is any text

[PATCH v2] rev-parse --parseopt: option argument name hints

with whitespace. It is unlikely that an underscore would be useful in the hint text. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- Documentation/git-rev-parse.txt | 11 +-- builtin/rev-parse.c | 17 - t/t1502-rev-parse-parseopt.sh | 20

Re: [PATCH] rev-parse --parseopt: option argument name hints

On 3/11/2014 12:10 PM, Junio C Hamano wrote: Junio C Hamano gits...@pobox.com writes: Documentation on the whole argument parsing is quite short, so, I though, adding an example just to show how usage is generated would look like I am trying to make this feature look important than it is :)

Re: [PATCH] rev-parse --parseopt: option argument name hints

On 3/12/2014 9:59 AM, Junio C Hamano wrote: Ilya Bobyr ilya.bo...@gmail.com writes: I though that an example just to describe `argh' while useful would look a bit disproportional, compared to the amount of text on --parseopt. But now that I've added a Usage text section to looks quite

Re: [PATCH] rev-parse --parseopt: option argument name hints

On 3/19/2014 11:46 AM, Junio C Hamano wrote: Ilya Bobyr ilya.bo...@gmail.com writes: I can not find this particular patch in the latest What's cooking email. Is there something I can do? IIRC, I think I was waiting for the version with a new Usage text section to the documentation you alluded

[PATCH v3] rev-parse --parseopt: option argument name hints

with whitespace. It is unlikely that an underscore would be useful in the hint text. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- Changed according to the last comments. Added Usage text paragraph in the documentation and updated variable names. Documentation/git-rev-parse.txt | 34

Re: [PATCH v3] rev-parse --parseopt: option argument name hints

On 3/20/2014 11:38 AM, Junio C Hamano wrote: Ilya Bobyr ilya.bo...@gmail.com writes: Built-in commands can specify names for option arguments when usage text is generated for a command. sh based commands should be able to do the same. Option argument name hint is any text that comes after

Re: [PATCH v3] rev-parse --parseopt: option argument name hints

On 3/20/2014 1:18 PM, Eric Sunshine wrote: On Thu, Mar 20, 2014 at 4:44 AM, Ilya Bobyr ilya.bo...@gmail.com wrote: Built-in commands can specify names for option arguments when usage text is generated for a command. sh based commands should be able to do the same. Option argument name hint

Re: [PATCH v3] rev-parse --parseopt: option argument name hints

On 3/20/2014 4:19 PM, Ilya Bobyr wrote: On 3/20/2014 11:38 AM, Junio C Hamano wrote: Ilya Bobyr ilya.bo...@gmail.com writes: [...] -opt_specflags* SP+ help LF +opt_specflags*arg_hint? SP+ help LF `opt_spec`:: @@ -313,6 +313,12 @@ Each line of options

[PATCH v4] rev-parse --parseopt: option argument name hints

Built-in commands can specify names for option arguments when usage text is generated for a command. sh based commands should be able to do the same. Option argument name hint is any text that comes after [*=?!] after the argument name up to the first whitespace. Signed-off-by: Ilya Bobyr

[PATCH 3/3] test-lib: '--run' to run only specific tests

Allow better control of the set of tests that will be executed for a single test suite. Mostly useful while debugging or developing as it allows to focus on a specific test. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- t/README | 65 ++- t/t-basic.sh | 233

[RFC/PATCH] Better control of the tests run by a test suite

Hello, This is a second attempt on a functionality I proposed in [PATCH 2/2] test-lib: GIT_TEST_ONLY to run only specific tests http://www.mail-archive.com/git%40vger.kernel.org/msg44828.html except that the implementation is quite different now. I hope that I have accounted for the

[PATCH 1/3] test-lib: Document short options in t/README

Most arguments that could be provided to a test have short forms. Unless documented the only way to learn then is to read the code. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- t/README | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/t/README b/t/README

[PATCH 2/3] test-lib: tests skipped by GIT_SKIP_TESTS say so

We used to show (missing ) next to tests skipped because they are specified in GIT_SKIP_TESTS. Use (GIT_SKIP_TESTS) instead. Plus tests that check basic GIT_SKIP_TESTS functions. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- t/t-basic.sh | 63

Re: [PATCH 1/3] test-lib: Document short options in t/README

On 3/24/2014 4:39 AM, Ramsay Jones wrote: On 24/03/14 08:49, Ilya Bobyr wrote: Most arguments that could be provided to a test have short forms. Unless documented the only way to learn then is to read the code. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- t/README | 10

Re: [PATCH 1/3] test-lib: Document short options in t/README

On 3/25/2014 10:23 AM, Junio C Hamano wrote: Ilya Bobyr ilya.bo...@gmail.com writes: On 3/24/2014 4:39 AM, Ramsay Jones wrote: On 24/03/14 08:49, Ilya Bobyr wrote: [...] [...] ---valgrind=tool:: +-v,--valgrind=tool:: The -v short option is taken, above ... :-P Right %) Thanks

Re: [RFC/PATCH] Better control of the tests run by a test suite

On 3/24/2014 9:58 PM, Junio C Hamano wrote: Jeff King p...@peff.net writes: On Mon, Mar 24, 2014 at 01:49:44AM -0700, Ilya Bobyr wrote: Here are some examples of how functionality added by the patch could be used. In order to run setup tests and then only a specific test (use case 1) one

[RFC/PATCH v2] Better control of the tests run by a test suite

This is an update verson of the patches I've posted here: [RFC/PATCH] Better control of the tests run by a test suite http://www.mail-archive.com/git@vger.kernel.org/msg46419.html Chanes are only in the first patch, according to

[PATCH 3/3] test-lib: '--run' to run only specific tests

Allow better control of the set of tests that will be executed for a single test suite. Mostly useful while debugging or developing as it allows to focus on a specific test. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- No changes from the previous version. t/README | 65

[PATCH 2/3] test-lib: tests skipped by GIT_SKIP_TESTS say so

We used to show (missing ) next to tests skipped because they are specified in GIT_SKIP_TESTS. Use (GIT_SKIP_TESTS) instead. Plus tests that check basic GIT_SKIP_TESTS functions. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- No changes from the previous version. t/t-basic.sh | 63

[PATCH 1/3] test-lib: Document short options in t/README

Most arguments that could be provided to a test have short forms. Unless documented, the only way to learn them is to read the code. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- Minor changes according to comments in http://www.mail-archive.com/git@vger.kernel.org/msg46423.html

Re: [PATCH 3/3] test-lib: '--run' to run only specific tests

On 3/27/2014 8:36 PM, Eric Sunshine wrote: On Thu, Mar 27, 2014 at 6:32 AM, Ilya Bobyr ilya.bo...@gmail.com wrote: Allow better control of the set of tests that will be executed for a single test suite. Mostly useful while debugging or developing as it allows to focus on a specific test

Re: [RTC/PATCH] Add 'update-branch' hook

On 4/20/2014 7:23 PM, Felipe Contreras wrote: This hook is invoked whenever a branch is updated, either when a branch is created or updated with 'git branch', or when it's rebased with 'git rebase'. It receives two parameters; the name of the branch, and the SHA-1 of the latest commit,

Re: [RTC/PATCH] Add 'update-branch' hook

On 4/21/2014 1:49 PM, Felipe Contreras wrote: Ilya Bobyr wrote: On 4/20/2014 7:23 PM, Felipe Contreras wrote: This hook is invoked whenever a branch is updated, either when a branch is created or updated with 'git branch', or when it's rebased with 'git rebase'. It receives two parameters

Re: [RTC/PATCH] Add 'update-branch' hook

On 4/20/2014 7:23 PM, Felipe Contreras wrote: [...] diff --git a/t/t5408-update-branch-hook.sh b/t/t5408-update-branch-hook.sh new file mode 100755 index 000..d921c0e --- /dev/null +++ b/t/t5408-update-branch-hook.sh @@ -0,0 +1,39 @@ +#!/bin/sh + +test_description='Test the

Re: [RTC/PATCH] Add 'update-branch' hook

On 4/21/2014 2:15 PM, Felipe Contreras wrote: Ilya Bobyr wrote: On 4/20/2014 7:23 PM, Felipe Contreras wrote: [...] diff --git a/t/t5408-update-branch-hook.sh b/t/t5408-update-branch-hook.sh new file mode 100755 index 000..d921c0e --- /dev/null +++ b/t/t5408-update-branch-hook.sh

Re: [RTC/PATCH] Add 'update-branch' hook

On 4/21/2014 2:17 PM, Felipe Contreras wrote: Ilya Bobyr wrote: Also, most have names that start with either pre- or post-. It seems reasonable for both pre-update-branch and post-update-branch to exist. I don't see what would be the point in that. Do you see the point in the other hooks

Re: [RTC/PATCH] Add 'update-branch' hook

On 4/21/2014 3:24 PM, Felipe Contreras wrote: Ilya Bobyr wrote: On Mon, Apr 21, 2014 at 2:35 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Ilya Bobyr wrote: test_expect_success 'setup' mkdir -p .git/hooks cat .git/hooks/update-branch -\\EOF #!/bin/sh

Re: [RTC/PATCH] Add 'update-branch' hook

On 4/20/2014 7:23 PM, Felipe Contreras wrote: [...] diff --git a/branch.c b/branch.c index 660097b..c2058d1 100644 --- a/branch.c +++ b/branch.c @@ -4,6 +4,7 @@ #include refs.h #include remote.h #include commit.h +#include run-command.h struct tracking { struct refspec

Re: [RTC/PATCH] Add 'update-branch' hook

On 4/21/2014 1:49 PM, Felipe Contreras wrote: Ilya Bobyr wrote: On 4/20/2014 7:23 PM, Felipe Contreras wrote: This hook is invoked whenever a branch is updated, either when a branch is created or updated with 'git branch', or when it's rebased with 'git rebase'. It receives two parameters

Re: [RTC/PATCH] Add 'update-branch' hook

On 4/21/2014 11:45 PM, Felipe Contreras wrote: [...] This is how it is suggested by t/README and how it is done in the other test suites. I can not see how your case is different, but I might be missing something. Let's take a cursoy look at `git grep -l 'EOF' t`. [...] So the point is

[RFC/PATCH v3] Better control of the tests run by a test suite

to be run in verbose mode: ./t-basic.sh --run=1-4,27v Ilya Bobyr (3): test-lib: Document short options in t/README test-lib: tests skipped by GIT_SKIP_TESTS say so test-lib: '--run' to run only specific tests t/README | 81 ++- t/t-basic.sh | 419

[PATCH 1/3] test-lib: Document short options in t/README

Most arguments that could be provided to a test have short forms. Unless documented, the only way to learn them is to read the code. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- t/README |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/t/README b/t/README

[PATCH 3/3] test-lib: '--run' to run only specific tests

Allow better control of the set of tests that will be executed for a single test suite. Mostly useful while debugging or developing as it allows to focus on a specific test. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- t/README | 73 +++- t/t-basic.sh | 356

[PATCH 2/3] test-lib: tests skipped by GIT_SKIP_TESTS say so

We used to show (missing ) next to tests skipped because they are specified in GIT_SKIP_TESTS. Use (GIT_SKIP_TESTS) instead. Plus tests that check basic GIT_SKIP_TESTS functions. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- t/t-basic.sh | 63

Re: [RTC/PATCH] Add 'update-branch' hook

On 4/22/2014 9:31 AM, Felipe Contreras wrote: Stephen Leake wrote: Felipe Contreras felipe.contre...@gmail.com writes: Ilya Bobyr wrote: On 4/21/2014 2:17 PM, Felipe Contreras wrote: Ilya Bobyr wrote: Also, most have names that start with either pre- or post-. It seems reasonable for both

Re: [PATCH 1/3] test-lib: Document short options in t/README

On 4/23/2014 11:24 AM, Junio C Hamano wrote: Ilya Bobyr ilya.bo...@gmail.com writes: Most arguments that could be provided to a test have short forms. Unless documented, the only way to learn them is to read the code. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- t/README |8

Re: [PATCH 3/3] test-lib: '--run' to run only specific tests

On 4/23/2014 11:40 AM, Junio C Hamano wrote: Ilya Bobyr ilya.bo...@gmail.com writes: @@ -187,10 +192,70 @@ and either can match the t[0-9]{4} part to skip the whole test, or t[0-9]{4} followed by .$number to say which particular test to skip. -Note that some tests in the existing test

Re: [PATCH 3/3] test-lib: '--run' to run only specific tests

On 4/23/2014 12:51 PM, Eric Sunshine wrote: On Tue, Apr 22, 2014 at 4:19 AM, Ilya Bobyr ilya.bo...@gmail.com wrote: Allow better control of the set of tests that will be executed for a single test suite. Mostly useful while debugging or developing as it allows to focus on a specific test

[PATCH 3/3] test-lib: '--run' to run only specific tests

Allow better control of the set of tests that will be executed for a single test suite. Mostly useful while debugging or developing as it allows to focus on a specific test. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- A number of minor changes according to the review comments. t/README

[PATCH 2/3] test-lib: tests skipped by GIT_SKIP_TESTS say so

We used to show (missing ) next to tests skipped because they are specified in GIT_SKIP_TESTS. Use (GIT_SKIP_TESTS) instead. Plus tests that check basic GIT_SKIP_TESTS functions. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- No changes. t/t-basic.sh | 63

[PATCH 1/3] test-lib: Document short options in t/README

Most arguments that could be provided to a test have short forms. Unless documented, the only way to learn them is to read the code. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- Changed to use AsciiDoc format. t/README |4 1 files changed, 4 insertions(+), 0 deletions(-) diff

[RFC/PATCH v4] Better control of the tests run by a test suite

-archive.com/git@vger.kernel.org/msg48463.html I've replied to those messages. There are two comments from Junio that did not result in changed. All the others have been addressed I hope. Ilya Bobyr (3): test-lib: Document short options in t/README test-lib: tests skipped by GIT_SKIP_TESTS say so test

[PATCHv2] rev-parse --parseopt: allow [*=?!] in argument hints

From: Ilya Bobyr ilya.bo...@gmail.com A line in the input to rev-parse --parseopt describes an option by listing a short and/or long name, optional flags [*=?!], argument hint, and then whitespace and help string. We did not allow any of the [*=?!] characters in the argument hints

[PATCHv3] rev-parse --parseopt: allow [*=?!] in argument hints

like ./t1502-rev-parse-parseopt.sh --run=1-2 to stop at the test case 2 without any further modification of the test state area. Signed-off-by: Ilya Bobyr ilya.bo...@gmail.com --- On 7/13/2015 2:55 PM, Junio C Hamano wrote: ilya.bo...@gmail.com writes: Junio, thank you very much for all

[PATCH] rev-parse --parseopt: allow [*=?!] in argument hints

From: Ilya Bobyr ilya.bo...@gmail.com It is not very likely that any of the *=?! Characters would be useful in the argument short or long names. On the other hand, there are already argument hints that contain the = sign. It used to be impossible to include any of the *=?! signs

Re: [PATCH] t: fix duplicate words of "output"

On 5/6/2016 10:26 AM, Junio C Hamano wrote: > Li Peng writes: > >> Fix duplicate words of "output" in comment. >> >> Signed-off-by: Li Peng >> --- >> t/t-basic.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/t/t-basic.sh