Re: [PATCH] imap-send: use Apple's Security framework for base64 encoding

2013-07-27 Thread Jeremy Huddleston Sequoia
Hi David, Thanks for massaging it to apply to master and cleaning up the style conflicts. On Jul 27, 2013, at 13:31, David Aguilar dav...@gmail.com wrote: From: Jeremy Huddleston jerem...@apple.com Use Apple's supported functions for base64 encoding instead of the deprecated OpenSSL

Re: [PATCH 2/3] OS X: Fix redeclaration of die warning

2013-08-05 Thread Jeremy Huddleston Sequoia
Thanks Brian, Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com On Aug 5, 2013, at 8:59, Brian Gernhardt br...@gernhardtsoftware.com wrote: compat/apple-common-crypto.h uses die() in one of its macros, but was included in git-compat-util.h before the definition of die. Fix

Re: [PATCH 1/3] Makefile: Fix APPLE_COMMON_CRYPTO with BLK_SHA1

2013-08-05 Thread Jeremy Huddleston Sequoia
Thanks Brian, Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com On Aug 5, 2013, at 8:59, Brian Gernhardt br...@gernhardtsoftware.com wrote: It used to be that APPLE_COMMON_CRYPTO did nothing when BLK_SHA1 was set. But APPLE_COMMON_CRYPTO is now used for more than just SHA1 (see

2.9.2 test failures on macOS

2016-08-03 Thread Jeremy Huddleston Sequoia
I have two test failures to report in git 2.9.2 on macOS: t3210-pack-refs.sh has not changed between 2.8.4 and 2.9.2. This test passed fine with 2.8.4, but it now fails with 2.9.2 at: not ok 26 - retry acquiring packed-refs.lock # # LOCK=.git/packed-refs.lock && #

Re: 2.9.2 test failures on macOS

2016-08-03 Thread Jeremy Huddleston Sequoia
> On Aug 3, 2016, at 07:35, Johannes Schindelin <johannes.schinde...@gmx.de> > wrote: > > Hi Jeremy, > > On Wed, 3 Aug 2016, Jeremy Huddleston Sequoia wrote: > >> I have two test failures to report in git 2.9.2 on macOS: >> >> >> t3210-p

Re: [PATCH] t4014-format-patch: Adjust git_version regex to better handle distro changes to DEF_VER

2016-10-10 Thread Jeremy Huddleston Sequoia
> On Oct 10, 2016, at 06:10, Jeff King <p...@peff.net> wrote: > > On Sun, Oct 09, 2016 at 07:53:23PM -0700, Jeremy Huddleston Sequoia wrote: > >> Subject: Re: [PATCH] t4014-format-patch: Adjust git_version regex to better >> handle distro chang

Re: [PATCH] t3700-add.sh: Avoid filename collission between tests which could lead to test failure

2016-10-10 Thread Jeremy Huddleston Sequoia
> On Oct 10, 2016, at 09:44, Junio C Hamano <gits...@pobox.com> wrote: > > Jeremy Huddleston Sequoia <jerem...@apple.com> writes: > >> Regressed-in: 610d55af0f082f6b866dc858e144c03d8ed4424c >> Signed-off-by: Jeremy Huddleston Sequoia <jerem...@app

Re: [PATCH] t4014-format-patch: Adjust git_version regex to better handle distro changes to DEF_VER

2016-10-10 Thread Jeremy Huddleston Sequoia
> On Oct 10, 2016, at 09:42, Junio C Hamano <gits...@pobox.com> wrote: > > Jeremy Huddleston Sequoia <jerem...@apple.com> writes: > >> Regressed-in: 480871e09ed2e5275b4ba16b278681e5a8c122ae > > Please be considerate to future readers of "git log"

Re: git 2.10.1 test regression in t4014-format-patch.sh

2016-10-09 Thread Jeremy Huddleston Sequoia
> On Oct 9, 2016, at 17:18, Josh Triplett <j...@joshtriplett.org> wrote: > > On October 9, 2016 5:15:22 PM PDT, Jeremy Huddleston Sequoia > <jerem...@freedesktop.org> wrote: >> Hey Josh, >> >> Hope you're doing well. >> >> I wanted to let

[PATCH] t4014-format-patch: Adjust git_version regex to better handle distro changes to DEF_VER

2016-10-09 Thread Jeremy Huddleston Sequoia
Regressed-in: 480871e09ed2e5275b4ba16b278681e5a8c122ae Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> CC: Josh Triplett <j...@joshtriplett.org> CC: Junio C Hamano <gits...@pobox.com> --- t/t4014-format-patch.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH] t4014-format-patch: Adjust git_version regex to better handle distro changes to DEF_VER

2016-10-09 Thread Jeremy Huddleston Sequoia
> On Oct 9, 2016, at 20:04, Josh Triplett <j...@joshtriplett.org> wrote: > > On October 9, 2016 7:53:23 PM PDT, Jeremy Huddleston Sequoia > <jerem...@apple.com> wrote: >> Regressed-in: 480871e09ed2e5275b4ba16b278681e5a8c122ae >> Signed-off-by: Jeremy Hu

Re: git 2.10.1 test regression in t3700-add.sh

2016-10-09 Thread Jeremy Huddleston Sequoia
> On Oct 9, 2016, at 20:22, Jeremy Huddleston Sequoia > <jerem...@freedesktop.org> wrote: > > The issue is that the whitespace before the filename in $(git ls-files -s > "$2") is a tab, and test_mode_in_index only looks for a space. Actually, looks like that a

Re: git 2.10.1 test regression in t3700-add.sh

2016-10-09 Thread Jeremy Huddleston Sequoia
> On Oct 9, 2016, at 17:15, Jeremy Huddleston Sequoia > <jerem...@freedesktop.org> wrote: > > Hi Thomas, > > I wanted to let you know that this patch of yours, which landed in git > 2.10.1, introduced some test failures, seen on macOS. > > Let me know if yo

Re: git 2.10.1 test regression in t3700-add.sh

2016-10-09 Thread Jeremy Huddleston Sequoia
The issue is that the whitespace before the filename in $(git ls-files -s "$2") is a tab, and test_mode_in_index only looks for a space. >< > On Oct 9, 2016, at 19:51, Jeremy Huddleston Sequoia > <jerem...@freedesktop.org> wrote: > > >> On Oct 9, 2

[PATCH] t3700-add.sh: Avoid filename collission between tests which could lead to test failure

2016-10-09 Thread Jeremy Huddleston Sequoia
Regressed-in: 610d55af0f082f6b866dc858e144c03d8ed4424c Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> CC: Thomas Gummerer <t.gumme...@gmail.com> CC: Junio C Hamano <gits...@pobox.com> --- t/t3700-add.sh | 10 +- 1 file changed, 5 insertions(+), 5 deleti

Re: git 2.10.1 test regression in t3700-add.sh

2016-10-11 Thread Jeremy Huddleston Sequoia
> On Oct 10, 2016, at 10:41, Junio C Hamano <gits...@pobox.com> wrote: > > Jeremy Huddleston Sequoia <jerem...@freedesktop.org> writes: > >> Actually, looks like that as just a rabbit hole. The real issue >> looks to be because an earlier test drops down

git 2.10.1 test regression in t3700-add.sh

2016-10-09 Thread Jeremy Huddleston Sequoia
Hi Thomas, I wanted to let you know that this patch of yours, which landed in git 2.10.1, introduced some test failures, seen on macOS. Let me know if you need any additional information to track these down. Thanks, Jeremy not ok 40 - git add --chmod=[+-]x changes index with already added

git 2.10.1 test regression in t4014-format-patch.sh

2016-10-09 Thread Jeremy Huddleston Sequoia
Hey Josh, Hope you're doing well. I wanted to let you know that this patch of yours, which landed in git 2.10.1, introduced some test failures, seen on macOS. Let me know if you need any additional information to track these down. Thanks, Jeremy not ok 65 - format-patch default signature #

Re: Subscribing Apple people to git-secur...@googlegroups.com

2018-07-09 Thread Jeremy Huddleston Sequoia
+Akila Hi, Replies inline. > On Jul 2, 2018, at 12:50, Jeff King wrote: > > On Mon, Jul 02, 2018 at 09:29:41PM +0200, Christian Couder wrote: > >> When people complained a month ago about the MacOS package on >> https://git-scm.com/ not being up-to-date after the Git security >> release, I

Re: Subscribing Apple people to git-secur...@googlegroups.com

2018-07-10 Thread Jeremy Huddleston Sequoia
> On Jul 10, 2018, at 5:27 AM, Ævar Arnfjörð Bjarmason wrote: > > On Tue, Jul 3, 2018 at 3:36 PM, Jeff King wrote: >> On Mon, Jul 02, 2018 at 01:15:19PM -0700, Jeremy Huddleston Sequoia wrote: >> >>>> I hope that maybe they're also interested in reduc