Signed-off-by: Josh Steadmon
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 6b72f37c29..bbcfc2bc9f 100644
--- a/Makefile
+++ b/Makefile
@@ -3104,7 +3104,7 @@ cover_db_html: cover_db
# An example command to build against libFuzzer from
fuzz-commit-graph identified a case where Git will read past the end of
a buffer containing a commit graph if the graph's header has an
incorrect chunk count. A simple bounds check in parse_commit_graph()
prevents this.
Signed-off-by: Josh Steadmon
---
commit-graph.c
erify and
corrupt_and_zero_graph_then_verify test functions.
Josh Steadmon (3):
commit-graph, fuzz: Add fuzzer for commit-graph
commit-graph: fix buffer read-overflow
Makefile: correct example fuzz build
.gitignore | 1 +
Makefile| 3 +-
commit-gr
that would be duplicated by the caller.
Adds fuzz-commit-graph.c, which provides a fuzzing entry point
compatible with libFuzzer (and possibly other fuzzing engines).
Signed-off-by: Josh Steadmon
---
.gitignore | 1 +
Makefile| 1 +
commit-graph.c | 53
On 2018.12.09 17:42, Junio C Hamano wrote:
> * js/protocol-advertise-multi (2018-11-17) 1 commit
> - protocol: advertise multiple supported versions
>
> The transport layer has been updated so that the protocol version
> used can be negotiated between the parties, by the initiator
> listing th
On 2018.12.09 13:01, Junio C Hamano wrote:
> Josh Steadmon writes:
>
> > diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh
> > index 5fe21db99f..5b6b44b78e 100755
> > --- a/t/t5318-commit-graph.sh
> > +++ b/t/t5318-commit-g
On 2018.12.10 05:28, SZEDER Gábor wrote:
> On Sun, Dec 09, 2018 at 01:01:29PM +0900, Junio C Hamano wrote:
> > Josh Steadmon writes:
> >
> > > diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh
> > > index 5fe21db99f..5b6b44b78e 100755
> > >
xt, l. 63-64
[3] Documentation/technical/http-protocol.txt, l. 247
Helped-by: Josh Steadmon
Signed-off-by: Jeff King
Signed-off-by: Junio C Hamano
Signed-off-by: Josh Steadmon
---
remote-curl.c | 93 ---
1 file changed, 59 insertions(+), 34 de
d match "version
20", for example).
Let's tighten this check to use strcmp(). Note that we don't need to
worry about a trailing newline here, because the ptk-line code will have
chomped it for us already.
Signed-off-by: Jeff King
Signed-off-by: Junio C Hamano
Signed-off-by
Add an HTTP path to the test server config that returns an ERR pkt-line
unconditionally. Verify in t5551 that remote-curl properly detects this
ERR message and aborts.
Signed-off-by: Josh Steadmon
Signed-off-by: Jeff King
Signed-off-by: Junio C Hamano
---
t/lib-httpd.sh | 1
catch remote HTTP errors.
[1]:
https://public-inbox.org/git/20181127045301.103807-1-masayasuz...@google.com/
Jeff King (2):
remote-curl: refactor smart-http discovery
remote-curl: tighten "version 2" check for smart-http
Josh Steadmon (1):
lib-httpd, t5551: check server-side H
this protocol spec change, the error packet handling code is
moved to pkt-line.c.
Signed-off-by: Masaya Suzuki
Signed-off-by: Josh Steadmon
---
Documentation/technical/pack-protocol.txt | 20 +++-
builtin/archive.c | 2 --
connect.c
that would be duplicated by the caller.
Adds fuzz-commit-graph.c, which provides a fuzzing entry point
compatible with libFuzzer (and possibly other fuzzing engines).
Signed-off-by: Josh Steadmon
---
.gitignore | 1 +
Makefile| 1 +
commit-graph.c | 53
fuzz-commit-graph identified a case where Git will read past the end of
a buffer containing a commit graph if the graph's header has an
incorrect chunk count. A simple bounds check in parse_commit_graph()
prevents this.
Signed-off-by: Josh Steadmon
---
commit-graph.c
* Avoid pointer arithmetic overflow when checking the graph's chunk
count.
* Merge the corrupt_graph_and_verify and
corrupt_and_zero_graph_then_verify test functions.
Josh Steadmon (3):
commit-graph, fuzz: Add fuzzer for commit-graph
commit-graph: fix buffer read-overflow
Make
Signed-off-by: Josh Steadmon
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 6b72f37c29..bbcfc2bc9f 100644
--- a/Makefile
+++ b/Makefile
@@ -3104,7 +3104,7 @@ cover_db_html: cover_db
# An example command to build against libFuzzer from
On 2018.12.12 17:17, Masaya Suzuki wrote:
> On Wed, Dec 12, 2018 at 3:02 AM Jeff King wrote:
> > This ERR handling has been moved to a very low level. What happens if
> > we're passing arbitrary data via the packet_read() code? Could we
> > erroneously trigger an error if a packfile happens to hav
On 2018.12.14 21:20, Ævar Arnfjörð Bjarmason wrote:
>
> On Fri, Nov 16 2018, Josh Steadmon wrote:
>
> I started looking at this to address
> https://public-inbox.org/git/nycvar.qro.7.76.6.1812141318520...@tvgsbejvaqbjf.bet/
> and was about to send a re-roll of my ow
On 2018.12.18 12:35, Jeff King wrote:
> On Thu, Dec 13, 2018 at 11:43:55AM -0800, Josh Steadmon wrote:
>
> > Add a new fuzz test for the commit graph and fix a buffer read-overflow
> > that it discovered. Additionally, fix the Makefile instructions for
> > building fuzzers
On 2018.12.14 23:39, Ævar Arnfjörð Bjarmason wrote:
>
> On Fri, Dec 14 2018, Josh Steadmon wrote:
>
> > On 2018.12.14 21:20, Ævar Arnfjörð Bjarmason wrote:
> >>
> >> On Fri, Nov 16 2018, Josh Steadmon wrote:
> >>
> >> I started looking a
UST
expand abbreviations in filter specifications before passing them to
other processes. It adds a new function
"expand_list_objects_filter_spec()" in list-objects-filter-options.c
that implements the expansion logic, and updates users of the
filter_spec field to instead expand the spec firs
n, to allow for more compatibility between server
implementations.
Signed-off-by: Josh Steadmon
---
Documentation/technical/protocol-v2.txt | 5 -
builtin/clone.c | 6 +-
builtin/fetch.c | 7 ++-
fetch-pack.c| 15 +
On 2018.12.17 16:33, Jeff King wrote:
> On Thu, Dec 13, 2018 at 02:18:26PM -0800, Josh Steadmon wrote:
>
> > On 2018.12.12 17:17, Masaya Suzuki wrote:
> > > On Wed, Dec 12, 2018 at 3:02 AM Jeff King wrote:
> > > > This ERR handling has been moved to
acts as a client or server must now register its
supported protocol versions.
Changes since V4: remove special cases around advertising version=0.
Changes since V5: no code changes, but corrected and clarified commit
message regarding changes around advertising version=0.
Josh Steadmon (1
unnecessary externs from function declarations
in protocol.h.
Signed-off-by: Josh Steadmon
---
builtin/archive.c | 3 +
builtin/clone.c | 4 ++
builtin/fetch-pack.c| 4 ++
builtin/fetch.c | 5 ++
builtin/ls-remote.c | 5 ++
builtin/pull.c
On 2019.01.02 15:15, Junio C Hamano wrote:
> Josh Steadmon writes:
>
> > When communicating with a remote server or a subprocess, use expanded
> > numbers rather than abbreviated numbers in the object filter spec (e.g.
> > "limit:blob=1k" becomes "limit:b
On 2018.12.29 13:19, Masaya Suzuki wrote:
> By using and sharing a packet_reader while handling a Git pack protocol
> request, the same reader option is used throughout the code. This makes
> it easy to set a reader option to the request parsing code.
>
> Signed-off-by: Masaya Suzuki
> ---
> bui
not our ref" err
> + grep "fatal: remote error: upload-pack: not our ref" err
> '
>
> test_expect_success 'server is initially ahead - ref in want' '
> @@ -254,7 +254,7 @@ test_expect_success 'server loses a ref - ref in want' '
> echo "s/master/raster/" >"$HTTPD_ROOT_PATH/one-time-sed" &&
> test_must_fail git -C local fetch 2>err &&
>
> - grep "ERR unknown ref refs/heads/raster" err
> + grep "fatal: remote error: unknown ref refs/heads/raster" err
> '
>
> stop_httpd
> diff --git a/transport.c b/transport.c
> index 5a74b609f..12db4251c 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -273,7 +273,8 @@ static struct ref *handshake(struct transport *transport,
> int for_push,
>
> packet_reader_init(&reader, data->fd[0], NULL, 0,
> PACKET_READ_CHOMP_NEWLINE |
> -PACKET_READ_GENTLE_ON_EOF);
> +PACKET_READ_GENTLE_ON_EOF |
> +PACKET_READ_DIE_ON_ERR_PACKET);
>
> data->version = discover_version(&reader);
> switch (data->version) {
> diff --git a/upload-pack.c b/upload-pack.c
> index 1638825ee..08b547cf0 100644
> --- a/upload-pack.c
> +++ b/upload-pack.c
> @@ -1078,7 +1078,9 @@ void upload_pack(struct upload_pack_options *options)
> if (options->advertise_refs)
> return;
>
> - packet_reader_init(&reader, 0, NULL, 0, PACKET_READ_CHOMP_NEWLINE);
> + packet_reader_init(&reader, 0, NULL, 0,
> +PACKET_READ_CHOMP_NEWLINE |
> +PACKET_READ_DIE_ON_ERR_PACKET);
>
> receive_needs(&reader, &want_obj);
> if (want_obj.nr) {
> --
> 2.20.1.415.g653613c723-goog
>
This all looks good to me.
Reviewed-by: Josh Steadmon
ocol-v2.txt
* Noted specific suffixes that receivers SHOULD accept
Josh Steadmon (1):
filter-options: Expand abbreviated numbers
Documentation/technical/protocol-v2.txt | 8 +++-
builtin/clone.c | 6 +-
builtin/fetch.c
n, to allow for more compatibility between server
implementations.
Signed-off-by: Josh Steadmon
---
Documentation/technical/protocol-v2.txt | 8 +++-
builtin/clone.c | 6 +-
builtin/fetch.c | 7 ++-
fetch-pack.c
On 2019.01.09 13:23, SZEDER Gábor wrote:
> On Mon, Jan 07, 2019 at 04:17:09PM -0800, Josh Steadmon wrote:
> > diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c
> > index 5285e7674d..9efb3e9902 100644
> > --- a/list-objects-filter-options.c
> >
&deepen_not, &shallows, want_obj))
> + &deepen_not, deepen_relative, &shallows,
> + want_obj))
> packet_flush(1);
> object_array_clear(&shallows);
> }
> @@ -1398,6 +1410,7 @@ static void send_shallow_info(struct upload_pack_data
> *data,
>
> if (!send_shallow_list(data->depth, data->deepen_rev_list,
> data->deepen_since, &data->deepen_not,
> +data->deepen_relative,
> &data->shallows, want_obj) &&
> is_repository_shallow(the_repository))
> deepen(INFINITE_DEPTH, data->deepen_relative, &data->shallows,
> --
> 2.19.0.271.gfe8321ec05.dirty
>
Looks good to me.
Reviewed-by: Josh Steadmon
On 2019.01.12 11:57, SZEDER Gábor wrote:
> On Thu, Dec 13, 2018 at 11:43:57AM -0800, Josh Steadmon wrote:
> > diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh
> > index 5fe21db99f..a1b5a75882 100755
> > --- a/t/t5318-commit-graph.sh
> > +++ b/t/t5318-com
that would be duplicated by the caller.
Adds fuzz-commit-graph.c, which provides a fuzzing entry point
compatible with libFuzzer (and possibly other fuzzing engines).
Signed-off-by: Josh Steadmon
---
.gitignore | 1 +
Makefile| 1 +
commit-graph.c | 53
fuzz-commit-graph identified a case where Git will read past the end of
a buffer containing a commit graph if the graph's header has an
incorrect chunk count. A simple bounds check in parse_commit_graph()
prevents this.
Signed-off-by: Josh Steadmon
---
commit-graph.c
Signed-off-by: Josh Steadmon
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 6b72f37c29..bbcfc2bc9f 100644
--- a/Makefile
+++ b/Makefile
@@ -3104,7 +3104,7 @@ cover_db_html: cover_db
# An example command to build against libFuzzer from
est functions.
Josh Steadmon (3):
commit-graph, fuzz: Add fuzzer for commit-graph
commit-graph: fix buffer read-overflow
Makefile: correct example fuzz build
Josh Steadmon (3):
commit-graph, fuzz: Add fuzzer for commit-graph
commit-graph: fix buffer read-overflow
Makefile: correct
On 2019.01.15 12:39, Junio C Hamano wrote:
> Josh Steadmon writes:
>
> > Signed-off-by: Josh Steadmon
> > ---
> > Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 6b72f37c29
fuzz-commit-graph identified a case where Git will read past the end of
a buffer containing a commit graph if the graph's header has an
incorrect chunk count. A simple bounds check in parse_commit_graph()
prevents this.
Signed-off-by: Josh Steadmon
---
commit-graph.c
pointer arithmetic overflow when checking the graph's chunk
count.
* Merge the corrupt_graph_and_verify and
corrupt_and_zero_graph_then_verify test functions.
Josh Steadmon (3):
commit-graph, fuzz: Add fuzzer for commit-graph
commit-graph: fix buffer read-overflow
Makefile: correct
ag is only applied to the fuzzers themselves. Switching back to
CFLAGS fixes the issue.
Signed-off-by: Josh Steadmon
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 6b72f37c29..bbcfc2bc9f 100644
--- a/Makefile
+++ b/Makefile
@@ -3104
that would be duplicated by the caller.
Adds fuzz-commit-graph.c, which provides a fuzzing entry point
compatible with libFuzzer (and possibly other fuzzing engines).
Signed-off-by: Josh Steadmon
---
.gitignore | 1 +
Makefile| 1 +
commit-graph.c | 53
On 2019.01.25 14:19, SZEDER Gábor wrote:
> On Tue, Jan 22, 2019 at 01:22:12PM -0800, Jeff Hostetler via GitGitGadget
> wrote:
> > From: Jeff Hostetler
> >
> > Created design document for Trace2 feature.
> >
> > Signed-off-by: Jeff Hostetler
> > ---
> > Documentation/technical/api-trace2.txt |
On 2019.01.22 13:22, Jeff Hostetler via GitGitGadget wrote:
> This patch series contains a greatly refactored version of my original
> Trace2 series [1] from August 2018.
>
> A new design doc in Documentation/technical/api-trace2.txt (in the first
> commit) explains the relationship of Trace2 to t
On 2019.01.24 13:51, Derrick Stolee via GitGitGadget wrote:
> From: Derrick Stolee
>
> In an environment where the multi-pack-index is useful, it is due
> to many pack-files and an inability to repack the object store
> into a single pack-file. However, it is likely that many of these
> pack-file
On 2019.01.24 13:51, Derrick Stolee via GitGitGadget wrote:
> The multi-pack-index provides a fast way to find an object among a large
> list of pack-files. It stores a single pack-reference for each object id, so
> duplicate objects are ignored. Among a list of pack-files storing the same
> object
One quick comment:
On 2019.03.28 06:31, Jeff Hostetler via GitGitGadget wrote:
[...]
> diff --git a/trace2.h b/trace2.h
> index 8f89e70c44..cda8349058 100644
> --- a/trace2.h
> +++ b/trace2.h
> @@ -38,7 +38,8 @@ void trace2_initialize_clock(void);
>
> /*
> * Initialize TRACE2 tracing facility
On 2019.03.29 10:04, Jeff Hostetler via GitGitGadget wrote:
[...]
> diff --git a/Documentation/technical/api-trace2.txt
> b/Documentation/technical/api-trace2.txt
> index baaa1153bb..13ca595c69 100644
> --- a/Documentation/technical/api-trace2.txt
> +++ b/Documentation/technical/api-trace2.txt
> @
eate mode 100644 trace2/tr2_sysenv.h
>
>
> base-commit: 041f5ea1cf987a4068ef5f39ba0a09be85952064
> Published-As:
> https://github.com/gitgitgadget/git/releases/tag/pr-169%2Fjeffhostetler%2Fcore-tr2-startup-and-sysenv-v2
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/g
objects referred to by any
wanted refs. For partial clones, just check that these objects were
transferred.
Signed-off-by: Josh Steadmon
---
builtin/clone.c | 6 --
connected.c | 15 +++
connected.h | 8
3 files changed, 27 insertions(+), 2 deletions(-)
diff --git
On 2019.04.03 13:57, Jonathan Tan wrote:
> > On Wed, Apr 03, 2019 at 10:27:21AM -0700, Josh Steadmon wrote:
> >
> > > For partial clones, doing a full connectivity check is wasteful; we skip
> > > promisor objects (which, for a partial clone, is all known objects)
jects)
during the actual graph walk.
Remove the mark_uninteresting() function as it's not used anywhere else.
Helped-By: Jonathan Tan
Helped-By: Jeff King
Helped-By: Jonathan Nieder
Signed-off-by: Josh Steadmon
---
Re-implemented following Jonathan & Jeff's advice (and also
On 2019.04.04 19:08, Jeff King wrote:
> On Thu, Apr 04, 2019 at 03:53:56PM -0700, Josh Steadmon wrote:
>
> > For large repositories, enumerating the list of all promisor objects (in
> > order to exclude them from a rev-list walk) can take a significant
> > amount of time).
On 2019.04.04 20:00, Jeff King wrote:
> On Thu, Apr 04, 2019 at 04:47:26PM -0700, Josh Steadmon wrote:
>
> > > Did you (or anybody else) have any thoughts on the case where a given
> > > object is referred to both by a promisor and a non-promisor (and we
> > > don
On 2019.04.04 17:09, Josh Steadmon wrote:
> On 2019.04.04 20:00, Jeff King wrote:
> > On Thu, Apr 04, 2019 at 04:47:26PM -0700, Josh Steadmon wrote:
> >
> > > > Did you (or anybody else) have any thoughts on the case where a given
> > > > object is r
Helped-By: Jonathan Tan
Helped-By: Jeff King
Helped-By: Jonathan Nieder
Signed-off-by: Josh Steadmon
Signed-off-by: Josh Steadmon
---
Changes since V2:
* Pulled the "OK to skip?" logic into a separate function.
Changes since V1:
* Switched to alternate approach, we now do the r
On 2019.04.08 13:28, Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason writes:
>
> > unique (AFAICT "actually unique" in practice) in the parallel in-flight
> > jh/trace2-sid-fix
> > (https://public-inbox.org/git/4352952677a11776a18ec9b6862cf358307cfafd.1553879063.git.gitgitgad...@gmail.com/)
> >
>
On 2019.04.09 00:23, Christian Couder wrote:
> On Mon, Apr 8, 2019 at 11:46 PM Josh Steadmon wrote:
> >
> > Helped-By: Jonathan Tan
> > Helped-By: Jeff King
> > Helped-By: Jonathan Nieder
> > Signed-off-by: Josh Steadmon
> >
> > Signed-off-by: Jo
On 2019.04.10 00:43, Junio C Hamano wrote:
> Jeff King writes:
>
> > On Wed, Apr 10, 2019 at 12:14:41AM +0900, Junio C Hamano wrote:
> >
> >> I've dealt with the stray double-sign-off locally, but is there
> >> anything else planned for v4 or later? Is this performance-only
> >> change, or does
On 2019.04.09 20:04, SZEDER Gábor wrote:
> On Mon, Apr 08, 2019 at 02:06:04PM -0700, Josh Steadmon wrote:
> > For large repositories, enumerating the list of all promisor objects (in
> > order to exclude them from a rev-list walk) can take a significant
> > amount of time).
&g
On 2019.04.11 11:32, Emily Shaffer via GitGitGadget wrote:
> RFC. I am still working on adding a section on handling refs and objects.
>
> A tutorial for beginners explaining how to commit to git/git from clone to
> push. This tutorial attempts to explain the GitGitGadget workflow; with the
> revi
On 2019.04.11 00:06, Jeff King wrote:
> On Tue, Apr 09, 2019 at 04:42:55PM -0700, Josh Steadmon wrote:
>
> > > warning: reflog of 'HEAD' references pruned commits
> > > warning: reflog of 'refs/heads/master' references
On 2019.04.17 14:40, Junio C Hamano wrote:
> Jeff King writes:
>
> >> I do not personally think, as the design of v2 stands, a standalone
> >> "serve" server that "can serve anything as long as it goes over
> >> protocol v2" makes much sense, but perhaps those who have been doing
> >> the v2 work
On 2019.04.13 01:34, Jeff King wrote:
> On Fri, Apr 12, 2019 at 03:38:47PM -0700, Josh Steadmon wrote:
>
> > > > Thank you for catching this. I haven't yet figured out the cause. I will
> > > > look into this more tomorrow and then send a V4 once I've f
that we get the objects referred to by any
wanted refs. For partial clones, just check that these objects were
transferred.
Signed-off-by: Josh Steadmon
---
This is an update of the original V1 approach (skipping the fully
connectivity check when doing a partial clone) with updated commit
message
Fix trace2_data_json_fl() to check for the presence of pfn_data_json_fl
in its targets, rather than pfn_data_fl, which is not actually called.
Signed-off-by: Josh Steadmon
---
trace2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/trace2.c b/trace2.c
index 8bbad56887
On 2019.04.25 19:15, Junio C Hamano wrote:
> * js/partial-clone-connectivity-check (2019-04-21) 1 commit
> (merged to 'next' on 2019-04-25 at ebd8b4bffd)
> + clone: do faster object check for partial clones
>
> During an initial "git clone --depth=..." partial clone, it is
> pointless to spen
Just a couple typo fixes listed below:
On 2019.04.23 12:34, Emily Shaffer wrote:
[snip]
> +=== Implementation
> +
> +It's probably useful to do at least something besides printing out a string.
> +Let's start by having a look at everything we get.
> +
> +Modify your `cmd_psuh` implementation to d
On 2019.05.01 22:52, Jeff King wrote:
> On Thu, Apr 25, 2019 at 03:16:57PM -0700, Josh Steadmon wrote:
>
> > On 2019.04.25 19:15, Junio C Hamano wrote:
> > > * js/partial-clone-connectivity-check (2019-04-21) 1 commit
> > > (merged to 'next' on 2019
Free the commit graph when verify_commit_graph_lite() reports an error.
Credit to OSS-Fuzz for finding this leak.
Signed-off-by: Josh Steadmon
---
commit-graph.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/commit-graph.c b/commit-graph.c
index 66865acbd7..4bce70d35c
On 2019.05.07 18:30, Jeff King wrote:
> Just as we instruct Apache to pass through ASAN_OPTIONS (so that
> server-side Git programs it spawns will respect our options while
> running the tests), we should do the same with LSAN_OPTIONS. Otherwise
> trying to collect a list of leaks like:
>
> ex
On 2019.05.09 07:22, Derrick Stolee via GitGitGadget wrote:
> This series replaces ds/commit-graph-file-v2, and I'm using the same
> gitgitgadget PR to continue the version numbers and hopefully make that
> clear. This is a slight modification on patches 1-11 from the incremental
> file format RFC
Correct the api-trace2 documentation, which lists "signal" as an
expected field for the signal event type, but which actually outputs
"signo" as the field name.
Signed-off-by: Josh Steadmon
---
Documentation/technical/api-trace2.txt | 2 +-
1 file changed, 1 insertion(+),
-schema.org/
Josh Steadmon (3):
trace2: correct trace2 field name documentation
trace2: Add a JSON schema for trace2 events
trace2: add a schema validator for trace2 events
Documentation/technical/api-trace2.txt| 2 +-
t/trace_schema_validator/.gitignore | 1 +
t
]:
https://json-schema.org/understanding-json-schema/reference/combining.html#allof
Signed-off-by: Josh Steadmon
---
t/trace_schema_validator/event_schema.json | 398 +++
t/trace_schema_validator/strict_schema.json | 511
2 files changed, 909 insertions(+)
create
-off-by: Josh Steadmon
---
t/trace_schema_validator/.gitignore | 1 +
t/trace_schema_validator/Makefile | 10 +++
.../trace_schema_validator.go | 74 +++
3 files changed, 85 insertions(+)
create mode 100644 t/trace_schema_validator/.gitignore
On 2019.06.12 15:28, Ævar Arnfjörð Bjarmason wrote:
>
> On Wed, Jun 12 2019, Josh Steadmon wrote:
>
> > trace_schema_validator can be used to verify that trace2 event output
> > conforms to the expectations set by the API documentation and codified
> > in event_schema.
On 2019.06.12 11:00, Junio C Hamano wrote:
> Josh Steadmon writes:
>
> > Correct the api-trace2 documentation, which lists "signal" as an
> > expected field for the signal event type, but which actually outputs
> > "signo" as the field name.
>
On 2019.06.14 11:59, Jeff Hostetler wrote:
>
>
> On 6/11/2019 7:31 PM, Josh Steadmon wrote:
> > Define a JSON schema[1] that can be used to validate trace2 event
> > objects. This can be used to add regression tests to verify that the
> > event output format d
On 2019.06.12 15:18, Jeff King wrote:
> On Wed, Jun 12, 2019 at 09:23:41AM -0700, Josh Steadmon wrote:
>
> > The problem with the existing validators is that they expect each file to
> > be a
> > complete JSON entity, whereas the trace output is one object per line. Yo
ince V1 of this series:
* dropped the documenation fix, as it can be submitted separately from
this series
* added JSON-array versions of the schema (currently unused)
* added the validation test to the CI suite
Josh Steadmon (3):
trace2: Add a JSON schema for trace2 events
trace2: add a schema
Signed-off-by: Josh Steadmon
---
ci/run-build-and-tests.sh | 5 +
1 file changed, 5 insertions(+)
diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh
index cdd2913440..0707c90549 100755
--- a/ci/run-build-and-tests.sh
+++ b/ci/run-build-and-tests.sh
@@ -14,6 +14,8 @@ make
]:
https://json-schema.org/understanding-json-schema/reference/combining.html#allof
Signed-off-by: Josh Steadmon
---
t/trace_schema_validator/README | 23 +
t/trace_schema_validator/event_schema.json| 398 ++
t/trace_schema_validator/list_schema.json | 401
-off-by: Josh Steadmon
---
t/trace_schema_validator/.gitignore | 1 +
t/trace_schema_validator/Makefile | 10 +++
.../trace_schema_validator.go | 78 +++
3 files changed, 89 insertions(+)
create mode 100644 t/trace_schema_validator/.gitignore
Correct the api-trace2 documentation, which lists "signal" as an
expected field for the signal event type, but which actually outputs
"signo" as the field name.
Signed-off-by: Josh Steadmon
---
This patch has been split off from the "Add a JSON Schema for trace2
events&q
On 2019.06.20 14:06, Emily Shaffer wrote:
> On Wed, Jun 19, 2019 at 08:17:29AM -0700, Junio C Hamano wrote:
> > Emily Shaffer writes:
> >
> > > Maybe there's a case for storing them as a set of patch files that are
> > > revision-controlled somewhere within Documentation/? There was some
> > > di
through
git-submodule and git-submodule--helper.
Signed-off-by: Josh Steadmon
---
builtin/clone.c| 9 +++
builtin/submodule--helper.c| 41 +-
git-submodule.sh | 17 -
t/t5617-clone-submodules-remote.sh | 19
(or any
other commit).
[js: addressed review comments:
* clarified that hook should write messages to stderr
* only discard the index if the hook is actually present
]
Signed-off-by: Michael J Gruber
Signed-off-by: Josh Steadmon
---
Documentation/githooks.txt| 7
by: Michael J Gruber
Signed-off-by: Josh Steadmon
---
Documentation/git-merge.txt | 2 +-
Documentation/merge-options.txt | 4
builtin/merge.c | 6 +++---
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/Documentation/git-merge.txt b/Documentation/git-merge.
ned-off-by: Josh Steadmon
---
...> t7503-pre-commit-and-pre-merge-hooks.sh} | 66 ++-
1 file changed, 65 insertions(+), 1 deletion(-)
rename t/{t7503-pre-commit-hook.sh => t7503-pre-commit-and-pre-merge-hooks.sh}
(67%)
diff --git a/t/t7503-pre-commit-hook.sh
b/t/t7503-pr
commit to 2/4.]
Signed-off-by: Michael J Gruber
Signed-off-by: Josh Steadmon
---
Documentation/githooks.txt | 2 +-
builtin/merge.c| 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt
index dcc6606d44..6a93478
I would like to revive discussion on this series; I have addressed most
of the review comments on the original series sent by Michael, with the
following exceptions:
* Martin's objection on 1/4 that the sample hook would always exit
successfully is (I believe) incorrect. To test this, I ran
"/
(I'm resending this cover letter with fixed Message-Id so that threading
@ public-inbox works properly. Sorry for the noise.)
I would like to revive discussion on this series; I have addressed most
of the review comments on the original series sent by Michael, with the
following exceptions:
* Mar
On 2019.07.10 20:32, Jakub Narebski wrote:
> Josh Steadmon writes:
>
> > Define a JSON schema[1] that can be used to validate trace2 event
> > objects. This can be used to add regression tests to verify that the
> > event output format does not change unexpectedly.
>
Thanks for the review, replies are inline below.
On 2019.07.11 15:35, Jakub Narebski wrote:
> Josh Steadmon writes:
>
> > trace_schema_validator can be used to verify that trace2 event output
> > conforms to the expectations set by the API documentation and codified
> >
Signed-off-by: Josh Steadmon
---
ci/run-build-and-tests.sh | 6 ++
1 file changed, 6 insertions(+)
diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh
index cdd2913440..ec38bf379a 100755
--- a/ci/run-build-and-tests.sh
+++ b/ci/run-build-and-tests.sh
@@ -14,6 +14,8 @@ make
-schema/reference/combining.html#allof
Signed-off-by: Josh Steadmon
---
t/trace_schema_validator/README | 23 +
t/trace_schema_validator/event_schema.json| 398 ++
t/trace_schema_validator/list_schema.json | 401 ++
.../strict_list_schema.json
ropped the documenation fix, as it can be submitted separately from
this series
* added JSON-array versions of the schema (currently unused)
* added the validation test to the CI suite
Josh Steadmon (3):
trace2: Add a JSON schema for trace2 events
trace2: add a schema validator for trace2 e
-off-by: Josh Steadmon
---
t/trace_schema_validator/.gitignore | 1 +
t/trace_schema_validator/Makefile | 18
.../trace_schema_validator.go | 82 +++
3 files changed, 101 insertions(+)
create mode 100644 t/trace_schema_validator/.gitignore
On 2019.07.01 13:19, Emily Shaffer wrote:
> Existing documentation on revision walks seems to be primarily intended
> as a reference for those already familiar with the procedure. This
> tutorial attempts to give an entry-level guide to a couple of bare-bones
> revision walks so that new Git contri
1 - 100 of 253 matches
Mail list logo
