Re: [PATCH] xdiff: reduce indent heuristic overhead

2018-06-29 Thread Jun Wu
Excerpts from Stefan Beller's message of 2018-06-29 16:37:41 -0700: > [...] > Jun, Junio > > By changing the authorship we'd want to have a sign off from the original > author, > before applying; in the previous attempt, I was merely taking the code from > mercurial as their copy of xdiff is

Re: [PATCH] xdiff: improve trimming preprocessing

2018-03-06 Thread Jun Wu
Excerpts from Junio C Hamano's message of 2018-03-06 11:29:44 -0800: > Eric Sunshine <sunsh...@sunshineco.com> writes: > > > On Tue, Mar 6, 2018 at 6:53 AM, Jun Wu <qu...@fb.com> wrote: > >> xdiff-interface trims common suffix if ctxlen is 0. Teach it to also

Re: [PATCH] xdiff: improve trimming preprocessing

2018-03-06 Thread Jun Wu
Excerpts from Eric Sunshine's message of 2018-03-06 14:23:46 -0500: > On Tue, Mar 6, 2018 at 6:53 AM, Jun Wu <qu...@fb.com> wrote: > > + printf "x%.0s" {1..934} >>d # pad common suffix to 1024 bytes > > The expression {x..y} is not portable to non-POSI

[PATCH] xdiff: improve trimming preprocessing

2018-03-06 Thread Jun Wu
ave visible overhead. [1]: https://phab.mercurial-scm.org/D2686 Signed-off-by: Jun Wu <qu...@fb.com> --- t/t4066-diff-trimming.sh | 49 +++ xdiff-interface.c| 60 +--- xdiff/xdiff.h| 3 +++ xdiff