[PATCH] Fix condition for redirecting stderr

hen stderr is not being used for logging. Signed-off-by: Lucas Werkmeister --- Notes: I have to apologize to the list here… even though I proposed this option with the goal of using it on my server, for some reason I decided to only use it there after the next Git release had come

Re: [PATCH] Fix condition for redirecting stderr

On 09.04.2018 04:23, Todd Zullinger wrote: > Lucas Werkmeister wrote: >> Since the --log-destination option was added in 0c591cacb ("daemon: add >> --log-destination=(stderr|syslog|none)", 2018-02-04) with the explicit >> goal of allowing logging to stderr when r

[PATCH] daemon: add --no-syslog to undo implicit --syslog

the message to the correct systemd unit. See systemd/systemd#2913 [1]. [1]: https://github.com/systemd/systemd/issues/2913 Signed-off-by: Lucas Werkmeister --- Notes: I decided not to add the option to git-daemon's --help output, since the similar --no-informative-errors option is

Re: [PATCH] daemon: add --no-syslog to undo implicit --syslog

tderr clobbers regular output. (Also, stderr is apparently closed with --detach, see below.) On 23.01.2018 19:30, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> On Mon, Jan 22 2018, Lucas Werkmeister jotted: >> >>> Several options imply --syslog, with

Re: [PATCH] daemon: add --no-syslog to undo implicit --syslog

On 23.01.2018 23:06, Lucas Werkmeister wrote: > Ah, I wasn’t aware of that – so with --detach, --no-syslog would be > better described as “disables all logging” rather than “log to stderr > instead”. IMHO it would still make sense to have the --no-syslog option > (then mainly for use

Re: [PATCH] daemon: add --no-syslog to undo implicit --syslog

On 24.01.2018 19:33, Junio C Hamano wrote: > Lucas Werkmeister writes: > >>> Moreover, --detach completely dissociates the process from the >>> original set of standard file descriptors by first closing them and >>> then connecting it to "/dev/null",

Re: [PATCH 2/6] t/lib-git-daemon: record daemon log

On 25.01.2018 01:55, Jeff King wrote: > When we start git-daemon for our tests, we send its stderr > log stream to a named pipe. We synchronously read the first > line to make sure that the daemon started, and then dump the > rest to descriptor 4. This is handy for debugging test > output with "--v

[PATCH v2] daemon: add --send-log-to=(stderr|syslog|none)

unit is associated with this stream. [1]: https://github.com/systemd/systemd/issues/2913 Signed-off-by: Lucas Werkmeister Helped-by: Ævar Arnfjörð Bjarmason Helped-by: Junio C Hamano --- Notes: This was originally “daemon: add --no-syslog to undo implicit --syslog”, but Junio pointed

Re: [PATCH v2] daemon: add --send-log-to=(stderr|syslog|none)

On 28.01.2018 07:40, Eric Sunshine wrote: > On Sat, Jan 27, 2018 at 1:31 PM, Lucas Werkmeister > wrote: >> This makes it possible to use --inetd while still logging to standard >> error. --syslog is retained as an alias for --send-log-to=syslog. A mode >> to disable lo

[PATCH v3] daemon: add --log-destination=(stderr|syslog|none)

: Eric Sunshine Signed-off-by: Lucas Werkmeister --- Notes: Next version on my quest to make git-daemon logging more reliable :) many thanks to Eric Sunshine for review. Main changes this version: - Rename --send-log-to to --log-destination, following the postgresql option

Re: contrib/completion/git-completion.bash: declare -g is not portable

On 04.02.2018 10:57, Eric Sunshine wrote: > On Sun, Feb 4, 2018 at 4:45 AM, Duy Nguyen wrote: >> On Sun, Feb 4, 2018 at 12:20 AM, Torsten Bögershausen wrote: >>> After running t9902-completion.sh on Mac OS I got a failure >>> in this style: >> >> Sorry I was new with this bash thingy. Jeff alread

Re: [PATCH v3] daemon: add --log-destination=(stderr|syslog|none)

On 04.02.2018 07:36, Eric Sunshine wrote: > On Sat, Feb 3, 2018 at 6:08 PM, Lucas Werkmeister > wrote: >> This new option can be used to override the implicit --syslog of >> --inetd, or to disable all logging. (While --detach also implies >> --syslog, --log-destination

[PATCH v4] daemon: add --log-destination=(stderr|syslog|none)

: Eric Sunshine Signed-off-by: Lucas Werkmeister --- Notes: Fixes log_destination not being initialized correctly and some minor style issues. Documentation/git-daemon.txt | 28 --- daemon.c | 46 +--- 2

Re: [PATCH v4] daemon: add --log-destination=(stderr|syslog|none)

On 04.02.2018 19:55, Ævar Arnfjörð Bjarmason wrote: > > On Sun, Feb 04 2018, Lucas Werkmeister jotted: > >> [--inetd | >>[--listen=] [--port=] >>[--user= [--group=]]] >> + [--log-destination=(stderr|syslog|none)] > &