[PATCH] Updated C# userdiff patterns.

2014-04-25 Thread Marius Ungureanu
t can happen inline in code to mention blocks which are unsafe. Also, delegates are not necessarily declared in class bodies, but can also happen inline in other functions. Keywords are based on MSDN docs. Signed-off-by: Marius Ungureanu --- userdiff.c | 12 ++-- 1 file changed, 6 inser

Re: [PATCH] Updated C# userdiff patterns.

2014-04-26 Thread Marius Ungureanu
On 26 Apr 2014, at 10:10, Johannes Sixt wrote: > Am 26.04.2014 01:25, schrieb Marius Ungureanu: >> New keywords: foreach, break, in, try, finally, as, is, typeof, var, >> default, fixed, checked, unchecked, this, lock, readonly, unsafe, >> ref, out, base, nul

Re: [PATCH] Updated C# userdiff patterns.

2014-04-26 Thread Marius Ungureanu
On a side note, I noticed some of the keywords I added shouldn’t be there. I just realised that simple statements have no reason to be there, but only block definitions. I’ll reduce the size of this patch on the keywords part. Thanks, Marius-- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH] Updated C# userdiff patterns.

2014-04-26 Thread Marius Ungureanu
On 26 Apr 2014, at 20:49, Johannes Sixt wrote: > Am 26.04.2014 11:55, schrieb Marius Ungureanu: >> On 26 Apr 2014, at 10:10, Johannes Sixt wrote: >>> Am 26.04.2014 01:25, schrieb Marius Ungureanu: >>>> diff --git a/userdiff.c b/userdiff.c >>>> index fad

Re: [PATCH] Updated C# userdiff patterns.

2014-04-27 Thread Marius Ungureanu
On 26 Apr 2014, at 21:50, Johannes Sixt wrote: > Am 26.04.2014 20:33, schrieb Marius Ungureanu: >> ... add as many unit tests I can. > > Great! Keep in mind that quantity is secondary. Quality counts. Obviously. By ‘as many’, I meant to cover all the cases here. >> I’

Re: [PATCH] Updated C# userdiff patterns.

2014-04-27 Thread Marius Ungureanu
Heya, so I’ll add the patches in the next 2 emails. I’ve changed a bit the main body of the methods/constructors regex. Basically, I’ve made the first item after the modifiers optional. That’s the return type and it’s not used in any case by operator overloads or constructors/destructors. I also

Re: [PATCH 1/2] update C# userdiff patterns

2014-04-27 Thread Marius Ungureanu
Remove all keywords since they don't cause conflicts. Add method modifiers: abstract, async, explicit, extern, implicit, partial, operator. Add properties modifiers: abstract, readonly. Add type modifiers: abstract. Parse C# operator functions. Fix constructor parsing. Signed-off-by: M

Re: [PATCH 2/2] add csharp userdiff tests

2014-04-27 Thread Marius Ungureanu
--- t/t4018/csharp-constructor | 4 t/t4018/csharp-destructor | 4 t/t4018/csharp-function| 4 t/t4018/csharp-member | 4 t/t4018/csharp-namespace | 4 t/t4018/csharp-operator| 4 t/t4018/csharp-property| 4 t/t4018/csharp-skip-call | 5 +++

Re: [PATCH 2/2] add csharp userdiff tests

2014-04-27 Thread Marius Ungureanu
Ugh, there’s an empty line at the beginning of the 2nd patch that shouldn’t be there. Thanks, Marius-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] add csharp userdiff tests

2014-04-27 Thread Marius Ungureanu
On 27 Apr 2014, at 19:19, Johannes Sixt wrote: > Am 27.04.2014 15:47, schrieb Marius Ungureanu: >> >> --- > > Thanks. Please signed off your patch. > Ah, yes, forgot to do that. > When you re-send, please place [PATCH v3 n/m] in the subject (and drop > the &q

Re: [PATCH 2/2] add csharp userdiff tests

2014-04-27 Thread Marius Ungureanu
> You can mark a userdiff test case that demonstrates a breakage by > including the work "broken" somewhere in the file. See > http://www.repo.or.cz/w/alt-git.git/commitdiff/9cc444f0570b196f1c51664ce2de1d8e1dee6046 > -- Hannes Would you like me to add tests first, then fix them? Or just like this