Re: [PATCH] Drop some dashes from built-in invocations in scripts

2017-08-05 Thread Michael Forney
On 8/5/17, Junio C Hamano wrote: > Have you made sure that all of these scripts, before calling > 'git-foo' in the current code, update their PATH so that these found > in the bog standard place (i.e. GIT_EXEC_PATH)? > > The reason I ask is because we can rest assured these

Re: [PATCH] Drop some dashes from built-in invocations in scripts

2017-08-05 Thread Michael Forney
On 8/5/17, Junio C Hamano <gits...@pobox.com> wrote: > Michael Forney <mfor...@mforney.org> writes: >> On 8/5/17, Junio C Hamano <gits...@pobox.com> wrote: >>> Have you made sure that all of these scripts, before calling >>> 'git-foo' in the curren

[PATCH] Drop some dashes from built-in invocations in scripts

2017-08-05 Thread Michael Forney
This way, they still work even if the built-in symlinks aren't installed. Signed-off-by: Michael Forney <mfor...@mforney.org> --- It looks like there was an effort to do this a number of years ago (through `make remove-dashes`). These are just a few I noticed were still left in the .sh s

Re: [PATCH] Drop some dashes from built-in invocations in scripts

2017-08-07 Thread Michael Forney
On 8/7/17, Junio C Hamano wrote: > Just to avoid possible confusion, the above is not to say "once it > is decided, you are not allowed to bring fresh arguments to the > discussion". As Peff said [*2*] in that old discussion thread, the > circumstances may have changed over 9

Confusing behavior with ignored submodules and `git commit -a`

2018-03-16 Thread Michael Forney
o.txt 1 file changed, 1 insertion(+), 1 deletion(-) $ git show commit 6ec564c15ddae099c71f01750b4c434557525653 (HEAD -> master) Author: Michael Forney <mfor...@mforney.org> Date: Fri Mar 16 20:18:37 2018 -0700 update foo.txt diff --git a/foo.txt b/foo.txt index d00491f..0cfbf08 100644 ---

Re: Confusing behavior with ignored submodules and `git commit -a`

2018-10-25 Thread Michael Forney
On 2018-03-16, Michael Forney wrote: > Hi, > > In the past few months have noticed some confusing behavior with > ignored submodules. I finally got around to bisecting this to commit > 5556808690ea245708fb80383be5c1afee2fb3eb (add, reset: ensure > submodules can be added o

Re: Confusing behavior with ignored submodules and `git commit -a`

2018-11-15 Thread Michael Forney
On 2018-11-15, Stefan Beller wrote: > On Wed, Nov 14, 2018 at 10:05 PM Michael Forney > wrote: >> Looking at ff6f1f564c, I don't really see anything that might be >> related to git-add, git-reset, or git-diff, so I'm guessing that this >> only worked before because the

Re: Confusing behavior with ignored submodules and `git commit -a`

2018-11-15 Thread Michael Forney
On 2018-11-15, Michael Forney wrote: > Here is a work-in-progress diff that seems to have the correct > behavior in all cases I tried. I was hoping that gmail wouldn't mess with the whitespace, but apparently it has, sorry about that. Let me try again. --- builtin/add.c | 1 - diff

Re: Confusing behavior with ignored submodules and `git commit -a`

2018-11-15 Thread Michael Forney
On 2018-11-15, Stefan Beller wrote: > On Thu, Nov 15, 2018 at 1:33 PM Michael Forney wrote: >> Well, currently the submodule config can be disabled in diff_flags by >> setting override_submodule_config=1. However, I'm thinking it may be >> simpler to selectively *enable*

Re: Confusing behavior with ignored submodules and `git commit -a`

2018-11-14 Thread Michael Forney
+bmwill On 2018-11-14, Michael Forney wrote: > On 2018-10-25, Stefan Beller wrote: >> I guess reverting that commit is not a good idea now, as >> I would expect something to break. >> >> Maybe looking through the series 614ea03a71 >> (Merge branch 'bw/subm

Re: Confusing behavior with ignored submodules and `git commit -a`

2018-11-14 Thread Michael Forney
On 2018-10-25, Stefan Beller wrote: > On Thu, Oct 25, 2018 at 11:03 AM Michael Forney > wrote: >> >> On 2018-03-16, Michael Forney wrote: >> > Hi, >> > >> > In the past few months have noticed some confusing behavior with >> > ignored submod