[PATCH 2/2] bisect--helper: `check_expected_revs` shell function in C

2016-06-08 Thread Pranit Bauva
implementation, we can safely delete the shell implementation. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 21 ++

[PATCH 1/2] bisect--helper: `is_expected_rev` shell function in C

2016-06-08 Thread Pranit Bauva
amily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- This applies on the previous patches. builtin/bisect--helper.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 4153e8a..06bc9b8 100644 --

Re: [PATCH 1/4] bisect--helper: `bisect_clean_state` shell function in C

2016-06-08 Thread Pranit Bauva
ote: >>> On Wed, Jun 8, 2016 at 3:46 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >>>> On Wed, Jun 8, 2016 at 4:01 AM, Eric Sunshine <sunsh...@sunshineco.com> >>>> wrote: >>>>> On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva <pranit.ba

Re: [PATCH 4/4] bisect--helper: `bisect_reset` shell function in C

2016-06-08 Thread Pranit Bauva
Hey Eric, On Wed, Jun 8, 2016 at 11:23 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Wed, Jun 8, 2016 at 9:20 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> On Wed, Jun 8, 2016 at 1:29 PM, Eric Sunshine <sunsh...@sunshineco.com> >> wrote: >>&

Re: [PATCH v2] builtin/commit.c: memoize git-path for COMMIT_EDITMSG

2016-06-09 Thread Pranit Bauva
Hey Jeff, On Thu, Jun 9, 2016 at 12:28 PM, Jeff King <p...@peff.net> wrote: > On Tue, Jun 07, 2016 at 08:25:17PM +0530, Pranit Bauva wrote: > >> On Wed, May 25, 2016 at 12:49 AM, Pranit Bauva <pranit.ba...@gmail.com> >> wrote: >> > This is a follow up commi

Re: [PATCH 4/4] bisect--helper: `bisect_reset` shell function in C

2016-06-08 Thread Pranit Bauva
Hey Eric, On Wed, Jun 8, 2016 at 1:29 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Reimplement `bisect_reset` shell function in C and add a `--bisect-reset` >> subcommand to `

Re: [PATCH 3/4] dir: introduce file_size() to check the size of file

2016-06-08 Thread Pranit Bauva
Hey Torsten, On Wed, Jun 8, 2016 at 1:47 PM, Torsten Bögershausen <tbo...@web.de> wrote: > On 06/08/2016 09:57 AM, Pranit Bauva wrote: >> >> Hey Eric, >> >> On Wed, Jun 8, 2016 at 1:07 PM, Eric Sunshine <sunsh...@sunshineco.com> >> wrote: >>

Re: [PATCH 2/4] t6030: explicitly test for bisection cleanup

2016-06-08 Thread Pranit Bauva
Hey Eric, On Wed, Jun 8, 2016 at 4:51 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> This is not an improvement in the test coverage but it helps in making >> it explicit as to what

Re: [PATCH 1/4] bisect--helper: `bisect_clean_state` shell function in C

2016-06-08 Thread Pranit Bauva
Hey Eric, On Wed, Jun 8, 2016 at 4:01 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Reimplement `bisect_clean_state` shell function in C and add a >> `bisect-clean-state` subcom

Re: [PATCH 3/4] dir: introduce file_size() to check the size of file

2016-06-08 Thread Pranit Bauva
Hey Eric, On Wed, Jun 8, 2016 at 1:07 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> dir: introduce file_size() to check the size of file >> >> At times we require to see if t

Re: [PATCH 1/4] bisect--helper: `bisect_clean_state` shell function in C

2016-06-08 Thread Pranit Bauva
Hey Eric, On Wed, Jun 8, 2016 at 1:32 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Wed, Jun 8, 2016 at 3:46 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> On Wed, Jun 8, 2016 at 4:01 AM, Eric Sunshine <sunsh...@sunshineco.com> >> wrote: >>&

[PATCH 4/4] bisect--helper: `bisect_reset` shell function in C

2016-06-07 Thread Pranit Bauva
istian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 51 +++- git-bisect.sh| 28 ++ 2 files changed, 52 insertions(+), 27 deletions(-) di

[PATCH 2/4] t6030: explicitly test for bisection cleanup

2016-06-07 Thread Pranit Bauva
; Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- I faced this problem while converting `bisect_clean_state` and the tests where showing breakages but it wasn't clear as to where exactly are they breaking. This will patch will help in that. Also I tested the test coverage of the

[PATCH 3/4] dir: introduce file_size() to check the size of file

2016-06-07 Thread Pranit Bauva
amily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- dir.c | 8 dir.h | 7 +++ 2 files changed, 15 insertions(+) diff --git a/dir.c b/dir.c index 6172b34..eaee718 100644 --- a/dir.c +++ b/dir.c @@ -2036,6 +2036,14 @@ int file_exists(const char *f) retu

[PATCH 1/4] bisect--helper: `bisect_clean_state` shell function in C

2016-06-07 Thread Pranit Bauva
, this subcommand will be retired and will be called by bisect_reset() and bisect_start(). Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bis

Re: [PATCH 2/4] t6030: explicitly test for bisection cleanup

2016-06-08 Thread Pranit Bauva
Hey Eric, On Wed, Jun 8, 2016 at 1:47 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Wed, Jun 8, 2016 at 4:07 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> On Wed, Jun 8, 2016 at 4:51 AM, Eric Sunshine <sunsh...@sunshineco.com> >> wrote: >>&

Re: [PATCH v4 37/38] i18n: unmark die messages for translation

2016-06-08 Thread Pranit Bauva
"Please call 'bisect_state' with at least one >> argument.")" ;; >> + die "Please call 'bisect_state' with at least one argument." ;; > > OK. This should have had "bug:" prefix from the beginning, but that > is outside the topic

Re: [PATCH v2] builtin/commit.c: memoize git-path for COMMIT_EDITMSG

2016-06-07 Thread Pranit Bauva
On Wed, May 25, 2016 at 12:49 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: > This is a follow up commit for f932729c (memoize common git-path > "constant" files, 10-Aug-2015). > > The many function calls to git_path() are replaced by > git_path_commit_edit

Re: [PATCH] Document the 'svn propset' command.

2016-06-13 Thread Pranit Bauva
=%H' for the file > +'devel/py-tipper/Makefile'. > + > 'show-externals':: > Shows the Subversion externals. Use -r/--revision to specify a > specific revision. Regards, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/4] dir: introduce file_size() to check the size of file

2016-06-13 Thread Pranit Bauva
ame, ) < 0) > + return 0; > + return xsize_t(st.st_size); > +} > > Or, more git-ish: > > size_t file_size(const char *filename) > +{ > + struct stat st; > + if (stat(filename, )) > + return 0; > + return xsize

Re: [PATCH 1/2] bisect--helper: `is_expected_rev` shell function in C

2016-06-10 Thread Pranit Bauva
Hey Eric, On Fri, Jun 10, 2016 at 3:03 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Wed, Jun 8, 2016 at 11:24 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Reimplement `is_expected_rev` shell function in C. This will further be >> called from `ch

Re: [PATCH] Fix spelling of "occurred"

2016-06-10 Thread Pranit Bauva
ling mistake in config.c and refs.h . Our translators take care of everything else. Thanks for your contribution. Regards, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] bisect--helper: `check_expected_revs` shell function in C

2016-06-10 Thread Pranit Bauva
Hey Eric, On Fri, Jun 10, 2016 at 3:24 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Wed, Jun 8, 2016 at 11:24 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Reimplement the `check_expected_revs` shell function in C and add a >> `--check-expected-revs

Re: [PATCH v8 2/3] bisect: rewrite `check_term_format` shell function in C

2016-05-24 Thread Pranit Bauva
Hey Johannes, On Wed, May 25, 2016 at 10:34 AM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi Pranit, > > I think this patch series is now in a fine shape. Just one minor nit: Thanks! > On Tue, 24 May 2016, Pranit Bauva wrote: > >> + OPT_CM

[GSOC Update] Week 6

2016-06-13 Thread Pranit Bauva
t/pull/13 [4]: https://github.com/pranitbauva1997/git/pull/14 [5]: http://thread.gmane.org/gmane.comp.version-control.git/295524 Regards, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH 1/2] bisect--helper: `is_expected_rev` shell function in C

2016-06-11 Thread Pranit Bauva
Hey Eric, On Sat, Jun 11, 2016 at 12:44 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Fri, Jun 10, 2016 at 9:39 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> On Fri, Jun 10, 2016 at 3:03 AM, Eric Sunshine <sunsh...@sunshineco.com> >> wrote: &g

Re: [PATCH] Document the 'svn propset' command.

2016-06-13 Thread Pranit Bauva
Hey Alfred, On Mon, Jun 13, 2016 at 7:54 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: > Hey Alfred, > > On Mon, Jun 13, 2016 at 6:22 PM, Alfred Perlstein <alf...@freebsd.org> wrote: >> Thank you Pranit. I thought that "signed off by" is used once so

Re: [PATCH] Document the 'svn propset' command.

2016-06-13 Thread Pranit Bauva
e end : Signed-off-by: Alfred Perlstein <alf...@freebsd.org> Though I will still recommend you to go through [1] properly. Regards, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] strbuf: describe the return value of strbuf_read_file()

2016-06-13 Thread Pranit Bauva
ill re-roll with specifying about negative values as errors. Regards, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2] strbuf: describe the return value of strbuf_read_file

2016-06-14 Thread Pranit Bauva
Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- strbuf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/strbuf.h b/strbuf.h index 7987405..83c5c98 100

[PATCH] strbuf: describe the return value of strbuf_read_file()

2016-06-13 Thread Pranit Bauva
Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- It is easy to be misguided on the return value of the function strbuf_read_file(). It does follow the pattern

[GSOC Update] Week 5

2016-06-06 Thread Pranit Bauva
7 [3]: https://github.com/pranitbauva1997/git/pull/13 [4]: https://github.com/pranitbauva1997/git/pull/10 [5]: http://thread.gmane.org/gmane.comp.version-control.git/295524 [6]: https://github.com/pranitbauva1997/git/pull/11 Regards, Pranit Bauva -- To unsubscribe from this list: send the line &quo

Re: [RFC/PATCH] bisect--helper: `bisect_clean_state` shell function in C

2016-05-31 Thread Pranit Bauva
Hey Christian, On Tue, May 31, 2016 at 3:18 AM, Christian Couder <christian.cou...@gmail.com> wrote: > On Mon, May 30, 2016 at 8:21 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> --- >> This patch contains a bug. I have tried to identify the bug

Re: [RFC/PATCH] bisect--helper: `bisect_clean_state` shell function in C

2016-05-31 Thread Pranit Bauva
Hey Michael, On Tue, May 31, 2016 at 9:55 AM, Michael Haggerty <mhag...@alum.mit.edu> wrote: > On 05/30/2016 08:21 PM, Pranit Bauva wrote: >> Reimplement `bisect_clean_state` shell function in C and add a >> `bisect-clean-state` subcommand to `git bisect--helper` to call it

Re: [PATCH] t6030: explicitly test for bisection cleanup

2016-05-27 Thread Pranit Bauva
Hey Christian, On Sat, May 28, 2016 at 12:30 AM, Christian Couder <christian.cou...@gmail.com> wrote: > On Fri, May 27, 2016 at 7:57 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> >> Anyone any comments? > > Maybe you could add this patch to, or squash

Re: [PATCH] t6030: explicitly test for bisection cleanup

2016-05-27 Thread Pranit Bauva
On Fri, May 13, 2016 at 3:44 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: > This is not an improvement in the test coverage but it helps in making > it explicit as to know what exactly is the error as other tests are > focussed on testing other things but they do

Re: [RFC/PATCH 1/2] log: add "log.showsignature" configuration variable

2016-05-26 Thread Pranit Bauva
config > automatically unset the config variable, which is necessary. Or you could probably use 'git -c' which makes it all the more compact. Regards, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[RFC/PATCH] bisect--helper: `bisect_clean_state` shell function in C

2016-05-30 Thread Pranit Bauva
, this subcommand will be retired and will be called by bisect_reset() and bisect_start(). Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- This patch contains a

[GSOC Update] Week 2

2016-05-29 Thread Pranit Bauva
bisect_write(). I plan to convert this function and add it as a subcommand. * Convert bisect_reset() and add it as a subcommand. * Convert get_terms() and add the variables TERM_GOOD and TERM_BAD in a struct in the global state. Regards, Pranit Bauva -- To unsubscribe from this list: s

Re: [GSOC Update] Week 2

2016-05-29 Thread Pranit Bauva
On Mon, May 30, 2016 at 11:07 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: > = SUMMARY == > My public git.git is available here[1]. I regularly keep pushing my work so > anyone interested can track me t

[PATCH v2 0/6] convert various shell functions in git-bisect to C

2016-06-15 Thread Pranit Bauva
. In this series I have tried to output error wherever possible. What are your views? [1]: http://thread.gmane.org/gmane.comp.version-control.git/296717 Pranit Bauva (6): bisect--helper: `bisect_clean_state` shell function in C t6030: explicitly test for bisection cleanup wrapper: move is_empty_file

[PATCH v2 3/6] wrapper: move is_empty_file() from builtin/am.c

2016-06-15 Thread Pranit Bauva
ppropriate boolean value is returned. Suggested-by: Torsten Bögershausen <tbo...@web.de> Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/am.c | 16 -

[PATCH v2 2/6] t6030: explicitly test for bisection cleanup

2016-06-15 Thread Pranit Bauva
; Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- I faced this problem while converting `bisect_clean_state` and the tests where showing breakages but it wasn't clear as to where exactly are they breaking. This will patch will help in that. Also I tested the test coverage of the

[PATCH v2 1/6] bisect--helper: `bisect_clean_state` shell function in C

2016-06-15 Thread Pranit Bauva
are ported, this subcommand will be retired and will be called by bisect_reset() and bisect_start(). Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bis

[PATCH v2 5/6] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C

2016-06-15 Thread Pranit Bauva
ting test suite. As more functions are ported, this subcommand would be retired and will be called by some other method. Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org>

[PATCH v2 4/6] bisect--helper: `bisect_reset` shell function in C

2016-06-15 Thread Pranit Bauva
istian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 48 +++- git-bisect.sh| 28 ++-- 2 files changed, 49 insertions(+), 27 deletions(-) di

[PATCH v2 6/6] bisect--helper: `bisect_write` shell function in C

2016-06-15 Thread Pranit Bauva
and make the method use the two variables from the global scope within the C code. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bis

Re: [PATCH v2 3/6] wrapper: move is_empty_file() from builtin/am.c

2016-06-15 Thread Pranit Bauva
Hey Junio, On Wed, Jun 15, 2016 at 11:42 PM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> diff --git a/builtin/am.c b/builtin/am.c >> index 3dfe70b..84f21d0 100644 >> --- a/builtin/am.c >> +++ b/built

Re: [PATCH v2 0/6] convert various shell functions in git-bisect to C

2016-06-15 Thread Pranit Bauva
Hey Eric, On Wed, Jun 15, 2016 at 11:23 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Wed, Jun 15, 2016 at 10:00 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Changes wrt previous version: >> * Use STRING_LIST_INIT_NODUP to avoid leaks in bis

Re: [PATCH v2 3/6] wrapper: move is_empty_file() from builtin/am.c

2016-06-15 Thread Pranit Bauva
Hey Eric, On Wed, Jun 15, 2016 at 11:52 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Wed, Jun 15, 2016 at 10:00 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> is_empty_file() can help to refactor a lot of code. Also it is quite >> helpful while convert

Re: [PATCH v2 1/6] bisect--helper: `bisect_clean_state` shell function in C

2016-06-15 Thread Pranit Bauva
Hey Eric, On Wed, Jun 15, 2016 at 11:34 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Wed, Jun 15, 2016 at 10:00 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Reimplement `bisect_clean_state` shell function in C and add a >> `bisect-clean-state` subcom

Re: [PATCH v2 5/6] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C

2016-06-17 Thread Pranit Bauva
Hey Christian, On Fri, Jun 17, 2016 at 2:17 AM, Christian Couder <christian.cou...@gmail.com> wrote: > On Thu, Jun 16, 2016 at 9:25 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Hey Eric, >> >> On Fri, Jun 17, 2016 at 12:46 AM, Eric Sunshine <sunsh...@s

Re: [PATCH v8 2/3] bisect: rewrite `check_term_format` shell function in C

2016-06-17 Thread Pranit Bauva
Hey Lars, Hope you enjoyed your vacations. :) On Thu, Jun 16, 2016 at 12:40 PM, Lars Schneider <larsxschnei...@gmail.com> wrote: > > On 24 May 2016, at 09:21, Pranit Bauva <pranit.ba...@gmail.com> wrote: > >> Reimplement the `check_term_format` shell function in C

Re: What's cooking in git.git (Jun 2016, #05; Thu, 16)

2016-06-17 Thread Pranit Bauva
he gcov rather than setting up a coverage tool for shell scripts. [1]: http://thread.gmane.org/gmane.comp.version-control.git/295518 Regards, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[RFC/PATCH] bisect--helper: `check_and_set_terms` shell function in C

2016-06-17 Thread Pranit Bauva
. Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- Collecting reviews. This patch is based on my previous series. I will also include this the next time I reroll the

[GSOC Update] Week 7

2016-06-20 Thread Pranit Bauva
my mid term evaluations this week. Hope I clear it successfully. [1]: https://github.com/pranitbauva1997/git [2]: http://thread.gmane.org/gmane.comp.version-control.git/297520 [3]: https://github.com/pranitbauva1997/git/pull/17 [4]: http://thread.gmane.org/gmane.comp.version-control.git/297266 Reg

Re: [PATCH v2 4/6] bisect--helper: `bisect_reset` shell function in C

2016-06-16 Thread Pranit Bauva
Hey Eric, On Thu, Jun 16, 2016 at 2:35 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Wed, Jun 15, 2016 at 10:00 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Reimplement `bisect_reset` shell function in C and add a `--bisect-reset` >> subcommand to `

Re: [PATCH v2 6/6] bisect--helper: `bisect_write` shell function in C

2016-06-16 Thread Pranit Bauva
Hey Eric, On Fri, Jun 17, 2016 at 12:25 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Wed, Jun 15, 2016 at 10:00 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Reimplement the `bisect_write` shell function in C and add a >> `bisect-write` subcommand to `

Re: [PATCH v2 5/6] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C

2016-06-16 Thread Pranit Bauva
Hey Eric, On Thu, Jun 16, 2016 at 2:44 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Wed, Jun 15, 2016 at 10:00 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Reimplement `is_expected_rev` & `check_expected_revs` shell function in >> C and add a `--

Re: [PATCH v2 5/6] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C

2016-06-16 Thread Pranit Bauva
Hey Eric, On Fri, Jun 17, 2016 at 12:46 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Thu, Jun 16, 2016 at 3:05 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> On Thu, Jun 16, 2016 at 2:44 AM, Eric Sunshine <sunsh...@sunshineco.com> >> wrote: >

Re: [PATCH v2 6/6] bisect--helper: `bisect_write` shell function in C

2016-06-17 Thread Pranit Bauva
Hey Christian, On Fri, Jun 17, 2016 at 2:08 AM, Christian Couder <christian.cou...@gmail.com> wrote: > On Thu, Jun 16, 2016 at 9:01 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Hey Eric, >> >> On Fri, Jun 17, 2016 at 12:25 AM, Eric Sunshine <sunsh...@s

[PATCH v3 6/6] bisect--helper: `bisect_write` shell function in C

2016-06-26 Thread Pranit Bauva
; Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 99 git-bisect.sh| 25 ++-- 2 files changed, 96 insertions(+), 28 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--help

[PATCH v3 4/6] bisect--helper: `bisect_reset` shell function in C

2016-06-26 Thread Pranit Bauva
istian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 47 ++- git-bisect.sh| 28 ++-- 2 files changed, 48 insertions(+), 27 deletions(-) di

[PATCH v3 3/6] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file()

2016-06-26 Thread Pranit Bauva
is_empty_file() can help to refactor a lot of code. This will be very helpful in porting "git bisect" to C. Suggested-by: Torsten Bögershausen <tbo...@web.de> Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org>

[PATCH v3 0/6] convert various shell functions in git-bisect to C

2016-06-26 Thread Pranit Bauva
36a3eeb..e70e4d1 100644 --- a/wrapper.c +++ b/wrapper.c @@ -697,14 +697,14 @@ void sleep_millisec(int millisec) poll(NULL, 0, millisec); } -int is_empty_file(const char *filename) +int is_empty_or_missing_file(const char *filename) { struct stat st; if (stat(file

[PATCH v3 1/6] bisect--helper: `bisect_clean_state` shell function in C

2016-06-26 Thread Pranit Bauva
are ported, this subcommand will be retired and will be called by bisect_reset() and bisect_start(). Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bis

[PATCH v3 2/6] t6030: explicitly test for bisection cleanup

2016-06-26 Thread Pranit Bauva
; Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- I faced this problem while converting `bisect_clean_state` and the tests where showing breakages but it wasn't clear as to where exactly are they breaking. This will patch will help in that. Also I tested the test coverage of the

[PATCH v3 5/6] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C

2016-06-26 Thread Pranit Bauva
ting test suite. As more functions are ported, this subcommand would be retired and will be called by some other method. Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Mentored-by: Lars Schneider <larsxschnei...@gmail.com> Mentored-by: Christian Couder <chrisc...@tuxfamily.org>

[RFC/PATCH 1/3] bisect--helper: `check_and_set_terms` shell function in C

2016-06-26 Thread Pranit Bauva
and allocate new memory for it thus flushing out the previous contents. Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- This series applies on top of my previous patch series[1]. [1]: http://thread.gmane.org/gmane.

[RFC/PATCH 2/3] bisect--helper: `bisect_next_check` shell function in C

2016-06-26 Thread Pranit Bauva
, this subcommand will be retired and will be called by some other methods. bisect_voc() is removed as it is redundant and does not serve any useful purpose. We are better off specifying "bad|new" "good|old" as and when we require in bisect_next_check(). Signed-off-by: Pra

[RFC/PATCH 3/3] bisect--helper: `get_terms` & `bisect_terms` shell function in C

2016-06-26 Thread Pranit Bauva
are ported, this subcommand will be retired and will be called by some other methods. Mentored-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- builtin/bisect--helper.c | 49 +++- g

[GSOC Update] Week 8

2016-06-27 Thread Pranit Bauva
279 Regards, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] SubmittingPatches : WIP tag in patches

2016-02-26 Thread Pranit Bauva
Eric Sunshine: > On Fri, Feb 26, 2016 at 9:05 AM, Pranit Bauva <pranit.ba...@zoho.com> wrote: >> --- > > Missing sign-off. > I have to inoculate the habit of signing off every time. >> diff --git a/Documentation/SubmittingPatches >> @@ -168,7 +168,9 @@ th

Re: [PATCH/RFC] git-commit: add a commit.verbose config variable

2016-02-25 Thread Pranit Bauva
at --verbose or --no-verbose may > have set before? Yes, this was the problem. I have fixed it now. But there is a glitch. See below. Eric Sunshine: > On Thu, Feb 25, 2016 at 9:57 PM, Pranit Bauva <pranit.ba...@zoho.com> wrote: >> From c273a02fc9cab9305cedf6e37422e257a1cc3b1e M

[PATCH] SubmittingPatches : WIP tag in patches

2016-02-25 Thread Pranit Bauva
--- Documentation/SubmittingPatches | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 98fc4cc..b2c7664 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -168,7 +168,9

[PATCH/RFC] git-commit: add a commit.verbose config variable

2016-02-25 Thread Pranit Bauva
>From c273a02fc9cab9305cedf6e37422e257a1cc3b1e Mon Sep 17 00:00:00 2001 From: Pranit Bauva <pranit.ba...@zoho.com> Date: Fri, 26 Feb 2016 07:14:18 +0530 Subject: [PATCH/RFC] git-commit: add a commit.verbose config variable Since many people always run the command with this option,

[PATCH/RFC v3] add a commit.verbose config variable

2016-03-10 Thread Pranit Bauva
Since many people always run the command with this option, it would be preferrable to specify it in the configuration file instead of passing the option with `git commit` again and again. Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- Documentation/config.txt

Re: [PATCH/RFC v3] add a commit.verbose config variable

2016-03-10 Thread Pranit Bauva
git_status_config instead of cmd_commit I have to yet figure out how to write the tests for this. I will see the examples that Matthieu Moy mentioned for their implementation. Regards, Pranit Bauva, IIT Kharagpur -- To unsubscribe from this list: send the line "unsubscribe git" in the body of

Re: [PATCH v4] commit: add a commit.verbose config variable

2016-03-10 Thread Pranit Bauva
version are : - put the code in git_commit_config() instead of git_status_config() - Add test to cover all possible scenarios Regards, Pranit Bauva IIT Kharagpur -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majo

[PATCH v4] commit: add a commit.verbose config variable

2016-03-10 Thread Pranit Bauva
Since many people always run the command with this option, it would be preferrable to specify it in the configuration file instead of passing the option with `git commit` again and again. Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- Documentation/config.txt

[PATCH] t/t7502-commit.sh : remove a repeated test

2016-03-10 Thread Pranit Bauva
This extra test was introducted in the commit f9c01817 Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- t/t7502-commit.sh | 5 - 1 file changed, 5 deletions(-) diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh index b39e313..725687d 100755 --- a/t/t7502-commit.sh +++ b/t

Re: [PATCH v4] commit: add a commit.verbose config variable

2016-03-10 Thread Pranit Bauva
> + if (!strcmp(k, "commit.verbose")){ > v3 did this line correctly but you somehow lost the SP between > "){". What happened? I will include the SP between )) and { . > Don't you need a test that status is not broken when the variable is > set? I will include the test for status too. But

Re: [PATCH/RFC v3] add a commit.verbose config variable

2016-03-10 Thread Pranit Bauva
I figured it out, It first runs status_init_config(). I might have thought "status" as status of the options and thus I may have edited there. On Fri, Mar 11, 2016 at 3:08 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: > On Fri, Mar 11, 2016 at 3:04 AM, Junio C Hamano

Re: [PATCH] t/t7502-commit.sh : remove a repeated test

2016-03-10 Thread Pranit Bauva
On Fri, Mar 11, 2016 at 4:51 AM, Eric Sunshine wrote: >> t/t7502-commit.sh : remove a repeated test > > Or: > > t7502: drop duplicate test > Sure! >> This extra test was introducted in the commit f9c01817 > > We normally add some parenthetical context when

Re: [PATCH v4] commit: add a commit.verbose config variable

2016-03-10 Thread Pranit Bauva
On Fri, Mar 11, 2016 at 4:31 AM, Eric Sunshine wrote: > Add commit.verbose configuration variable as a convenience > for those who always prefer --verbose. > > or something. Sure! > As a convenience to reviewers, please use this area below the "---" > line to

[PATCH v2] t/t7502 : drop duplicate test

2016-03-10 Thread Pranit Bauva
This extra test was introduced erroneously by f9c0181 (t7502: test commit.status, --status and --no-status, 2010-01-13) Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- t/t7502-commit.sh | 5 - 1 file changed, 5 deletions(-) diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh

Re: Gsoc 16

2016-03-15 Thread Pranit Bauva
Hey, Open Source projects run because of people who contribute in their free time (mainly). It might not be possible for someone to be active all times Sometimes it may take around 2-3 days. Give it a little more time. On Wed, Mar 16, 2016 at 2:30 AM, Saurabh Jain

Re: [PATCH v7] commit: add a commit.verbose config variable

2016-03-15 Thread Pranit Bauva
On Wed, Mar 16, 2016 at 2:46 AM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> ... But then I am still not convinced for the >> requirement of another variable `opt-verbose` as I believe that the >> `verbose` a

Re: [PATCH v7] commit: add a commit.verbose config variable

2016-03-15 Thread Pranit Bauva
On Wed, Mar 16, 2016 at 1:54 AM, Junio C Hamano <gits...@pobox.com> wrote: > Pranit Bauva <pranit.ba...@gmail.com> writes: > >> First one to introduce a new variable `config_verbose` to store the >> value read by the config. Till then the value of verbose can be set &

Re: [PATCH v7] commit: add a commit.verbose config variable

2016-03-15 Thread Pranit Bauva
On Wed, Mar 16, 2016 at 12:54 AM, Eric Sunshine wrote: >> As Eric Sunshine mentioned ($gmane.org/288811), it would react >> according to the multiple verbosity level and since its not currently >> defined in `commit` it will react as it is reacting when verbosity >> level

Re: [PATCH/RFC] parse-options.c: make OPTION__COUNTUP consider negative values

2016-03-18 Thread Pranit Bauva
On Thu, Mar 17, 2016 at 12:58 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Wed, Mar 16, 2016 at 9:50 PM, Jeff King <p...@peff.net> wrote: >> On Wed, Mar 16, 2016 at 11:16:58PM +, Pranit Bauva wrote: >>> The reason to make it consider negati

[PATCH/RFC] parse-options.c: make OPTION__COUNTUP consider negative values

2016-03-19 Thread Pranit Bauva
ption have multiple levels of that option. Eg. : initialize verbose = -1 `git commit` => verbose = -1 `git commit -v` => verbose = 1 `git commit -v -v` => verbose = 1 `git commit --no-verbose` => verbose = 0 Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- The disc

Re: [PATCH v4] commit: add a commit.verbose config variable

2016-03-11 Thread Pranit Bauva
On Fri, Mar 11, 2016 at 11:14 AM, Eric Sunshine wrote: > It's a bit tricky if you're not used to it, but check-for-diff > actually does what you want, and does so in a more direct way. While > it's true that it's not an "editor" per se, it does get access to the > entire

Re: [PATCH v5] commit: add a commit.verbose config variable

2016-03-14 Thread Pranit Bauva
On Mon, Mar 14, 2016 at 1:54 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Sat, Mar 12, 2016 at 1:41 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >> Add commit.verbose configuration variable as a convenience for those >> who always prefer --verbose. >&g

[PATCH v6] commit: add a commit.verbose config variable

2016-03-14 Thread Pranit Bauva
Add commit.verbose configuration variable as a convenience for those who always prefer --verbose. Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- The previous versions of this patch are: - [v5] $gmane/288728 - [v4] $

[PATCH v7] commit: add a commit.verbose config variable

2016-03-14 Thread Pranit Bauva
Add commit.verbose configuration variable as a convenience for those who always prefer --verbose. Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- The previous versions of this patch are: - [v6] $gmane/288811 - [v5] $

Re: [PATCH] add a commit.verbose config variable

2016-03-09 Thread Pranit Bauva
the patch together but I could not find the test examples that could be used from the existing code base. If someone has an idea in mind then I could probably write the tests. Though I have tested this personally for all the cases but I think it would be preferable to automate the j

[PATCH] add a commit.verbose config variable

2016-03-09 Thread Pranit Bauva
file. Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- Documentation/config.txt | 4 Documentation/git-commit.txt | 7 ++- builtin/commit.c | 7 +++ 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/Documentation/config.txt b/Documentation/conf

[PATCH v5] commit: add a commit.verbose config variable

2016-03-11 Thread Pranit Bauva
Add commit.verbose configuration variable as a convenience for those who always prefer --verbose. Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> Mentored-by: Eric Sunshine <sunsh...@sunshineco.com> --- The previous versions of this patch are: - [v4] $gmane/288652 - [v3] $

[PATCH v8 2/2] commit: add a commit.verbose config variable

2016-03-19 Thread Pranit Bauva
Add commit.verbose configuration variable as a convenience for those who always prefer --verbose. Helped-by: Junio C Hamano <gits...@pobox.com> Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com> --- The previous ve

  1   2   3   4   5   6   >