Re: [PATCH 4/5] safe_create_leading_directories(): fix a mkdir/rmdir race

2013-12-22 Thread Ramsay Jones
); } else { retval = -1; } ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 23/23] compat/mingw.h: Fix the MinGW and msvc builds

2013-12-28 Thread Ramsay Jones
On 28/12/13 10:00, Jeff King wrote: On Wed, Dec 25, 2013 at 11:08:57PM +0100, Erik Faye-Lund wrote: On Sat, Dec 21, 2013 at 3:00 PM, Jeff King p...@peff.net wrote: From: Ramsay Jones ram...@ramsay1.demon.co.uk Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk Signed-off-by: Junio C

[PATCH 1/2] send-pack.c: mark a file-local function static

2014-01-05 Thread Ramsay Jones
Commit f2c681cf (send-pack: support pushing from a shallow clone via http, 05-12-2013) adds the 'advertise_shallow_grafts_buf' function as an external symbol. Noticed by sparse. ('advertise_shallow_grafts_buf' was not declared. Should it be static?) Signed-off-by: Ramsay Jones ram...@ramsay1

[PATCH 2/2] shallow: Remove unused code

2014-01-05 Thread Ramsay Jones
algorithm. However, this function has no callers. (The commented out call sites would need to change, in order to provide information required by the function.) Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Junio, This should, perhaps, be marked as RFC; if the patch to actually use

Re: [PATCH] .gitignore: Ignore editor backup and swap files

2014-01-16 Thread Ramsay Jones
core.excludesfile. ;-) ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH/RFC] Makefile: Fix compilation of windows resource file

2014-01-20 Thread Ramsay Jones
. Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Junio, This patch is marked RFC because, as I was just about to send this email, I realized it wouldn't always work: $ touch git.rc $ make V=1 GIT_VERSION=1.9.dirty git.res windres -O coff \ -DMAJOR=1 -DMINOR=9

Re: [PATCH/RFC] Makefile: Fix compilation of windows resource file

2014-01-21 Thread Ramsay Jones
On 21/01/14 21:36, Junio C Hamano wrote: Junio C Hamano gits...@pobox.com writes: Ramsay Jones ram...@ramsay1.demon.co.uk writes: If the git version number consists of less than three period separated numbers, then the windows resource file compilation issues a syntax error: $ touch

Re: [PATCH v6 00/11] Add interpret-trailers builtin

2014-03-05 Thread Ramsay Jones
into the implementation file. Noticed by sparse ('process_trailers' was not declared. Should it be static?). Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- trailer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/trailer.c b/trailer.c index b5de616..95d5874 100644 --- a/trailer.c +++ b/trailer.c

Re: [PATCH 1/3] test-lib: Document short options in t/README

2014-03-24 Thread Ramsay Jones
:: +-v,--valgrind=tool:: The -v short option is taken, above ... :-P Execute all Git binaries under valgrind tool tool and exit with status 126 on errors (just like regular tests, this will only stop the test script when running under -i). ATB, Ramsay Jones -- To unsubscribe

Re: What's cooking in git.git (Apr 2014, #01; Fri, 4)

2014-04-07 Thread Ramsay Jones
are worth it? Indeed. I haven't seen any numbers. ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: What's cooking in git.git (Apr 2014, #03; Fri, 11)

2014-04-12 Thread Ramsay Jones
threads 27.75(36.46+1.98) 5302.5: index-pack 4 threads 27.93(37.24+2.82) 5302.6: index-pack 8 threads 29.34(38.23+3.04) 5302.7: index-pack default number of threads 26.25(36.55+1.84) $ HTH ATB, Ramsay Jones -- To unsubscribe from

Re: What's cooking in git.git (Apr 2014, #03; Fri, 11)

2014-04-16 Thread Ramsay Jones
On 16/04/14 00:18, Duy Nguyen wrote: On Tue, Apr 15, 2014 at 11:45 PM, Junio C Hamano gits...@pobox.com wrote: Ramsay Jones ram...@ramsay1.demon.co.uk writes: On 11/04/14 23:22, Junio C Hamano wrote: [...] [New Topics] * nd/index-pack-one-fd-per-thread (2014-04-09) 1 commit - index-pack

split index: sparse warning

2014-04-30 Thread Ramsay Jones
to something like: 690 if (the_index.cache_changed index_lock.fd = 0) { ... but I haven't spent any time investigating this, so take this suggestion which a large pinch of salt! :-P ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message

[PATCH] t6006-*.sh: Fix truncation tests

2014-05-20 Thread Ramsay Jones
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Alexey, If you need to re-roll your 'as/pretty-truncate' branch, could you please squash the relevant parts of this patch into the corresponding patches of your patch series. (ie this is a patch against the head of the current pu

Re: [PATCH] t6006-*.sh: Fix truncation tests

2014-05-20 Thread Ramsay Jones
On 20/05/14 15:19, Alexey Shumkin wrote: On Tue, May 20, 2014 at 02:54:20PM +0100, Ramsay Jones wrote: Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Alexey, If you need to re-roll your 'as/pretty-truncate' branch, could you please squash the relevant parts of this patch

Re: [PATCH] t6006 (rev-list-format): quote format strings to avoid error on some shells

2014-05-20 Thread Ramsay Jones
-by: Alexey Shumkin alex.crez...@gmail.com Suggested-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- t/t6006-rev-list-format.sh | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/t/t6006-rev-list-format.sh b/t/t6006-rev-list-format.sh index c6e9a73..19434ad 100755

Re: [PATCH] t6006-*.sh: Fix truncation tests

2014-05-20 Thread Ramsay Jones
On 20/05/14 17:02, Alexey Shumkin wrote: On Tue, May 20, 2014 at 04:01:22PM +0100, Ramsay Jones wrote: On 20/05/14 15:19, Alexey Shumkin wrote: On Tue, May 20, 2014 at 02:54:20PM +0100, Ramsay Jones wrote: Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Alexey, If you need

[PATCH/RFC] t0000-*.sh: Fix the GIT_SKIP_TESTS sub-tests

2014-05-20 Thread Ramsay Jones
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- The test suite has been failing for me on the pu branch for a while now. I finally found a few minutes to take a look. This failure is specific to the dash shell (/bin/sh) on my system (ie it may well affect other shells, but I haven't

Re: [PATCH/RFC] t0000-*.sh: Fix the GIT_SKIP_TESTS sub-tests

2014-05-20 Thread Ramsay Jones
On 20/05/14 22:40, Jonathan Nieder wrote: Ramsay Jones wrote: --- a/t/t-basic.sh +++ b/t/t-basic.sh @@ -296,8 +296,9 @@ test_expect_success 'test --verbose-only' ' ' test_expect_success 'GIT_SKIP_TESTS' -GIT_SKIP_TESTS='git.2' \ -run_sub_test_lib_test git

Re: [PATCH/RFC] t0000-*.sh: Fix the GIT_SKIP_TESTS sub-tests

2014-05-20 Thread Ramsay Jones
On 20/05/14 23:44, Jonathan Nieder wrote: Hi, Ramsay Jones wrote: On 20/05/14 22:40, Jonathan Nieder wrote: What should happen if I have set GIT_SKIP_TESTS explicitly to run only some of the tests in t-basic? A quick test (with the above patch applied) shows that it works as I

Re: [PATCH v4 4/5] t4205, t6006: Add failing tests for the case when i18n.logOutputEncoding is set

2014-05-21 Thread Ramsay Jones
-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com Reviewed-by: Ramsay Jones ram...@ramsay1.demon.co.uk Hmm, I didn't really review these patches. I simply noted a problem on my system and provided you with an extended bug-report and assisted you in fixing it up. So, if it even warrants a mention

Re: [PATCH v9 3/8] add line number and file name info to `config_set`

2014-08-07 Thread Ramsay Jones
the declaration in config.c until it is needed. (To make it easier to see if it is necessary in the context of the patch which will make use of it). ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v8 0/8] Rewrite `git_config()` using config-set API

2014-08-08 Thread Ramsay Jones
which introduces the struct in cache.h does not make use of that struct in any interface. It *is* an implementation detail of some code in config.c only. I do not know how that structure will be used in future patches. ;-) ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v8 0/8] Rewrite `git_config()` using config-set API

2014-08-11 Thread Ramsay Jones
On 10/08/14 18:29, Junio C Hamano wrote: Ramsay Jones ram...@ramsay1.demon.co.uk writes: On 08/08/14 15:07, Tanay Abhra wrote: ... (cc to Ramsay) The discussion in both threads (v8 and v9), boils down to this, is the `key_value_info` struct really required to be declared public

Re: [ANNOUNCE] Git v2.1.0

2014-08-17 Thread Ramsay Jones
upgraded to Linux Mint 17 since then, so my toolchain may be up to the job now, so perhaps I should build it myself. ;-) ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] Undefine strlcpy if needed.

2014-08-24 Thread Ramsay Jones
on this). ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] bisect: save heap memory. allocate only the required amount

2014-08-24 Thread Ramsay Jones
; HTH ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Undefine strlcpy if needed.

2014-08-24 Thread Ramsay Jones
On 24/08/14 12:13, tsuna wrote: On Sun, Aug 24, 2014 at 4:10 AM, Ramsay Jones ram...@ramsay1.demon.co.uk wrote: Hmm, which version of OS X are we talking about? OS X 10.9.4: $ uname -a Darwin damogran.local 13.3.0 Darwin Kernel Version 13.3.0: Tue Jun 3 21:27:35 PDT 2014; root:xnu

Re: [PATCH] Undefine strlcpy if needed.

2014-08-24 Thread Ramsay Jones
On 24/08/14 22:09, tsuna wrote: On Sun, Aug 24, 2014 at 12:49 PM, Torsten Bögershausen tbo...@web.de wrote: On 2014-08-24 18.18, Ramsay Jones wrote: On 24/08/14 12:13, tsuna wrote: On Sun, Aug 24, 2014 at 4:10 AM, Ramsay Jones ram...@ramsay1.demon.co.uk wrote: Hmm, which version of OS X

Re: [PATCH] Undefine strlcpy if needed.

2014-08-25 Thread Ramsay Jones
On 25/08/14 02:54, tsuna wrote: On Sun, Aug 24, 2014 at 5:32 PM, Ramsay Jones ram...@ramsay1.demon.co.uk wrote: Again, I don't have access to an OS X system, so I don't know which package provides libintl/gettext, but it seems to be missing on your system. Probably yeah, those libraries

Re: [PATCH 1/3] log-tree: make add_name_decoration a public function

2014-08-26 Thread Ramsay Jones
/ format it into a temporary buffer and copy it to the final flex-array). Signed-off-by: Jeff King p...@peff.net ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] bisect: save heap memory. allocate only the required amount

2014-08-26 Thread Ramsay Jones
in these two examples, I'm inclined to give up this line of inquiry. Indeed. :-D ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] bisect: save heap memory. allocate only the required amount

2014-08-26 Thread Ramsay Jones
On 26/08/14 13:14, Jeff King wrote: On Tue, Aug 26, 2014 at 12:57:21PM +0100, Ramsay Jones wrote: + ret = xcalloc(1, base + extra); + va_start(ap, fmt); + vsnprintf(ret + offset, extra, fmt, ap); What is the relationship between 'base' and 'offset'? Let me assume that base

Re: [PATCH] bisect: save heap memory. allocate only the required amount

2014-08-26 Thread Ramsay Jones
On 26/08/14 13:43, Jeff King wrote: On Tue, Aug 26, 2014 at 01:37:44PM +0100, Ramsay Jones wrote: On my 64-bit system using gcc, sizeof() returns 16; it has to pad the whole thing to 64-bit alignment in case I put two of them in an array. But offsetof(name) is 12, since the array of char

Re: [PATCH v3] teach fast-export an --anonymize option

2014-08-28 Thread Ramsay Jones
that the bug is still present? For example, if I anonymized git.git, and did 'git branch -v' (say), how easy would it be for me to recognise which branch was 'next'? ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3 2/2] headers: include dependent headers

2014-09-07 Thread Ramsay Jones
? Unless you also change each '.c' file which includes cache.h to also include git-compat-util.h first, then I suspect (if nothing else) file I/O may be broken. (see _FILE_OFFSET_BITS). Also, see Documentation/CodingGuidelines (lines 331-333). ATB, Ramsay Jones -- To unsubscribe from this list: send

Re: [PATCH v3 2/2] headers: include dependent headers

2014-09-07 Thread Ramsay Jones
On 07/09/14 21:37, David Aguilar wrote: On Sun, Sep 07, 2014 at 12:01:00PM +0100, Ramsay Jones wrote: On 07/09/14 11:35, René Scharfe wrote: Am 07.09.2014 um 11:36 schrieb David Aguilar: Add dependent headers so that including a header does not require including additional headers

t2017 test failure in pu

2014-09-08 Thread Ramsay Jones
within a conditional such that !log_all_ref_updates is true, so that the above can be simplified!) I guess 'create_reflog' should be called 'maybe_create_reflog' :-D HTH ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord

Re: [PATCH 12/16] sha1_file: add for_each iterators for loose and packed objects

2014-10-05 Thread Ramsay Jones
a sparse warning), rather than add an extern declaration to cache.h (which would also suppress sparse). ATB, Ramsay Jones +{ +uint32_t i; +int r = 0; + +for (i = 0; i p-num_objects; i++) { +const unsigned char *sha1 = nth_packed_object_sha1(p, i); + +if (!sha1

[PATCH] revision: remove definition of unused 'add_object' function

2014-10-18 Thread Ramsay Jones
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Jeff, I noticed that your 'jk/prune-mtime' branch removes the last caller of the add_object() function; specifically commit 5f78a431a (reachable: use traverse_commit_list instead of custom walk, 15-10-2014). If you need to re-roll

[PATCH] object: make add_object_array_with_mode a static function

2014-10-18 Thread Ramsay Jones
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Jeff, I noticed that your 'jk/prune-mtime' branch also removes the only call to the add_object_array_with_mode() function outside of the object.c file; specifically commit 75ac69fa (traverse_commit_list: support pending blobs/trees

Re: [PATCH] revision: remove definition of unused 'add_object' function

2014-10-19 Thread Ramsay Jones
On 19/10/14 02:36, Jeff King wrote: On Sat, Oct 18, 2014 at 10:36:12PM +0100, Ramsay Jones wrote: I noticed that your 'jk/prune-mtime' branch removes the last caller of the add_object() function; specifically commit 5f78a431a (reachable: use traverse_commit_list instead of custom walk, 15-10

Re: [PATCH] object: make add_object_array_with_mode a static function

2014-10-19 Thread Ramsay Jones
On 19/10/14 03:03, Jeff King wrote: On Sun, Oct 19, 2014 at 12:19:07AM +0100, Ramsay Jones wrote: [snip] I actually wondered while writing this series whether anyone actually _uses_ the mode in object_array (the new code I added sets it to the appropriate value to be on the safe side

[PATCH] receive-pack.c: mark file local symbols as static

2014-10-23 Thread Ramsay Jones
Commit 8796e182 (receive-pack.c: use a single transaction when atomic-push is negotiated, 21-10-2014) added the 'transaction' and 'err' variables as external symbols. Noticed by sparse. ('err' was not declared. Should it be static?) Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi

[PATCH] dir.c: mark a file local function as static

2014-10-30 Thread Ramsay Jones
Commit b74884b86 (untracked cache: make a wrapper around {open,read,close}dir(), 27-10-2014) added the read_cached_dir() function as an external symbol. Noticed by sparse. ('read_cached_dir' was not declared. Should it be static?). Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi

[PATCH] sparse: suppress an using sizeof on a function warning

2014-11-07 Thread Ramsay Jones
use the same solution used in commit 9371322a6 (sparse: suppress some using sizeof on a function warnings, 06-10-2013) which solved exactly this problem for the other commands using libcurl. Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Bernhard, If you need to re-roll your 'br

Re: [PATCH] git-imap-send: use libcurl for implementation

2014-11-09 Thread Ramsay Jones
. ATB, Ramsay Jones --- Documentation/git-imap-send.txt | 15 +++- INSTALL | 15 ++-- Makefile| 18 +++- imap-send.c | 176 ++-- 4 files changed, 187 insertions(+), 37 deletions

[RFC/PATCH v2 0/1] cygwin: fast stat functions

2013-07-10 Thread Ramsay Jones
. (I don't think so). - Is the 5% slowdown on MinGW a real problem? (are the static inline functions being in-lined?) - I need to double check that I have replaced all relevant lstat() calls. ATB, Ramsay Jones Ramsay Jones (1): cygwin: Add fast_lstat() and fast_fstat

[RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-10 Thread Ramsay Jones
, 924aaf3e, 05bab3ea and 0117c2f0. In order to limit the adverse effects caused by this implementation, we provide a new fast stat interface, which allows us to use this only for interactions with the index (i.e. the cached stat data). Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk

Re: [RFC/PATCH 0/1] cygwin: Remove the Win32 l/stat() functions

2013-07-11 Thread Ramsay Jones
Torsten Bögershausen wrote: On 30.06.13 19:28, Ramsay Jones wrote: [ ... ] You have just described my second patch! :D Unfortunately, I have not had any time to work on the patch this weekend. However, despite the patch being a bit rough around the edges, I decided to send it out (see below

[PATCH] Fix some sparse warnings

2013-07-15 Thread Ramsay Jones
the initialiser expression with '{NULL}'. Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Jeff, If you need to re-roll the patches in your 'jk/in-pack-size-measurement' branch, could you please squash this (or something like it) into the patches equivalent to commit 7c07385d (zero-initialize

[RFC/PATCH] Add the NO_SENTINEL build variable

2013-07-15 Thread Ramsay Jones
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Jeff, One of the three gcc compilers that I use does not understand the sentinel function attribute. (so, it spews 108 warning messages) Is this, or something like it, too ugly for you to squash into your patch? :-D ATB, Ramsay

Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-16 Thread Ramsay Jones
Mark Levedahl wrote: On 07/10/2013 04:23 PM, Ramsay Jones wrote: Commit adbc0b6b (cygwin: Use native Win32 API for stat, 30-09-2008) added a Win32 specific implementation of the stat functions. In order to handle absolute paths, cygwin mount points and symbolic links, this implementation may

Re: [PATCH] Cygwin has trustable filemode

2013-07-16 Thread Ramsay Jones
= UnfortunatelyYes NO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease # There are conflicting reports about this. # On some boxes NO_MMAP is needed, and not so elsewhere. Should you revert commit c869753e (Force core.filemode to false on Cygwin., 30-12-2006) instead? ATB, Ramsay Jones

Re: [PATCH v2 00/19] Index-v5

2013-07-16 Thread Ramsay Jones
twice, with unpredictable results. I wrote a patch to address this at the time (Hmm, seems to be built on v1.8.1), but didn't submit it since your patch didn't progress. :-D I have included the patch below. ATB, Ramsay Jones -- 8 -- From: Ramsay Jones ram...@ramsay1.demon.co.uk Date: Sun, 9 Sep 2012

Re: [RFC/PATCH] Add the NO_SENTINEL build variable

2013-07-18 Thread Ramsay Jones
Jonathan Nieder wrote: Ramsay Jones wrote: One of the three gcc compilers that I use does not understand the sentinel function attribute. (so, it spews 108 warning messages) Do you know what version of gcc introduced the sentinel attribute? Would it make sense for the ifdef in git-compat

[PATCH] Add the GIT_SENTINEL macro

2013-07-18 Thread Ramsay Jones
the sentinel attribute for gcc v4.0 and newer. Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- This was built on the next branch ATB, Ramsay Jones argv-array.h | 2 +- builtin/revert.c | 4 ++-- exec_cmd.h| 2 +- git-compat-util.h | 7 +++ run-command.h | 2 +- 5

[PATCH] Fix some sparse warnings

2013-07-18 Thread Ramsay Jones
the initialiser expression with '{NULL}'. Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- This was built on the next branch. ATB, Ramsay Jones sha1_file.c | 2 +- streaming.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sha1_file.c b/sha1_file.c index 4c2365f..e4ab0a4

Re: [PATCH] t3032 - make compatible with systems using \r\n as a line ending

2013-07-18 Thread Ramsay Jones
SED_STRIPS_CR SED_OPTIONS=-b test_have_prereq MINGW export GREP_OPTIONS=-U which may explain why it works for me on MinGW, but not why it works on cygwin 1.5. ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord

Re: [PATCH] Fix some sparse warnings

2013-07-18 Thread Ramsay Jones
Jeff King wrote: On Tue, Jul 16, 2013 at 07:57:20AM +0200, Johannes Sixt wrote: Am 7/15/2013 19:31, schrieb Ramsay Jones: Sparse issues three Using plain integer as NULL pointer warnings. Each warning relates to the use of an '{0}' initialiser expression in the declaration of an 'struct

Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-18 Thread Ramsay Jones
this only for interactions with the index (i.e. the cached stat data). Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- I've tested this on Cygwin 1.7 on WIndows 7 , comparing to the results using your prior patch (removing the Cygwin specific lstat entirely) and get the same results

Re: t3032 incompatible with Cygwin/Windows

2013-07-18 Thread Ramsay Jones
... # passed all 11 test(s) 1..11 $ ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] test-lib.sh - define and use GREP_STRIPS_CR

2013-07-20 Thread Ramsay Jones
mleved...@gmail.com --- This replaces my earlier patch against t3032 (8896b287 on pu) Yep, this looks good and (as expected) it works on cygwin 1.5 too. :-D Thanks. ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord

Re: [PATCH] Cygwin has trustable filemode

2013-07-20 Thread Ramsay Jones
setting need to change from the current setup. ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC/PATCH] Add the NO_SENTINEL build variable

2013-07-21 Thread Ramsay Jones
Junio C Hamano wrote: Ramsay Jones ram...@ramsay1.demon.co.uk writes: Jonathan Nieder wrote: Ramsay Jones wrote: One of the three gcc compilers that I use does not understand the sentinel function attribute. (so, it spews 108 warning messages) Do you know what version of gcc introduced

Re: [PATCH] Fix some sparse warnings

2013-07-21 Thread Ramsay Jones
Jeff King wrote: On Thu, Jul 18, 2013 at 09:25:50PM +0100, Ramsay Jones wrote: Sparse issues some Using plain integer as NULL pointer warnings. Each warning relates to the use of an '{0}' initialiser expression in the declaration of an 'struct object_info'. The first field of this structure

Re: [PATCH] Add the GIT_SENTINEL macro

2013-07-21 Thread Ramsay Jones
Junio C Hamano wrote: Ramsay Jones ram...@ramsay1.demon.co.uk writes: The sentinel function attribute is not understood by versions of the gcc compiler prior to v4.0. At present, for earlier versions of gcc, the build issues 108 warnings related to the unknown attribute. In order

Re: [PATCH] Cygwin has trustable filemode

2013-07-21 Thread Ramsay Jones
it. ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] test-url-normalize.c: Fix gcc errors and sparse warnings

2013-07-24 Thread Ramsay Jones
: *** [test-url-normalize.o] Error 1 In order to fix the error, we simply protect the use of the 'max_requests' variable with an preprocessor conditional. Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Kyle, When you next update the patches in your 'km/http-curl-config-per-url' branch

Re: What's cooking in git.git (Jul 2013, #07; Sun, 21)

2013-07-24 Thread Ramsay Jones
of this simpler solution. Comments? Me too, thanks to all contributors Thank you for taking the time to help address this issue! ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http

[RFC/PATCH] commit-slab.h: Fix memory allocation and addressing

2013-07-27 Thread Ramsay Jones
physical address. Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Junio, While looking into a sparse warning, which involved the use of the commit-slab.h header file, I noticed some problems with that code. (at least I _think_ I did! ;-) I was convinced, just by reading the code

[PATCH] revision.c: Fix a sparse warning

2013-07-27 Thread Ramsay Jones
Sparse issues an symbol 'saved_parents_slab' was not declared. Should it be static? warning. In order to suppress the warning, since this symbol does not require more than file visibility, we simply add the static modifier to its declaration. Signed-off-by: Ramsay Jones ram...@ramsay1

Re: What's cooking in git.git (Jul 2013, #09; Mon, 29)

2013-07-31 Thread Ramsay Jones
is still very much broken. ATB, Ramsay Jones [1] I do have another patch, patch #0 actually, which I said I didn't want applied! :-P [2] I ran the test suite on v1.8.4-rc0 + 1 patch, like so: $ GIT_SKIP_TESTS='t0061.3' make test test-outp16 21 $ tail -17 test-outp16 [22:33:53] t9902

Re: [PATCH 0/3] git config --get-urlmatch $section.$key $url

2013-07-31 Thread Ramsay Jones
the patch before building the next and pu branches; OK it's not too onerous, but still ... :-P ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: What's cooking in git.git (Jul 2013, #09; Mon, 29)

2013-08-01 Thread Ramsay Jones
Junio C Hamano wrote: Ramsay Jones ram...@ramsay1.demon.co.uk writes: I am personally in favor of this simpler solution. Comments? I had expected this to me marked for 'master'. Has this simply been overlooked, or do you have reservations about applying this patch? I am just being

Re: [PATCH 1/2] submodule: fix confusing variable name

2013-08-09 Thread Ramsay Jones
of the public API, so we can't just remove it. It would require a deprecation period, etc,. (Adding/documenting $sm_path as an alternative *may* be worth doing. dunno.) HTH ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord

Re: [PATCH v3 06/24] read-cache: Don't compare uid, gid and ino on cygwin

2013-08-18 Thread Ramsay Jones
is no longer necessary and can simply be dropped from this series. [I have not had time to read your new patches yet, but I seem to remember being concerned about those platforms which have UNRELIABLE_FSTAT set. (ie cygwin, MinGW and Windows.)] ATB, Ramsay Jones Signed-off-by: Thomas Gummerer

[PATCH] builtin/fetch.c: Fix a sparse warning

2013-08-28 Thread Ramsay Jones
Sparse issues an 'prepare_transport' was not declared. Should it be static? warning. In order to suppress the warning, since this symbol only requires file scope, we simply add the static modifier to it's declaration. Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Junio, When

[PATCH/RFC] t9500-*.sh: Fix highlight test hang on Linux Mint

2013-09-06 Thread Ramsay Jones
the user to specify the correct tool, introduce the GIT_TEST_HIGHLIGHT_BIN variable. Also, add '/dev/null' to the command line of the highlight invocation; this avoids hanging the test if the filter script is used nonetheless. Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Junio, I

Re: Test failures in t4034

2012-08-19 Thread Ramsay Jones
regex routines suffer this bug. These patches were not applied since I didn't think this would be a common problem. I simply set NO_REGEX=1 in my config.mak, since the compat/ regex routines don't suffer from this problem. HTH ATB, Ramsay Jones -- To unsubscribe from this list: send the line

Re: [RFC/PATCH] t3300-*.sh: Fix a TAP parse error

2012-08-19 Thread Ramsay Jones
Junio C Hamano wrote: Jonathan Nieder jrnie...@gmail.com writes: Ramsay Jones wrote: Junio C Hamano wrote: Observing that all well-written test scripts we have begin with this boilerplate line: test_expect_success setup ' I wouldn't mind introducing a new helper function test_setup

read-cache-v5.c: compiler warnings

2012-08-19 Thread Ramsay Jones
to do so in the last 10 days. So, I'm just giving you a heads up ... ;-P HTH ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Test failures in t4034

2012-08-21 Thread Ramsay Jones
Junio C Hamano wrote: Ramsay Jones ram...@ramsay1.demon.co.uk writes: I had the same problem (or at least it *looks* like the same problem) on Linux last year (May 2011), which turned out to be a bug in the regex routines in an old version of glibc. I don't know OS X at all, so

Re: [PATCH] fast_export.c: Fix a compiler warning

2012-08-21 Thread Ramsay Jones
Florian Achleitner wrote: On Sunday 19 August 2012 16:29:02 Ramsay Jones wrote: Ok, I'll add it to the next version. This warning only occurs when building for 32bit, thus I never saw it. There would be a format flag for printf that sprecifies the platform's size_t integer type: z

Re: read-cache-v5.c: compiler warnings

2012-08-21 Thread Ramsay Jones
Thomas Gummerer wrote: On 08/19, Ramsay Jones wrote: Hi Thomas, Just an FYI; two out of the three gcc compilers I use (Linux, cygwin but not MingW), issue the following warnings: CC read-cache-v5.o read-cache-v5.c: In function `write_index_v5': read-cache-v5.c:1011

[PATCH] vcs-svn: Fix 'fa/remote-svn' and 'fa/vcs-svn' in pu

2012-08-23 Thread Ramsay Jones
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Florian, The build on pu is currently broken: CC remote-testsvn.o LINK git-remote-testsvn cc: vcs-svn/lib.a: No such file or directory make: *** [git-remote-testsvn] Error 1 This is caused by a dependency

[PATCH 1/3] remote-testsvn.c: Avoid the getline() GNU extension function

2012-08-25 Thread Ramsay Jones
Jones ram...@ramsay1.demon.co.uk --- Hi Florian, Could you please squash this into commit 0320cef0 (remote-svn: add marks-file regeneration, 22-08-2012). ATB, Ramsay Jones remote-testsvn.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/remote-testsvn.c b/remote

[PATCH 2/3] t9020-*.sh: Fix urls passed to git-remote in test setup

2012-08-25 Thread Ramsay Jones
remove the extraneous '/' character from the urls. Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Florian, This test fails on cygwin. Could you please squash this into commit 2d597d73 (Add a test script for remote-svn, 20-08-2012). Thanks! ATB, Ramsay Jones t/t9020-remote

[PATCH 3/3] t9020-*.sh: Skip all tests when python not available

2012-08-25 Thread Ramsay Jones
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Florian, Since python is not installed on MinGW, this test fails with an unable to spawn script type message when attempting to execute svnrdump. So, could you, in addition to the previous patch, squash this into commit 2d597d73 (Add

Re: [PATCH 1/3] remote-testsvn.c: Avoid the getline() GNU extension function

2012-08-30 Thread Ramsay Jones
Erik Faye-Lund wrote: On Sat, Aug 25, 2012 at 7:13 PM, Ramsay Jones ram...@ramsay1.demon.co.uk wrote: The getline() function is a GNU extension (you need to define _GNU_SOURCE before including stdio.h) and is, therefore, not portable. In particular, getline() is not available on MinGW

Re: [PATCH 1/3] remote-testsvn.c: Avoid the getline() GNU extension function

2012-08-30 Thread Ramsay Jones
Junio C Hamano wrote: Erik Faye-Lund kusmab...@gmail.com writes: On Sat, Aug 25, 2012 at 7:13 PM, Ramsay Jones ram...@ramsay1.demon.co.uk wrote: The getline() function is a GNU extension (you need to define _GNU_SOURCE before including stdio.h) and is, therefore, not portable

Re: [PATCH] vcs-svn: Fix 'fa/remote-svn' and 'fa/vcs-svn' in pu

2012-08-30 Thread Ramsay Jones
be *32-bit* Linux, cygwin and MinGW, of course. ;-) ATB, Ramsay Jones -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Test failures in t4034

2012-09-01 Thread Ramsay Jones
Junio C Hamano wrote: Ramsay Jones ram...@ramsay1.demon.co.uk writes: [snip] diff --git a/test-regex.c b/test-regex.c new file mode 100644 index 000..9259985 --- /dev/null +++ b/test-regex.c @@ -0,0 +1,35 @@ +#include stdlib.h +#include stdio.h +#include stdarg.h +#include sys

[PATCH v2] test-regex: Add a test to check for a bug in the regex routines

2012-09-01 Thread Ramsay Jones
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- .gitignore | 1 + Makefile | 1 + t/t0070-fundamental.sh | 5 + test-regex.c | 20 4 files changed, 27 insertions(+) create mode 100644 test-regex.c diff --git

[PATCH 0/6] Fix Tap parse error etc.

2012-09-01 Thread Ramsay Jones
the time ... [BTW, the pu branch is *very* broken on cygwin (it's the v5 index branch). I have a patch to fix it up; I just need to write it up.] Ramsay Jones (6): t3300-*.sh: Fix a TAP parse error t3902-*.sh: Skip all tests rather than each test t4016-*.sh: Skip all tests rather than each test

[PATCH 1/6] t3300-*.sh: Fix a TAP parse error

2012-09-01 Thread Ramsay Jones
=1, Tests=0, 2 wallclock secs ( 0.02 usr 0.03 sys + \ 0.84 cusr 0.41 csys = 1.29 CPU) Result: NOTESTS $ Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- t/t3300-funny-names.sh | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff

[PATCH 2/6] t3902-*.sh: Skip all tests rather than each test

2012-09-01 Thread Ramsay Jones
Each test in this file is skipped if the TABS_IN_FILENAMES test prerequisite is set. Use the 'skip_all' facility at the head of the file to skip all of the tests instead. Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- t/t3902-quoted.sh | 31 +++ 1 file

[PATCH 3/6] t4016-*.sh: Skip all tests rather than each test

2012-09-01 Thread Ramsay Jones
Each test in this file is skipped if the TABS_IN_FILENAMES test prerequisite is set. Use the 'skip_all' facility at the head of the file to skip all of the tests instead. Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- t/t4016-diff-quote.sh | 20 +--- 1 file changed

[PATCH 4/6] test-lib.sh: Fix some shell coding style violations

2012-09-01 Thread Ramsay Jones
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- t/test-lib.sh | 60 +-- 1 file changed, 38 insertions(+), 22 deletions(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 78c4286..56b028c 100644 --- a/t/test-lib.sh +++ b/t/test

[PATCH 5/6] test-lib.sh: Add check for invalid use of 'skip_all' facility

2012-09-01 Thread Ramsay Jones
the test with an error message to alert the test author. Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- t/test-lib.sh | 4 1 file changed, 4 insertions(+) diff --git a/t/test-lib.sh b/t/test-lib.sh index 56b028c..283d27a 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -383,6 +383,10

  1   2   3   4   5   6   7   8   9   10   >