[PATCH] remote.name.pushurl does not consider aliases when pushing

2013-03-17 Thread Rob Hoelz
modified. I hope my commit messages explain the problem I encountered well enough; if not, I can always go back and amend them. Patches follow. -Rob From 5007b11e86c0835807632cb41e6cfa75ce9a1aa1 Mon Sep 17 00:00:00 2001 From: Rob Hoelz r...@hoelz.ro Date: Sun, 17 Mar 2013 21:49:20 +0100 Subject

Re: [PATCH] remote.name.pushurl does not consider aliases when pushing

2013-03-17 Thread Rob Hoelz
On Sun, 17 Mar 2013 15:14:32 -0700 Junio C Hamano gits...@pobox.com wrote: Rob Hoelz r...@hoelz.ro writes: Hi everyone! I found a bug in Git today and wrote up a fix; I did my best to conform to the rules layed out in Documentation/SubmittingPatches, but please let me know if I need

[PATCH] push: Alias pushurl from push rewrites

2013-03-17 Thread Rob Hoelz
/myuser/] insteadOf = mygithub: [url g...@github.com:myuser/] pushInsteadOf = mygithub: [remote origin] url = github:organization/project pushurl = mygithub:project Signed-off-by: Rob Hoelz r...@hoelz.ro --- remote.c | 2 +- t/t5516-fetch-push.sh | 20

Re: [PATCH] push: Alias pushurl from push rewrites

2013-03-18 Thread Rob Hoelz
On 3/18/13 12:35 AM, Junio C Hamano wrote: Rob Hoelz r...@hoelz.ro writes: git push currently doesn't consider pushInsteadOf when using pushurl; this tests and fixes that. If you use pushurl with an alias that has a pushInsteadOf configuration value, Git does not take advantage

Re: [PATCH] push: Alias pushurl from push rewrites

2013-03-18 Thread Rob Hoelz
On Sun, 17 Mar 2013 16:35:59 -0700 Junio C Hamano gits...@pobox.com wrote: Rob Hoelz r...@hoelz.ro writes: git push currently doesn't consider pushInsteadOf when using pushurl; this tests and fixes that. If you use pushurl with an alias that has a pushInsteadOf configuration value

[PATCH] push: Alias pushurl from push rewrites

2013-03-18 Thread Rob Hoelz
. This commit fixes that. Signed-off-by: Rob Hoelz r...@hoelz.ro --- remote.c | 2 +- t/t5516-fetch-push.sh | 81 +++ 2 files changed, 82 insertions(+), 1 deletion(-) diff --git a/remote.c b/remote.c index ca1f8f2..de7a915 100644

Re: [PATCH] push: Alias pushurl from push rewrites

2013-03-20 Thread Rob Hoelz
On 3/19/13 7:08 PM, Junio C Hamano wrote: Jonathan Nieder jrnie...@gmail.com writes: Junio C Hamano wrote: Jonathan Nieder jrnie...@gmail.com writes: Test nits: ... Hope that helps, Jonathan Nieder (3): push test: use test_config where appropriate push test: simplify check of push

Re: [PATCH] push: Alias pushurl from push rewrites

2013-03-27 Thread Rob Hoelz
On Wed, 20 Mar 2013 07:35:58 -0700 Junio C Hamano gits...@pobox.com wrote: Rob Hoelz r...@hoelz.ro writes: On 3/19/13 7:08 PM, Junio C Hamano wrote: Jonathan Nieder jrnie...@gmail.com writes: Junio C Hamano wrote: Jonathan Nieder jrnie...@gmail.com writes: Test nits: ... Hope

[PATCH] push: Alias pushurl from push rewrites

2013-03-27 Thread Rob Hoelz
. This commit fixes that. Signed-off-by: Rob Hoelz r...@hoelz.ro --- remote.c | 6 +++- t/t5516-fetch-push.sh | 77 +++ 2 files changed, 82 insertions(+), 1 deletion(-) diff --git a/remote.c b/remote.c index e53a6eb..1ea240a 100644

Re: [PATCH] push: Alias pushurl from push rewrites

2013-03-27 Thread Rob Hoelz
On Wed, 27 Mar 2013 15:07:18 -0700 Junio C Hamano gits...@pobox.com wrote: Jonathan Nieder jrnie...@gmail.com writes: Sorry, typo. The configuration in the example above should have been [url git://anongit.myserver.example.com/] insteadOf = myserver.example.com:

Re: [PATCH] push: Alias pushurl from push rewrites

2013-03-27 Thread Rob Hoelz
On Wed, 27 Mar 2013 15:47:35 -0700 Jonathan Nieder jrnie...@gmail.com wrote: Hi, Rob Hoelz wrote: On Wed, 27 Mar 2013 11:23:45 -0700 Jonathan Nieder jrnie...@gmail.com wrote: Suppose I configure [url git://anongit.myserver.example.com/] insteadOf

Re: [PATCH] push: Alias pushurl from push rewrites

2013-03-27 Thread Rob Hoelz
On Wed, 27 Mar 2013 15:56:56 -0700 Jonathan Nieder jrnie...@gmail.com wrote: Rob Hoelz wrote: My mistake; I had not seen it! I thought you may have found a bug in my implementation, so I wanted to double check. =) Well, I had found an unfortunate consequence of the implementation

Re: [PATCH] push: Alias pushurl from push rewrites

2013-03-28 Thread Rob Hoelz
On Thu, 28 Mar 2013 12:25:07 -0700 Jonathan Nieder jrnie...@gmail.com wrote: Josh Triplett wrote: Related to this, as a path forward, I do think it makes sense to have a setting usable as an insteadOf that only applies to pushurl, even though pushInsteadOf won't end up serving that