git archive --format zip utf-8 issues

2012-08-10 Thread Sven Strickroth
4490a6dab1df5404f91ab3eb871f133154bff0bf Length DateTimeName - -- - 6 2012-08-10 23:41 +?+?++.txt - --- 6 1 file -- Best regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server

Re: git archive --format zip utf-8 issues

2012-08-10 Thread Sven Strickroth
regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: git archive --format zip utf-8 issues

2012-08-11 Thread Sven Strickroth
) the Windows 7 build-in zip displays them correctly, too. -- Best regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 2/2] git-svn, perl/Git.pm: extend and use Git-prompt method for querying users

2012-10-06 Thread Sven Strickroth
merged? The issues are still there. -- Best regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/2] second try

2012-11-11 Thread Sven Strickroth
problems, so I try again. -- Best regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] git-svn, perl/Git.pm: add central method for prompting passwords honoring GIT_ASKPASS and SSH_ASKPASS

2012-11-11 Thread Sven Strickroth
is introduced in this commit. This change also adds a fallback to SSH_ASKPASS. Signed-off-by: Sven Strickroth em...@cs-ware.de --- perl/Git.pm| 48 +++- perl/Git/SVN/Prompt.pm | 20 +--- 2 files changed, 48 insertions(+), 20

[PATCH 2/2] git-svn, perl/Git.pm: extend and use Git-prompt method for querying users

2012-11-11 Thread Sven Strickroth
for non password queries, and makes use of it instead of using hand-rolled prompt-response code that only works with the interactive terminal. Signed-off-by: Sven Strickroth em...@cs-ware.de --- perl/Git.pm| 28 +--- perl/Git/SVN/Prompt.pm | 16

Re: [PATCH 0/2] second try

2012-12-17 Thread Sven Strickroth
Hi, Am 26.11.2012 05:50 schrieb Junio C Hamano: Sven Strickroth sven.strickr...@tu-clausthal.de writes: Am 11.11.2012 17:40 schrieb Sven Strickroth: Am 06.10.2012 20:28 schrieb Junio C Hamano: It is either that it was simply forgotten, or after I wrote the part you quoted early in January

[PATCH 1/3] git-svn, perl/Git.pm: add central method for prompting passwords

2012-12-17 Thread Sven Strickroth
to solve this issue, but was incomplete as described above. Instead of using hand-rolled prompt-response code that only works with the interactive terminal, a reusable prompt() method is introduced in this commit. Signed-off-by: Sven Strickroth em...@cs-ware.de --- perl/Git.pm| 45

[PATCH] mergetools: Add tortoisegitmerge helper

2013-01-20 Thread Sven Strickroth
$REMOTE -merged $MERGED + check_unchanged + else + echo TortoiseGitMerge cannot be used without a base 12 + return 1 + fi +} -- Best regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server -- To unsubscribe from this list: send the line

[PATCH] mergetools: Add tortoisegitmerge helper

2013-01-21 Thread Sven Strickroth
have a space in it. Fixing this required changes in git and also in TortoiseGitMerge; see https://github.com/msysgit/msysgit/issues/57. The new tortoisegitmerge helper was added so that people can still use TortoiseMerge from TortoiseSVN (and older TortoiseGit versions). Signed-off-by: Sven

[PATCH] mergetools: Add tortoisegitmerge helper

2013-01-21 Thread Sven Strickroth
have a space in it. Fixing this required changes in git and also in TortoiseGitMerge; see https://github.com/msysgit/msysgit/issues/57. The new tortoisegitmerge helper was added so that people can still use TortoiseMerge from TortoiseSVN (and older TortoiseGit versions). Signed-off-by: Sven

Re: [PATCH] mergetools: Add tortoisegitmerge helper

2013-01-24 Thread Sven Strickroth
Am 21.01.2013 09:26 schrieb Sven Strickroth: - The TortoiseGit team renamed TortoiseMerge.exe to TortoiseGitMerge.exe (starting with 1.8.0) in order to make clear that this one has special support for git and prevent confusion with the TortoiseSVN TortoiseMerge version

Re: [PATCH] mergetools: Add tortoisegitmerge helper

2013-01-24 Thread Sven Strickroth
Am 24.01.2013 20:51 schrieb Junio C Hamano: Sven Strickroth sven.strickr...@tu-clausthal.de writes: - The TortoiseGit team renamed TortoiseMerge.exe to TortoiseGitMerge.exe (starting with 1.8.0) in order to make clear that this one has special support for git and prevent confusion

[PATCH] mergetools: Enhance tortoisemerge to work with

2013-01-25 Thread Sven Strickroth
with the TortoiseSVN TortoiseMerge version. - The tortoisemerge mergetool does not work with filenames which have a space in it. Fixing this required changes in git and also in TortoiseGitMerge; see https://github.com/msysgit/msysgit/issues/57. Signed-off-by: Sven Strickroth em...@cs-ware.de Reported

Re: [PATCH] mergetools: Enhance tortoisemerge to work with

2013-01-25 Thread Sven Strickroth
Am 25.01.2013 19:28 schrieb Junio C Hamano: Sven Strickroth sven.strickr...@tu-clausthal.de writes: TortoiseGitMerge and filenames with spaces ??? ECANNOTPARSE. ... ah, wait. Is this a broken-off tail of your subject line? Yes. +touch $BACKUP +basename

Re: [PATCH] mergetools: Enhance tortoisemerge to work with

2013-01-25 Thread Sven Strickroth
The TortoiseGit team renamed TortoiseMerge.exe to TortoiseGitMerge.exe (starting with 1.8.0) in order to make clear that this one has special support for git and prevent confusion with the TortoiseSVN TortoiseMerge version. Signed-off-by: Sven Strickroth em...@cs-ware.de --- mergetools

[PATCH 1/2] mergetools: Added support for TortoiseGitMerge

2013-01-25 Thread Sven Strickroth
The TortoiseGit team renamed TortoiseMerge.exe to TortoiseGitMerge.exe (starting with 1.8.0) in order to make clear that this one has special support for git and prevent confusion with the TortoiseSVN TortoiseMerge version. Signed-off-by: Sven Strickroth em...@cs-ware.de --- mergetools

[PATCH 2/2] mergetools: Make tortoisemerge work with

2013-01-25 Thread Sven Strickroth
-values by space instead of colons as TortoiseSVN TortoiseMerge does and supports filesnames with spaces in it this way now. Signed-off-by: Sven Strickroth em...@cs-ware.de Reported-by: Sebastian Schuberth sschube...@gmail.com --- mergetools/tortoisemerge | 14 +++--- 1 file changed, 11

Re: [PATCH 2/2] mergetools: Make tortoisemerge work with

2013-01-27 Thread Sven Strickroth
for file paths with spaces. Detect when it is installed and prefer it over TortoiseMerge. This message implies, that I have to combine two patches again?! -- Best regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server -- To unsubscribe from this list: send the line unsubscribe git

[PATCH] mergetools: Enable tortoisemerge to handle filenames with

2013-02-01 Thread Sven Strickroth
was modified in order to handle filenames with spaces correctly. The -key value form was choosen because this way no escaping for quotes within quotes is necessary; see https://github.com/msysgit/msysgit/issues/57 Signed-off-by: Sven Strickroth em...@cs-ware.de Reported-by: Sebastian Schuberth sschube

Re: [PATCH] mergetools: Enable tortoisemerge to handle filenames with

2013-02-01 Thread Sven Strickroth
Am 01.02.2013 21:07 schrieb Sebastian Schuberth: mergetools: Teach tortoisemerge about TortoiseGitMerge This subject doesn't make any sense if we don't combine the two patches. -- Best regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server -- To unsubscribe from this list: send

Re: [PATCH] mergetools: Enable tortoisemerge to handle filenames with

2013-02-01 Thread Sven Strickroth
://www.mingw.org/wiki/Posix_path_conversion Sven? I just mailed a new patch. Thanks to Sebastian for pointing this out! @Junio: Feel free to optimize the commit message. -- Best regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server -- To unsubscribe from this list: send the line

Re: [PATCH] mergetools: Enable tortoisemerge to handle filenames with spaces with TortoiseGitMerge

2013-02-01 Thread Sven Strickroth
which fixes handling file names with spaces [2] (as written above). [1] http://www.mingw.org/wiki/Posix_path_conversion [2] https://github.com/msysgit/msysgit/issues/57 Signed-off-by: Sven Strickroth em...@cs-ware.de Reported-by: Sebastian Schuberth sschube...@gmail.com --- mergetools/tortoisemerge

[PATCH] connect.c: Tell *PLink to always use ssh protocol

2013-02-06 Thread Sven Strickroth
Default values for *plink can be set using PuTTY. If a user makes telnet the default in PuTTY this breaks ssh clones in git. Since git clones of the type user@host:path use ssh, tell *plink to use ssh and override PuTTY defaults for the protocol to use. Signed-off-by: Sven Strickroth em...@cs

Re: [PATCH] connect.c: Tell *PLink to always use ssh protocol

2013-02-07 Thread Sven Strickroth
Am 07.02.2013 00:22 schrieb Jeff King: On Wed, Feb 06, 2013 at 10:58:49PM +0100, Sven Strickroth wrote: Default values for *plink can be set using PuTTY. If a user makes telnet the default in PuTTY this breaks ssh clones in git. Since git clones of the type user@host:path use ssh, tell

Re: [PATCH] connect.c: Tell *PLink to always use ssh protocol

2013-03-09 Thread Sven Strickroth
Am 07.02.2013 00:22 schrieb Jeff King: On Wed, Feb 06, 2013 at 10:58:49PM +0100, Sven Strickroth wrote: Default values for *plink can be set using PuTTY. If a user makes telnet the default in PuTTY this breaks ssh clones in git. Since git clones of the type user@host:path use ssh, tell

[PATCH 2/3] mingw.h: Define only if necessary

2013-05-08 Thread Sven Strickroth
Since the latest version of MSVC EWOULDBLOCK, EAFNOSUPPORT and ECONNABORTED are defined in errno.h. When used with MSVC mingw.h is included from msvc.h and causes warnings about redefinitions. Signed-off-by: Sven Strickroth em...@cs-ware.de --- compat/mingw.h | 6 ++ 1 file changed, 6

[PATCH 1/3] poll.h lies in the same folder, so use normal quotes for include

2013-05-08 Thread Sven Strickroth
Some compilers, like Visual C++ complain when is used instead of double quotes for non system includes. Signed-off-by: Sven Strickroth em...@cs-ware.de --- compat/poll/poll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/poll/poll.c b/compat/poll/poll.c index

[PATCH 3/3] Initialize variables with values

2013-05-08 Thread Sven Strickroth
With MSVC initializing a variable with int a=a causes a warning about using an uninitialized value. Signed-off-by: Sven Strickroth em...@cs-ware.de --- builtin/rev-list.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/rev-list.c b/builtin/rev-list.c index 67701be

Re: [PATCH 1/5] msvc: Fix compilation errors caused by poll.h emulation

2013-05-08 Thread Sven Strickroth
into the includes path causes redefinition errors. How have you tested this? I think the check in git-compat-util.h has to be extended to only include any poll.h if _MSC_VER is defined. -- Best regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server -- To unsubscribe from this list: send the line

Re: [PATCH 1/5] msvc: Fix compilation errors caused by poll.h emulation

2013-05-09 Thread Sven Strickroth
libgit works now. -- Best regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RFC: git status --amend

2015-03-31 Thread Sven Strickroth
with a better naming) to git status. What do you think of this idea? -- Best regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] Close config file handle if the entry to unset is not found

2015-08-14 Thread Sven Strickroth
Am 14.08.2015 um 21:35 schrieb Eric Sunshine: Signed-off-by: Sup Yut Sum ch3co...@gmail.com Signed-off-by: Sven Strickroth em...@cs-ware.de --- diff --git a/config.c b/config.c index 9fd275f..89b49e3 100644 --- a/config.c +++ b/config.c @@ -2048,6 +2048,7 @@ int

[PATCH] Correctly close config file handle in case of error

2015-08-14 Thread Sven Strickroth
Without this patch there might be open file handle leaks. Signed-off-by: Sven Strickroth em...@cs-ware.de Signed-off-by: Sup Yut Sum ch3co...@gmail.com --- config.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/config.c b/config.c index 9fd275f..83caa25 100644

[PATCH] vsnprintf in Visual Studio 2015 doesn't need SNPRINTF_SIZE_CORR any more

2015-08-14 Thread Sven Strickroth
W/o this fix there is one character missing at the end. Signed-off-by: Sven Strickroth em...@cs-ware.de --- compat/snprintf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/snprintf.c b/compat/snprintf.c index 42ea1ac..0b11688 100644 --- a/compat/snprintf.c +++ b

[PATCH] Correctly close config file handle in case of error

2015-08-14 Thread Sven Strickroth
Without this patch there might be open file handle leaks. Signed-off-by: Sven Strickroth em...@cs-ware.de Signed-off-by: Sup Yut Sum ch3co...@gmail.com --- config.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/config.c b/config.c index 9fd275f..8138d5d 100644 --- a/config.c +++ b

[PATCH] Close config file handle if the entry to unset is not found

2015-08-14 Thread Sven Strickroth
Without this patch there might be open handle leaks. Signed-off-by: Sup Yut Sum ch3co...@gmail.com Signed-off-by: Sven Strickroth em...@cs-ware.de --- config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/config.c b/config.c index 9fd275f..89b49e3 100644 --- a/config.c +++ b/config.c

[PATCH] Correctly close config file handle in case of error

2015-08-14 Thread Sven Strickroth
Without this patch there might be open file handle leaks. Signed-off-by: Sven Strickroth em...@cs-ware.de Signed-off-by: Sup Yut Sum ch3co...@gmail.com --- config.c | 4 1 file changed, 4 insertions(+) diff --git a/config.c b/config.c index 9fd275f..c06dc2f 100644 --- a/config.c +++ b

[PATCH] commit: do not lose SQUASH_MSG contents

2016-03-13 Thread Sven Strickroth
commit log skeleton first when concluding a normal merge, and then show the "# Conflicts:" list, to help the user write the log message for the resulting commit. Signed-off-by: Sven Strickroth <s...@cs-ware.de> --- builtin/commit.c | 11 ++- 1 file changed, 10 insertions(+),

[PATCH 2/2] MSVC: VS2013 comes with inttypes.h

2016-03-29 Thread Sven Strickroth
Reduce the number of defines which need to be managed within vanilal git. Signed-off-by: Sven Strickroth <s...@cs-ware.de> --- compat/mingw.h | 2 +- compat/vcbuild/include/unistd.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/compat/mingw.h b/

[PATCH 1/2] MSVC: vsnprintf in Visual Studio 2015 doesn't need SNPRINTF_SIZE_CORR any more

2016-03-29 Thread Sven Strickroth
In MSVC2015 the behavior of vsnprintf was changed. W/o this fix there is one character missing at the end. Signed-off-by: Sven Strickroth <s...@cs-ware.de> --- compat/snprintf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/snprintf.c b/compat/snprintf.c

[PATCH] commit: do not lose SQUASH_MSG contents

2016-03-21 Thread Sven Strickroth
commit log skeleton first when concluding a normal merge, and then show the "# Conflicts:" list, to help the user write the log message for the resulting commit. Test by Junio C Hamano <gits...@pobox.com>. Signed-off-by: Sven Strickroth <s...@cs-ware.de> --- buil

[PATCH] Also read SQUASH_MSG if a conflict on a merge squash occurred

2016-03-07 Thread Sven Strickroth
After a merge --squash with a conflict the commit message did not contain the information about the squashed commits, but only the "# Conflicts:" information. Signed-off-by: Sven Strickroth <s...@cs-ware.de> --- builtin/commit.c | 6 ++ 1 file changed, 6 insertions(+) diff

Re: [PATCH] Also read SQUASH_MSG if a conflict on a merge squash occurred

2016-03-08 Thread Sven Strickroth
sg())) { > read SQUASH_MSG; > } > if (file_exists(git_path_merge_msg())) > read MERGE_MSG; > } > hook_arg1 = "merge"; > } Here hook_arg1 would be always "merge" and never "squash"... Before

[PATCH] commit: do not lose SQUASH_MSG contents

2016-03-08 Thread Sven Strickroth
When concluding a conflicted "git merge --squash", the command failed to read SQUASH_MSG that was prepared by "git merge", and showed only the "# Conflicts:" list of conflicted paths. Signed-off-by: Sven Strickroth <em...@cs-ware.de> --- builtin/commit.c | 20

Commit message not helpful after merge squash with conflicts

2016-03-05 Thread Sven Strickroth
ssues/1902 -- Best regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2 V3] MSVC: Use shipped headers instead of fallback definitions

2016-03-30 Thread Sven Strickroth
VS2010 comes with stdint.h [1] VS2013 comes with inttypes.h [2] [1] https://stackoverflow.com/a/2628014/3906760 [2] https://blogs.msdn.microsoft.com/vcblog/2013/07/19/c99-library-support-in-visual-studio-2013/ Signed-off-by: Sven Strickroth <s...@cs-ware.de> --- compat/m

Re: [PATCH 2/2 V2] MSVC: VS2013 comes with inttypes.h

2016-03-29 Thread Sven Strickroth
Signed-off-by: Sven Strickroth <em...@cs-ware.de> --- compat/mingw.h | 2 +- compat/vcbuild/include/unistd.h | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/compat/mingw.h b/compat/mingw.h index 6b6d695..137f42e 100644 --- a/compat/mingw.h +++ b/

Re: [PATCH 1/2] MSVC: vsnprintf in Visual Studio 2015 doesn't need SNPRINTF_SIZE_CORR any more

2016-03-29 Thread Sven Strickroth
[1] https://msdn.microsoft.com/en-us/library/1kt27hek.aspx Signed-off-by: Sven Strickroth <s...@cs-ware.de> --- compat/snprintf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/snprintf.c b/compat/snprintf.c index 42ea1ac..0b11688 100644 --- a/compat/snprintf.c +++ b/c

Stash pop/apply conflict and --theirs and --ours

2016-10-22 Thread Sven Strickroth
urs should be swapped in git index, so that git checkout --theirs and --ours work as expected. PS: I'm sorry if this was already discussed, I haven't found any discussion. -- Best regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server

git init --separate-git-dir does not update symbolic .git links for submodules

2017-03-04 Thread Sven Strickroth
ot updated and still points to the .git directory of the parent repository which now is a file. This issue is present for me in Git 2.12.0. -- Best regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server

[PATCH] doc: use https link to Wikipeai to avoid http redirect

2017-05-13 Thread Sven Strickroth
Signed-off-by: Sven Strickroth <em...@cs-ware.de> --- Documentation/gitweb.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt index 96156e5e1..88450589a 100644 --- a/Documentation/gitweb.txt +++ b/Documentation/gitw

[PATCH] Use https links to Wikipedia to avoid http redirects

2017-05-13 Thread Sven Strickroth
Signed-off-by: Sven Strickroth <em...@cs-ware.de> --- Documentation/gitweb.txt | 2 +- bisect.c | 2 +- gitweb/gitweb.perl | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt index 96156e5e1..884

[PATCH] msvc: Directly use MS version (_stricmp) of strcasecmp

2018-11-18 Thread Sven Strickroth
This also removes an implicit conversion from size_t (unsigned) to int (signed). _stricmp as well as _strnicmp are both available since VS2012. Signed-off-by: Sven Strickroth --- compat/msvc.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/compat/msvc.h b/compat

[PATCH] .mailmap: record canonical email address for Sven Strickroth

2018-11-20 Thread Sven Strickroth
Signed-off-by: Sven Strickroth --- .mailmap | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.mailmap b/.mailmap index f165222a78..a30f409f39 100644 --- a/.mailmap +++ b/.mailmap @@ -235,6 +235,8 @@ Steven Grimm Steven Grimm kor...@midwinter.com Steven Walter Steven Walter +Sven

[PATCH] msvc: Directly use MS version (_stricmp) of strcasecmp

2018-11-19 Thread Sven Strickroth
This also removes an implicit conversion from size_t (unsigned) to int (signed). _stricmp as well as _strnicmp are both available since VS2012. Signed-off-by: Sven Strickroth --- compat/msvc.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/compat/msvc.h b/compat