The README file moved to README.md in ad21f5 (README: use markdown
syntax, 2016-02-25).
Reported-by: マッチョコ太郎
Signed-off-by: Todd Zullinger
---
Hi,
マッチョコ太郎 wrote:
hi
I downloaded tarball (tar.gz) from git web site and tried to make rpm file.
But, when I run command "$rpmbuild -tb --
Pranit Bauva wrote:
On Sat, Apr 2, 2016 at 9:18 PM, マッチョコ太郎 wrote:
hi
I downloaded tarball (tar.gz) from git web site and tried to make rpm file.
But, when I run command "$rpmbuild -tb --clean git-2.8.0.tar.gz",
error message is displayed and rpm file creation stopped.
The error message is l
Hi Rudy,
I think the commit subject should include a bit more detail. Ideally,
the subject would start with 'bash prompt: ' to make it clear what
area the commit involves. Then you would want to describe what
inconsistency is being fixed (and why).
Rudy YAYON wrote:
---
contrib/completion
Hi,
brian m. carlson wrote:
> On Tue, Mar 26, 2019 at 09:06:03PM -0400, Todd Zullinger wrote:
>> There's still the matter of 2.0 dropping docbook45. I'll
>> try to get around to testing 1.5.x releases with docbook5 to
>> see if they work reasonably well. If not
Hi Ævar,
Ævar Arnfjörð Bjarmason wrote:
> diff --git a/Documentation/git-gc.txt b/Documentation/git-gc.txt
> index 66386439b7..c037a46b09 100644
> --- a/Documentation/git-gc.txt
> +++ b/Documentation/git-gc.txt
> @@ -45,28 +45,12 @@ OPTIONS
> --auto::
> With this option, 'git gc' checks whe
Asciidoc uses either one-line or two-line syntax for document/section
titles[1]. The two-line form is used in git-status. Fix a few section
titles in the porcelain v2 section which were inadvertently using
markdown syntax.
[1] http://asciidoc.org/userguide.html#X17
Signed-off-by: Todd
Just chipping away at the remaining differences between asciidoc and
asciidoctor.
Todd Zullinger (2):
Documentation/rev-list-options: wrap --date= block with "--"
Documentation/git-status: fix titles in porcelain v2 section
Documentation/git-status.txt | 12
Doc
quot;--" block
markers to correctly format the block.
When using asciidoc there is no change in how the content is rendered.
Signed-off-by: Todd Zullinger
---
The issue this fixes can be seen in the git-log and git-rev-list docs on
git-scm.com:
https://git-scm.com/docs/git-log#Documentation/
Hi Junio,
Junio C Hamano wrote:
> * sg/asciidoctor-in-ci (2019-04-01) 6 commits
> - ci: fix AsciiDoc/Asciidoctor stderr check in the documentation build job
> - ci: stick with Asciidoctor v1.5.8 for now
> - ci: install Asciidoctor in 'ci/install-dependencies.sh'
> - Documentation/technical/pro
Hi,
Jeff King wrote:
> On Sat, Mar 30, 2019 at 02:30:00PM -0400, Todd Zullinger wrote:
>
>> Using "+" to continue multiple list items is more tedious and
>> error-prone than wrapping the entire block with "--" block markers.
>>
>> When using asc
Jeff King wrote:
> On Sat, Mar 30, 2019 at 02:30:01PM -0400, Todd Zullinger wrote:
>
>> Asciidoc uses either one-line or two-line syntax for document/section
>> titles[1]. The two-line form is used in git-status. Fix a few section
>> titles in the porcelain v2 section
Hi,
Jeff Hostetler wrote:
> On 3/30/2019 2:30 PM, Todd Zullinger wrote:
>> The '^### ' lines were added in 1cd828ddc8 ("git-status.txt: describe
>> --porcelain=v2 format", 2016-08-11). I'm _presuming_ they were made
>> with markdown syntax in
Hi,
Martin Ågren wrote:
> On Sat, 30 Mar 2019 at 19:30, Todd Zullinger wrote:
>>
>> Just chipping away at the remaining differences between asciidoc and
>> asciidoctor.
>>
>> Todd Zullinger (2):
>> Documentation/rev-list-options: wrap --date= block with
brian m. carlson wrote:
> On Sat, Mar 30, 2019 at 02:00:14PM -0400, Todd Zullinger wrote:
>> Thanks for the very useful docbook5/xmlto details!
>>
>> The hard-coded use of the non-namespaced stylesheets in
>> xmlto is unfortunate. I hadn't gotten far enough alon
leading single-quote. This renders properly in asciidoc
and asciidoctor.
Signed-off-by: Todd Zullinger
---
Maybe it would be easier to change the example commit messages
and avoid having to nest single quotes within double quotes? I
don't know if that's much preferable to escaping only the
Hi,
Martin Ågren wrote:
> On Fri, 5 Apr 2019 at 03:40, Todd Zullinger wrote:
>> There are two other changes I've got queued locally. One in
>> git-show-branch.txt removes the last use of {apostrophe}.
>> Another in git-svn.txt is a bit of a work-around for a
>>
The second paragraph in the CONFIGURATION section intends to emphasize
the word 'must' with bold type. Adjust the formatting slightly to
provide similar results between asciidoc and asciidoctor.
Signed-off-by: Todd Zullinger
---
I debated changing 'must' from bold to italic
the whole paragraph in this way.
There's lots more monospacing to be done in this document, but since our
main motivation is addressing AsciiDoc/Asciidoctor discrepancies like
this one, let's just convert this one paragraph.
Signed-off-by: Todd Zullinger
---
Documentation/git-svn.txt
Hi,
Martin Ågren wrote:
> On Sat, 6 Apr 2019 at 00:51, Todd Zullinger wrote:
>> Here's what I have currently. I haven't tested this much with
>> asciidoctor-1.5.x releases (or maybe not at all -- it's been a
>> week or so since I worked on this).
>
&g
the {apostrophe} is rendered literally with Asciidoctor
(at least with 1.5.5-2.0.3). Avoid this by using single-quotes.
Escaping the leading single-quote allows the content to render properly
in AsciiDoc and Asciidoctor.
Signed-off-by: Todd Zullinger
---
Documentation/git-show-branch.txt | 2 +
Martin Ågren wrote:
> I think what's happening could be related to the fix in the first patch.
> There, it's ok to explicitly escape only the first '. The second one is
> matched to it and gets escaped implicitly. Something like that could be
> happening here, too, just that we don't want it to. (S
Hi,
Junio C Hamano wrote:
> * tz/doc-apostrophe-no-longer-needed (2019-04-08) 1 commit
> - Documentation/git-show-branch: drop last use of {apostrophe}
>
> Doc formatting fix.
>
> Will merge to 'next'.
>
>
> * tz/git-svn-doc-markup-fix (2019-04-08) 1 commit
> - Documentation/git-svn: impro
Hi,
Jeff King wrote:
> The description for the "-t" option contains a sub-list of all of the
> possible file status outputs. But because of the newline separating that
> list from the description paragraph, asciidoc treats the sub-list
> entries as a continuation of the overall options list, rathe
allations.
Signed-off-by: Todd Zullinger
---
I ran into such a broken jgit on Fedora >= 30¹. This is clearly a
problem in the Fedora jgit package which will hopefully be resolved
soon. But it may be good to avoid wasting time debugging tests which
fail due to a broken tool outs
Hi,
Ævar Arnfjörð Bjarmason wrote:
>
> On Tue, May 14 2019, Jonathan Nieder wrote:
>
>> Todd Zullinger wrote:
>>
>>> The JGIT prereq uses 'type jgit' to determine whether jgit is present.
>>> While this should be sufficient, if the jgit found i
Hi,
Jeff King wrote:
> On Tue, May 14, 2019 at 02:14:19AM +, brian m. carlson wrote:
>
>> On Mon, May 13, 2019 at 10:05:20PM -0400, Todd Zullinger wrote:
>>> diff --git a/t/test-lib.sh b/t/test-lib.sh
>>> index 908ddb9c46..599fd70e14 100644
>>> ---
e other
dependencies, see e.g. the CURL and UNZIP prerequisites.
Signed-off-by: Todd Zullinger
---
As promised, I stole the second paragraph from Ævar nearly verbatim. :)
t/test-lib.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 908ddb9c46
[-cc: lkml, +cc: Duy as author of a good number of
diff-related commits in 2.22.0 :) ]
Hi,
While running the 2.22.0-rc1 tests on Fedora, I hit a few
new test failures since 2.21.0 -- but only on the s390x
architecture.
I haven't had time to dig into these the past few days, so I
thought I would
I wrote:
> While running the 2.22.0-rc1 tests on Fedora, I hit a few
> new test failures since 2.21.0 -- but only on the s390x
> architecture.
>
> I haven't had time to dig into these the past few days, so I
> thought I would send what I do have in case the problem is
> obvious to someone else. I
Hi,
Duy Nguyen wrote:
> On Fri, May 24, 2019 at 2:14 AM Todd Zullinger wrote:
>> I am guessing it's no coincidence that this only fails on
>> s390x and it is the only big endian architecture in the
>> fedora build system.
>
> I see a problem with -w and wro
Hi,
Nguyễn Thái Ngọc Duy wrote:
> This should fix the diff tests failure on s360x. It's a serious problem
> and I plan to do something to prevent it from happening again.
Thanks for looking at this!
I applied this on top of master/2.22.0-rc1 and see a number
of compiler errors using gcc-9.1.1 wi
I wrote:
> Below are the compiler errors.
Well, to be precise, all but imap-send are warnings rather
than errors.
--
Todd
Duy Nguyen wrote:
> On Sat, May 25, 2019 at 12:36 AM Todd Zullinger wrote:
>> I applied this on top of master/2.22.0-rc1 and see a number
>> of compiler errors using gcc-9.1.1 with fedora's standard
>> compiler options for rpm builds.
>
> That last patch 4/3 is n
Eric Wong wrote:
> Chris Mayo wrote:
>> git-send-email uses the TLS support in the Net::SMTP core module from
>> recent versions of Perl. Documenting the minimum version is complex
>> because of separate numbering for Perl (5.21.5~169), Net:SMTP (2.34)
>> and libnet (3.01). Version numbers from co
Hi,
Sorry I missed your earlier reply which also mentioned using
$obj->can() Ævar. That's what I get for typing a reply and
then walking away for a few hours before hitting send. ;)
Ævar Arnfjörð Bjarmason wrote:
> Same, but to bikeshed a bit, at this point we can just do:
>
> diff --gi
; long is the same
> size as 'int' and nobody has complained so far). Some safety checks may
> be implemented in the future to prevent class of bugs.
>
> Reported-by: Todd Zullinger
> Signed-off-by: Nguyễn Thái Ngọc Duy
> ---
> diff.h | 2 +-
> 1 file changed, 1 in
Signed-off-by: Todd Zullinger
---
These are all just minor typos I noticed while reading the
release notes.
I did find the first entry on the checkout --no-overlay read
a bit strangely with the multiple "out's" in '... checking
out paths out ...'. Is it any easier
Hi,
Tigran Mkrtchyan wrote:
> diff --git a/Documentation/config/tag.txt b/Documentation/config/tag.txt
> index 663663bdec..675483c3c3 100644
> --- a/Documentation/config/tag.txt
> +++ b/Documentation/config/tag.txt
> @@ -8,6 +8,13 @@ tag.sort::
> linkgit:git-tag[1]. Without the "--sort=" opt
Hi,
[added Christian, SZEDER, and Jeff to Cc as author and
helpers on the newly-added t0016-oidmap]
Randall S. Becker wrote:
> A preview of the situation with testing 2.23.0.rc0 on
> NonStop is not great. We have had some new failures right
> off the bat on our NonStop platforms. This is a previe
Jeff King wrote:
> On Tue, Jul 30, 2019 at 08:59:33PM -0400, Jeff King wrote:
>
>>> OTOH, this is not just any hashmap, but an oidmap, and I could imagine
>>> that there might be use cases where it would be beneficial if the
>>> iteration order were to match the oid order (but don't know whether w
Jeff King wrote:
> On Tue, Jul 30, 2019 at 09:59:17PM -0400, Todd Zullinger wrote:
>> At the risk of showing my complete lack of knowledge about
>> these tests, I was wondering if the order mattered for the
>> other tests in t0011 and t0016.
[...]
>> You've got
Hi,
John Paul Adrian Glaubitz wrote:
> Recent versions of git are failing the testsuite on big-endian targets
> such as s390x in Debian.
>
> Build logs are:
>
>> https://buildd.debian.org/status/fetch.php?pkg=git&arch=s390x&ver=1%3A2.23.0%7Erc0-1&stamp=1564449102&raw=0
>> https://buildd.debian.o
Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> Jeff King writes:
>>
+ if (mailmap < 0)
mailmap = 0;
- }
>>>
>>> This should be "mailmap = 1" to match the commit message, no? (Which
>>> also implies we may want a new test).
>>
[...]
> +test_expect_success 'log.mai
The git-multi-pack-index doc links to technical/multi-pack-index.html.
Ensure it is built to prevent a broken link.
Signed-off-by: Todd Zullinger
---
While building 2.20.0-rc0 I noticed the broken link from
git-multi-pack-index to technical/multi-pack-index.html.
Documentation/Makefile | 1
e attribute for cookies", 2018-08-28)
Signed-off-by: Todd Zullinger
---
[Resending with the list in Cc; sorry for spamming you,
Junio, Jeff, and Gábor.]
The in-development version of Fedora updated to the recently
released curl-7.61.1 in the past few days. This isn't
breakage from the 2.1
Jeff King wrote:
> On Fri, Sep 07, 2018 at 07:22:05PM -0400, Todd Zullinger wrote:
>
>> With curl-7.61.1 cookies are sorted by creation-time¹. Sort the output
>> used in the 'cookies stored in http.cookiefile when http.savecookies
>> set' test before co
g...@jeffhostetler.com wrote:
> +# As a sanity check, ask Python to parse our generated JSON. Let Python
> +# recursively dump the resulting dictionary in sorted order. Confirm that
> +# that matches our expectations.
> +test_expect_success PYTHON 'parse JSON using Python' '
[...]
> + python
Thomas Fischer wrote:
> I agree that the entire chain of empty directories should not be tracked, as
> git tracks content, not files.
>
> However, when I run 'rm path/to/some/file', I expect path/to/some/ to still
> exist.
>
> Similarly, when I run 'git rm path/to/some/file', I expect path/to/s
Ramsay Jones wrote:
[...]
> I don't run the p4 or svn tests, so ... :-D
Heh, lucky you. :)
I try to run them all as part of the fedora builds since
they cover much more than I'd ever use. That's the main
reason I noticed the bare python. That would trip me up
when it came time to build on a nea
ername
not ok 18 - Got keys decrypted by git config option
not ok 19 - Got keys decrypted by command option
# test_external test git-credential-netrc was ok
make: Leaving directory
'/builddir/build/BUILD/git-2.18.0.rc1/contrib/credential/netrc'
netrc test exit status: 0
Todd Zullin
Running "make" in contrib/credential/netrc should run the "all" target
rather than the "test" target. Add an empty "all::" target like most of
our other Makefiles.
Signed-off-by: Todd Zullinger
---
contrib/credential/netrc/Makefile | 3 +++
1 file change
The netrc test.pl script calls git-credential-netrc which imports the
Git module. Pass GITPERLLIB to git-credential-netrc via PERL5LIB to
ensure the in-tree Git module is used for testing.
Signed-off-by: Todd Zullinger
---
contrib/credential/netrc/test.pl | 3 +++
1 file changed, 3 insertions
Hi Luis,
Luis Marsano wrote:
> Thanks for looking into this and addressing these issues.
And thank you for digging further. :)
> On Thu, Jun 7, 2018 at 1:20 AM Todd Zullinger wrote:
>> I noticed failures from the contrib/credential/netrc tests
>> while building 2.18.0 rele
Hi,
Ævar Arnfjörð Bjarmason wrote:
>
> On Sun, Jun 10 2018, Todd Zullinger wrote:
>
>>> I added 'use autodie;' without realizing it had external dependencies.
>>> According to the documentation
>>> http://perldoc.perl.org/autodie.html
>>
Running "make" in contrib/credential/netrc should run the "all" target
rather than the "test" target. Add an empty "all::" target like most of
our other Makefiles.
Signed-off-by: Todd Zullinger
---
contrib/credential/netrc/Makefile | 3 +++
1 file change
Signed-off-by: Todd Zullinger
---
contrib/credential/netrc/t-git-credential-netrc.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/contrib/credential/netrc/t-git-credential-netrc.sh
b/contrib/credential/netrc/t-git-credential-netrc.sh
index 58191a62f8..c5661087fe
e in-tree Git.pm for tests
git-credential-netrc: fix exit status when tests fail
Todd Zullinger (2):
git-credential-netrc: make "all" default target of Makefile
git-credential-netrc: minor whitespace cleanup in test script
contrib/credential/netrc/Makefile | 3 +
From: Luis Marsano
The netrc test.pl script calls git-credential-netrc which imports the
Git module. Pass GITPERLLIB to git-credential-netrc via PERL5LIB to
ensure the in-tree Git module is used for testing.
Signed-off-by: Luis Marsano
---
contrib/credential/netrc/t-git-credential-netrc.sh |
From: Luis Marsano
Signed-off-by: Luis Marsano
---
contrib/credential/netrc/test.pl | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/contrib/credential/netrc/test.pl b/contrib/credential/netrc/test.pl
index 2b5280ad6a..c0fb3718b2 100755
--- a/contrib/credential/netrc/test.
Eric Sunshine wrote:
> On Tue, Jun 12, 2018 at 11:10 PM, Todd Zullinger wrote:
>> Signed-off-by: Todd Zullinger
>> ---
>> diff --git a/contrib/credential/netrc/t-git-credential-netrc.sh
>> b/contrib/credential/netrc/t-git-credential-netrc.sh
>> index 58191
Hi,
Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason writes:
>
>> Per my reading of the file this was the only thing autodie was doing
>> in this file (there was no other code it altered). So let's remove it,
>> both to fix the logic error and to get rid of the dependency.
>>
>> 1. <87efhfvxzu..
Hi Johannes,
I was splitting a repository tonight and ran 'rebase -i
--root' to reword the initial commit. Then git died with
'BUG: sequencer.c:795: root commit without message.'
A simple test case to show the failure:
-- >8 --
diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interact
Hi Johannes,
Johannes Schindelin via GitGitGadget wrote:
> From: GitGitGadget
>
> Todd Zullinger reported this bug in
> https://public-inbox.org/git/20180615043111.gs3...@zaya.teonanacatl.net/:
> when calling git rebase --root and trying to reword the
> root commit's mes
Hi,
Junio C Hamano wrote:
> Todd Zullinger writes:
>
>> Hi Johannes,
>>
>> Johannes Schindelin via GitGitGadget wrote:
>>> From: GitGitGadget
>>>
>>> Todd Zullinger reported this bug in
>>> https://public-inbox.org/git/201806150431
Hi Phillip,
Phillip Wood wrote:
> On 15/06/18 05:31, Johannes Schindelin via GitGitGadget wrote:
>>
>> From: Todd Zullinger
>>
>> +test_expect_failure 'rebase -i --root reword root commit' '
>> +test_when_finished "test_might_fail git r
Hi Junio,
Junio C Hamano wrote:
> * tz/cred-netrc-cleanup (2018-06-18) 3 commits
> - git-credential-netrc: fix exit status when tests fail
> - git-credential-netrc: use in-tree Git.pm for tests
> - git-credential-netrc: minor whitespace cleanup in test script
>
> Build and test procedure for
When testing a reworded root commit, ensure that the squash-onto commit
which is created and amended is still the root commit.
Suggested-by: Phillip Wood
Helped-by: Johannes Schindelin
Signed-off-by: Todd Zullinger
---
Hi Johannes,
Johannes Schindelin wrote:
>On Mon, 18 Jun 2018, T
Junio C Hamano wrote:
> Todd Zullinger writes:
>> Or Junio may just squash this onto js/rebase-i-root-fix.
>
> Nah, not for a hotfix on the last couple of days before the final.
> We'd need to build on top, not "squash".
Indeed. I somehow missed that you&#
The default core.excludesfile path is $XDG_CONFIG_HOME/git/ignore.
$HOME/.config/git/ignore is used if XDG_CONFIG_HOME is empty or unset,
as described later in the document.
Signed-off-by: Todd Zullinger
---
Documentation/gitignore.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Make it easier to find references to core.excludesfile and the default
$XDG_CONFIG_HOME/git/ignore path.
Signed-off-by: Todd Zullinger
---
I noticed the typo in core.excludesfile and $XDG_CONFIG_HOME while I was
verifing the previous change to clarify the documentation matched the code.
Fixing
other times using `/etc/gitconfig` to refer to the system-wide
config file.
Update the SYNOPSIS of gitattributes(5) to include the system-wide
config file as well.
Signed-off-by: Todd Zullinger
---
I noticed this while looking to update gitattributes.txt to
note the system-wide config file. I t
Jeff King wrote:
> On Wed, Jun 27, 2018 at 12:56:37AM -0400, Todd Zullinger wrote:
>
>> Replace `$(prefix)/etc/gitconfig` and `$(prefix)/etc/gitattributes` in
>> generated documentation with the paths chosen when building. Readers of
>> the documentation should not ne
I wrote:
> Jeff King wrote:
>> (Related, there's a build target in the local Makefile for using
>> asciidoctor; does it need updated, too?)
>
> I didn't test asciidoctor specficially, but it also respects
> the ASCIIDOC_EXTRA parameters, so I think it will work just
> as well. I'll try
Junio C Hamano wrote:
> Todd Zullinger writes:
>
>> The default core.excludesfile path is $XDG_CONFIG_HOME/git/ignore.
>> $HOME/.config/git/ignore is used if XDG_CONFIG_HOME is empty or unset,
>
> ... because $HOME/.config is the default value for XDG_CONFIG_HOME
>
Junio C Hamano wrote:
> Jeff King writes:
>
>> Specifically, I'm thinking of:
>>
>> 1. The pre-built documentation that Junio builds for
>> quick-install-doc. This _could_ be customized during the "quick"
>> step, but it's probably not worth the effort. However, we'd want
>> some
ocumentation with a DOC_GENERIC Makefile knob.
The default generic paths may be further customized via the
DOC_ETC_GITCONFIG and DOC_ETC_GITATTRIBUTES variables.
Define DOC_GENERIC in dist-doc make target to ensure generic paths are
used in the generated html and manpage tarballs.
Helped
les if tests are run multiple times.
Add a cleanup script to force flushing the gpg-agent for that GNUPGHOME
(if any) before setting up the GPG relevant-environment.
Killing gpg-agent once per test is sufficient.
Signed-off-by: Todd Zullinger
---
t/lib-gpg.sh | 1 -
1 file changed, 1 deletio
d and sets the
GPGSM prereq. While we're here, drop the space after ">>".
Signed-off-by: Todd Zullinger
---
t/lib-gpg.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh
index f1277bef4f..207009793b 100755
--- a/t/lib-gpg.sh
nough control
for most cases.
¹ https://dev.gnupg.org/T2964
² https://fedoraproject.org/wiki/Changes/GnuPG2_as_default_GPG_implementation
Todd Zullinger (2):
t/lib-gpg: quote path to ${GNUPGHOME}/trustlist.txt
t/lib-gpg: drop redundant killing of gpg-agent
t/lib-gpg.sh | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--
Todd
SZEDER Gábor wrote:
> On Fri, Feb 08, 2019 at 05:48:27AM -0500, Randall S. Becker wrote:
>> We have a few new breakages on the NonStop port in 2.21.0-rc0. The first is
>> in t5403, as below:
[...]
>> The post-checkout hook is:
>> #!/usr/local/bin/bash
>> echo "$@" >$GIT_DIR/post-checkout.args
>>
SZEDER Gábor wrote:
> On Thu, Feb 07, 2019 at 10:17:45PM -0500, Todd Zullinger wrote:
>> When gpgsm is installed, lib-gpg.sh attempts to update trustlist.txt to
>> relax the checking of some root certificate requirements. The path to
>> "${GNUPGHOME}" contains s
Hi Sergey,
There was a previous discussion of this in December 2017,
which might be useful:
https://public-inbox.org/git/01020160a0004473-277c3d7c-4e3b-4c50-9d44-4a106f37f1d9-000...@eu-west-1.amazonses.com/
It didn't end with a patch applied, but it's likely worth
reading to help you make a case
[-cc: linux-kernel & git-packagers]
SZEDER Gábor wrote:
> On Fri, Feb 08, 2019 at 03:11:29PM -0500, Todd Zullinger wrote:
>> It made me wonder how I had missed it in my own testing.
>> This one requires SHELL_PATH to be bash, while I only set
>> TEST_SHELL_PATH to bash fo
SZEDER Gábor wrote:
> On Thu, Feb 07, 2019 at 10:17:44PM -0500, Todd Zullinger wrote:
>> Looking through the build logs for the fedora git packages, I noticed it
>> was missing the GPGSM prereq.
>
> Just curious: how did you noticed the missing GPGSM prereq?
I just grep
Hi,
Keith Smiley wrote:
>> On Feb 8, 2019, at 22:27, Todd Zullinger wrote:
>>
>> Hi Sergey,
>>
>> There was a previous discussion of this in December 2017,
>> which might be useful:
>>
>> https://public-inbox.org/git/01020160a0004473-277c3
SZEDER Gábor wrote:
> On Sat, Feb 09, 2019 at 06:05:53PM -0500, Todd Zullinger wrote:
>> SZEDER Gábor wrote:
>>> Just curious: how did you noticed the missing GPGSM prereq?
>>
>> I just grep the build output for '# SKIP|skipped:' and then
>> filter
nd", 2012-07-24) and 89c57ab3f0 ("t: pass GIT_TRACE through
Apache", 2015-03-13), respectively.
Signed-off-by: Todd Zullinger
---
I missed this with rc0, but poking through build logs I noticed a number
of 'AH01506: PassEnv variable GIT_TEST_SIDEBAND_ALL was undefined'
Jeff King wrote:
> Yeah, I do have the feeling that not many people really exercise our -rc
> candidates. I'm not sure how to improve that. We could try to push
> packagers to make them available (and I think Jonathan already does for
> Debian's "experimental" track).
Similarly, I try to make them
Jeff King wrote:
> On Thu, Feb 14, 2019 at 01:35:13AM -0500, Todd Zullinger wrote:
>
>> 07c3c2aa16 ("tests: define GIT_TEST_SIDEBAND_ALL", 2019-01-16) added
>> GIT_TEST_SIDEBAND_ALL to the apache.conf PassEnv list. Avoid warnings
>> from Apache when t
m f628825481 ("t/lib-httpd: handle running under
>> --valgrind", 2012-07-24) and 89c57ab3f0 ("t: pass GIT_TRACE through
>> Apache", 2015-03-13), respectively.
>>
>> Signed-off-by: Todd Zullinger
>> ---
>> I missed this with rc0, but poking throug
Hi,
Randall S. Becker wrote:
> On February 21, 2019 15:00, I wrote:
>> t9020 subtests 1,2,5,6 failed - Not new. unsurprising as there is no SVN or
>> perl with SVN module on platform. It might be useful to have a detection to
>> skip of Perl SVN is not present.
>
> While this is a bit of a hack,
Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason writes:
>
>> It was my reading of the seek=* section ("the implementation shall seek
>> to the specified offset"). I didn't spot that bit covered in of=*. Yeah,
>> I see that's defined & safe after reading that.
>
> OK, so...
>
> -- >8 --
> From:
Hi,
Robert P. J. Day wrote:
>
> not so much a git issue as what looks like a fedora packaging issue.
Yeah, it's just a minor packaging issue. The gitweb
manpages are included in the main git package rather than in
the gitweb package with the rest of the gitweb files. I'll
fix that for future
Hi,
I was playing with the completion.commands config added in
6532f3740b ("completion: allow to customize the completable
command list", 2018-05-20) and noticed an issue removing
multiple commands.
I wanted to remove completion for cherry and mergetool, so I
added them both to the config:
g
The completion.commands config var must be set in either the system-wide
or global config file. The completion script does not read a local
repository config.
Signed-off-by: Todd Zullinger
---
Documentation/config/completion.txt | 3 ++-
Documentation/git.txt | 3 ++-
2 files
6532f3740b ("completion: allow to customize the completable command
list", 2018-05-20) added the completion.commands config variable.
Multiple commands may be added or removed, separated by a space.
Demonstrate the failure of multiple removals.
Signed-off-by: Todd Zullinger
--
which
arrived only a few seconds later). Thanks to both of you for the
very quick replies!
I'll leave it to those who know better to follow up with a change to
use string_list_split().
Here's a first stab at improving the docs and fixing the bug.
Jeff King (1):
completion: fix multiple
From: Jeff King
6532f3740b ("completion: allow to customize the completable
command list", 2018-05-20) added the completion.commands config
variable.
The documentation states multiple commands may be added,
separated by spaces. Adding multiple commands to remove fails,
only removing the last co
SZEDER Gábor wrote:
> On Fri, Mar 01, 2019 at 01:22:52PM -0500, Eric Sunshine wrote:
>> On Fri, Mar 1, 2019 at 12:35 PM Todd Zullinger wrote:
>>> 6532f3740b ("completion: allow to customize the completable command
>>> list", 2018-05-20) added the completion.c
Jeff King wrote:
> On Fri, Mar 01, 2019 at 12:34:40PM -0500, Todd Zullinger wrote:
>
>> Jeff King wrote:
>>> I can reproduce your problem, though the test you included passes for me
>>> even with the current tip of master.
>>
>> Oh, hrm. I think the iss
1 - 100 of 233 matches
Mail list logo
