Re: [PATCH] add: don't complain when adding empty project root

2013-12-23 Thread Torsten Bögershausen
On 2013-12-23 10.02, Nguyễn Thái Ngọc Duy wrote: This behavior was added in 07d7bed (add: don't complain when adding empty project root - 2009-04-28) then broken by 84b8b5d (remove match_pathspec() in favor of match_pathspec_depth() - 2013-07-14). Reinstate it. Noticed-by: Thomas Ferris

Re: [PATCH] add: don't complain when adding empty project root

2013-12-24 Thread Torsten Bögershausen
On 2013-12-24 00.46, Duy Nguyen wrote: [snip] We don't complain about adding an empty directory before or after this patch. Ok, thanks for the explanation. I think that https://www.kernel.org/pub/software/scm/git/docs/git-add.html could deserve an update. My understanding is that filepattern

Re: aborted 'git fetch' leaves workspace unusable

2013-12-30 Thread Torsten Bögershausen
On 2013-12-30 18.07, stephen_le...@stephe-leake.org wrote: I forgot to do 'ssh-add', so a 'git fetch' running under Windows Emacs Windows native emacs or emacs under cygwin ? tried to prompt for the ssh passphrase, could not find an ssh passphrase prompt program, and aborted. That left the

Re: [PATCH] remote-hg: do not fail on invalid bookmarks

2014-01-06 Thread Torsten Bögershausen
On 2013-12-29 12.30, Antoine Pelisse wrote: Mercurial can have bookmarks pointing to nullid (the empty root revision), while Git can not have references to it. When cloning or fetching from a Mercurial repository that has such a bookmark, the import will fail because git-remote-hg will not be

Re: A question about the error: svn_fspath__is_canonical

2014-01-10 Thread Torsten Bögershausen
On 2014-01-10 20.28, Jonathan Nieder wrote: Dan Kaplan wrote: Do you think it'll still work? Yes, that's why I suggested it. ;-) You might need to install the gcc-core, libcurl-devel, openssl-devel, and subversion-perl packages first. Regards, Jonathan

Re: Git: Question about specific subtree usage

2014-01-12 Thread Torsten Bögershausen
On 2014-01-12 01.23, THILLOSEN Andreas wrote: Hi, I have a question about a specific use case for subtrees, but I'm not I feel a little bit confused: Are you talking about git submodules? And you may want to have a look at the repo tool: https://code.google.com/p/git-repo/ HTH /Torsten --

Re: Re* manpage for git-pull mentions a non-valid option -m in a comment

2014-01-14 Thread Torsten Bögershausen
On 2014-01-14 19.26, Junio C Hamano wrote: Ivan Zakharyaschev i...@altlinux.org writes: Hello! git-1.8.4.4 The manpage for git-pull mentions -m in a comment: --edit, -e, --no-edit Invoke an editor before committing successful mechanical merge to further edit the auto-generated merge

Re: [PATCH/WIP v2 03/14] read-cache: connect to file watcher

2014-01-17 Thread Torsten Bögershausen
On 2014-01-17 10.47, Nguyễn Thái Ngọc Duy wrote: [snip[ diff --git a/file-watcher-lib.c b/file-watcher-lib.c +int connect_watcher(const char *path) Could it be worth to check if we can use some code from unix-socket.c ? Especially important could be that unix_sockaddr_init() wotks around a

Re: file permissions in Git repo

2014-01-17 Thread Torsten Bögershausen
On 01/17/2014 03:26 AM, Jeff King wrote: On Thu, Jan 16, 2014 at 03:58:57PM -0800, SH wrote: We have a repository which holds lots of shell and perl scripts. We add the files to repository (from windows client) with executable permissions (using cygwin) but when we pull that repository on

Re: file permissions in Git repo

2014-01-17 Thread Torsten Bögershausen
(Please no top posting next time) On 2014-01-17 20.20, SH wrote: On Friday, January 17, 2014 10:08 AM, Torsten Bögershausen tbo...@web.de wrote: On 01/17/2014 03:26 AM, Jeff King wrote: On Thu, Jan 16, 2014 at 03:58:57PM -0800, SH wrote: We have a repository which holds lots of shell

Re: [msysGit] Consecutive git gc fails on Windows network share

2014-01-20 Thread Torsten Bögershausen
: 'rerere' 'gc' trace: built-in: git 'rerere' 'gc' The problem might be related to this commit: https://github.com/msysgit/git/commit/a1bbc6c0176f1fa2d4aa571cc0183a1f0ff9b285 Best regards, Jochen -- Am Freitag, 17. Januar 2014 19:02:07 UTC+1 schrieb Torsten Bögershausen: So

Re: libz and RHEL 5.9 compile of Git

2014-01-22 Thread Torsten Bögershausen
On 2014-01-22 16.59, salmansheikh wrote: Hello, I have a RHEL system that I am not the admin of. I needed to install git and got the source. Everything is okay until I got to this point below. I downloaded and installed the latest libz (1.2.8) but i installed it under a local directory

Re: libz and RHEL 5.9 compile of Git

2014-01-23 Thread Torsten Bögershausen
On 2014-01-22 22.27, salmansheikh wrote: Got it working but then I had some issues with the perl portions of the install and I subsequently thought I could eliminate those portions and tried setting export NO_PERL=1 and that installed everything else...and got pass this error but when I tried

[PATCH] repack.c: chmod +w before rename()

2014-01-24 Thread Torsten Bögershausen
. So setting a file to read-only under Windows is a way for a user to protect it from being deleted. Changing the behaviour of rename() globally may not be what we want. Reported-by: Jochen Haag zwanzi...@googlemail.com Signed-off-by: Torsten Bögershausen tbo...@web.de --- builtin/repack.c | 4

Re: [PATCH 2/2] setup: Don't dereference in-tree symlinks for absolute paths

2014-01-26 Thread Torsten Bögershausen
On 2014-01-26 15.22, Martin Erik Werner wrote: The prefix_path_gently() function currently applies real_path to everything if given an absolute path, dereferencing symlinks both outside and inside the work tree. In order to manipulate symliks in the work tree using absolute paths, symlinks

[PATCH v2] repack.c: Use move_temp_to_file() instead of rename()

2014-01-27 Thread Torsten Bögershausen
In a1bbc6c0 a shell command mv -f was replaced with the rename() function. Use move_temp_to_file() from sha1_file.c instead of rename(). This is in line with the handling of other Git internal tmp files, and calls adjust_shared_perm() Signed-off-by: Torsten Bögershausen tbo...@web.de --- Thanks

Re: [PATCH] add: don't complain when adding empty project root

2014-01-30 Thread Torsten Bögershausen
[] filepattern is related to current directory too (e.g. *.sh from t won't cover git-rebase.sh, :/*.sh does). Yes a patch to update git-add.txt to use the term pathspec instead of filepattern would be nice. A pointer to pathspec glossary could help discover case-insensitive matching, negative

Re: [PATCH v3 3/4] setup: Add 'abspath_part_inside_repo' function

2014-01-31 Thread Torsten Bögershausen
On 2014-01-31 21.22, Martin Erik Werner wrote: In order to extract the part of an absolute path which lies inside the repo, it is not possible to directly use real_path, since that would dereference symlinks both outside and inside the work tree. Add an 'abspath_part_inside_repo' function

Re: [PATCH 1/2] init-db.c: honor case on case preserving fs

2014-02-01 Thread Torsten Bögershausen
On 2014-02-01 10.14, Reuben Hawkins wrote: Most case-insensitive filesystems are case-preserving. In these filesystems (such as HFS+ on OS X) you can name a file Filename.txt, then rename the file to FileName.txt. That file will be accessible by both filenames, but the case is otherwise

Re: [PATCH v4 3/4] setup: Add 'abspath_part_inside_repo' function

2014-02-02 Thread Torsten Bögershausen
On 2014-02-02 12.21, David Kastrup wrote: Martin Erik Werner martinerikwer...@gmail.com writes: On Sun, Feb 02, 2014 at 09:19:04AM +0700, Duy Nguyen wrote: On Sun, Feb 2, 2014 at 8:59 AM, Martin Erik Werner martinerikwer...@gmail.com wrote: + /* check if work tree is already the

Re: [PATCH v4 3/4] setup: Add 'abspath_part_inside_repo' function

2014-02-02 Thread Torsten Bögershausen
Another comment: The raw comparison with '/' is probably working well on all POSIX/Linux/Unix systems. To be more portable, the macro is_dir_sep() can be used: if (is_dir_sep(path[wtlen])) Since the path is already normalized by 'normalize_path_copy_len' which seems to guarantee

Re: [msysGit] Re: [PATCH v2] repack.c: Use move_temp_to_file() instead of rename()

2014-02-02 Thread Torsten Bögershausen
(It seems as if the mail went only to Junio, sorry) On 2014-02-02 16.09, Torsten Bögershausen wrote: On 2014-01-29 19.17, Junio C Hamano wrote: But after a closer inspection, I no longer think that hunk is an improvement. These new packfiles were created by pack-objects, which finishes each

Re: [PATCH] fast-import.c: always honor the filename case

2014-02-02 Thread Torsten Bögershausen
On 2014-02-02 14.13, Reuben Hawkins wrote: fast-import should not use strncmp_icase. When it does, files with similar names, but different case can be lost in the import. For example... M 100644 :1 FileName.txt D Filename.txt That seems to be wrong, shouldn't it be D Filename.txt M 100644

Re: [PATCH] fast-import.c: always honor the filename case

2014-02-03 Thread Torsten Bögershausen
[] So to summarize, when fast-import uses strncmp_icase (what fast-import does now) import on a repository where ignorecase=true is wrong. My patch, fast-import.c: always honor the filename case fixes this. Can you verify? Thanks in advance, Reuben Yes, I can verify. My feeling is that

Re: [PATCH v6 4/6] t0060: Add tests for prefix_path when path begins with work tree

2014-02-04 Thread Torsten Bögershausen
On 2014-02-04 15.25, Martin Erik Werner wrote: t/t0060-path-utils.sh | 10 ++ 1 file changed, 10 insertions(+) diff --git a/t/t0060-path-utils.sh b/t/t0060-path-utils.sh index b8e92e1..c0a14f6 100755 --- a/t/t0060-path-utils.sh +++ b/t/t0060-path-utils.sh @@ -201,6 +201,16 @@

Re: [PATCH] repack.c: rename and unlink pack file if it exists

2014-02-05 Thread Torsten Bögershausen
On 2014-02-05 02.16, Jeff King wrote: On Tue, Feb 04, 2014 at 03:40:15PM -0800, Junio C Hamano wrote: * Somehow this came to my private mailbox without Cc to list, so I am forwarding it. I think with 1190a1ac (pack-objects: name pack files after trailer hash, 2013-12-05),

Re: [PATCH] repack.c: rename and unlink pack file if it exists

2014-02-05 Thread Torsten Bögershausen
On 2014-02-05 21.31, Junio C Hamano wrote: Jeff King p...@peff.net writes: The minimal fix you posted below does make sense to me as a stopgap, and we can look into dropping the code entirely during the next cycle. It would be nice to have a test to cover this case, though. Sounds

Re: [PATCH] fast-import.c: always honor the filename case

2014-02-05 Thread Torsten Bögershausen
On 2014-02-03 23.11, Reuben Hawkins wrote: On Mon, Feb 3, 2014 at 2:21 PM, Torsten Bögershausen tbo...@web.de mailto:tbo...@web.de wrote: [] So to summarize, when fast-import uses strncmp_icase (what fast-import does now) import on a repository where ignorecase=true is wrong

Re: [PATCH v3 00/26] inotify support

2014-02-08 Thread Torsten Bögershausen
On 03.02.14 05:28, Nguyễn Thái Ngọc Duy wrote: I managed to review the code 0..12/26, so some parts are missing. The list below became longer than what I intended, my comments may be hard to read, and there is a mixture of minor and major remarks. I would appreciate if we could have an outline

Re: [PATCH 1/2] dir: warn about trailing spaces in exclude pattern

2014-02-08 Thread Torsten Bögershausen
On 2014-02-08 09.10, Nguyễn Thái Ngọc Duy wrote: Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- dir.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/dir.c b/dir.c index b35b633..9edde44 100644 --- a/dir.c +++ b/dir.c @@ -491,6 +491,16 @@ void

Re: [PATCH v3 00/26] inotify support

2014-02-09 Thread Torsten Bögershausen
On 2014-02-08 09.53, Duy Nguyen wrote: Thanks for the comments. I can see I now have some work to do in the coming weeks :) file-watcher.c | 32 1 file changed, 32 insertions(+) I feel a little bit unsure about the 700. Most often

Re: [PATCH] fast-import.c: always honor the filename case

2014-02-09 Thread Torsten Bögershausen
On 2014-02-06 12.24, Reuben Hawkins wrote: [snipped away minor interesting stuff] Reading the answers from Peff and Junio, I am convinced that the fast-import should not look at core.ignorecase at all. Agreed, but my patch 0001-fast-import.c-ignorecase-iff-... is working very well

Re: [PATCH v3 00/26] inotify support

2014-02-10 Thread Torsten Bögershausen
On 2014-02-10 11.37, Duy Nguyen wrote: Could we use relative path names internally, relative to $GIT_DIR ? No because this is when the client tell the server about $GIT_DIR. I guess we can use realpath(1) here. Good. I realized that the watcher can watch several repos at the same time.

Re: [PATCH] fast-import.c: always honor the filename case

2014-02-11 Thread Torsten Bögershausen
On 2014-02-10 15.24, Reuben Hawkins wrote: On Sun, Feb 9, 2014 at 2:34 PM, Torsten Bögershausen tbo...@web.de mailto:tbo...@web.de wrote: On 2014-02-06 12 tel:2014-02-06%2012.24, Reuben Hawkins wrote: [snipped away minor interesting stuff] Reading the answers from Peff

Re: feature request: text=input option in .gitattributes

2014-02-12 Thread Torsten Bögershausen
On 2014-02-11 15.57, Cameron Taggart wrote: After requesting this as https://github.com/msysgit/msysgit/issues/164, I was told to take it upstream, so here I am. I would like a text=input feature added that has the same behavior as text=auto, except that it defaults to core.autocrlf=input

Re: [PATCH] blame: add a failing test for a CRLF issue.

2014-02-19 Thread Torsten Bögershausen
On 02/18/2014 08:45 PM, brian m. carlson wrote: If a file contains CRLF line endings in a repository with core.autocrlf=input, then blame always marks the lines as Not Committed Yet, even if they are unmodified. Add a failing test for this case, so we are at least aware of this issue.

Re: What's cooking in git.git (Feb 2014, #06; Wed, 19)

2014-02-21 Thread Torsten Bögershausen
On 2014-02-21 10.55, Max Horn wrote: On 20.02.2014, at 20:22, Junio C Hamano gits...@pobox.com wrote: Max Horn m...@quendi.de writes: On 19.02.2014, at 22:41, Junio C Hamano gits...@pobox.com wrote: * fc/transport-helper-fixes (2013-12-09) 6 commits - remote-bzr: support the new 'force'

Re: git-svn fetch after tag conversion?

2014-02-21 Thread Torsten Bögershausen
On 2014-02-21 15.42, Robert Dailey wrote: I'm converting a large SVN repository to a Git repository. I've run the first step of `git svn fetch` and now I have all of my branches, tags, and trunk. However my tags are still just branches, I have not converted them yet. As I transition my team

Re: Git in GSoC 2014 Suggestion: core.filemode always false for cygwin

2014-02-26 Thread Torsten Bögershausen
On 2014-02-25 16.41, Jeff King wrote: I'm pleased to announce that Git has been accepted to this year's Google Summer of Code. I'm not sure if this is the right way to propose mini projects, but in case the answer is not no, may I suggest one: Motivation, the problem: Since commit

Re: Branch Name Case Sensitivity

2014-02-27 Thread Torsten Bögershausen
On 2014-02-27 20.50, Junio C Hamano wrote: Lee Hopkins leer...@gmail.com writes: Last week I ran across a potential bug with branch names on case insensitive file systems, the complete scenario can be found here: https://groups.google.com/forum/#!topic/msysgit/ugKL-sVMiqI The tldr is

Re: Branch Name Case Sensitivity

2014-02-28 Thread Torsten Bögershausen
On 2014-03-01 03.42, Lee Hopkins wrote: I went ahead and took a stab at a solution. My solution is more aggressive than a warning, I actually prevent the creation of ambiguous refs. My changes are also in refs.c, which may not be appropriate, but it seemed like the natural place. I have

Re: [PATCH v4 13/27] git-stash: avoid hardcoding $GIT_DIR/logs/....

2014-03-01 Thread Torsten Bögershausen
On 2014-03-01 13.12, Nguyễn Thái Ngọc Duy wrote: Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- git-stash.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/git-stash.sh b/git-stash.sh index ae7d16e..12d9b37 100755 --- a/git-stash.sh +++ b/git-stash.sh

Re: [PATCH v4 19/27] wrapper.c: wrapper to open a file, fprintf then close

2014-03-01 Thread Torsten Bögershausen
On 2014-03-01 13.12, Nguyễn Thái Ngọc Duy wrote: Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- cache.h | 2 ++ wrapper.c | 31 +++ 2 files changed, 33 insertions(+) diff --git a/cache.h b/cache.h index 98b5dd3..99b86d9 100644 --- a/cache.h +++

Re: [PATCH v4 24/27] prune: strategies for linked checkouts

2014-03-01 Thread Torsten Bögershausen
On 2014-03-01 13.13, Nguyễn Thái Ngọc Duy wrote: [] +static dev_t get_device_or_die(const char *path) +{ + struct stat buf; + if (stat(path, buf)) + die_errno(failed to stat '%s', path); + /* Ah Windows! Make different drives different partitions */ + if

Re: Branch Name Case Sensitivity

2014-03-04 Thread Torsten Bögershausen
On 2014-03-04 14.23, Karsten Blees wrote: Am 03.03.2014 18:51, schrieb Junio C Hamano: Lee Hopkins leer...@gmail.com writes: I went ahead and took a stab at a solution. My solution is more aggressive than a warning, I actually prevent the creation of ambiguous refs. My changes are also in

Re: [PATCH v5 01/28] path.c: make get_pathname() return strbuf instead of static buffer

2014-03-07 Thread Torsten Bögershausen
On 2014-03-08 03.47, Nguyễn Thái Ngọc Duy wrote: We've been avoiding PATH_MAX whenever possible. This patch makes get_pathname() return a strbuf and updates the callers to take advantage of this. The code is simplified as we no longer need to worry about buffer overflow. vsnpath() behavior

Re: howto to run git without a master branch

2014-03-08 Thread Torsten Bögershausen
On 2014-03-08 22.37, Carlos Pereira wrote: Hi, git newbie here. I would like to work with two main branches: master-g and master-x, instead of the usual master, and apparently git does not like this. After creating a local repository with these two branches, and a server repository

Re: What's cooking in git.git (Mar 2014, #03; Fri, 14)

2014-03-15 Thread Torsten Bögershausen
On 2014-03-14 23.09, Junio C Hamano wrote: * ap/remote-hg-skip-null-bookmarks (2014-01-02) 1 commit - remote-hg: do not fail on invalid bookmarks Reported to break tests ($gmane/240005) Expecting a reroll. I wonder what should happen here. The change breaks all the tests in

Re: [PATCH 3/7] test patch hunk editing with commit -p -m

2014-03-15 Thread Torsten Bögershausen
On 2014-03-11 22.03, Junio C Hamano wrote: Benoit Pierre benoit.pie...@gmail.com writes: Add (failing) test: with commit changing the environment to let hooks now that no editor will be used (by setting GIT_EDITOR to :), the edit hunk functionality does not work (no editor is launched and

Re: [PATCH 3/7] test patch hunk editing with commit -p -m

2014-03-15 Thread Torsten Bögershausen
On 2014-03-15 17.11, Benoit Pierre wrote: On Sat, Mar 15, 2014 at 1:28 PM, Torsten Bögershausen tbo...@web.de wrote: On 2014-03-11 22.03, Junio C Hamano wrote: Benoit Pierre benoit.pie...@gmail.com writes: Add (failing) test: with commit changing the environment to let hooks now

Re: [PATCH] git-rebase: Teach rebase - shorthand.

2014-03-18 Thread Torsten Bögershausen
On 03/18/2014 09:44 AM, Brian Gesiak wrote: Teach rebase the same shorthand as checkout and merge; that is, that - means the branch we were previously on. Reported-by: Tim Chase g...@tim.thechases.com Signed-off-by: Brian Gesiak modoca...@gmail.com --- git-rebase.sh | 4

Re: [PATCH 4/7] commit: fix patch hunk editing with commit -p -m

2014-03-19 Thread Torsten Bögershausen
On 03/18/2014 11:00 AM, Benoit Pierre wrote: Don't change git environment: move the GIT_EDITOR=: override to the hook command subprocess, like it's already done for GIT_INDEX_FILE. Signed-off-by: Benoit Pierre benoit.pie...@gmail.com --- builtin/checkout.c | 8 builtin/clone.c

Re: What's cooking in git.git (Mar 2014, #04; Thu, 20)

2014-03-20 Thread Torsten Bögershausen
On 03/20/2014 10:09 PM, Junio C Hamano wrote: * ap/remote-hg-skip-null-bookmarks (2014-03-19) 1 commit - remote-hg: do not fail on invalid bookmarks Will merge to 'next'. Hmm, am I the only one who has 11 failures in test-hg-hg-git.sh, like this: (Tested under Debian 7, commit

Re: [PATCH v3] remote-hg: do not fail on invalid bookmarks

2014-03-21 Thread Torsten Bögershausen
On 2014-03-21 12.36, Max Horn wrote: All tests passed :-), thanks from my side. comments inline, some are debatable Mercurial can have bookmarks pointing to nullid (the empty root revision), while Git can not have references to it. When cloning or fetching from a Mercurial repository that has

Re: File extension conflict when working with git and latex

2014-03-22 Thread Torsten Bögershausen
On 2014-03-21 17.13, Matthias Beyer wrote: Hi, I struggled with a really nasty issue today (and yesterday): I work on a semester project paper which is written in latex and therefor version-controlled with git. We compile the document using pdflatex, we automate the compiling with make.

Re: [PATCH v3] remote-hg: do not fail on invalid bookmarks

2014-03-22 Thread Torsten Bögershausen
On 2014-03-21 23.32, Junio C Hamano wrote: Max Horn m...@quendi.de writes: Hi Torsten, On 21.03.2014, at 21:47, Torsten Bögershausen tbo...@web.de wrote: On 2014-03-21 12.36, Max Horn wrote: All tests passed :-), Excellent. thanks from my side. comments inline, some are debatable

Re: Git-hooks pre-push script does not receive input on stdin

2014-03-23 Thread Torsten Bögershausen
On 2014-03-23 01.44, David Cowden wrote: http://stackoverflow.com/questions/22585091/git-hooks-pre-push-script-does-not-receive-input-via-stdin Is this a bug in git? Or am I just a shell noob? Thanks in advance, David I assume that you have the right version of Git ? You can look into

Re: [PATCH v3 18/25] setup.c: support multi-checkout repo setup

2014-03-24 Thread Torsten Bögershausen
On 02/18/2014 02:40 PM, Nguyễn Thái Ngọc Duy wrote: The repo setup procedure is updated to detect $GIT_DIR/commondir and set $GIT_COMMON_DIR properly. The core.worktree is ignored when $GIT_DIR/commondir presents. This is because commondir repos are intended for separate/linked checkouts and

Re: [PATCH 05/22] lockfile: unlock file if lockfile permissions cannot be adjusted

2014-04-02 Thread Torsten Bögershausen
[] diff --git a/lockfile.c b/lockfile.c index c1af65b..1928e5e 100644 --- a/lockfile.c +++ b/lockfile.c @@ -148,9 +148,11 @@ static int lock_file(struct lock_file *lk, const char *path, int flags) lock_file_list = lk; lk-on_list = 1;

Re: [PATCH 12/22] delete_ref_loose(): don't muck around in the lock_file's filename

2014-04-02 Thread Torsten Bögershausen
[] diff --git a/refs.c b/refs.c index 28d5eca..11ad23e 100644 --- a/refs.c +++ b/refs.c @@ -2485,12 +2485,14 @@ static int repack_without_ref(const char *refname) static int delete_ref_loose(struct ref_lock *lock, int flag) { if (!(flag REF_ISPACKED) || flag REF_ISSYMREF) { -

Re: [PATCH 13/22] config: change write_error() to take a (struct lock_file *) argument

2014-04-02 Thread Torsten Bögershausen
On 04/01/2014 05:58 PM, Michael Haggerty wrote: Reduce the amount of code that has to know about the lock_file's filename field. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- config.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/config.c

Re: What's cooking in git.git (Apr 2014, #01; Fri, 4)

2014-04-05 Thread Torsten Bögershausen
On 2014-04-05 11.19, Johannes Sixt wrote: Am 04.04.2014 22:58, schrieb Junio C Hamano: * sz/mingw-index-pack-threaded (2014-03-19) 1 commit - Enable index-pack threading in msysgit. What is the status of this topic? A failure report exists ($gmane/245170), and I am aware of Duy's

[PATCH] Unicode: update of combining code points

2014-04-07 Thread Torsten Bögershausen
the range 300-6FF, there may be more to be updated. Signed-off-by: Torsten Bögershausen tbo...@web.de --- utf8.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/utf8.c b/utf8.c index a831d50..77c28d4 100644 --- a/utf8.c +++ b/utf8.c @@ -84,11 +84,10 @@ static int git_wcwidth

[PATCH] Unicode: update of combining code points

2014-04-07 Thread Torsten Bögershausen
the range 300-6FF, there may be more to be updated. Signed-off-by: Torsten Bögershausen tbo...@web.de --- utf8.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/utf8.c b/utf8.c index a831d50..77c28d4 100644 --- a/utf8.c +++ b/utf8.c @@ -84,11 +84,10 @@ static int git_wcwidth

[PATCH] Unicode: update of combining code points

2014-04-07 Thread Torsten Bögershausen
the range 300-6FF, there may be more to be updated. Signed-off-by: Torsten Bögershausen tbo...@web.de --- utf8.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/utf8.c b/utf8.c index a831d50..77c28d4 100644 --- a/utf8.c +++ b/utf8.c @@ -84,11 +84,10 @@ static int git_wcwidth

[PATCH] Unicode: update of combining code points

2014-04-07 Thread Torsten Bögershausen
the range 300-6FF, there may be more to be updated. Signed-off-by: Torsten Bögershausen tbo...@web.de --- utf8.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/utf8.c b/utf8.c index a831d50..77c28d4 100644 --- a/utf8.c +++ b/utf8.c @@ -84,11 +84,10 @@ static int git_wcwidth

Re: What's cooking in git.git (Apr 2014, #01; Fri, 4)

2014-04-08 Thread Torsten Bögershausen
On 04/07/2014 09:42 PM, Ramsay Jones wrote: On 07/04/14 19:35, Johannes Sixt wrote: Am 05.04.2014 11:19, schrieb Johannes Sixt: Am 04.04.2014 22:58, schrieb Junio C Hamano: * sz/mingw-index-pack-threaded (2014-03-19) 1 commit - Enable index-pack threading in msysgit. What is the status

Re: [PATCH] Unicode: update of combining code points

2014-04-09 Thread Torsten Bögershausen
On 04/09/2014 12:37 AM, Junio C Hamano wrote: Jonathan Nieder jrnie...@gmail.com writes: Torsten Bögershausen wrote: Unicode 6.3 defines the following code as combining or accents, git_wcwidth() should return 0. Earlier unicode standards had defined these code point as reserved: Thanks

Re: [PATCH] Unicode: update of combining code points

2014-04-09 Thread Torsten Bögershausen
Excellent, thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 2/2] Verify index file before we opportunistically update it

2014-04-11 Thread Torsten Bögershausen
On 2014-04-10 21.28, Junio C Hamano wrote: Yiannis Marangos yiannis.maran...@gmail.com writes: +n = xpread(fd, sha1, 20, st.st_size - 20); +if (n != 20) +goto out; I think it is possible for pread(2) to give you a short-read. The existing callers of emulated mmap

Re: wrong handling of text git attribute leading to files incorrectly reported as modified

2014-04-11 Thread Torsten Bögershausen
On 2014-04-11 22.20, Frank Ammeter wrote: I’m not a git expert and this might be the wrong place to ask this question, so please send me somewhere else if I’m in the wrong place. I asked the same question on stack overflow, but didn’t get any response:

Re: [PATCH v3 00/25] Lockfile correctness and refactoring

2014-04-15 Thread Torsten Bögershausen
refs.c: int close_ref(struct ref_lock *lock) { if (close_lock_file(lock-lk)) return -1; lock-lock_fd = -1; return 0; } When the close() fails, fd is still = 0, even if the file is closed. Could it be written like this ? int close_ref(struct ref_lock

Re: [PATCH] Unicode: update of combining code points

2014-04-15 Thread Torsten Bögershausen
On 15.04.14 21:10, Peter Krefting wrote: Torsten Bögershausen: diff --git a/utf8.c b/utf8.c index a831d50..77c28d4 100644 --- a/utf8.c +++ b/utf8.c Is there a script that generates this code from the Unicode database files, or did you hand-update it? Some of the code points which

Re: [PATCH] config.c: fix a compiler warning

2014-04-16 Thread Torsten Bögershausen
On 2014-04-16 17.29, Jeff King wrote: On Wed, Apr 16, 2014 at 04:13:53PM +0200, Stepan Kasal wrote: Date: Thu, 10 Apr 2014 16:37:15 +0200 This change fixes a gcc warning when building msysGit. [] +NORETURN static void die_bad_number(const char *name, const char *value) { const

Re: [PATCH] Unicode: update of combining code points

2014-04-16 Thread Torsten Bögershausen
On 2014-04-16 12.51, Kevin Bracey wrote: On 16/04/2014 07:48, Torsten Bögershausen wrote: On 15.04.14 21:10, Peter Krefting wrote: Torsten Bögershausen: diff --git a/utf8.c b/utf8.c index a831d50..77c28d4 100644 --- a/utf8.c +++ b/utf8.c Is there a script that generates this code from

[PATCH v2] utf8.c: partially update to version 6.3

2014-04-17 Thread Torsten Bögershausen
/~mgk25/download/uniset.tar.gz fi if ! test -f uniset; then tar xzf uniset.tar.gz fi ) ./uniset/uniset +cat=Me +cat=Mn +cat=Cf -00AD +1160-11FF +200B c Helped-by: Kevin Bracey ke...@bracey.fi Signed-off-by: Torsten Bögershausen tbo...@web.de --- utf8.c | 116

Re: [PATCH] t3910: show failure of core.precomposeunicode with decomposed filenames

2014-04-28 Thread Torsten Bögershausen
On 28.04.14 21:35, Jeff King wrote: On Mon, Apr 28, 2014 at 12:17:28PM -0700, Junio C Hamano wrote: 3. Convert index filenames to their precomposed form when we read the index from disk. This would be efficient, but we would have to be careful not to write the precomposed

Re: [PATCH 03/12] MINGW: compat/mingw.h: do not attempt to redefine lseek on mingw-w64

2014-04-28 Thread Torsten Bögershausen
On 2014-04-28 15.51, Marat Radchenko wrote: mingw-w64 has lseek defined in io.h. [] #define off_t off64_t +#ifndef lseek #define lseek _lseeki64 +#endif Is the commit message in line with the code? I would have expected something in this style: #if defined(__x86_64__) ! defined(lseek))

Re: [PATCH] t3910: show failure of core.precomposeunicode with decomposed filenames

2014-04-28 Thread Torsten Bögershausen
On 2014-04-28 22.03, Jeff King wrote: On Mon, Apr 28, 2014 at 09:52:07PM +0200, Torsten Bögershausen wrote: To my knowledge repos with decomposed unicode should be rare in practice. I only can speak for european (or latin based) or cyrillic languages myself: I've run across several cases

Re: [PATCH] t3910: show failure of core.precomposeunicode with decomposed filenames

2014-04-29 Thread Torsten Bögershausen
On 04/29/2014 05:23 AM, Jeff King wrote: On Mon, Apr 28, 2014 at 10:49:30PM +0200, Torsten Bögershausen wrote: OK, thanks for the description. In theory we can make Git composition ignoring by changing index_file_exists() in name-hash.c. (Both names must be precomposed first and compared

Re: [PATCH] t3910: show failure of core.precomposeunicode with decomposed filenames

2014-04-30 Thread Torsten Bögershausen
review: commit 85305ce306cb88a07dad6350d6ba8c5f2f817af6 Author: Torsten Bögershausen tbo...@web.de Date: Wed Apr 30 10:30:04 2014 +0200 core.precomposeunicode with decomposed filenames Commit 750b2e4785e shows a failure of core.precomposeunicode when decomposed filenames

Re: [PATCH] t3910: show failure of core.precomposeunicode with decomposed filenames

2014-05-04 Thread Torsten Bögershausen
(Sorry for the late reply, I'm handicapped by some local IT problems) Peff, do you know if the fix below helps ? On 2014-04-28 18.16, Jeff King wrote: If you have existing decomposed filenames in your git repository (e.g., that were created with older versions of git that did not precompose

Re: [PATCH] t3910: show failure of core.precomposeunicode with decomposed filenames

2014-05-04 Thread Torsten Bögershausen
On 2014-04-30 16.57, Torsten Bögershausen wrote: There is something wrong with the patch, (test suite hangs or TC fail), so I need to com back later. Sorry for the noise. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] t3910: show failure of core.precomposeunicode with decomposed filenames

2014-05-07 Thread Torsten Bögershausen
On 2014-05-05 23.46, Jeff King wrote: [] 2. Do all index filename comparisons under Mac OS X using a UTF-8 aware comparison function regardless if core.precomposeunicode is set. This would probably have bad performance, and somewhat defeats the point of converting the

Re: [PATCH 2/2] ignorecase: Fix git mv on insensitive filesystems

2014-05-08 Thread Torsten Bögershausen
On 05/08/2014 08:37 AM, Johannes Sixt wrote: Am 5/7/2014 19:46, schrieb Junio C Hamano: David Turner dtur...@twopensource.com writes: On Wed, 2014-05-07 at 08:17 +0200, Johannes Sixt wrote: } else if (cache_name_pos(src, length) 0) bad = _(not under

[PATCH 1/2] utf8.c: use a table for double_width

2014-05-09 Thread Torsten Bögershausen
Refactor git_wcwidth() and replace the if-else-if chain. Use the table double_width which is scanned by the bisearch() function, which is already used to find combining code points. Signed-off-by: Torsten Bögershausen tbo...@web.de --- utf8.c | 41 ++--- 1

[PATCH 2/2] Make it possible to update git_wcwidth()

2014-05-09 Thread Torsten Bögershausen
...@bracey.fi for helping with their Unicode knowledge Signed-off-by: Torsten Bögershausen tbo...@web.de --- .gitignore| 1 + Makefile | 1 + unicode_width.h | 288 ++ update_unicode.sh | 37 +++ utf8.c

Re: Error using git-remote-hg

2014-05-12 Thread Torsten Bögershausen
I'm using git 1.9.3 on Mac OS X 10.9.2, with hg 3.0 installed with brew. It used to work before, on this same repository, since then git and hg were both upgraded. In short: The remote helper of Git 1.9.3 is not compatible with hg 3.0 You can eiher downgrade hg, or rebuild Git and

Re: Error using git-remote-hg

2014-05-13 Thread Torsten Bögershausen
(Please use reply-all and don't snip the important stuff) On 2014-05-13 09.54, Charles Brossollet wrote: Le 12 mai 2014 à 21:37, Felipe Contreras felipe.contre...@gmail.com a écrit : Torsten Bögershausen wrote: I'm using git 1.9.3 on Mac OS X 10.9.2, with hg 3.0 installed with brew

Re: Git on Mac OS X 10.4.10

2014-08-14 Thread Torsten Bögershausen
On 08/14/2014 02:13 PM, Markus Hitter wrote: I'm new to this list, so: Hello everybody! My backup servers run Mac OS X 10.4.10. Yes, these are old, but very reliable and easily up to the task. And Mac OS X 10.4 is the latest OS supported there (PowerPC G3). Recently I tried to upgrade to

Re: [PATCH v3 03/10] setup: convert setup_git_directory_gently_1 et al. to strbuf

2014-08-16 Thread Torsten Bögershausen
On 2014-07-28 20.26, René Scharfe wrote: Convert setup_git_directory_gently_1() and its helper functions setup_explicit_git_dir(), setup_discovered_git_dir() and setup_bare_git_dir() to use a struct strbuf to hold the current working directory. Replacing the PATH_MAX-sized buffer used before

[PATCH 2/2] Push the Makefile variable NATIVE_CRLF to C

2014-08-16 Thread Torsten Bögershausen
Re-do the fix in 757543ae0c5d8d: Propagate the Makefile variable NATIVE_CRLF to the C preprocessor Signed-off-by: Torsten Bögershausen tbo...@web.de --- Makefile | 4 1 file changed, 4 insertions(+) diff --git a/Makefile b/Makefile index 63a210d..00ba537 100644 --- a/Makefile +++ b

[PATCH 1/2] t0027: Tests for core.eol=native, eol=lf, eol=crlf

2014-08-16 Thread Torsten Bögershausen
for shell functions according to the coding guide lines - Replace txtbin with attr Signed-off-by: Torsten Bögershausen tbo...@web.de --- t/t0027-auto-crlf.sh | 220 --- 1 file changed, 120 insertions(+), 100 deletions(-) diff --git a/t/t0027-auto

t5534 broken when gpg not installed

2014-08-16 Thread Torsten Bögershausen
(I couldn't find a post for this patch) The following is needed for systems without gpg to make t5534 pass: diff --git a/t/t5534-push-signed.sh b/t/t5534-push-signed.sh index 3acc864..ee5aaff 100755 --- a/t/t5534-push-signed.sh +++ b/t/t5534-push-signed.sh @@ -45,7 +45,7 @@ test_expect_success

[PATCH] Push the NATIVE_CRLF Makefile variable to C and added a test for native.

2014-08-18 Thread Torsten Bögershausen
as native is crlf, we actually normalize text files to this line ending convention when core.autocrlf is false. Signed-off-by: Pat Thoyts pattho...@users.sourceforge.net Signed-off-by: Stepan Kasal ka...@ucw.cz Signed-off-by: Torsten Bögershausen tbo...@web.de --- (This is from MINGW, and some part of my

[PATCH v2 1/3] Push the NATIVE_CRLF Makefile variable to C and added a test for native.

2014-08-22 Thread Torsten Bögershausen
as native is crlf, we actually normalize text files to this line ending convention when core.autocrlf is false. Signed-off-by: Pat Thoyts pattho...@users.sourceforge.net Signed-off-by: Stepan Kasal ka...@ucw.cz Signed-off-by: Torsten Bögershausen tbo...@web.de --- This mini series mainly updates git.git

[PATCH v2 3/3] t0026: Add missing

2014-08-22 Thread Torsten Bögershausen
Fix the broken chain Reported-By: Eric Sunshine sunsh...@sunshineco.com Signed-off-by: Torsten Bögershausen tbo...@web.de --- t/t0026-eol-config.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t0026-eol-config.sh b/t/t0026-eol-config.sh index 43a580a..4806969

[PATCH v2 2/3] MinGW: Update tests to handle a native eol of crlf

2014-08-22 Thread Torsten Bögershausen
Some of the tests were written with the assumption that the native eol would always be lf. After defining NATIVE_CRLF on MinGW, these tests began failing. This change will update the tests to also handle a native eol of crlf. Signed-off-by: Brice Lambson brice...@live.com Signed-off-by: Torsten

Re: [PATCH v2 1/3] Push the NATIVE_CRLF Makefile variable to C and added a test for native.

2014-08-23 Thread Torsten Bögershausen
On 2014-08-23 00.54, Junio C Hamano wrote: Torsten Bögershausen tbo...@web.de writes: Commit 95f31e9a correctly points out that the NATIVE_CRLF setting is incorrectly set on Mingw git. However, the Makefile variable is not propagated to the C preprocessor and results in no change. This patch

Re: [PATCH] Undefine strlcpy if needed.

2014-08-24 Thread Torsten Bögershausen
On 2014-08-24 18.18, Ramsay Jones wrote: On 24/08/14 12:13, tsuna wrote: On Sun, Aug 24, 2014 at 4:10 AM, Ramsay Jones ram...@ramsay1.demon.co.uk wrote: Hmm, which version of OS X are we talking about? OS X 10.9.4: $ uname -a Darwin damogran.local 13.3.0 Darwin Kernel Version 13.3.0: Tue

  1   2   3   4   5   6   7   8   9   10   >