[BUG] v2.16.0-rc0 seg faults when git bisect skip

2018-01-03 Thread Yasushi SHOJI
Hi, git version 2.16.0.rc0 seg faults on my machine when I git bisect skip Here is a back trace: $ /opt/mygit/bin/git --version git version 2.16.0.rc0 $ /opt/mygit/bin/git bisect skip Segmentation fault (core dumped) $ gdb /opt/mygit/bin/git core GNU gdb (Debian 7.12-6+b1) 7.12.0.20161007-git

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

2018-01-04 Thread Yasushi SHOJI
Hi, On Thu, Jan 4, 2018 at 3:26 AM, Martin Ågren wrote: > On 3 January 2018 at 15:21, Ævar Arnfjörð Bjarmason wrote: >> >> On Wed, Jan 03 2018, Yasushi SHOJI jotted: >> >>> Hi, >>> >>> git version 2.16.0.rc0 seg faults on my machine when I >

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

2018-01-04 Thread Yasushi SHOJI
Hi, On Fri, Jan 5, 2018 at 11:45 AM, Yasushi SHOJI wrote: > So that I can make a test case. OK, here is the step to reproduce on git.git $ git bisect start $ git bisect bad v2.16.0-rc0 $ git bisect good 0433d533f13671f4313c31e34707f0f5281a18e0 $ git bisect good $ git bisect bad $ git bis

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

2018-01-06 Thread Yasushi SHOJI
Hi Martin, Thank you for your comment. I haven't have time to read the code carefully so bare with me. On Sat, Jan 6, 2018 at 5:21 PM, Martin Ågren wrote: >> On Fri, Jan 5, 2018 at 11:45 AM, Yasushi SHOJI >> wrote: >>> When does the list allowed to contain NULLs? &

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

2018-01-08 Thread Yasushi SHOJI
d? I also found a bug in show_list(). I'm attaching a patch as well. -- yashi From d149a1348e94ea0246a10181751ce3bf9ba48198 Mon Sep 17 00:00:00 2001 From: Yasushi SHOJI Date: Mon, 8 Jan 2018 22:31:10 +0900 Subject: [PATCH 1/2] bisect: debug: convert struct o

Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip

2018-01-09 Thread Yasushi SHOJI
Hi, On Tue, Jan 9, 2018 at 12:09 AM, Christian Couder wrote: > ... "i == cnt" is always false above. I think it should be "i == cnt - 1". uga. Thanks. That's stupid of me. > And with your code one can wonder why the cleanup is part of the loop. OK. I have nothing to offer, then. Thank you

[PATCH] bisect: debug: convert struct object to object_id

2018-01-09 Thread Yasushi SHOJI
The commit f2fd0760f62e79609fef7bfd7ecebb002e8e4ced converted struct object to object_id but a debug function show_list(), which is ifdef'ed to noop, in bisect.c wasn't. So fix it. Signed-off-by: Yasushi SHOJI --- bisect.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH] RelNotes: fsmonitor: add a pointer to man page and the word itself

2018-01-16 Thread Yasushi SHOJI
Add a pointer to git-update-index(1) and a bit more detail about fsmonitor and watchman to help people following up the new feature. --- Hi Ben and Junio, Wouldn't it be nice to tell the world a bit more about "file system monitor" we now support? I think that "git status" and "watchman" might n

[patch] possible memory leak in diff.c::diff_free_filepair()

2005-08-13 Thread Yasushi SHOJI
UMMARY: ==27983==definitely lost: 0 bytes in 0 blocks. ==27983== possibly lost: 0 bytes in 0 blocks. ==27983==still reachable: 276 bytes in 6 blocks. ==27983== suppressed: 0 bytes in 0 blocks. Signed-off-by: Yasushi SHOJI <[EMAIL PROTECTED]> --- diff --git a/diff.c

Re: [patch] possible memory leak in diff.c::diff_free_filepair()

2005-08-13 Thread Yasushi SHOJI
At Sat, 13 Aug 2005 12:30:59 -0700, Junio C Hamano wrote: > > Yasushi SHOJI <[EMAIL PROTECTED]> writes: > > > When I run git-diff-tree on big change, it seems the command eats so > > much memory. so I just put git under valgrind to see what's going on. > >

[PATCH] Just run Ispell through git.txt

2005-08-15 Thread Yasushi SHOJI
[PATCH] Just run Ispell through git.txt Signed-off-by: Yasushi SHOJI <[EMAIL PROTECTED]> --- Documentation/git.txt | 16 1 files changed, 8 insertions(+), 8 deletions(-) 7752fb658ce21b5156547593df01a3a4584ebf80 diff --git a/Documentation/git.txt b/Documentation/git.txt

Re: gitweb - option to disable rename detection

2005-08-15 Thread Yasushi SHOJI
At Mon, 15 Aug 2005 11:53:20 -0700 (PDT), Linus Torvalds wrote: > > On Tue, 16 Aug 2005, Yasushi SHOJI wrote: > > > > It seems to me that git-diff-tree needs huge memory if you try to diff > > on big change with rename detection enabled. > > > > This isn&#

Re: [patch] possible memory leak in diff.c::diff_free_filepair()

2005-08-15 Thread Yasushi SHOJI
At Sat, 13 Aug 2005 14:31:59 -0700, Junio C Hamano wrote: > > Yasushi SHOJI <[EMAIL PROTECTED]> writes: > > > oops. probably my english wasn't clear. my patch fixes > > diff_free_filepair(). > > When the command is run on linux-2.6 repository, virtual

Re: [RFC PATCH] Add support for figuring out where in the git archive we are

2005-08-16 Thread Yasushi SHOJI
At Tue, 16 Aug 2005 15:45:35 -0700 (PDT), Linus Torvalds wrote: > > This is really partly a serious patch, but also just a query whether > people would want git to work in subdirectories, not just the top-level > directory. > > So you can be in linux/drivers, and if you do a > > git-diff

Re: gitweb - option to disable rename detection

2005-08-16 Thread Yasushi SHOJI
At Mon, 15 Aug 2005 15:43:26 -0700 (PDT), Linus Torvalds wrote: > > On Tue, 16 Aug 2005, Yasushi SHOJI wrote: > > > > > Instead of disabling it entirely, how about just having some limit on it? > > > > ah, that's a good idea. here is a quick and dirty p

[PATCH] gitweb - Use instead of .

2005-08-18 Thread Yasushi SHOJI
Use instead of . RSS 2.0 Specification doesn't have . see http://blogs.law.harvard.edu/tech/rss I've tested this with Mozilla Thunderbird version 1.0.6 (20050802), and seems to be working well. Signed-off-by: Yasushi SHOJI <[EMAIL PROTECTED]> --- gitweb.cgi |5 ++--- 1

[PATCH] gitweb - Add and .

2005-08-18 Thread Yasushi SHOJI
the author of the item. guid - A string that uniquely identifies the item. Signed-off-by: Yasushi SHOJI <[EMAIL PROTECTED]> --- gitweb.cgi |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) 0a477312bf2975cf3240d3cf107ff7ac2e32049a diff --git a/gitweb.cgi b/gitweb.cgi --- a/g

Re: [PATCH] gitweb - Use instead of .

2005-08-18 Thread Yasushi SHOJI
At Thu, 18 Aug 2005 18:01:09 +0200, Kay Sievers wrote: > > On Thu, Aug 18, 2005 at 11:30:41PM +0900, Yasushi SHOJI wrote: > > Use instead of . > > > > RSS 2.0 Specification doesn't have . > > see http://blogs.law.harvard.edu/tech/rss > > See here: >

Re: [PATCH] gitweb - Use instead of .

2005-08-18 Thread Yasushi SHOJI
At Thu, 18 Aug 2005 17:36:07 +0200, Sven Verdoolaege wrote: > > On Thu, Aug 18, 2005 at 11:30:41PM +0900, Yasushi SHOJI wrote: > > Use instead of . > > > > Hmm in snownews this gets displayed as "Use instead of .". > (http://www.liacs.nl/~sverdool/g

Re: [patch] possible memory leak in diff.c::diff_free_filepair()

2005-08-21 Thread Yasushi SHOJI
At Mon, 15 Aug 2005 21:32:12 -0700, Junio C Hamano wrote: > > Yasushi SHOJI <[EMAIL PROTECTED]> writes: > > > parepare_temp_file() and diff_populate_filespec() has a lot in > > similarity. so it'd be nice to refactor some. and re-introduce > > diff_fre

Re: [PATCH] Introduce "reset type" flag to "git reset"

2005-08-23 Thread Yasushi SHOJI
At Tue, 23 Aug 2005 15:08:44 -0700, Junio C Hamano wrote: > > Sam Ravnborg <[EMAIL PROTECTED]> writes: > > > But --soft, --hard looks rather confusing to me. > > > > Something like --force or --prune may be a bit more intuitive, and let > > default behaviour be the one you name --soft for now. >

Re: [PATCH] Introduce "reset type" flag to "git reset"

2005-08-23 Thread Yasushi SHOJI
At Tue, 23 Aug 2005 17:22:47 -0700, Junio C Hamano wrote: > > Yasushi SHOJI <[EMAIL PROTECTED]> writes: > > > for --hard option, what you want to do is to completely revert the > > current state of your index file and work tree to known point. > > > >