Selectively clone Git submodules -- a useful feature?

2015-06-18 Thread Lars Schneider
Hi, AFAIK Git has two ways to clone a repository with respect to submodules: (1) Plain clone of just the repository itself: git clone git://github.com/foo/bar.git (2) Recursive clone of the repository including all its submodules: git clone --recursive git://github.com/foo/bar.git I am working

Re: [PATCH v4] git-p4: fix faulty paths for case insensitive systems

2015-08-23 Thread Lars Schneider
On 21 Aug 2015, at 20:01, Junio C Hamano gits...@pobox.com wrote: larsxschnei...@gmail.com writes: From: Lars Schneider larsxschnei...@gmail.com PROBLEM: We run P4 servers on Linux and P4 clients on Windows. For an unknown reason the file path for a number of files in P4 does not match

Re: [PATCH v4] git-p4: fix faulty paths for case insensitive systems

2015-08-24 Thread Lars Schneider
snip While I was working on the examples for this email reply I realized that the problem is only present for paths given in a client-spec. I added a test case to prove that. That means I don’t need to request *all* paths. I *think* it is sufficient to request the paths mentioned in

Re: [PATCH v2] git-p4: fix faulty paths for case insensitive systems

2015-08-21 Thread Lars Schneider
...@pobox.com wrote: Lars Schneider larsxschnei...@gmail.com writes: + find . | grep TWO/file1.txt + find . | grep TWO/File2.txt + find . | grep TWO/file3.txt Not sure about the find | grep here either. See answers above. These are not very good tests

Re: [PATCH v4] git-p4: fix faulty paths for case insensitive systems

2015-08-24 Thread Lars Schneider
On 24 Aug 2015, at 08:33, Junio C Hamano gits...@pobox.com wrote: Lars Schneider larsxschnei...@gmail.com writes: - Have you checked git log on our history and notice how nobody says PROBLEM: and SOLUTION: in capital letters? Don't try to be original in the form; your contributions

Re: [PATCH v4] git-p4: fix faulty paths for case insensitive systems

2015-08-24 Thread Lars Schneider
that! On 21 August 2015 at 18:19, larsxschnei...@gmail.com wrote: From: Lars Schneider larsxschnei...@gmail.com PROBLEM: We run P4 servers on Linux and P4 clients on Windows. For an unknown reason the file path for a number of files in P4 does not match the directory path with respect to case

Re: [PATCH v2] git-p4: fix faulty paths for case insensitive systems

2015-08-20 Thread Lars Schneider
Thanks for your feedback! See my answers below. On 20 Aug 2015, at 06:59, Torsten Bögershausen tbo...@web.de wrote: Some nit-picking below: On 08/19/2015 10:04 PM, larsxschnei...@gmail.com wrote: From: Lars Schneider larsxschnei...@gmail.com PROBLEM: We run P4 servers on Linux and P4

Re: [PATCH] git-p4: fix faulty paths for case insensitive systems

2015-08-04 Thread Lars Schneider
? Cheers, Lars On 05 Aug 2015, at 00:06, Luke Diamand l...@diamand.org wrote: On 02/08/15 16:15, larsxschnei...@gmail.com wrote: From: Lars Schneider larsxschnei...@gmail.com Hi, I want to propose this patch as it helped us to migrate a big source code base successfully from P4 to Git. I am

Re: [PATCH v1] git-p4: Add option to ignore empty commits

2015-10-24 Thread Lars Schneider
On 20 Oct 2015, at 19:27, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: > >> diff --git a/git-p4.py b/git-p4.py >> index 0093fa3..6c50c74 100755 >> --- a/git-p4.py >> +++ b/git-p4.py >> @@ -2288,12 +2288,6 @@ class P4Sync(Command, P4UserMap): >>

Re: [PATCH v1] git-p4: Add option to ignore empty commits

2015-10-24 Thread Lars Schneider
On 21 Oct 2015, at 08:32, Luke Diamand <l...@diamand.org> wrote: > On 19/10/15 19:43, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> A changelist that contains only excluded files (e.g. via client spec or >> b

[RFC] t5516 "75 - deny fetch unreachable SHA1, allowtipsha1inwant=true" flaky?

2015-10-24 Thread Lars Schneider
Hi, while working on the Git CI integration I noticed that t5516 "75 - deny fetch unreachable SHA1, allowtipsha1inwant=true" (introduced in 68ee628) seems to be flaky on TravisCI. I get the following output in verbose mode:

Re: [RFC] t5516 "75 - deny fetch unreachable SHA1, allowtipsha1inwant=true" flaky?

2015-10-25 Thread Lars Schneider
(or > 1?), in most cases must be because it manages to write everything > before the context switch to the remote upload-pack occurs. > > What is actually the wanted outcome? Should git-fetch try to continue > to see if the already received response is enough to continue as > nor

Re: [PATCH] git-p4: import the ctypes module

2015-10-21 Thread Lars Schneider
Hi Etienne, thanks for reporting this! Junio is right, I messed that up on my Windows testing box! :-( Sorry! If you have any questions around submitting patches I am happy to help as I just recently went through the learning process myself! @Dennis: Thanks for the quick patch! Thanks, Lars

Re: [PATCH v1] git-p4: Add option to ignore empty commits

2015-10-28 Thread Lars Schneider
On 26 Oct 2015, at 21:40, Luke Diamand <l...@diamand.org> wrote: > On 24/10/15 19:08, Lars Schneider wrote: >> >> On 21 Oct 2015, at 08:32, Luke Diamand <l...@diamand.org> wrote: >> >>> On 19/10/15 19:43, larsxschnei...@gmail.com wrote: >>&

Re: [RFC] URL rewrite in .gitmodules

2015-10-25 Thread Lars Schneider
On 20 Oct 2015, at 00:07, Stefan Beller <sbel...@google.com> wrote: > On Mon, Oct 19, 2015 at 12:28 PM, Lars Schneider > <larsxschnei...@gmail.com> wrote: >> Hi, >> >> I have a closed source Git repo which references an Open Source Git repo as >> Subm

Re: [RFC] URL rewrite in .gitmodules

2015-10-25 Thread Lars Schneider
On 20 Oct 2015, at 19:33, Junio C Hamano <gits...@pobox.com> wrote: > Lars Schneider <larsxschnei...@gmail.com> writes: > >> If not, what do you think about a patch that adds a "url" section >> similar to the one in git config to a .gitmodules file? >

Re: [PATCH] fix flaky untracked-cache test

2015-10-21 Thread Lars Schneider
Looks good to me, Ack. Test run with 74301d6 + my TravisCI patch: https://travis-ci.org/larsxschneider/git/builds/86702932 ... on Linux it failed in 1/2 cases after 53min ... on OSX it failed in 2/2 cases after 6min Test run with 74301d6 + my TravisCI patch + David's t7063 patch:

[RFC] Clone repositories recursive with depth 1

2015-11-11 Thread Lars Schneider
Hi, I have a clean build machine and I want to clone my source code to this machine while transferring only the minimal necessary amount of data. Therefore I use this command: git clone --recursive --depth 1 --single-branch Apparently this does not clone the submodules with "--depth 1"

Re: [RFC] Clone repositories recursive with depth 1

2015-11-12 Thread Lars Schneider
On 11 Nov 2015, at 21:09, Stefan Beller <sbel...@google.com> wrote: > On Wed, Nov 11, 2015 at 11:19 AM, Stefan Beller <sbel...@google.com> wrote: >> On Wed, Nov 11, 2015 at 6:09 AM, Lars Schneider >> <larsxschnei...@gmail.com> wrote: >>> Hi, >&g

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

2015-11-13 Thread Lars Schneider
> On 13 Nov 2015, at 11:32, Torsten Bögershausen <tbo...@web.de> wrote: > > On 2015-11-13 09.57, Eric Sunshine wrote: >> On Fri, Nov 13, 2015 at 3:46 AM, Lars Schneider >> <larsxschnei...@gmail.com> wrote: >>> On 11 Nov 2015, at 18:49, Ramsay Jones <r

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

2015-11-13 Thread Lars Schneider
On 11 Nov 2015, at 18:49, Ramsay Jones wrote: > > > On 11/11/15 02:00, Stefan Beller wrote: >> On Tue, Nov 10, 2015 at 5:22 PM, Eric Sunshine >> wrote: >>> On Tue, Nov 10, 2015 at 7:23 PM, Ramsay Jones >>>

Re: [PATCH v2] add test to demonstrate that shallow recursive clones fail

2015-11-15 Thread Lars Schneider
On 13 Nov 2015, at 00:34, Stefan Beller <sbel...@google.com> wrote: > On Thu, Nov 12, 2015 at 1:37 AM, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> "git clone --recursive --depth 1 --single-branch &quo

Re: [PATCH v2] add test to demonstrate that shallow recursive clones fail

2015-11-15 Thread Lars Schneider
On 13 Nov 2015, at 06:35, Jeff King <p...@peff.net> wrote: > On Thu, Nov 12, 2015 at 10:37:41AM +0100, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> "git clone --recursive --depth 1 --single-branch "

Re: [RFC] URL rewrite in .gitmodules

2015-11-15 Thread Lars Schneider
On 26 Oct 2015, at 17:52, Jens Lehmann <jens.lehm...@web.de> wrote: > Am 26.10.2015 um 17:34 schrieb Stefan Beller: >> On Sun, Oct 25, 2015 at 8:12 AM, Lars Schneider <larsxschnei...@gmail.com> >> wrote: >>> On 20 Oct 2015, at 19:33, Junio C Hamano <gits..

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

2015-11-11 Thread Lars Schneider
On 11 Nov 2015, at 03:00, Stefan Beller wrote: > On Tue, Nov 10, 2015 at 5:22 PM, Eric Sunshine > wrote: >> On Tue, Nov 10, 2015 at 7:23 PM, Ramsay Jones >> wrote: >>> Commit f8117f55 ("http: use off_t to store partial

Re: [PATCH] test: accept death by SIGPIPE as a valid failure mode

2015-11-05 Thread Lars Schneider
> On 05 Nov 2015, at 08:47, Jeff King wrote: > > On Fri, Oct 30, 2015 at 02:22:14PM -0700, Junio C Hamano wrote: > >> On a local host, the object/history transport code often talks over >> pipe with the other side. The other side may notice some (expected) >> failure, send the

Re: [PATCH v4 3/4] git-p4: retry kill/cleanup operations in tests with timeout

2015-11-06 Thread Lars Schneider
est less flaky. >> >> Signed-off-by: Lars Schneider <larsxschnei...@gmail.com> >> --- >> diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh >> +retry_until_success() { >> +timeout=$(($(date +%s) + $RETRY_TIMEOUT)) >> +until "$@" 2>/dev/n

Re: [PATCH v4 2/4] git-p4: add p4d timeout in tests

2015-11-06 Thread Lars Schneider
h individual git p4 test >> needs to finish before 300s or it will fail. >> >> Signed-off-by: Lars Schneider <larsxschnei...@gmail.com> >> --- >> diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh >> @@ -81,6 +85,19 @@ start_p4d() { >># wil

Re: [PATCH v4 4/4] Add Travis CI support

2015-11-06 Thread Lars Schneider
> On 06 Nov 2015, at 14:57, Sebastian Schuberth <sschube...@gmail.com> wrote: > > On Fri, Nov 6, 2015 at 2:55 PM, Lars Schneider <larsxschnei...@gmail.com> > wrote: > >>> I think running different configuration per branch makes sense, yes. >> >&

Re: [PATCH v4 4/4] Add Travis CI support

2015-11-06 Thread Lars Schneider
> On 06 Nov 2015, at 14:20, Sebastian Schuberth <sschube...@gmail.com> wrote: > > On Fri, Nov 6, 2015 at 2:11 PM, Lars Schneider <larsxschnei...@gmail.com> > wrote: > >> Per platform/compiler (Linux/clang) we run two configurations. One >> normal config

Re: [PATCH v4 4/4] Add Travis CI support

2015-11-06 Thread Lars Schneider
> On 06 Nov 2015, at 14:36, Sebastian Schuberth <sschube...@gmail.com> wrote: > > On Fri, Nov 6, 2015 at 2:28 PM, Lars Schneider <larsxschnei...@gmail.com> > wrote: > >> Well, I partly agree. Right now the running time is ~20 min (that means less >> tha

Re: [PATCH v4 3/4] git-p4: retry kill/cleanup operations in tests with timeout

2015-11-06 Thread Lars Schneider
est less flaky. >> >> Signed-off-by: Lars Schneider <larsxschnei...@gmail.com> >> --- >> diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh >> +retry_until_success() { >> +timeout=$(($(date +%s) + $RETRY_TIMEOUT)) >> +until "$@" 2>/dev/n

Re: [PATCH v4 4/4] Add Travis CI support

2015-11-06 Thread Lars Schneider
Mavericks" using gcc and clang. >> >> Perforce and Git-LFS are installed and therefore available for the >> respective tests. >> >> Signed-off-by: Lars Schneider <larsxschnei...@gmail.com> >> --- >> diff --git a/.travis.yml b/.travis.yml >

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-15 Thread Lars Schneider
On 15 Oct 2015, at 10:12, Matthieu Moy <matthieu@grenoble-inp.fr> wrote: > Lars Schneider <larsxschnei...@gmail.com> writes: > >> I was reluctant to this because I feared problems. Especially while >> running tests in parallel. > > Isn't the point o

[BUG] t7063-status-untracked-cache flaky?

2015-10-15 Thread Lars Schneider
Hi, I noticed that "t7063-status-untracked-cache.sh" occasionally fails with "not ok 24 - test sparse status with untracked cache". E.g. on OS X compiled with gcc: https://travis-ci.org/larsxschneider/git/jobs/85432514 E.g. on Linux compiled with gcc:

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-15 Thread Lars Schneider
On 13 Oct 2015, at 12:32, Jean-Noël Avila wrote: > Le 11/10/2015 19:55, larsxschnei...@gmail.com a écrit : >> + >> +before_script: make >> + >> +script: make --quiet test > > Travis can be used in container mode but that would need getting rid of > "sudo" command and only

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-14 Thread Lars Schneider
On 12 Oct 2015, at 22:20, Matthieu Moy wrote: > larsxschnei...@gmail.com writes: > >> --- /dev/null >> +++ b/.travis.yml >> @@ -0,0 +1,46 @@ >> +language: c >> + >> +os: >> + - linux >> + - osx >> + >> +compiler: >> + - clang >> + - gcc >> + >>

[RFC] URL rewrite in .gitmodules

2015-10-19 Thread Lars Schneider
Hi, I have a closed source Git repo which references an Open Source Git repo as Submodule. The Open Source Git repo references yet another Open Source repo as submodule. In order to avoid failing builds due to external services I mirrored the Open Source repos in my company network. That works

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-12 Thread Lars Schneider
>> + brew_force_set_latest_binary_hash () { >> +FORUMULA=$1 > > Is this spelling intentional or is it a misspelling of "formula"? This is a misspelling. I will fix it. Thanks, Lars -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-12 Thread Lars Schneider
On 12 Oct 2015, at 01:05, Sebastian Schuberth wrote: > On 10/11/2015 19:55, larsxschnei...@gmail.com wrote: > >> + sudo apt-get update -qq >> + sudo apt-get install -y apt-transport-https >> + sudo apt-get install perforce-server git-lfs > > Why no "-y"

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-12 Thread Lars Schneider
On 12 Oct 2015, at 12:37, Sebastian Schuberth <sschube...@gmail.com> wrote: > On Mon, Oct 12, 2015 at 7:12 PM, Lars Schneider > <larsxschnei...@gmail.com> wrote: > >>>> +install: make configure && ./configure >>>> + >>>

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-12 Thread Lars Schneider
On 12 Oct 2015, at 09:02, Junio C Hamano wrote: > Sebastian Schuberth writes: > >> Semantically, it does not seem correct to me that configuarion goes to >> the install step. As "make test" will build git anyway, I'd instead >> propose to get rid of

Re: [PATCH] http: fix some printf format warnings on 32-bit builds

2015-11-14 Thread Lars Schneider
On 13 Nov 2015, at 21:02, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: > > > On 13/11/15 08:57, Eric Sunshine wrote: >> On Fri, Nov 13, 2015 at 3:46 AM, Lars Schneider >> <larsxschnei...@gmail.com> wrote: >>> On 11 Nov 2015, at 18:49, Ramsay

Re: [PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout

2015-11-17 Thread Lars Schneider
On 16 Nov 2015, at 22:14, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Sun, Nov 15, 2015 at 8:08 AM, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> In rare cases kill/cleanup operations in tests fail. R

Re: [PATCH v5 5/6] git-p4: add trap to kill p4d on test exit

2015-11-17 Thread Lars Schneider
On 16 Nov 2015, at 09:43, Luke Diamand <l...@diamand.org> wrote: > On 15/11/15 13:08, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Sometimes the "prove" test runner hangs on test exit because p4d is >&

Re: [PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout

2015-11-17 Thread Lars Schneider
On 16 Nov 2015, at 09:36, Luke Diamand <l...@diamand.org> wrote: > On 15/11/15 13:08, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> In rare cases kill/cleanup operations in tests fail. Retry these >> operatio

Re: [PATCH v6] git-p4: Obey core.ignorecase when using P4 client specs.

2015-08-26 Thread Lars Schneider
On 26 Aug 2015, at 22:05, Junio C Hamano gits...@pobox.com wrote: larsxschnei...@gmail.com writes: From: Lars Schneider larsxschnei...@gmail.com We run P4 servers on Linux and P4 clients on Windows. For an unknown reason the file path for a number of files in P4 does not match

Re: [RFC PATCH] git-p4: add option to store files in Git LFS on import

2015-08-30 Thread Lars Schneider
or do you want to support Python 2/3 in parallel? I would prefer the former… - Lars On 30 Aug 2015, at 10:49, Luke Diamand l...@diamand.org wrote: On 28 August 2015 at 13:24, larsxschnei...@gmail.com wrote: From: Lars Schneider larsxschnei...@gmail.com I am migrating huge Perforce

Re: [PATCH v5] git-p4: Obey core.ignorecase when using P4 client specs.

2015-08-25 Thread Lars Schneider
On 25 Aug 2015, at 08:54, Luke Diamand l...@diamand.org wrote: On 24/08/15 22:30, larsxschnei...@gmail.com wrote: From: Lars Schneider larsxschnei...@gmail.com Thanks to Luke Diamand I realized the core problem and propose here a substiantially simpler fix to my PATCH v4. The test cases

Re: [PATCH v5] git-p4: Obey core.ignorecase when using P4 client specs.

2015-08-25 Thread Lars Schneider
On 25 Aug 2015, at 10:33, Torsten Bögershausen tbo...@web.de wrote: On 08/25/2015 08:54 AM, Luke Diamand wrote: On 24/08/15 22:30, larsxschnei...@gmail.com wrote: From: Lars Schneider larsxschnei...@gmail.com Thanks to Luke Diamand I realized the core problem and propose here

Re: [PATCH v3] git-p4: add "--path-encoding" option

2015-09-01 Thread Lars Schneider
On 01 Sep 2015, at 19:35, Junio C Hamano <gits...@pobox.com> wrote: > Lars Schneider <larsxschnei...@gmail.com> writes: > >> On 01 Sep 2015, at 01:13, Junio C Hamano <gits...@pobox.com> wrote: >> >>> larsxschnei...@gmail.com writes: >>>

Re: [PATCH v3] git-p4: add "--path-encoding" option

2015-09-01 Thread Lars Schneider
On 01 Sep 2015, at 06:37, Torsten Bögershausen <tbo...@web.de> wrote: > On 01/09/15 00:10, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Signed-off-by: Lars Schneider <larsxschnei...@gmail.com> >>

Re: [PATCH v1] t9821: use test_config

2015-09-03 Thread Lars Schneider
On 03 Sep 2015, at 15:04, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Thu, Sep 3, 2015 at 5:34 AM, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Signed-off-by: Lars Schneider <larsxschnei...@gmail.

Re: [PATCH v5] git-p4: add config git-p4.pathEncoding

2015-09-03 Thread Lars Schneider
On 03 Sep 2015, at 10:26, Remi Galan Alfonso <remi.galan-alfo...@ensimag.grenoble-inp.fr> wrote: > Hi Lars, > > Lars Schneider <larsxschnei...@gmail.com> writes: > >> +test_expect_success 'Clone repo containing iso8859-1 encoded path

Re: [PATCH v6] git-p4: add config git-p4.pathEncoding

2015-09-03 Thread Lars Schneider
On 03 Sep 2015, at 19:03, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: > >> +test_expect_success 'Clone repo containing iso8859-1 encoded paths without >> git-p4.pathEncoding' ' >> +git p4 clone --destination="$git" //depot && >> +test_when_finished

Re: [PATCH v2 2/4] git-p4: add gitConfigInt reader

2015-09-03 Thread Lars Schneider
On 03 Sep 2015, at 21:57, Luke Diamand <l...@diamand.org> wrote: > On 03/09/15 17:35, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> > > Explanation? Add a git config reader for integer variables. Please note th

Re: [PATCH v2 1/4] git-p4: add optional type specifier to gitConfig reader

2015-09-03 Thread Lars Schneider
On 03 Sep 2015, at 22:18, Junio C Hamano <gits...@pobox.com> wrote: > Lars Schneider <larsxschnei...@gmail.com> writes: > >> On 03 Sep 2015, at 21:55, Luke Diamand <l...@diamand.org> wrote: >> >>> On 03/09/15 17:35, larsxschnei...@gmail.com

Re: [PATCH v2 1/4] git-p4: add optional type specifier to gitConfig reader

2015-09-03 Thread Lars Schneider
On 03 Sep 2015, at 21:55, Luke Diamand <l...@diamand.org> wrote: > On 03/09/15 17:35, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> > > I think this commit may need some explanation! The functions “gitConfig” and “gi

Re: [RFC PATCH] git-p4: add option to store files in Git LFS on import

2015-09-03 Thread Lars Schneider
On 30 Aug 2015, at 18:36, Luke Diamand <l...@diamand.org> wrote: > On 30 August 2015 at 11:18, Lars Schneider <larsxschnei...@gmail.com> wrote: >> Thanks for your feedback! >> >> I like the “handle big files” plugin kind of idea. However, I wonder if it &g

Re: [PATCH v3] git-p4: add "--path-encoding" option

2015-09-01 Thread Lars Schneider
On 01 Sep 2015, at 16:35, Torsten Bögershausen <tbo...@web.de> wrote: > On 2015-09-01 14.47, Lars Schneider wrote: >>>> +test_expect_success 'Create a repo containing iso8859-1 encoded paths' ' >>>>>> +cd "$cli" && >>>>

Re: [PATCH v3] git-p4: add "--path-encoding" option

2015-09-01 Thread Lars Schneider
On 01 Sep 2015, at 01:13, Junio C Hamano <gits...@pobox.com> wrote: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> > > Here is a space for you to describe what it does and why it is a > good idea to h

Re: [PATCH v2 4/4] git-p4: add support for large file systems

2015-09-03 Thread Lars Schneider
On 03 Sep 2015, at 22:03, Luke Diamand <l...@diamand.org> wrote: > On 03/09/15 17:35, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Perforce repositories can contain large (binary) files. Migrating these >> r

Re: [PATCH v2 1/4] git-p4: add optional type specifier to gitConfig reader

2015-09-04 Thread Lars Schneider
On 03 Sep 2015, at 23:31, Junio C Hamano <gits...@pobox.com> wrote: > Lars Schneider <larsxschnei...@gmail.com> writes: > >> In case I agree with a reviewer. What is the more appropriate action? >> A response like the one above or a new role that includes the chan

Re: [PATCH v5] git-p4: Obey core.ignorecase when using P4 client specs.

2015-08-25 Thread Lars Schneider
On 25 Aug 2015, at 13:57, Luke Diamand l...@diamand.org wrote: On 25/08/15 11:30, larsxschnei...@gmail.com wrote: Unfortunately the command line option is not sufficient as the resulting paths are still messed up. I added the switch but it looks like as core.ignorecase does some

Re: [PATCHv1 0/2] git-p4: work on a detached head

2015-09-09 Thread Lars Schneider
I wanted to play with the patch and apply it to my source but the process is really complicated for me. I wonder if you can give me a few recommendations how to work efficiently with email patches. I don’t want to start a flame-war about what email client is “right", I am just curious how you

Re: [PATCH v5 6/7] git-p4: add support for large file systems

2015-09-16 Thread Lars Schneider
On 16 Sep 2015, at 10:36, Luke Diamand <l...@diamand.org> wrote: > On 14/09/15 14:26, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Perforce repositories can contain large (binary) files. Migrating these >> r

Re: [PATCH v2 2/2] git-p4: handle "Translation of file content failed"

2015-09-16 Thread Lars Schneider
On 16 Sep 2015, at 00:12, Luke Diamand <l...@diamand.org> wrote: > On 15/09/15 16:38, Lars Schneider wrote: >> >> On 15 Sep 2015, at 08:43, Luke Diamand <l...@diamand.org> wrote: >> > > >>> Do we know the mechanism by which we end up

Re: [PATCH v2 2/2] git-p4: handle "Translation of file content failed"

2015-09-15 Thread Lars Schneider
On 15 Sep 2015, at 08:43, Luke Diamand <l...@diamand.org> wrote: > On 14/09/15 17:55, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> A P4 repository can get into a state where it contains a file with >> type UTF-

Re: [PATCH v7] git-p4: improve path encoding verbose output

2015-09-15 Thread Lars Schneider
On 15 Sep 2015, at 09:31, Luke Diamand <l...@diamand.org> wrote: > On 14/09/15 18:10, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> If a path with non-ASCII characters is detected then print always the >

Re: [PATCH v7] git-p4: improve path encoding verbose output

2015-09-15 Thread Lars Schneider
On 14 Sep 2015, at 20:40, Junio C Hamano <gits...@pobox.com> wrote: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> If a path with non-ASCII characters is detected then print always the >> encod

Re: [PATCH v2 1/2] git-p4: add test case for "Translation of file content failed" error

2015-09-15 Thread Lars Schneider
On 15 Sep 2015, at 06:40, Torsten Bögershausen <tbo...@web.de> wrote: > On 09/14/2015 06:55 PM, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> A P4 repository can get into a state where it contains a file with >

Re: [PATCH v2 3/4] git-p4: Fix t9815 git-p4-submit-fail test case on OS X

2015-10-04 Thread Lars Schneider
On 04 Oct 2015, at 11:23, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: > >> +if test_have_prereq CYGWIN; then >> +: # NOOP >> +elif test_have_prereq DARWIN; then >> +stat -f %Sp text | egrep ^-r-- &&

Re: [PATCH v2 2/4] Add prereq to detect OS X

2015-10-04 Thread Lars Schneider
On 04 Oct 2015, at 11:28, Junio C Hamano <gits...@pobox.com> wrote: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Some Unix tools differ between Linux and Mac OS X. Add this prereq to >> detect OS X and h

Re: [PATCH v8 0/7] git-p4: add support for large file systems

2015-10-04 Thread Lars Schneider
On 03 Oct 2015, at 10:23, Junio C Hamano wrote: > Junio C Hamano writes: > >> Luke Diamand writes: >> >>> All looks good to me, Ack. >>> >>> One tiny thing perhaps Junio could comment on: the git commit message >>> for

Re: [PATCH v2 4/4] git-p4: Disable t9819 git-p4-case-folding test on OS X

2015-10-04 Thread Lars Schneider
On 04 Oct 2015, at 11:26, Junio C Hamano <gits...@pobox.com> wrote: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> The OS X file system is case insensitive by default. Consequently this >> test does not a

Re: [RFC/PATCH v1] Add Travis CI support

2015-09-26 Thread Lars Schneider
On 25 Sep 2015, at 10:05, Luke Diamand wrote: > On 25 September 2015 at 08:27, Johannes Schindelin > wrote: >> Hi, >> >> On 2015-09-25 05:14, Dennis Kaarsemaker wrote: >>> On do, 2015-09-24 at 17:41 -0700, Junio C Hamano wrote:

Re: [PATCH v1 1/2] git-p4: print stderr if P4 read_pipe operation fails

2015-09-09 Thread Lars Schneider
On 09 Sep 2015, at 18:00, Junio C Hamano <gits...@pobox.com> wrote: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> If read_pipe crashes then the caller can inspect the error and handle >> it appropria

Re: [PATCH v4 4/5] git-p4: add support for large file systems

2015-09-09 Thread Lars Schneider
On 09 Sep 2015, at 19:20, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: > >> @@ -2226,17 +2355,16 @@ class P4Sync(Command, P4UserMap): >> text = regexp.sub(r'$\1$', text) >> contents = [ text ] >> >> -self.gitStream.write("M %s

Re: git-p4: nicodeDecodeError in ./t9822-git-p4-path-encoding.sh

2015-09-21 Thread Lars Schneider
On 21 Sep 2015, at 09:52, Luke Diamand wrote: > On 21/09/15 08:01, Luke Diamand wrote: >> Lars, >> >> When I run t9822-git-p4-path-encoding.sh, the last test fails (it's >> supposed to pass) with the following backtrace. >> >> This is with 'next' at

Re: [PATCH v5 6/7] git-p4: add support for large file systems

2015-09-20 Thread Lars Schneider
On 16 Sep 2015, at 17:20, Junio C Hamano <gits...@pobox.com> wrote: > Lars Schneider <larsxschnei...@gmail.com> writes: > >>>> +git-p4.largeFileSystem:: >>>> + Specify the system that is used for large (binary) files. Please note >>>>

Re: [PATCH v3 1/2] git-p4: add test case for "Translation of file content failed" error

2015-09-20 Thread Lars Schneider
On 20 Sep 2015, at 23:16, Eric Sunshine wrote: > On Sun, Sep 20, 2015 at 12:22 PM, wrote: >> A P4 repository can get into a state where it contains a file with >> type UTF-16 that does not contain a valid UTF-16 BOM. If git-p4 >> attempts to

Re: [PATCH v7 0/7] git-p4: add support for large file systems

2015-09-23 Thread Lars Schneider
On 23 Sep 2015, at 13:25, Luke Diamand <l...@diamand.org> wrote: > Adding back git@vger.kernel.org, which I inadvertently dropped off the thread. > > On 23 September 2015 at 12:22, Luke Diamand <l...@diamand.org> wrote: >> On 23 September 2015 at 11:09, Lars Schneide

Re: git-p4: t9819 failing

2015-09-23 Thread Lars Schneider
On 23 Sep 2015, at 11:27, Luke Diamand wrote: > Lars, > > I just noticed that your change "git-p4: honor core.ignorecase when > using P4 client specs" seems to break t9819. > > I suspect that the problem is just that t9819 needs to be updated to > reflect your change - do

Re: git-p4: t9819 failing

2015-09-23 Thread Lars Schneider
On 23 Sep 2015, at 13:11, Luke Diamand <l...@diamand.org> wrote: > On 23 September 2015 at 11:27, Lars Schneider <larsxschnei...@gmail.com> > wrote: >> >> On 23 Sep 2015, at 11:27, Luke Diamand <l...@diamand.org> wrote: >> >>> Lars, >

Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error

2015-09-23 Thread Lars Schneider
gt; >> On Tue, Sep 22, 2015 at 9:02 AM, Junio C Hamano <gits...@pobox.com> wrote: >>> Lars Schneider <larsxschnei...@gmail.com> writes: >>> >>>> This works. >>> >>> OK, and thanks; as I don't do perforce, the squash was withou

Re: [PATCH v7 0/7] git-p4: add support for large file systems

2015-09-23 Thread Lars Schneider
On 23 Sep 2015, at 00:03, Junio C Hamano <gits...@pobox.com> wrote: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> diff to v6: >> * fix spaces in .gitattributes for Git-LFS files (old "[:space:]"

Re: [PATCH v7 1/7] git-p4: add optional type specifier to gitConfig reader

2015-09-23 Thread Lars Schneider
On 22 Sep 2015, at 23:49, Junio C Hamano <gits...@pobox.com> wrote: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> The functions “gitConfig” and “gitConfigBool” are almost identical. Make >> “gitConfi

Re: [PATCH v7 0/7] git-p4: add support for large file systems

2015-09-23 Thread Lars Schneider
On 23 Sep 2015, at 10:18, Lars Schneider <larsxschnei...@gmail.com> wrote: > > On 23 Sep 2015, at 09:58, Luke Diamand <l...@diamand.org> wrote: > >> On 21 September 2015 at 23:41, <larsxschnei...@gmail.com> wrote: >>> From: Lars Schneider <

Re: [PATCH v7 0/7] git-p4: add support for large file systems

2015-09-23 Thread Lars Schneider
On 23 Sep 2015, at 09:58, Luke Diamand <l...@diamand.org> wrote: > On 21 September 2015 at 23:41, <larsxschnei...@gmail.com> wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> diff to v6: >> * fix spaces in .gitattributes for Git-

Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error

2015-09-21 Thread Lars Schneider
On 21 Sep 2015, at 20:09, Junio C Hamano <gits...@pobox.com> wrote: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> A P4 repository can get into a state where it contains a file with >> type UTF-16 that d

Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error

2015-09-22 Thread Lars Schneider
On 22 Sep 2015, at 03:10, Junio C Hamano wrote: > Eric Sunshine writes: > >> Yes, it's because $d is a variable reference, even within double >> quotes. > > s/even/especially/ ;-) > > Here is what I queued as SQUASH??? > > diff --git

Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error

2015-09-22 Thread Lars Schneider
On 22 Sep 2015, at 01:54, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Mon, Sep 21, 2015 at 7:03 PM, Lars Schneider > <larsxschnei...@gmail.com> wrote: >> On 21 Sep 2015, at 20:09, Junio C Hamano <gits...@pobox.com> wrote: >>> larsxschnei...@gmai

Re: [PATCH v3 1/2] git-p4: add test case for "Translation of file content failed" error

2015-09-21 Thread Lars Schneider
On 21 Sep 2015, at 09:49, Luke Diamand <l...@diamand.org> wrote: > On 20/09/15 17:22, larsxschnei...@gmail.com wrote: >> From: Lars Schneider <larsxschnei...@gmail.com> > > When I run this, I get errors reported on the sed usage: > > t9824-git-p4-handle-utf16

Re: git-p4: t9819 failing

2015-09-25 Thread Lars Schneider
the disk > usage, but I think it still needs to be updated following the other > changes to case-handling. > > Luke > > On 24 September 2015 at 08:45, Luke Diamand <l...@diamand.org> wrote: >> On 23 September 2015 at 13:28, Lars Schneider <larsxschnei...@gmail.com

Re: [PATCH 1/2] git-p4: support multiple depot paths in p4 submit

2015-12-08 Thread Lars Schneider
On 07 Dec 2015, at 19:51, Sam Hocevar <s...@hocevar.net> wrote: > On Sun, Dec 06, 2015, Lars Schneider wrote: >> Thanks for the patch! Do you see a way to demonstrate the bug in a test case >> similar to t9821 [1]? > > Not yet, I'm afraid. It's proving tri

Re: [PATCH 1/2] git-p4: support multiple depot paths in p4 submit

2015-12-06 Thread Lars Schneider
Thanks for the patch! Do you see a way to demonstrate the bug in a test case similar to t9821 [1]? Cheers, Lars [1] https://github.com/git/git/blob/master/t/t9821-git-p4-path-variations.sh > On 05 Dec 2015, at 12:22, Sam Hocevar wrote: > > When submitting from a repository

[RFC] Case insensitive URL rewrite

2015-12-11 Thread Lars Schneider
Hi, the "url..insteadOf" git config is case sensitive. I understand that this makes sense on case sensitive file systems. However, URLs are mostly case insensitive: Consider this: git clone https://GIThub.com/GIT/GIT git clone https://github.com/git/git Both commands will clone the same

Re: Where does http.sslcainfo get set in Windows (2.6.3)?

2015-12-14 Thread Lars Schneider
Hi Titus, try to look here: C:\Users\All Users\Git\config (that's where I found it... maybe different on your end). Cheers, Lars > On 14 Dec 2015, at 16:45, Titus Barik wrote: > > Hi all, > > I'm in Windows using git version: git version 2.6.3.windows.1. Git is > installed

Re: [PATCH v1 0/2] git-p4: kill watchdog and suppress irrelevant output

2015-12-22 Thread Lars Schneider
On 21 Dec 2015, at 21:31, Junio C Hamano <gits...@pobox.com> wrote: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> Hi, >> >> these patches extend "git-p4: add trap to kill p4d on test exit&qu

Re: [PATCH v1 2/2] git-p4: suppress non test relevant output

2015-12-22 Thread Lars Schneider
On 21 Dec 2015, at 21:38, Junio C Hamano <gits...@pobox.com> wrote: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> If tests are executed in verbose mode then the retry logic clutters the >> test output

  1   2   3   4   5   6   7   8   9   10   >