Re: [PATCH/RFC] diff/read-cache: don't assume empty files will filter to empty

2017-07-17 Thread Junio C Hamano
Andrei Purdea writes: > diff --git a/read-cache.c b/read-cache.c > index 2121b6e7b..ca306993c 100644 > --- a/read-cache.c > +++ b/read-cache.c > @@ -262,9 +262,8 @@ static int ce_match_stat_basic(const struct > cache_entry *ce, struct stat *st) > changed |=

[PATCH/RFC] diff/read-cache: don't assume empty files will filter to empty

2017-07-16 Thread Andrei Purdea
Hey guys, please see the below patch. (please read commit message first and then the following:) In particular I'd like to hear comments about the changes I made to how smudging works. I am not confident on whether it is a good way to permanently fix the problem. I'm wondering if there's a better