Re: [PATCH] Add $(LIBS) and set libiconv in tools/Makefile for Darwin
Mark Allen [EMAIL PROTECTED] writes: Looks good to me, Junio. There's a very small typo in your commit though. :-) Thanks. - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] Add $(LIBS) and set libiconv in tools/Makefile for Darwin
[PATCH] Add $(LIBS) and set libiconv in tools/Makefile for Darwin This trivial patch creates $(LIBS) and sets it to iconv in tools/Makefile because MacOS 10.4 [gcc 4.0] gets cranky about libiconv routines referenced in mailinfo.c (convert_to_utf8) and no library pointer to link the symbols against. I haven't tested this on Linux yet (but I will tomorrow when I get into work). Signed-off-by: Mark Allen [EMAIL PROTECTED][PATCH] Add LIBS field and populate with iconv to tools/Makefile for Darwin OS X.4 [gcc 4.0] gets cranky about iconv data structures and no library pointer to link the symbols against. Signed-off-by: Mark Allen [EMAIL PROTECTED] --- tools/Makefile |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) 44865be29a83e2b4b0bf65c6dae427203b7be9b9 diff --git a/tools/Makefile b/tools/Makefile --- a/tools/Makefile +++ b/tools/Makefile @@ -7,13 +7,14 @@ ALL_CFLAGS = $(CFLAGS) INSTALL=install prefix=$(HOME) bindir=$(prefix)/bin +LIBS=iconv # DESTDIR= PROGRAMS=git-mailsplit git-mailinfo SCRIPTS=git-applymbox git-applypatch git-%: %.c - $(CC) $(ALL_CFLAGS) -o $@ $(filter %.c,$^) + $(CC) $(ALL_CFLAGS) -l$(LIBS) -o $@ $(filter %.c,$^) all: $(PROGRAMS)
Re: [PATCH] Add $(LIBS) and set libiconv in tools/Makefile for Darwin
Mark Allen [EMAIL PROTECTED] writes: This trivial patch creates $(LIBS) and sets it to iconv in tools/Makefile because MacOS 10.4 [gcc 4.0] gets cranky about libiconv routines referenced in mailinfo.c (convert_to_utf8) and no library pointer to link the symbols against. I'd do this slightly differently. Could you take a look at what I have in the proposed updates branch, especially Flatten tools/ directory commit? What I am aiming for is to have platform specific ifeq() thing in only one place. - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
