Re: [PATCH] Avoid loading commits twice in log with diffs

2013-03-04 Thread Thomas Rast
Junio C Hamano writes: > Thomas Rast writes: > >> Test with patchbefore >> >> 4000.2: log --raw -3000 0.50(0.43+0.06) 0.54(0.46+0.06) +7.0%*** >> 4000.3: log -p -3000 2.34(2.20+0.13) 2.37

Re: [PATCH] Avoid loading commits twice in log with diffs

2013-03-02 Thread Junio C Hamano
Thomas Rast writes: > Test with patchbefore > > 4000.2: log --raw -3000 0.50(0.43+0.06) 0.54(0.46+0.06) +7.0%*** > 4000.3: log -p -3000 2.34(2.20+0.13) 2.37(2.22+0.13) +1.2% >

[PATCH] Avoid loading commits twice in log with diffs

2013-03-02 Thread Thomas Rast
If you run a log with diffs (such as -p, --raw, --stat etc.) the current code ends up loading many objects twice. For example, for 'log -3000 -p' my instrumentation said the objects loaded more than once are distributed as follows: 2008 blob 2103 commit 2678 tree Fixing blobs and trees wil