Re: [PATCH] Fix a bug in compat/bswap.h endianness detection

2014-05-30 Thread Junio C Hamano
Thanks; this should have been caught during the review. +# if defined(_BIG_ENDIAN) && !defined(_LITTLE_ENDIAN) +# ... +# elif defined(_BIG_ENDIAN) && !defined(_LITTLE_ENDIAN) +# ... +# else -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@v

[PATCH] Fix a bug in compat/bswap.h endianness detection

2014-05-30 Thread Ben Walton
The changes to make detection of endianness more portable had a bug that breaks on (at least) Solaris x86. The bug appears to be a simple copy/paste typo. It checks for _BIG_ENDIAN and not _LITTLE_ENDIAN for both the case where we would decide the system is big endian and little endian. Instead, th