[PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Daniel Graña
Signed-off-by: Daniel Graña dan...@gmail.com --- t/t7409-submodule-detached-worktree.sh | 31 --- 1 files changed, 24 insertions(+), 7 deletions(-) diff --git a/t/t7409-submodule-detached-worktree.sh b/t/t7409-submodule-detached-worktree.sh index db75642..d88f400

Re: [PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Jeff King
On Mon, Jul 30, 2012 at 01:10:10PM -0300, Daniel Graña wrote: Subject: Re: [PATCH] Improve tests for detached worktree in git-submodule Signed-off-by: Daniel Graña dan...@gmail.com The space between the subject and your S-o-b is an excellent place to explain the rationale for your commit

Re: [PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Junio C Hamano
Daniel Graña dan...@gmail.com writes: Signed-off-by: Daniel Graña dan...@gmail.com --- t/t7409-submodule-detached-worktree.sh | 31 --- 1 files changed, 24 insertions(+), 7 deletions(-) diff --git a/t/t7409-submodule-detached-worktree.sh

Fwd: [PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Daniel Graña
Forwardning for the record as vger rejected my previous HTML email. -- Forwarded message -- From: Daniel Graña dan...@gmail.com Date: Mon, Jul 30, 2012 at 2:04 PM Subject: Re: [PATCH] Improve tests for detached worktree in git-submodule To: Jeff King p...@peff.net Cc: Junio C

Re: [PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Daniel Graña
On Mon, Jul 30, 2012 at 2:02 PM, Junio C Hamano gits...@pobox.com wrote: Daniel Graña dan...@gmail.com writes: Signed-off-by: Daniel Graña dan...@gmail.com --- t/t7409-submodule-detached-worktree.sh | 31 --- 1 files changed, 24 insertions(+), 7 deletions(-)

[PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Daniel Graña
* Check submodule is correctly initialized and updated after cloning .dotfiles Signed-off-by: Daniel Graña dan...@gmail.com --- Remove $TRASH_DIRECTORY and git rev-parse --verify HEAD as suggested by Junio t/t7409-submodule-detached-worktree.sh | 31 --- 1 files

Re: [PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Junio C Hamano
Daniel Graña dan...@gmail.com writes: On Mon, Jul 30, 2012 at 2:02 PM, Junio C Hamano gits...@pobox.com wrote: Daniel Graña dan...@gmail.com writes: Signed-off-by: Daniel Graña dan...@gmail.com --- t/t7409-submodule-detached-worktree.sh | 31 --- 1 files

Re: [PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Daniel Graña
On Mon, Jul 30, 2012 at 2:43 PM, Daniel Graña dan...@gmail.com wrote: * Check submodule is correctly initialized and updated after cloning .dotfiles Signed-off-by: Daniel Graña dan...@gmail.com --- Ignore this patch, I am sending another without extra space after standard output redirection.

Re: [PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Daniel Graña dan...@gmail.com writes: ... is it still better than git rev-parse --max-count=1 HEAD seen in t7406-submodule.update.sh? git rev-parse --max-count=1 HEAD will show --max-count=1\n followed by the value of HEAD, so if the expected result

[PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Daniel Graña
* Check submodule is correctly initialized and updated after cloning .dotfiles Signed-off-by: Daniel Graña dan...@gmail.com --- t/t7409-submodule-detached-worktree.sh | 31 --- 1 files changed, 24 insertions(+), 7 deletions(-) diff --git