Re: [PATCH] Makefile: fix default regex settings on Darwin
David Aguilar wrote: t0070-fundamental.sh fails on Mac OS X 10.8 by default. Fix it by using Git's regex library. Can you say more about the failure? What does ./t0070-fundamental.sh -v say? Curious, Jonathan -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Makefile: fix default regex settings on Darwin
On Fri, May 10, 2013 at 11:31 PM, Jonathan Nieder jrnie...@gmail.com wrote: David Aguilar wrote: t0070-fundamental.sh fails on Mac OS X 10.8 by default. Fix it by using Git's regex library. Can you say more about the failure? What does ./t0070-fundamental.sh -v say? [..snip...] expecting success: # if this test fails, re-build git with NO_REGEX=1 test-regex fatal: regex bug confirmed: re-build git with NO_REGEX=1 not ok 4 - check for a bug in the regex routines # # # if this test fails, re-build git with NO_REGEX=1 # test-regex # # failed 1 among 4 test(s) 1..4 -- David -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Makefile: fix default regex settings on Darwin
David Aguilar wrote:
expecting success:
# if this test fails, re-build git with NO_REGEX=1
test-regex
fatal: regex bug confirmed: re-build git with NO_REGEX=1
Thanks. Gah. That means that regcomp() with REG_NEWLINE is letting
[^={} \t]+
match the newline in
={}\nfred
despite the POSIX requirement
A newline in string shall not be matched by a period outside
a bracket expression or by any form of a non-matching list
where
A non-matching list expression begins with a circumflex ('^')
and specifies a list that shall match any single-character
collating element except for the expressions represented in
the list after the leading circumflex.
and if I understand you correctly, this is a regression in Apple
libc. :(
With the commit message modified to mention the fatal: regex bug
confirmed: re-build git with NO_REGEX=1 and uname -a output,
Reviewed-by: Jonathan Nieder jrnie...@gmail.com
Do you know if this has been reported to Apple and
openradar.appspot.com?
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Makefile: fix default regex settings on Darwin
On Sat, May 11, 2013 at 12:04 AM, Jonathan Nieder jrnie...@gmail.com wrote:
David Aguilar wrote:
expecting success:
# if this test fails, re-build git with NO_REGEX=1
test-regex
fatal: regex bug confirmed: re-build git with NO_REGEX=1
Thanks. Gah. That means that regcomp() with REG_NEWLINE is letting
[^={} \t]+
match the newline in
={}\nfred
despite the POSIX requirement
A newline in string shall not be matched by a period outside
a bracket expression or by any form of a non-matching list
where
A non-matching list expression begins with a circumflex ('^')
and specifies a list that shall match any single-character
collating element except for the expressions represented in
the list after the leading circumflex.
and if I understand you correctly, this is a regression in Apple
libc. :(
With the commit message modified to mention the fatal: regex bug
confirmed: re-build git with NO_REGEX=1 and uname -a output,
Reviewed-by: Jonathan Nieder jrnie...@gmail.com
Thanks. I can adjust the commit message and re-roll to make this patch 1/3.
Do you know if this has been reported to Apple and
openradar.appspot.com?
I checked and nope, there are no bug reports. I tried to submit one
by creating a new radar but that page said to go to
bugreport.apple.com.
I tried to login there but after entering my credentials I got, An
error has occurred. Please report the error to Apple Inc. by emailing
the error detail to devb...@apple.com. Oh bother ;-)
I refreshed the page and finally got in. I submitted a bug.. Problem # 13868200
I hop on this laptop to test for cross-platform issues (I'm a Linux
user myself ;-) and it's been pretty good at finding 'em.
--
David
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
