On Sun, Mar 23, 2014 at 9:10 AM, Ashwin Jha wrote:
> On 03/23/2014 02:10 PM, Eric Sunshine wrote:
>> On Sat, Mar 22, 2014 at 11:12 AM, Ashwin Jha wrote:
>>> - if (memcmp(buffer, "tree ", 5))
>>> + buffer = (char *)skip_prefix(buffer, "tree ");
>>
>> These casts are ugly. It should be
fsck_commit. Replace memcmp by skip_prefix
In his review, Tanay already mentioned indicating a resubmission via
[PATCH vN]. Additionally, specify the module or function being
modified, followed by a colon and space. On this project, it is
customary to forego capitalization in the subject (and only
Thanks for the resubmission. Comments below...
On Sat, Mar 22, 2014 at 11:12 AM, Ashwin Jha wrote:
> Subject: [PATCH] Modify fsck_commit. Replace memcmp by skip_prefix
In his review, Tanay already mentioned indicating a resubmission via
[PATCH vN]. Additionally, specify the module or funct
Hi,
Nit: In subject, patch should be like [PATCH v2] for each increasing order
of revision.
Also, after the --- (three dashes), you can write what you changed with each
patch revision. Also to link the previous patches if you can.
So the corrected mail subject header will look something like thi
Replace memcmp by skip_prefix as it serves the dual
purpose of checking the string for a prefix as well
as skipping that prefix.
Signed-off-by: Ashwin Jha
---
fsck.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/fsck.c b/fsck.c
index 64bf279..0
5 matches
Mail list logo
