Re: [PATCH] Remove deprecated OPTION_BOOLEAN

2013-07-29 Thread Junio C Hamano
Stefan Beller writes: > On 07/29/2013 07:58 PM, Junio C Hamano wrote: >> Stefan Beller writes: >> >>> So recently Junio released -rc0. Is that a reason to not >>> send out patches, which do not do bugfixes? So the following >>> commit for example doesn't fix a bug nor does it add a feature. >>

Re: [PATCH] Remove deprecated OPTION_BOOLEAN

2013-07-29 Thread Stefan Beller
On 07/29/2013 08:11 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> As of b04ba2bb4 OPTION_BOOLEAN was deprecated. > > The primary purpose of b04ba2bb (parse-options: deprecate > OPT_BOOLEAN, 2011-09-27) is to deprecate OPT_BOOLEAN(), which was > hard to use correctly. > > OPT_BOOLEAN()

Re: [PATCH] Remove deprecated OPTION_BOOLEAN

2013-07-29 Thread Junio C Hamano
Stefan Beller writes: > As of b04ba2bb4 OPTION_BOOLEAN was deprecated. The primary purpose of b04ba2bb (parse-options: deprecate OPT_BOOLEAN, 2011-09-27) is to deprecate OPT_BOOLEAN(), which was hard to use correctly. OPT_BOOLEAN() is not touched at all with this patch, it seems. Do they want

Re: [PATCH] Remove deprecated OPTION_BOOLEAN

2013-07-29 Thread Stefan Beller
On 07/29/2013 07:58 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> So recently Junio released -rc0. Is that a reason to not >> send out patches, which do not do bugfixes? So the following >> commit for example doesn't fix a bug nor does it add a feature. >> Is it fine to send out such ki

Re: [PATCH] Remove deprecated OPTION_BOOLEAN

2013-07-29 Thread Junio C Hamano
Stefan Beller writes: > So recently Junio released -rc0. Is that a reason to not > send out patches, which do not do bugfixes? So the following > commit for example doesn't fix a bug nor does it add a feature. > Is it fine to send out such kind of commits during the -rc > times or better wait fo

[PATCH] Remove deprecated OPTION_BOOLEAN

2013-07-29 Thread Stefan Beller
Hi, the following patch removes the OPTION_BOOLEAN from all commands. So recently Junio released -rc0. Is that a reason to not send out patches, which do not do bugfixes? So the following commit for example doesn't fix a bug nor does it add a feature. Is it fine to send out such kind of commits

[PATCH] Remove deprecated OPTION_BOOLEAN

2013-07-29 Thread Stefan Beller
As of b04ba2bb4 OPTION_BOOLEAN was deprecated. This commit removes all occurrences of OPTION_BOOLEAN. In b04ba2bb4 Junio suggested to replace it with either OPTION_SET_INT or OPTION_COUNTUP instead. However a pattern, which occurred often with the OPTION_BOOLEAN was a hidden boolean parameter. So I