Re: [PATCH] Revert completion: fix shell expansion of items

2012-09-26 Thread Jeff King
On Wed, Sep 26, 2012 at 12:37:25AM +0200, SZEDER Gábor wrote: I looked into this issue, but quickly got lost in quoting-escaping hell. Ideally we could do some quoting in __gitcomp_nl(), so it would work for all kinds of input, but I couldn't come up with anything working. Alternatively, we

Re: [PATCH] Revert completion: fix shell expansion of items

2012-09-25 Thread SZEDER Gábor
On Tue, Sep 25, 2012 at 12:31:19AM -0400, Jeff King wrote: Yeah, doing git checkout jk/tab is not working at all, and I noticed the buggy commit is on the maint track, but has not yet been released. I'm not sure of the solution, but I think we should do this in the meantime: -- 8 --

Re: [PATCH] Revert completion: fix shell expansion of items

2012-09-25 Thread Junio C Hamano
SZEDER Gábor sze...@ira.uka.de writes: On Tue, Sep 25, 2012 at 12:31:19AM -0400, Jeff King wrote: Yeah, doing git checkout jk/tab is not working at all, and I noticed the buggy commit is on the maint track, but has not yet been released. I'm not sure of the solution, but I think we should do

[PATCH] Revert completion: fix shell expansion of items

2012-09-24 Thread Jeff King
On Thu, Sep 20, 2012 at 08:11:52PM +0200, SZEDER Gábor wrote: Solves the original problem for me. Me too. Thanks. While it solves the original problem, it seems to break refs completion, as demonstrated by the following POC test: diff --git a/t/t9902-completion.sh