Re:Re: [PATCH] Rewrite the diff-no-index.c

2014-03-17 Thread 沈承恩
thank you for your comments At 2014-03-17 17:13:38,"Eric Sunshine" wrote: >Thanks for the resubmission. Comments below... > >On Sun, Mar 16, 2014 at 8:44 AM, wrote: >> From: 沈承恩 >> Subject: [PATCH] Rewrite the diff-no-index.c > >This is your second ve

Re: [PATCH] Rewrite the diff-no-index.c

2014-03-17 Thread Matthieu Moy
- Original Message - > Thank you for your comments.If I rename some function when I work on a large > project like git,whether it will cause other error that I can not solve .So > I use the ugly way for this reason. (please, don't top-post on this list). The read_directory to be renamed i

Re:Re: [PATCH] Rewrite the diff-no-index.c

2014-03-17 Thread 沈承恩
... > >On Sun, Mar 16, 2014 at 8:44 AM, wrote: >> From: 沈承恩 >> Subject: [PATCH] Rewrite the diff-no-index.c > >This is your second version of the patch, so you should say [PATCH v2]. > >Most patches rewrite something, so "rewrite" in the subject does not &g

Re: [PATCH] Rewrite the diff-no-index.c

2014-03-17 Thread Eric Sunshine
Thanks for the resubmission. Comments below... On Sun, Mar 16, 2014 at 8:44 AM, wrote: > From: 沈承恩 > Subject: [PATCH] Rewrite the diff-no-index.c This is your second version of the patch, so you should say [PATCH v2]. Most patches rewrite something, so "rewrite" in the

[PATCH] Rewrite the diff-no-index.c

2014-03-16 Thread ubuntu2012
From: 沈承恩 I am sorry for that I send this agian.Last patch I have some error.(Maybe this time will like the previous).It is apply for GSOC Signed-off-by: 沈承恩 --- diff-no-index.c |5 +++-- dir.h |3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/diff-no-in