[PATCH] Use long for timezone in pretty.c:show_ident_date()

2014-03-07 Thread Brian Gernhardt 
The value is parsed with strtol and compared against LONG_MIN and
LONG_MAX, which doesn't make much sense for an int.

Signed-off-by: Brian Gernhardt br...@gernhardtsoftware.com
---
 pretty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pretty.c b/pretty.c
index 3b811ed..29ebc4f 100644
--- a/pretty.c
+++ b/pretty.c
@@ -397,7 +397,7 @@ static const char *show_ident_date(const struct ident_split 
*ident,
   enum date_mode mode)
 {
unsigned long date = 0;
-   int tz = 0;
+   long tz = 0;
 
if (ident-date_begin  ident-date_end)
date = strtoul(ident-date_begin, NULL, 10);
-- 
1.9.0.281.gfc51f0a.dirty

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Use long for timezone in pretty.c:show_ident_date()

2014-03-07 Thread Eric Sunshine 
On Fri, Mar 7, 2014 at 1:47 PM, Brian Gernhardt
br...@gernhardtsoftware.com wrote:
 The value is parsed with strtol and compared against LONG_MIN and
 LONG_MAX, which doesn't make much sense for an int.

 Signed-off-by: Brian Gernhardt br...@gernhardtsoftware.com

Thanks. Find a more complete fix here [1].

[1]: http://thread.gmane.org/gmane.comp.version-control.git/243582/focus=243617

 ---
  pretty.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/pretty.c b/pretty.c
 index 3b811ed..29ebc4f 100644
 --- a/pretty.c
 +++ b/pretty.c
 @@ -397,7 +397,7 @@ static const char *show_ident_date(const struct 
 ident_split *ident,
enum date_mode mode)
  {
 unsigned long date = 0;
 -   int tz = 0;
 +   long tz = 0;

 if (ident-date_begin  ident-date_end)
 date = strtoul(ident-date_begin, NULL, 10);
 --
 1.9.0.281.gfc51f0a.dirty

 --
 To unsubscribe from this list: send the line unsubscribe git in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html