Re: [PATCH] branch: change install_branch_config() to use skip_prefix()

2014-02-27 Thread Dmitry S. Dolzhenko
Michael, Thank you for your remarks. > If you look at what skip_prefix() and starts_with() do, I think you will > find that you are doing too much work here. How about this one? const char *shortname = skip_prefix(remote, "refs/heads/"); int remote_is_branch = shortname != NULL;

Re: [PATCH] branch: change install_branch_config() to use skip_prefix()

2014-02-27 Thread David Kastrup
Michael Haggerty writes: > Dmitry, > > Thanks for your patch. Please see my comments below. > > On 02/27/2014 12:13 PM, Dmitry S. Dolzhenko wrote: >> Change install_branch_config() function to use skip_prefix() >> for getting short name of remote branch. > > English tweak suggestion: > > Change

Re: [PATCH] branch: change install_branch_config() to use skip_prefix()

2014-02-27 Thread Michael Haggerty
Dmitry, Thanks for your patch. Please see my comments below. On 02/27/2014 12:13 PM, Dmitry S. Dolzhenko wrote: > Change install_branch_config() function to use skip_prefix() > for getting short name of remote branch. English tweak suggestion: Change THE install_branch_config() function to use

[PATCH] branch: change install_branch_config() to use skip_prefix()

2014-02-27 Thread Dmitry S. Dolzhenko
Change install_branch_config() function to use skip_prefix() for getting short name of remote branch. Signed-off-by: Dmitry S. Dolzhenko --- branch.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/branch.c b/branch.c index 723a36b..310749b 100644 --- a/branch.c +++ b/b