Re: [PATCH] branch.c: change install_branch_config() to use skip_prefix()
Hi Jacopo,
Thanks for your comments. I just update this PATCH as v2. I appreciate
more comments from you and others in the new thread.
Regards,
Guanglin
2014-03-02 22:01 GMT+08:00 Jacopo Notarstefano :
> The part about this being a GSoC microproject should go below the
> three dashes, since it's not information that needs to
> be recorded in the codebase.
>
> On Sun, Mar 2, 2014 at 12:52 PM, Guanglin Xu wrote:
>> GSoC2014 Microproject: according to the idea#2 for microprojects, change
>> install_branch_config() to use skip_prefix() and make it conform to the
>> usage of previous starts_with().
>>
>> Signed-off-by: Guanglin Xu
>> ---
>> branch.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/branch.c b/branch.c
>> index 723a36b..ca4e824 100644
>> --- a/branch.c
>> +++ b/branch.c
>> @@ -50,7 +50,7 @@ static int should_setup_rebase(const char *origin)
>> void install_branch_config(int flag, const char *local, const char *origin,
>> const char *remote)
>> {
>> const char *shortname = remote + 11;
>> - int remote_is_branch = starts_with(remote, "refs/heads/");
>> + int remote_is_branch = (NULL != skip_prefix(remote ,"refs/heads/"));
>> struct strbuf key = STRBUF_INIT;
>> int rebasing = should_setup_rebase(origin);
>>
>> --
>> 1.9.0
>>
>> Hi,
>> I am Guanglin Xu. I plan to apply for GSoC 2014.
>> --
>> To unsubscribe from this list: send the line "unsubscribe git" in
>> the body of a message to majord...@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] branch.c: change install_branch_config() to use skip_prefix()
The part about this being a GSoC microproject should go below the
three dashes, since it's not information that needs to
be recorded in the codebase.
On Sun, Mar 2, 2014 at 12:52 PM, Guanglin Xu wrote:
> GSoC2014 Microproject: according to the idea#2 for microprojects, change
> install_branch_config() to use skip_prefix() and make it conform to the usage
> of previous starts_with().
>
> Signed-off-by: Guanglin Xu
> ---
> branch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/branch.c b/branch.c
> index 723a36b..ca4e824 100644
> --- a/branch.c
> +++ b/branch.c
> @@ -50,7 +50,7 @@ static int should_setup_rebase(const char *origin)
> void install_branch_config(int flag, const char *local, const char *origin,
> const char *remote)
> {
> const char *shortname = remote + 11;
> - int remote_is_branch = starts_with(remote, "refs/heads/");
> + int remote_is_branch = (NULL != skip_prefix(remote ,"refs/heads/"));
> struct strbuf key = STRBUF_INIT;
> int rebasing = should_setup_rebase(origin);
>
> --
> 1.9.0
>
> Hi,
> I am Guanglin Xu. I plan to apply for GSoC 2014.
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] branch.c: change install_branch_config() to use skip_prefix()
GSoC2014 Microproject: according to the idea#2 for microprojects, change
install_branch_config() to use skip_prefix() and make it conform to the usage
of previous starts_with().
Signed-off-by: Guanglin Xu
---
branch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/branch.c b/branch.c
index 723a36b..ca4e824 100644
--- a/branch.c
+++ b/branch.c
@@ -50,7 +50,7 @@ static int should_setup_rebase(const char *origin)
void install_branch_config(int flag, const char *local, const char *origin,
const char *remote)
{
const char *shortname = remote + 11;
- int remote_is_branch = starts_with(remote, "refs/heads/");
+ int remote_is_branch = (NULL != skip_prefix(remote ,"refs/heads/"));
struct strbuf key = STRBUF_INIT;
int rebasing = should_setup_rebase(origin);
--
1.9.0
Hi,
I am Guanglin Xu. I plan to apply for GSoC 2014.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
