Re: [PATCH] checkout: avoid unncessary match_pathspec calls

2013-03-23 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > --- > Junio, this patch clearly conflicts wih nd/magic-pathspecs. Do you > want me to: > > - hold it off until nd/magic-pathspecs graduates > - rebase on top of nd/magic-pathspecs and repost > - leave it to you to handle conflicts > ? I'd prefer to take sm

Re: [PATCH] checkout: avoid unncessary match_pathspec calls

2013-03-23 Thread Eric Sunshine
On Sat, Mar 23, 2013 at 6:55 AM, Nguyễn Thái Ngọc Duy wrote: > checkout: avoid unncessary match_pathspec calls s/unncessary/unnecessary/ > In checkout_paths() we do this > ... -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org

[PATCH] checkout: avoid unncessary match_pathspec calls

2013-03-23 Thread Nguyễn Thái Ngọc Duy
In checkout_paths() we do this - for i = 0..active_nr, if not updated, call match_pathspec - for ..., call match_pathspec (inside unmerge_cache) - for ..., call match_pathspec (for showing "path .. is unmerged) - for ..., if not updated, call match_pathspec and update paths That's a lot of du