Re: [PATCH] cherry-pick: better error message when the parameter is a non-commit

2013-04-08 Thread Junio C Hamano
Miklos Vajna writes: > When copy&paste goes wrong, and the user e.g. tries to cherry-pick a > blob, the error message used to be: It is the other way around. When the user tries to cherry-pick a non-commit we say a correct but nonspecific "expected one commit", and it does not matter how the us

Re: [PATCH] cherry-pick: better error message when the parameter is a non-commit

2013-04-08 Thread Junio C Hamano
Miklos Vajna writes: > On Wed, Apr 03, 2013 at 11:27:04AM +0200, Miklos Vajna > wrote: >> When copy&paste goes wrong, and the user e.g. tries to cherry-pick a >> blob, the error message used to be: >> >> fatal: BUG: expected exactly one commit from walk >> >> Instead, now it is: >> >>

Re: [PATCH] cherry-pick: better error message when the parameter is a non-commit

2013-04-08 Thread Miklos Vajna
Hi, On Wed, Apr 03, 2013 at 11:27:04AM +0200, Miklos Vajna wrote: > When copy&paste goes wrong, and the user e.g. tries to cherry-pick a > blob, the error message used to be: > > fatal: BUG: expected exactly one commit from walk > > Instead, now it is: > > fatal: Can't cherry-pick

[PATCH] cherry-pick: better error message when the parameter is a non-commit

2013-04-03 Thread Miklos Vajna
When copy&paste goes wrong, and the user e.g. tries to cherry-pick a blob, the error message used to be: fatal: BUG: expected exactly one commit from walk Instead, now it is: fatal: Can't cherry-pick a blob Signed-off-by: Miklos Vajna --- sequencer.c | 9 - 1 file chan