Re: [PATCH] commit: Fix a memory leak in determine_author_info
On 07/15/2013 04:42 PM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>> The date variable is assigned new memory via xmemdupz and 2 lines later
>> it is assigned new memory again via xmalloc, but the first assignment
>> is never freed nor used.
>> ---
>> builtin/commit.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/builtin/commit.c b/builtin/commit.c
>> index 790e5ab..00da83c 100644
>> --- a/builtin/commit.c
>> +++ b/builtin/commit.c
>> @@ -534,7 +534,6 @@ static void determine_author_info(struct strbuf
>> *author_ident)
>> (lb - strlen(" ") -
>> (a + strlen("\nauthor ";
>> email = xmemdupz(lb + strlen("<"), rb - (lb + strlen("<")));
>> -date = xmemdupz(rb + strlen("> "), eol - (rb + strlen("> ")));
>> len = eol - (rb + strlen("> "));
>> date = xmalloc(len + 2);
>> *date = '@';
>
> Makes sense. I'd assume this is signed-off?
>
As I realised I did not sign it,
I resend it with some other findings a few hours later,
so you'll find it there as well.
See Message-ID
<1373837749-14402-2-git-send-email-stefanbel...@googlemail.com>
[PATCH 2/4] commit: Fix a memory leak in determine_author_info
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] commit: Fix a memory leak in determine_author_info
Stefan Beller writes:
> The date variable is assigned new memory via xmemdupz and 2 lines later
> it is assigned new memory again via xmalloc, but the first assignment
> is never freed nor used.
> ---
> builtin/commit.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/builtin/commit.c b/builtin/commit.c
> index 790e5ab..00da83c 100644
> --- a/builtin/commit.c
> +++ b/builtin/commit.c
> @@ -534,7 +534,6 @@ static void determine_author_info(struct strbuf
> *author_ident)
> (lb - strlen(" ") -
>(a + strlen("\nauthor ";
> email = xmemdupz(lb + strlen("<"), rb - (lb + strlen("<")));
> - date = xmemdupz(rb + strlen("> "), eol - (rb + strlen("> ")));
> len = eol - (rb + strlen("> "));
> date = xmalloc(len + 2);
> *date = '@';
Makes sense. I'd assume this is signed-off?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] commit: Fix a memory leak in determine_author_info
The date variable is assigned new memory via xmemdupz and 2 lines later
it is assigned new memory again via xmalloc, but the first assignment
is never freed nor used.
---
builtin/commit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/builtin/commit.c b/builtin/commit.c
index 790e5ab..00da83c 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -534,7 +534,6 @@ static void determine_author_info(struct strbuf
*author_ident)
(lb - strlen(" ") -
(a + strlen("\nauthor ";
email = xmemdupz(lb + strlen("<"), rb - (lb + strlen("<")));
- date = xmemdupz(rb + strlen("> "), eol - (rb + strlen("> ")));
len = eol - (rb + strlen("> "));
date = xmalloc(len + 2);
*date = '@';
--
1.8.3.2.806.gdee5b9b
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
