[PATCH] commit --amend: test specifies authorship but forgets to check
The test case --amend option copies authorship specifies that the git-commit option `--amend` uses the authorship of the replaced commit for the new commit. Add the omitted check that this property actually holds. Signed-off-by: Fabian Ruch baf...@gmail.com --- Without the check, the test case succeeds even with nonsense in the `expected` file. An `--amend` implementation which simply uses the committer name and date as if it was not amending would have been deemed correct. This is not the case, the implementation still passes the test suite after the correction. Quickly skimming over the rest of the file, I couldn't find the same thing twice. t/t7509-commit.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/t/t7509-commit.sh b/t/t7509-commit.sh index b61fd3c..9ac7940 100755 --- a/t/t7509-commit.sh +++ b/t/t7509-commit.sh @@ -77,6 +77,7 @@ test_expect_success '--amend option copies authorship' ' git commit -a --amend -m amend test author_header Initial expect author_header HEAD actual + test_cmp expect actual echo amend test expect message_body HEAD actual -- 2.0.1 -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] commit --amend: test specifies authorship but forgets to check
Fabian Ruch baf...@gmail.com writes: The test case --amend option copies authorship specifies that the git-commit option `--amend` uses the authorship of the replaced commit for the new commit. Add the omitted check that this property actually holds. Signed-off-by: Fabian Ruch baf...@gmail.com --- Without the check, the test case succeeds even with nonsense in the `expected` file. An `--amend` implementation which simply uses the committer name and date as if it was not amending would have been deemed correct. This is not the case, the implementation still passes the test suite after the correction. Quickly skimming over the rest of the file, I couldn't find the same thing twice. t/t7509-commit.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/t/t7509-commit.sh b/t/t7509-commit.sh index b61fd3c..9ac7940 100755 --- a/t/t7509-commit.sh +++ b/t/t7509-commit.sh @@ -77,6 +77,7 @@ test_expect_success '--amend option copies authorship' ' git commit -a --amend -m amend test author_header Initial expect author_header HEAD actual + test_cmp expect actual echo amend test expect message_body HEAD actual Makes sense; thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
