Re: [PATCH] contrib/git-credential-gnome-keyring.c: small stylistic cleanups

2013-12-13 Thread Junio C Hamano
Junio C Hamano writes: > John Szakmeister writes: > >> On Mon, Dec 9, 2013 at 1:06 PM, Junio C Hamano wrote: >> [snip] >>> >>> I thought we cast without SP after the (typename), i.e. >>> >>> gpointer *data = (gpointer *)user_data; >> >> I've found a mixture of both in the code base, and

Re: [PATCH] contrib/git-credential-gnome-keyring.c: small stylistic cleanups

2013-12-12 Thread Junio C Hamano
John Szakmeister writes: > On Mon, Dec 9, 2013 at 1:06 PM, Junio C Hamano wrote: > [snip] >> >> I thought we cast without SP after the (typename), i.e. >> >> gpointer *data = (gpointer *)user_data; > > I've found a mixture of both in the code base, and the > CodingGuidelines doesn't say

Re: [PATCH] contrib/git-credential-gnome-keyring.c: small stylistic cleanups

2013-12-10 Thread John Szakmeister
On Mon, Dec 9, 2013 at 1:06 PM, Junio C Hamano wrote: [snip] > > I thought we cast without SP after the (typename), i.e. > > gpointer *data = (gpointer *)user_data; I've found a mixture of both in the code base, and the CodingGuidelines doesn't say either way. I'm happy to switch the fil

Re: [PATCH] contrib/git-credential-gnome-keyring.c: small stylistic cleanups

2013-12-09 Thread Junio C Hamano
John Szakmeister writes: > Signed-off-by: John Szakmeister > --- > The gnome-keyring credential backend had a number of coding style > violations. I believe this fixes all of them. > > .../gnome-keyring/git-credential-gnome-keyring.c | 55 > ++ > 1 file changed, 25 inser

RE: [PATCH] contrib/git-credential-gnome-keyring.c: small stylistic cleanups

2013-12-07 Thread Felipe Contreras
John Szakmeister wrote: > Signed-off-by: John Szakmeister > --- > The gnome-keyring credential backend had a number of coding style > violations. I believe this fixes all of them. > > .../gnome-keyring/git-credential-gnome-keyring.c | 55 > ++ > 1 file changed, 25 inserti

Re: [PATCH] contrib/git-credential-gnome-keyring.c: small stylistic cleanups

2013-12-04 Thread Junio C Hamano
Thanks, will queue. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] contrib/git-credential-gnome-keyring.c: small stylistic cleanups

2013-12-03 Thread John Szakmeister
Signed-off-by: John Szakmeister --- The gnome-keyring credential backend had a number of coding style violations. I believe this fixes all of them. .../gnome-keyring/git-credential-gnome-keyring.c | 55 ++ 1 file changed, 25 insertions(+), 30 deletions(-) diff --git a/con