Re: [PATCH] diff: Fixes shortstat number of files

2012-11-27 Thread Junio C Hamano
Antoine Pelisse writes: > Indeed stat seems to be broken on master by commit 74faaa16 from Linus > Torvalds > > There are three separated issues here: > - unmerged files are marked as "interesting" in stat and probably > shouldn't, with some patch like this: > > data->is_interesting = p

Re: [PATCH] diff: Fixes shortstat number of files

2012-11-26 Thread Antoine Pelisse
bly should the way it's done in stat. That is with something like this: if (!data->files[i]->is_interesting && (added + deleted == 0)) { continue; } Cheers, Antoine Pelisse -- Forwarded message -- From: Junio C Ha

Re: [PATCH] diff: Fixes shortstat number of files

2012-11-25 Thread Junio C Hamano
Antoine Pelisse writes: > Subject: Re: [PATCH] diff: Fixes shortstat number of files Please replace "Fixes" with "Fix at least (because our log messages are written as if a patch is giving an order to the codebase, iow, in imperative mood), but we would prefer to see a concr

[PATCH] diff: Fixes shortstat number of files

2012-11-23 Thread Antoine Pelisse
There is a discrepancy between the last line of `git diff --stat` and `git diff --shortstat` in case of a merge. The unmerged files are actually counted twice, thus doubling the value of "file changed". In fact, while stat decrements number of files when seeing an unmerged file, shortstat doesn't.

[PATCH] diff: Fixes shortstat number of files

2012-11-22 Thread Antoine Pelisse
There is a discrepancy between the last line of `git diff --stat` and `git diff --shortstat` in case of a merge. The unmerged files are actually counted twice, thus doubling the value of "file changed". In fact, while stat decrements number of files when seeing an unmerged file, shortstat doesn't.

[PATCH] diff: Fixes shortstat number of files

2012-11-22 Thread Antoine Pelisse
There is a discrepancy between the last line of `git diff --stat` and `git diff --shortstat` in case of a merge. The unmerged files are actually counted twice, thus doubling the value of "file changed". In fact, while stat decrements number of files when seeing an unmerged file, shortstat doesn't.