[PATCH] [git-am] Handle git show output correctly

2012-09-12 Thread Peter Jones
This patch adds the ability for git am to accept patches in the format generated by git show. Some people erroneously use git show instead of git format-patch, and it's nice as a maintainer to be able to easily take their patch rather than going back and forth with them to get a correctly

Re: [PATCH] [git-am] Handle git show output correctly

2012-09-12 Thread Matthieu Moy
Peter Jones pjo...@redhat.com writes: Subject: [PATCH] [git-am] Handle git show output correctly The convention in Git is subsystem: summary of change (i.e. no brackets around git-am, just am: and no capital for Handle). My other concerns (name of stgit, multi-lines subject lines and lack

Re: [PATCH] [git-am] Handle git show output correctly

2012-09-12 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: Peter Jones pjo...@redhat.com writes: Subject: [PATCH] [git-am] Handle git show output correctly The convention in Git is subsystem: summary of change (i.e. no brackets around git-am, just am: and no capital for Handle). My other concerns

Re: [PATCH] [git-am] Handle git show output correctly

2012-09-12 Thread Peter Jones
On Wed, 2012-09-12 at 10:32 -0700, Junio C Hamano wrote: We do not want to apply git show output that munges the log message, period. If you want to give patches to somebody (or to yourself) via e-mail or via sneaker-net, git format-patch is there for you. Do not butcher am to accept a

[PATCH] git-am: Handle git show output correctly

2012-09-12 Thread Peter Jones
This patch adds the ability for git am to accept patches in the format generated by git show. Some people erroneously use git show instead of git format-patch, and it's nice as a maintainer to be able to easily take their patch rather than going back and forth with them to get a correctly

Re: [PATCH] [git-am] Handle git show output correctly

2012-09-12 Thread Junio C Hamano
Peter Jones pjo...@redhat.com writes: Let me put it a different way - if you won't accept git-am handling git show output because git show has output that wasn't designed to be parsed ever, would you be opposed to a patch that switches the git show output to be something usable? The output

Re: [PATCH] git-am: Handle git show output correctly

2012-09-12 Thread Andreas Ericsson
On 09/13/2012 12:19 AM, Junio C Hamano wrote: Dan Johnson computerdr...@gmail.com writes: Not really. If we start encouraging people to use git show output as a kosher input to am, we would have to support such use forever, and we end up painting ourselves in a corner we cannot get out of

Re: [PATCH] git-am: Handle git show output correctly

2012-09-12 Thread Junio C Hamano
Dan Johnson computerdr...@gmail.com writes: I was assuming Peter would accept the patch, and reply with a in the future, please submit the output of format-patch, thus correcting the submitter's behavior. This warning would serve someone who did not know that they wanted the output of