Re: [PATCH] git-p4: Fix occasional truncation of symlink contents.

2013-08-12 Thread Alexandru Juncu
On 11 August 2013 14:57, Pete Wyckoff p...@padd.com wrote: al...@rosedu.org wrote on Thu, 08 Aug 2013 16:17 +0300: Symlink contents in p4 print sometimes have a trailing new line character, but sometimes it doesn't. git-p4 should only remove the last character if that character is '\n'.

Re: [PATCH] git-p4: Fix occasional truncation of symlink contents.

2013-08-12 Thread Pete Wyckoff
al...@rosedu.org wrote on Mon, 12 Aug 2013 10:46 +0300: On 11 August 2013 14:57, Pete Wyckoff p...@padd.com wrote: al...@rosedu.org wrote on Thu, 08 Aug 2013 16:17 +0300: Symlink contents in p4 print sometimes have a trailing new line character, but sometimes it doesn't. git-p4 should

Re: [PATCH] git-p4: Fix occasional truncation of symlink contents.

2013-08-12 Thread Alexandru Juncu
On 12 August 2013 15:38, Pete Wyckoff p...@padd.com wrote: al...@rosedu.org wrote on Mon, 12 Aug 2013 10:46 +0300: On 11 August 2013 14:57, Pete Wyckoff p...@padd.com wrote: al...@rosedu.org wrote on Thu, 08 Aug 2013 16:17 +0300: Symlink contents in p4 print sometimes have a trailing new

Re: [PATCH] git-p4: Fix occasional truncation of symlink contents.

2013-08-12 Thread Junio C Hamano
-p4: Fix occasional truncation of symlink contents. Symlink contents in p4 print sometimes have a trailing new line character, but sometimes it doesn't. git-p4 should only remove the last character if that character is '\n'. Signed-off-by: Alex Juncu aju...@ixiacom.com Signed-off-by: Alex Badea aba

Re: [PATCH] git-p4: Fix occasional truncation of symlink contents.

2013-08-11 Thread Pete Wyckoff
al...@rosedu.org wrote on Thu, 08 Aug 2013 16:17 +0300: Symlink contents in p4 print sometimes have a trailing new line character, but sometimes it doesn't. git-p4 should only remove the last character if that character is '\n'. Your patch looks fine, and harmless if symlinks continue to have

[PATCH] git-p4: Fix occasional truncation of symlink contents.

2013-08-08 Thread Alexandru Juncu
Symlink contents in p4 print sometimes have a trailing new line character, but sometimes it doesn't. git-p4 should only remove the last character if that character is '\n'. Signed-off-by: Alex Juncu aju...@ixiacom.com Signed-off-by: Alex Badea aba...@ixiacom.com --- git-p4.py | 8 ++-- 1