Re: [PATCH] git-rebase: clean up dashed-usages in messages

[Junio C Hamano]

Kaartic Sivaraam  writes:

> Signed-off-by: Kaartic Sivaraam 
> ---

Thanks.  Two fewer git-foo exposed to the end user.  Good ;-)

>  git-rebase.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/git-rebase.sh b/git-rebase.sh
> index 6344e8d5e..2f5d138a0 100755
> --- a/git-rebase.sh
> +++ b/git-rebase.sh
> @@ -9,7 +9,7 @@ OPTIONS_STUCKLONG=t
>  OPTIONS_SPEC="\
>  git rebase [-i] [options] [--exec ] [--onto ] [] 
> []
>  git rebase [-i] [options] [--exec ] [--onto ] --root []
> -git-rebase --continue | --abort | --skip | --edit-todo
> +git rebase --continue | --abort | --skip | --edit-todo
>  --
>   Available options are
>  v,verbose! display a diffstat of what changed upstream
> @@ -216,7 +216,7 @@ run_pre_rebase_hook () {
>  }
>  
>  test -f "$apply_dir"/applying &&
> - die "$(gettext "It looks like git-am is in progress. Cannot rebase.")"
> + die "$(gettext "It looks like 'git am' is in progress. Cannot rebase.")"
>  
>  if test -d "$apply_dir"
>  then

[PATCH] git-rebase: clean up dashed-usages in messages

[Kaartic Sivaraam]

Signed-off-by: Kaartic Sivaraam 
---
 git-rebase.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/git-rebase.sh b/git-rebase.sh
index 6344e8d5e..2f5d138a0 100755
--- a/git-rebase.sh
+++ b/git-rebase.sh
@@ -9,7 +9,7 @@ OPTIONS_STUCKLONG=t
 OPTIONS_SPEC="\
 git rebase [-i] [options] [--exec ] [--onto ] [] 
[]
 git rebase [-i] [options] [--exec ] [--onto ] --root []
-git-rebase --continue | --abort | --skip | --edit-todo
+git rebase --continue | --abort | --skip | --edit-todo
 --
  Available options are
 v,verbose! display a diffstat of what changed upstream
@@ -216,7 +216,7 @@ run_pre_rebase_hook () {
 }
 
 test -f "$apply_dir"/applying &&
-   die "$(gettext "It looks like git-am is in progress. Cannot rebase.")"
+   die "$(gettext "It looks like 'git am' is in progress. Cannot rebase.")"
 
 if test -d "$apply_dir"
 then
-- 
2.15.0.291.g0d8980c5d

Re: [PATCH] git-rebase: clean up dashed-usages in messages

[Junio C Hamano]

Kaartic Sivaraam  writes:

> On Sunday 19 November 2017 07:42 AM, Junio C Hamano wrote:
>>>   test -f "$apply_dir"/applying &&
>>> -   die "$(gettext "It looks like git-am is in progress. Cannot rebase.")"
>>> +   die "$(gettext "It looks like you are in the middle of an am session. 
>>> Cannot rebase.")"
>>
>> Probably not, as 'am' alone would be confusing.
>>
>>  "It looks like 'git am' is in progress. Cannot rebase."
>>
>> may be a more sensible improvement.
>
> Let me guess, 'am' alone would be confusing because it follows 'an' in
> the error message.

With a, an or the, or without, 'am' alone, unlike 'status',
'rebase', etc., do not look much like a subcommand name, and that is
why the original chose to say git-am.  The suggestion is to make the
primary change (i.e. remove mention of dashed form) without changing
or breaking what the original wanted to do.

Re: [PATCH] git-rebase: clean up dashed-usages in messages

[Kaartic Sivaraam]

On Sunday 19 November 2017 07:42 AM, Junio C Hamano wrote:

  test -f "$apply_dir"/applying &&
-   die "$(gettext "It looks like git-am is in progress. Cannot rebase.")"
+   die "$(gettext "It looks like you are in the middle of an am session. Cannot 
rebase.")"


Probably not, as 'am' alone would be confusing.

 "It looks like 'git am' is in progress. Cannot rebase."

may be a more sensible improvement.



Let me guess, 'am' alone would be confusing because it follows 'an' in 
the error message. So, the user might mistake it to be some kind of typo 
in the error message. Is that close to why 'am' alone would be confusing?


Anyways, I stole that from a message shown by 'git status',

"You are in the middle of an am session."

So, does that require a change too?


---
Kaartic

Re: [PATCH] git-rebase: clean up dashed-usages in messages

[Junio C Hamano]

>  git rebase [-i] [options] [--exec ] [--onto ] [] 
> []
>  git rebase [-i] [options] [--exec ] [--onto ] --root []
> -git-rebase --continue | --abort | --skip | --edit-todo
> +git rebase --continue | --abort | --skip | --edit-todo

A good change.

>  test -f "$apply_dir"/applying &&
> - die "$(gettext "It looks like git-am is in progress. Cannot rebase.")"
> + die "$(gettext "It looks like you are in the middle of an am session. 
> Cannot rebase.")"

Probably not, as 'am' alone would be confusing.

"It looks like 'git am' is in progress. Cannot rebase."

may be a more sensible improvement.

[PATCH] git-rebase: clean up dashed-usages in messages

[Kaartic Sivaraam]

Signed-off-by: Kaartic Sivaraam 
---
 git-rebase.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/git-rebase.sh b/git-rebase.sh
index 6344e8d5e..42a485aaa 100755
--- a/git-rebase.sh
+++ b/git-rebase.sh
@@ -9,7 +9,7 @@ OPTIONS_STUCKLONG=t
 OPTIONS_SPEC="\
 git rebase [-i] [options] [--exec ] [--onto ] [] 
[]
 git rebase [-i] [options] [--exec ] [--onto ] --root []
-git-rebase --continue | --abort | --skip | --edit-todo
+git rebase --continue | --abort | --skip | --edit-todo
 --
  Available options are
 v,verbose! display a diffstat of what changed upstream
@@ -216,7 +216,7 @@ run_pre_rebase_hook () {
 }
 
 test -f "$apply_dir"/applying &&
-   die "$(gettext "It looks like git-am is in progress. Cannot rebase.")"
+   die "$(gettext "It looks like you are in the middle of an am session. 
Cannot rebase.")"
 
 if test -d "$apply_dir"
 then
-- 
2.15.0.291.g0d8980c5d