Re: [PATCH] git-send-email: don't return undefined value in extract_valid_address()

2012-11-20 Thread Junio C Hamano
Krzysztof Mazur krzys...@podlesie.net writes: In the fallback check, when Email::Valid is not available, the extract_valid_address() does not check for success of matching regex, and $1, which can be undefined, is always returned. Now if match fails an empty string is returned. That much we

Re: [PATCH] git-send-email: don't return undefined value in extract_valid_address()

2012-11-20 Thread Krzysztof Mazur
On Tue, Nov 20, 2012 at 12:27:36PM -0800, Junio C Hamano wrote: Krzysztof Mazur krzys...@podlesie.net writes: In the fallback check, when Email::Valid is not available, the extract_valid_address() does not check for success of matching regex, and $1, which can be undefined, is always

Re: [PATCH] git-send-email: don't return undefined value in extract_valid_address()

2012-11-20 Thread Junio C Hamano
Krzysztof Mazur krzys...@podlesie.net writes: Yes, it's just to hide the warning, the error (warning in this case) it's already correctly generated: W: unable to extract a valid address from: x a.patch But it is of no use if the message is sent out without the intended recipient, no? It is