Re: [PATCH] git p4: catch p4 describe errors

2012-11-03 Thread Matt Arsenault
On Nov 3, 2012, at 16:07 , Pete Wyckoff wrote: > > Arthur and Matt, you've both had intermittent "p4 describe" > errors. I've not been able to repeat this or come up with > a possible root cause. But it is clear that the error handling > in this area is weak. I tried this week to find the comm

[PATCH] git p4: catch p4 describe errors

2012-11-03 Thread Pete Wyckoff
Group the two calls to "p4 describe" into a new helper function, and try to validate the p4 results. The current behavior when p4 describe fails is to die with a python backtrace. The new behavior will print the full response. Based-on-patch-by: Matt Arsenault Signed-off-by: Pete Wyckoff ---