Re: [PATCH] help.c: add a compatibility comment to cmd_version()

2013-04-18 Thread Philip Oakley
From: "Junio C Hamano" Sent: Thursday, April 18, 2013 1:13 AM "Philip Oakley" writes: How about * E.g. git gui uses the extended regular expression "^git version [1-9]+(\.[0-9]+)+.*" * to check for an acceptable version string. The ERE is from git-gui.sh:L958. That is exactly the kin

Re: [PATCH] help.c: add a compatibility comment to cmd_version()

2013-04-17 Thread Junio C Hamano
"Philip Oakley" writes: > How about >* E.g. git gui uses the extended regular expression "^git version > [1-9]+(\.[0-9]+)+.*" >* to check for an acceptable version string. > > The ERE is from git-gui.sh:L958. That is exactly the kind of guarantee we do _not_ want to give. > ... Hence my

Re: [PATCH] help.c: add a compatibility comment to cmd_version()

2013-04-17 Thread Philip Oakley
From: "Junio C Hamano" Sent: Tuesday, April 16, 2013 11:35 PM "Philip Oakley" writes: int cmd_version(int argc, const char **argv, const char *prefix) { + /* + * The format of this string should be kept stable for compatibility + * with external projects that rely on the output of "git vers

Re: [PATCH] help.c: add a compatibility comment to cmd_version()

2013-04-16 Thread Junio C Hamano
"Philip Oakley" writes: >> int cmd_version(int argc, const char **argv, const char *prefix) >> { >> + /* >> + * The format of this string should be kept stable for compatibility >> + * with external projects that rely on the output of "git version". > > Shouldn't the expected format of our known

Re: [PATCH] help.c: add a compatibility comment to cmd_version()

2013-04-16 Thread Philip Oakley
From: "David Aguilar" Sent: Tuesday, April 16, 2013 9:33 PM External projects have been known to parse the output of "git version". Help prevent future authors from changing its format by adding a comment to its implementation. Signed-off-by: David Aguilar --- help.c | 4 1 file changed,

Re: [PATCH] help.c: add a compatibility comment to cmd_version()

2013-04-16 Thread Junio C Hamano
David Aguilar writes: > External projects have been known to parse the output of > "git version". Help prevent future authors from changing > its format by adding a comment to its implementation. > > Signed-off-by: David Aguilar > --- > help.c | 4 > 1 file changed, 4 insertions(+) > > di

[PATCH] help.c: add a compatibility comment to cmd_version()

2013-04-16 Thread David Aguilar
External projects have been known to parse the output of "git version". Help prevent future authors from changing its format by adding a comment to its implementation. Signed-off-by: David Aguilar --- help.c | 4 1 file changed, 4 insertions(+) diff --git a/help.c b/help.c index 1dfa0b0..